[jira] [Commented] (PHOENIX-6587) Validate explicit pre-split and existing splits on salted tables
[ https://issues.apache.org/jira/browse/PHOENIX-6587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511022#comment-17511022 ] ASF GitHub Bot commented on PHOENIX-6587: - stoty commented on pull request #1353: URL: https://github.com/apache/phoenix/pull/1353#issuecomment-1075917383 org.apache.phoenix.end2end.LocalIndexSplitMergeIT.testLocalIndexScanWithMergeSpecialCase() doesn't even use salted tables. I must have broken something else in the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Validate explicit pre-split and existing splits on salted tables > > > Key: PHOENIX-6587 > URL: https://issues.apache.org/jira/browse/PHOENIX-6587 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > Specifying the split points manually on salted tables can break them. > The easiest thing to do is to disallow it, which ensures that the table is > created with the default per bucket presplit. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [phoenix] stoty commented on pull request #1353: PHOENIX-6587 Disallow specifying explicit pre-split on salted tables
stoty commented on pull request #1353: URL: https://github.com/apache/phoenix/pull/1353#issuecomment-1075917383 org.apache.phoenix.end2end.LocalIndexSplitMergeIT.testLocalIndexScanWithMergeSpecialCase() doesn't even use salted tables. I must have broken something else in the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6671) Avoid ShortCirtuation Coprocessor Connection with HBase 2.x
[ https://issues.apache.org/jira/browse/PHOENIX-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510820#comment-17510820 ] Lars Hofhansl commented on PHOENIX-6671: Hi [~comnetwork] , thanks for working out the patch. HBASE-26869 does indeed fix the slow scanning problem. I think the user problem is not actually a problem. (Although I will say that generally it's weird the calls issues locally via a short circuit connection are issued as the system user who started the HBase process, instead of on behalf of the user who issued the outer request. But that is a different problem.) > Avoid ShortCirtuation Coprocessor Connection with HBase 2.x > --- > > Key: PHOENIX-6671 > URL: https://issues.apache.org/jira/browse/PHOENIX-6671 > Project: Phoenix > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 5.2.0, 5.1.3 > > Attachments: 6671-5.1.txt > > > See PHOENIX-6501, PHOENIX-6458, and HBASE-26812. > HBase's ShortCircuit Connection are fundamentally broken in HBase 2. We might > be able to fix it there, but with all the work the RPC handlers perform now > (closing scanning, resolving current user, etc), I doubt we'll get that 100% > right. HBase 3 has removed this functionality. > Even with HBase 2, which does not have the async protobuf code, I could > hardly see any performance improvement from circumventing the RPC stack in > case the target of a Get or Scan is local. Even in the most ideal conditions > where everything is local, there was improvement outside of noise. > I suggest we do not use ShortCircuited Connections in Phoenix 5+. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6632) Migrate connectors to Spark-3
[ https://issues.apache.org/jira/browse/PHOENIX-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510754#comment-17510754 ] ASF GitHub Bot commented on PHOENIX-6632: - stoty commented on pull request #71: URL: https://github.com/apache/phoenix-connectors/pull/71#issuecomment-1075381421 Thanks, I've added them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate connectors to Spark-3 > - > > Key: PHOENIX-6632 > URL: https://issues.apache.org/jira/browse/PHOENIX-6632 > Project: Phoenix > Issue Type: Improvement > Components: spark-connector >Affects Versions: connectors-6.0.0 >Reporter: Ashwin Balasubramani >Assignee: Istvan Toth >Priority: Major > > With Spark-3, the DatasourceV2 API has had major changes, where a new > TableProvider Interface has been introduced. These new changes bring in more > control to the data source developer and better integration with > spark-optimizer. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [phoenix-connectors] stoty commented on pull request #71: PHOENIX-6632 Migrate connectors to spark-3
stoty commented on pull request #71: URL: https://github.com/apache/phoenix-connectors/pull/71#issuecomment-1075381421 Thanks, I've added them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6669) RVC returns a wrong result
[
https://issues.apache.org/jira/browse/PHOENIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510733#comment-17510733
]
ASF GitHub Bot commented on PHOENIX-6669:
-
gokceni closed pull request #1407:
URL: https://github.com/apache/phoenix/pull/1407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RVC returns a wrong result
> --
>
> Key: PHOENIX-6669
> URL: https://issues.apache.org/jira/browse/PHOENIX-6669
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.16.1
>Reporter: Xinyi Yan
>Priority: Major
>
> {code:java}
> CREATE TABLE IF NOT EXISTS DUMMY (
> PK1 VARCHAR NOT NULL,
> PK2 BIGINT NOT NULL,
> PK3 BIGINT NOT NULL,
> PK4 VARCHAR NOT NULL,
> COL1 BIGINT,
> COL2 INTEGER,
> COL3 VARCHAR,
> COL4 VARCHAR, CONSTRAINT PK PRIMARY KEY
> (
> PK1,
> PK2,
> PK3,
> PK4
> )
> );UPSERT INTO DUMMY (PK1, PK4, COL1, PK2, COL2, PK3, COL3, COL4)
> VALUES ('xx', 'xid1', 0, 7, 7, 7, 'INSERT', null);
> {code}
> The non-RVC query returns no row, but the RVC query returns a wrong result.
> {code:java}
> 0: jdbc:phoenix:localhost> select PK2
> . . . . . . . . . . . . .> from DUMMY
> . . . . . . . . . . . . .> where PK1 ='xx'
> . . . . . . . . . . . . .> and (PK1 > 'xx' AND PK1 <= 'xx')
> . . . . . . . . . . . . .> and (PK2 > 5 AND PK2 <=5)
> . . . . . . . . . . . . .> and (PK3 > 2 AND PK3 <=2);
> +--+
> | PK2 |
> +--+
> +--+
> No rows selected (0.022 seconds)
> 0: jdbc:phoenix:localhost> select PK2
> . . . . . . . . . . . . .> from DUMMY
> . . . . . . . . . . . . .> where (PK1 = 'xx')
> . . . . . . . . . . . . .> and (PK1, PK2, PK3) > ('xx', 5, 2)
> . . . . . . . . . . . . .> and (PK1, PK2, PK3) <= ('xx', 5, 2);
> +--+
> | PK2 |
> +--+
> | 7 |
> +--+
> 1 row selected (0.033 seconds) {code}
> {code:java}
> 0: jdbc:phoenix:localhost> EXPLAIN select PK2 from DUMMY where (PK1 = 'xx')
> and (PK1, PK2, PK3) > ('xx', 5, 2) and (PK1, PK2, PK3) <= ('xx', 5, 2);
> +--+--+--+--+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +--+--+--+--+
> | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN RANGE SCAN OVER DUMMY ['xx'] |
> null | null |
> | SERVER FILTER BY FIRST KEY ONLY | null
> | null | |
> +--+--+--+--+
> 2 rows selected (0.024 seconds)
> 0: jdbc:phoenix:localhost> explain select PK2 from DUMMY where PK1 ='xx' and
> (PK1 > 'xx' AND PK1 <= 'xx') and (PK2 > 5 AND PK2 <=5) and (PK3 > 2 AND PK3
> <=2);
> +--+--+--+--+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +--+--+--+--+
> | DEGENERATE SCAN OVER DUMMY | null
> | null | |
> +--+--+--+--+
> 1 row selected (0.015 seconds){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (PHOENIX-6669) RVC returns a wrong result
[
https://issues.apache.org/jira/browse/PHOENIX-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510731#comment-17510731
]
ASF GitHub Bot commented on PHOENIX-6669:
-
gokceni commented on pull request #1407:
URL: https://github.com/apache/phoenix/pull/1407#issuecomment-1075355428
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> RVC returns a wrong result
> --
>
> Key: PHOENIX-6669
> URL: https://issues.apache.org/jira/browse/PHOENIX-6669
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.16.1
>Reporter: Xinyi Yan
>Priority: Major
>
> {code:java}
> CREATE TABLE IF NOT EXISTS DUMMY (
> PK1 VARCHAR NOT NULL,
> PK2 BIGINT NOT NULL,
> PK3 BIGINT NOT NULL,
> PK4 VARCHAR NOT NULL,
> COL1 BIGINT,
> COL2 INTEGER,
> COL3 VARCHAR,
> COL4 VARCHAR, CONSTRAINT PK PRIMARY KEY
> (
> PK1,
> PK2,
> PK3,
> PK4
> )
> );UPSERT INTO DUMMY (PK1, PK4, COL1, PK2, COL2, PK3, COL3, COL4)
> VALUES ('xx', 'xid1', 0, 7, 7, 7, 'INSERT', null);
> {code}
> The non-RVC query returns no row, but the RVC query returns a wrong result.
> {code:java}
> 0: jdbc:phoenix:localhost> select PK2
> . . . . . . . . . . . . .> from DUMMY
> . . . . . . . . . . . . .> where PK1 ='xx'
> . . . . . . . . . . . . .> and (PK1 > 'xx' AND PK1 <= 'xx')
> . . . . . . . . . . . . .> and (PK2 > 5 AND PK2 <=5)
> . . . . . . . . . . . . .> and (PK3 > 2 AND PK3 <=2);
> +--+
> | PK2 |
> +--+
> +--+
> No rows selected (0.022 seconds)
> 0: jdbc:phoenix:localhost> select PK2
> . . . . . . . . . . . . .> from DUMMY
> . . . . . . . . . . . . .> where (PK1 = 'xx')
> . . . . . . . . . . . . .> and (PK1, PK2, PK3) > ('xx', 5, 2)
> . . . . . . . . . . . . .> and (PK1, PK2, PK3) <= ('xx', 5, 2);
> +--+
> | PK2 |
> +--+
> | 7 |
> +--+
> 1 row selected (0.033 seconds) {code}
> {code:java}
> 0: jdbc:phoenix:localhost> EXPLAIN select PK2 from DUMMY where (PK1 = 'xx')
> and (PK1, PK2, PK3) > ('xx', 5, 2) and (PK1, PK2, PK3) <= ('xx', 5, 2);
> +--+--+--+--+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +--+--+--+--+
> | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN RANGE SCAN OVER DUMMY ['xx'] |
> null | null |
> | SERVER FILTER BY FIRST KEY ONLY | null
> | null | |
> +--+--+--+--+
> 2 rows selected (0.024 seconds)
> 0: jdbc:phoenix:localhost> explain select PK2 from DUMMY where PK1 ='xx' and
> (PK1 > 'xx' AND PK1 <= 'xx') and (PK2 > 5 AND PK2 <=5) and (PK3 > 2 AND PK3
> <=2);
> +--+--+--+--+
> | PLAN | EST_BYTES_READ
> | EST_ROWS_READ | |
> +--+--+--+--+
> | DEGENERATE SCAN OVER DUMMY | null
> | null | |
> +--+--+--+--+
> 1 row selected (0.015 seconds){code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [phoenix] gokceni closed pull request #1407: PHOENIX-6669 RVC where optimization scan merge creates incorrect results
gokceni closed pull request #1407: URL: https://github.com/apache/phoenix/pull/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix] gokceni commented on pull request #1407: PHOENIX-6669 RVC where optimization scan merge creates incorrect results
gokceni commented on pull request #1407: URL: https://github.com/apache/phoenix/pull/1407#issuecomment-1075355428 Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-6632) Migrate connectors to Spark-3
[ https://issues.apache.org/jira/browse/PHOENIX-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510543#comment-17510543 ] ASF GitHub Bot commented on PHOENIX-6632: - richardantal commented on pull request #71: URL: https://github.com/apache/phoenix-connectors/pull/71#issuecomment-1075286772 I've started to review this change and the original #69 . I ran a `mvn verify` with the scala test and it seems to be okey. I haven't finished the review yet but I think we should add the new phoenix5-spark3 artifact to the assembly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Migrate connectors to Spark-3 > - > > Key: PHOENIX-6632 > URL: https://issues.apache.org/jira/browse/PHOENIX-6632 > Project: Phoenix > Issue Type: Improvement > Components: spark-connector >Affects Versions: connectors-6.0.0 >Reporter: Ashwin Balasubramani >Assignee: Istvan Toth >Priority: Major > > With Spark-3, the DatasourceV2 API has had major changes, where a new > TableProvider Interface has been introduced. These new changes bring in more > control to the data source developer and better integration with > spark-optimizer. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [phoenix-connectors] richardantal commented on pull request #71: PHOENIX-6632 Migrate connectors to spark-3
richardantal commented on pull request #71: URL: https://github.com/apache/phoenix-connectors/pull/71#issuecomment-1075286772 I've started to review this change and the original #69 . I ran a `mvn verify` with the scala test and it seems to be okey. I haven't finished the review yet but I think we should add the new phoenix5-spark3 artifact to the assembly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (PHOENIX-6671) Avoid ShortCirtuation Coprocessor Connection with HBase 2.x
[
https://issues.apache.org/jira/browse/PHOENIX-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510237#comment-17510237
]
chenglei edited comment on PHOENIX-6671 at 3/22/22, 12:12 PM:
--
[~larsh]，is HBASE-26869 fix the slow scan problem you mentioned? To me, I
think option 2 is more acceptable, because the {{User}} problem is hard to fix.
was (Author: comnetwork):
[~larsh]，whether HBASE-26869 fix the slow scan problem you mentioned? To me, I
think option 2 is more acceptable, because the {{User}} problem is hard to fix.
> Avoid ShortCirtuation Coprocessor Connection with HBase 2.x
> ---
>
> Key: PHOENIX-6671
> URL: https://issues.apache.org/jira/browse/PHOENIX-6671
> Project: Phoenix
> Issue Type: Bug
>Reporter: Lars Hofhansl
>Assignee: Lars Hofhansl
>Priority: Major
> Fix For: 5.2.0, 5.1.3
>
> Attachments: 6671-5.1.txt
>
>
> See PHOENIX-6501, PHOENIX-6458, and HBASE-26812.
> HBase's ShortCircuit Connection are fundamentally broken in HBase 2. We might
> be able to fix it there, but with all the work the RPC handlers perform now
> (closing scanning, resolving current user, etc), I doubt we'll get that 100%
> right. HBase 3 has removed this functionality.
> Even with HBase 2, which does not have the async protobuf code, I could
> hardly see any performance improvement from circumventing the RPC stack in
> case the target of a Get or Scan is local. Even in the most ideal conditions
> where everything is local, there was improvement outside of noise.
> I suggest we do not use ShortCircuited Connections in Phoenix 5+.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [phoenix-queryserver] stoty closed pull request #79: PHOENIX-6614 QueryServerTest fails for hostname upper case letters
stoty closed pull request #79: URL: https://github.com/apache/phoenix-queryserver/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-queryserver] stoty closed pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
stoty closed pull request #80: URL: https://github.com/apache/phoenix-queryserver/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on pull request #80: PHOENIX-6613 QueryServerBasicsIT usage by external tools
stoty commented on pull request #80: URL: https://github.com/apache/phoenix-queryserver/pull/80#issuecomment-1074893759 I've committed the change without the changes that result in too long lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
