[jira] [Commented] (PHOENIX-6059) Adding more pagination tests
[ https://issues.apache.org/jira/browse/PHOENIX-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176532#comment-17176532 ] Hudson commented on PHOENIX-6059: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4092 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4092/]) PHOENIX-6059 Adding more pagination tests (yanxinyi: rev 8e34b2bf14e5b6c45c7212104768792390cf0d06) * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetOptionalIT.java > Adding more pagination tests > > > Key: PHOENIX-6059 > URL: https://issues.apache.org/jira/browse/PHOENIX-6059 > Project: Phoenix > Issue Type: Improvement >Reporter: Xinyi Yan >Assignee: Xinyi Yan >Priority: Minor > Attachments: PHOENIX-6059.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Adding more tests for the pagination. Such as single/multiple columns, > combination of data types, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5958) Diverged view created via an older client still sees dropped column data
[
https://issues.apache.org/jira/browse/PHOENIX-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172350#comment-17172350
]
Hudson commented on PHOENIX-5958:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4088 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4088/])
PHOENIX-5958: Diverged view created via an older client still sees
(chinmayskulkarni: rev ffeddf55328ac69dac6ee565abec34e1f7002d13)
* (add) phoenix-core/src/it/resources/sql_files/query_add_data.sql
* (add) phoenix-core/src/it/resources/sql_files/create_diverged_view.sql
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ColumnMutator.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DropColumnMutator.java
* (add) phoenix-core/src/it/resources/sql_files/query_create_diverged_view.sql
* (delete) phoenix-core/src/it/resources/sql_files/query_more.sql
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java
* (delete) phoenix-core/src/it/resources/sql_files/query.sql
* (add) phoenix-core/src/it/resources/sql_files/query_create_add.sql
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
* (add)
phoenix-core/src/it/resources/gold_files/gold_query_create_diverged_view.txt
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
> Diverged view created via an older client still sees dropped column data
>
>
> Key: PHOENIX-5958
> URL: https://issues.apache.org/jira/browse/PHOENIX-5958
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5958-4.x-v2.patch, PHOENIX-5958-4.x-v3.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> By "diverged view" I mean creating a view and then dropping one of the
> inherited columns from the view. Steps to reproduce:
> Start a 4.x server and connect with a pre-4.15 (I tried a 4.14.3) client
> {code:sql}
> CREATE TABLE IF NOT EXISTS S.T (A INTEGER PRIMARY KEY, B INTEGER);
> CREATE VIEW IF NOT EXISTS S.V (new_col INTEGER) AS SELECT * FROM S.T;
> UPSERT INTO S.T VALUES(1,2);
> ALTER VIEW S.V DROP COLUMN B;
> SELECT * FROM S.T;
> ++--+
> | A | B |
> ++--+
> | 1 | 2 |
> ++--+
> SELECT * FROM S.V; gives:
> ++--+--+
> | B | A | NEW_COL |
> ++--+--+
> | 2 | 1 | null|
> ++--+--+
> {code}
> Though the column 'B' has been dropped from the view. This is a problem for
> both when phoenix.allow.system.catalog.rollback=true or false. This exact bug
> does not happen for a 4.x client, though PHOENIX-6030 and PHOENIX-6032
> highlight other issues related to this code path for 4.x clients.
> The problem is mostly due to changes introduced by
> [PHOENIX-4893|https://issues.apache.org/jira/browse/PHOENIX-4893]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6022) RVC Offset does not handle trailing nulls properly
[ https://issues.apache.org/jira/browse/PHOENIX-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167816#comment-17167816 ] Hudson commented on PHOENIX-6022: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #4087 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4087/]) PHOENIX-6022 RVC Offset does not handle trailing nulls properly (yanxinyi: rev ce0de92029efecbfe3be2bd47dfc57e1da7cf6a0) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/RVCOffsetCompilerTest.java > RVC Offset does not handle trailing nulls properly > -- > > Key: PHOENIX-6022 > URL: https://issues.apache.org/jira/browse/PHOENIX-6022 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 4.16.0 >Reporter: Daniel Wong >Assignee: Daniel Wong >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-6022-4.x.patch, PHOENIX-6022-master.patch > > Time Spent: 40m > Remaining Estimate: 0h > > While working on PHOENIX-5924 found that if there was a trailing null the > Phoenix Optimizer during resolution of the miniwhere does not generate a > point get due to how we write/handle trailing nulls in the rowkey. The > sanity check that it is a point get therefore fails. This causes an > exception to be returned to the user. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6045) Delete that should qualify for index path does not use index when multiple indexes are available.
[ https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167558#comment-17167558 ] Hudson commented on PHOENIX-6045: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4085 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4085/]) PHOENIX-6045 Delete that should qualify for index path does not use (kozdemir: rev bb936d1fee64dc36281c48591e672da671a5878c) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java > Delete that should qualify for index path does not use index when multiple > indexes are available. > - > > Key: PHOENIX-6045 > URL: https://issues.apache.org/jira/browse/PHOENIX-6045 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: Daniel Wong >Assignee: Kadir OZDEMIR >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: MultipleDeleteReproIT.java, PHOENIX-6045.4.x.001.patch, > PHOENIX-6045.4.x.002.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Delete that should qualify for index path does not use index when multiple > indexes are available. Test case to reproduce will be below. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5986) DropTableWithViewsIT.testDropTableWithChildViews is flapping again
[
https://issues.apache.org/jira/browse/PHOENIX-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164940#comment-17164940
]
Hudson commented on PHOENIX-5986:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4078 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078/])
PHOENIX-5986 Fix flapping test (giskender: rev
d17eb0a96ca2467be6791783eb314f90740fa94c)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/task/Task.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexRebuildTaskIT.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/SplitSystemCatalogIT.java
> DropTableWithViewsIT.testDropTableWithChildViews is flapping again
> --
>
> Key: PHOENIX-5986
> URL: https://issues.apache.org/jira/browse/PHOENIX-5986
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Gokcen Iskender
>Priority: Major
> Labels: phoenix-hardening, quality-improvement
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5986.4.x.001.patch, PHOENIX-5986.4.x.002.patch,
> PHOENIX-5986.4.x.003.patch, PHOENIX-5986.4.x.004.patch,
> PHOENIX-5986.master.001.patch, PHOENIX-5986.master.002.patch,
> PHOENIX-5986.master.003.patch, PHOENIX-5986.master.004.patch,
> PHOENIX-5986.master.005.patch, build-4022-full-console-log.txt,
> build-4023-full-console-log.txt
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> DropTableWithViewsIT.testDropTableWithChildViews is flapping again. I see
> [PHOENIX-5074|https://issues.apache.org/jira/browse/PHOENIX-5074] fixed this
> test so that the task is run immediately, but somehow this test is still
> intermittently failing.
> This has caused recent preCommit failures for PHOENIX-5981 (build
> [4010|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4010//testReport/])
> and
> PHOENIX-5984 (build
> [4011|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//testReport/]).
> When I run this test locally, it passes sometimes and fails sometimes. This
> is the relevant stack trace:
> {code:java}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertFalse(Assert.java:65)
> at org.junit.Assert.assertFalse(Assert.java:75)
> at
> org.apache.phoenix.end2end.DropTableWithViewsIT.testDropTableWithChildViews(DropTableWithViewsIT.java:158)
> {code}
> Failure is observed in [this
> assertion|https://github.com/apache/phoenix/blob/f5ebf2aaa337d0b4b935f10917cee3d99d621c98/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java#L158].
> I also see that the test sometimes fails because it expects task status to
> be COMPLETED, but sees status to be STARTED instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6044) Precommit script over-zealous zombie check may clobber parallel Phoenix test
[ https://issues.apache.org/jira/browse/PHOENIX-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164941#comment-17164941 ] Hudson commented on PHOENIX-6044: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4078 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078/]) PHOENIX-6044 Precommit script over-zealous zombie check may clobber (stoty: rev ce83d74050a8cc1637068f3fb8980e14f9bde611) * (edit) dev/test-patch.sh > Precommit script over-zealous zombie check may clobber parallel Phoenix test > > > Key: PHOENIX-6044 > URL: https://issues.apache.org/jira/browse/PHOENIX-6044 > Project: Phoenix > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Labels: phoenix-hardening, quality-improvement > Fix For: 5.1.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The precommit script has a zombie check, that does not take into account the > fact that there may be multiple Phoenix "mvn verify" checks running on the > same Jenkins worker. > When the mvn verify of the precommit script finishes, it checks if there are > still mvn verify jobs running for Phoenix - finds the processes for the > second job - , flags those as Zombies, and kills their processes. > test-patch.sh 899-922 lines > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6013) RVC Offset does not handle coerced literal nulls properly.
[ https://issues.apache.org/jira/browse/PHOENIX-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164939#comment-17164939 ] Hudson commented on PHOENIX-6013: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4078 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078/]) PHOENIX-6013 RVC Offset does not handle coerced literal nulls properly (yanxinyi: rev 66f20fdd5aae30ad36f2772dff1b768e3ef96ab8) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/compile/RVCOffsetCompilerTest.java > RVC Offset does not handle coerced literal nulls properly. > -- > > Key: PHOENIX-6013 > URL: https://issues.apache.org/jira/browse/PHOENIX-6013 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 4.14.3 >Reporter: Daniel Wong >Assignee: Daniel Wong >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-6013-4.x.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > As part of query rewrite paths the offset may go through the A=null gets > rewritten to A IS NULL, the code sanity checks against an equality comparison > op which is not the case on this rewrite. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6023) Wrong result when issuing query for an immutable table with multiple column families
[
https://issues.apache.org/jira/browse/PHOENIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164938#comment-17164938
]
Hudson commented on PHOENIX-6023:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4078 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078/])
PHOENIX-6023 Wrong result when issuing query for an immutable table with
(stoty: rev 9f10fd0ba156d5a33d9a0e97870328cc667d2627)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereCompiler.java
> Wrong result when issuing query for an immutable table with multiple column
> families
>
>
> Key: PHOENIX-6023
> URL: https://issues.apache.org/jira/browse/PHOENIX-6023
> Project: Phoenix
> Issue Type: Bug
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6023-addendum.master.v1.patch,
> PHOENIX-6023.addendum.master.v2.patch, PHOENIX-6023.master.v3.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Steps to reproduce are as follows:
> 1. Create an immutable table with multiple column families:
> {code}
> 0: jdbc:phoenix:> CREATE TABLE TEST (
> . . . . . . . . > ID VARCHAR PRIMARY KEY,
> . . . . . . . . > A.COL1 VARCHAR,
> . . . . . . . . > B.COL2 VARCHAR
> . . . . . . . . > ) IMMUTABLE_ROWS = TRUE;
> No rows affected (1.182 seconds)
> {code}
> 2. Upsert some rows:
> {code}
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id0', '0', 'a');
> 1 row affected (0.138 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id1', '1', NULL);
> 1 row affected (0.009 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id2', '2', 'b');
> 1 row affected (0.011 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id3', '3', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id4', '4', 'c');
> 1 row affected (0.006 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id5', '5', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id6', '6', 'd');
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id7', '7', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id8', '8', 'e');
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id9', '9', NULL);
> 1 row affected (0.009 seconds)
> {code}
> 3. Count query is okay:
> {code}
> 0: jdbc:phoenix:> SELECT COUNT(COL1) FROM TEST WHERE COL2 IS NOT NULL;
> ++
> | COUNT(A.COL1) |
> ++
> | 5 |
> ++
> 1 row selected (0.1 seconds)
> {code}
> 4. However, the following select query returns wrong result (it should return
> 5 records):
> {code}
> 0: jdbc:phoenix:> SELECT COL1 FROM TEST WHERE COL2 IS NOT NULL;
> +---+
> | COL1 |
> +---+
> | 0 |
> | 1 |
> | 2 |
> | 3 |
> | 4 |
> | 5 |
> | 6 |
> | 7 |
> | 8 |
> | 9 |
> +---+
> 10 rows selected (0.058 seconds)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6016) Support HBase 2.3.0
[ https://issues.apache.org/jira/browse/PHOENIX-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163466#comment-17163466 ] Hudson commented on PHOENIX-6016: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4072 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4072/]) PHOENIX-6016 Support HBase 2.3.0 (stoty: rev a8d6ba036bc15eb66004a99e88a5d8a4fd1cab4c) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/LocalIndexIT.java * (edit) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java * (edit) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatUtil.java * (edit) phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/MultiHfileOutputFormat.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatDelegateHTable.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/PermissionsCacheIT.java * (edit) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/TableSnapshotResultIterator.java * (edit) phoenix-core/src/it/resources/compatible_client_versions.json * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/DelegateHTable.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatStoreFileReader.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/transaction/OmidTransactionTable.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatPermissionUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java * (edit) pom.xml * (add) phoenix-hbase-compat-2.3.0/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java * (edit) phoenix-core/pom.xml * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatOmidTransactionTable.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriverTest.java * (edit) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java * (add) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatOmidTransactionTable.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyTool.java * (add) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatOmidTransactionTable.java * (add) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatStoreFileReader.java * (edit) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatPermissionUtil.java * (add) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatDelegateHTable.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/OffsetCell.java * (add) phoenix-hbase-compat-2.1.6/src/main/java/org/apache/phoenix/compat/hbase/CompatDelegateHTable.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/CompatUtil.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/hbase/index/write/recovery/TestPerRegionIndexWriteCache.java * (add) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatStoreFileReader.java * (edit) phoenix-hbase-compat-2.2.1/src/main/java/org/apache/phoenix/compat/hbase/CompatPermissionUtil.java * (edit) phoenix-core/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReader.java * (add) phoenix-hbase-compat-2.3.0/src/main/java/org/apache/phoenix/compat/hbase/test/DelegateCell.java > Support HBase 2.3.0 > --- > > Key: PHOENIX-6016 > URL: https://issues.apache.org/jira/browse/PHOENIX-6016 > Project: Phoenix > Issue Type: Improvement >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6016.master.v1.patch, > PHOENIX-6016.master.v2.patch, PHOENIX-6016.master.v3.patch, > PHOENIX-6016.master.v4.patch, PHOENIX-6016.master.v5.patch > > Time Spent: 1h 50m > Remaining Estimate: 0h > > Hbase 2.3.0 has been released. > Make sure Phoenix works with it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6026) Fix BackwardCompatibilityIT so it can run locally
[
https://issues.apache.org/jira/browse/PHOENIX-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162365#comment-17162365
]
Hudson commented on PHOENIX-6026:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4066 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4066/])
PHOENIX-6026: Fix BackwardCompatibilityIT so it can run locally
(chinmayskulkarni: rev 218a71c07259a6ac4660335bf3636325e1ee138d)
* (add) phoenix-core/src/it/resources/scripts/execute_query.sh
* (delete) phoenix-core/src/it/scripts/execute_query.sh
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
> Fix BackwardCompatibilityIT so it can run locally
> -
>
> Key: PHOENIX-6026
> URL: https://issues.apache.org/jira/browse/PHOENIX-6026
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0
> Environment: Branch: 4.x
> OS: MacOS 10.13.6
> java runtime version: 1.8.0_181
> mvn version: 3.5.2
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Major
> Labels: phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6026-4.x-v1.patch, PHOENIX-6026-4.x-v2.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When you try running BackwardCompatibilityIT on 4.x locally it fails with the
> following exception:
> {code:java}
> java.io.FileNotFoundException:
> src/it/resources/compatible_client_versions.json (No such file or directory)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6023) Wrong result when issuing query for an immutable table with multiple column families
[
https://issues.apache.org/jira/browse/PHOENIX-6023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162364#comment-17162364
]
Hudson commented on PHOENIX-6023:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4066 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4066/])
PHOENIX-6023 Wrong result when issuing query for an immutable table with
(github: rev 59044045189f275c75938d441e7a7d74e7670005)
* (add)
phoenix-core/src/it/java/org/apache/phoenix/end2end/ImmutableTableIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereCompiler.java
> Wrong result when issuing query for an immutable table with multiple column
> families
>
>
> Key: PHOENIX-6023
> URL: https://issues.apache.org/jira/browse/PHOENIX-6023
> Project: Phoenix
> Issue Type: Bug
>Reporter: Toshihiro Suzuki
>Assignee: Toshihiro Suzuki
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Steps to reproduce are as follows:
> 1. Create an immutable table with multiple column families:
> {code}
> 0: jdbc:phoenix:> CREATE TABLE TEST (
> . . . . . . . . > ID VARCHAR PRIMARY KEY,
> . . . . . . . . > A.COL1 VARCHAR,
> . . . . . . . . > B.COL2 VARCHAR
> . . . . . . . . > ) IMMUTABLE_ROWS = TRUE;
> No rows affected (1.182 seconds)
> {code}
> 2. Upsert some rows:
> {code}
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id0', '0', 'a');
> 1 row affected (0.138 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id1', '1', NULL);
> 1 row affected (0.009 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id2', '2', 'b');
> 1 row affected (0.011 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id3', '3', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id4', '4', 'c');
> 1 row affected (0.006 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id5', '5', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id6', '6', 'd');
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id7', '7', NULL);
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id8', '8', 'e');
> 1 row affected (0.007 seconds)
> 0: jdbc:phoenix:> UPSERT INTO TEST VALUES ('id9', '9', NULL);
> 1 row affected (0.009 seconds)
> {code}
> 3. Count query is okay:
> {code}
> 0: jdbc:phoenix:> SELECT COUNT(COL1) FROM TEST WHERE COL2 IS NOT NULL;
> ++
> | COUNT(A.COL1) |
> ++
> | 5 |
> ++
> 1 row selected (0.1 seconds)
> {code}
> 4. However, the following select query returns wrong result (it should return
> 5 records):
> {code}
> 0: jdbc:phoenix:> SELECT COL1 FROM TEST WHERE COL2 IS NOT NULL;
> +---+
> | COL1 |
> +---+
> | 0 |
> | 1 |
> | 2 |
> | 3 |
> | 4 |
> | 5 |
> | 6 |
> | 7 |
> | 8 |
> | 9 |
> +---+
> 10 rows selected (0.058 seconds)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5976) Cannot drop a column when the index view is involved
[
https://issues.apache.org/jira/browse/PHOENIX-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161467#comment-17161467
]
Hudson commented on PHOENIX-5976:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4063 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4063/])
PHOENIX-5976 Cannot drop a column when the index view is involved (yanxinyi:
rev 4c03f087f2c3b562459f5c09814d7eeafc727b11)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/DropColumnMutator.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropColumnIT.java
> Cannot drop a column when the index view is involved
> -
>
> Key: PHOENIX-5976
> URL: https://issues.apache.org/jira/browse/PHOENIX-5976
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.16.0
>Reporter: Xinyi Yan
>Assignee: Xinyi Yan
>Priority: Blocker
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5976.4.x.patch, PHOENIX-5976.4.x.v2.patch
>
>
> This is how to reproduce it on the 4.x branch:
> {code:java}
> // create table
> stmt.execute("CREATE TABLE IF NOT EXISTS DUMMY (ID CHAR(10) NOT
> NULL,KEY_PREFIX CHAR(3) NOT NULL," +
> " CONSTRAINT PK PRIMARY KEY (ID,KEY_PREFIX))");
> // create view
> stmt.execute(
> "CREATE VIEW IF NOT EXISTS DUMMY_VIEW (PK1 DATE NOT NULL,PK2
> CHAR(15) NOT NULL," +
> "NON_PK1 CHAR(15),NON_PK2 CHAR(15) CONSTRAINT PKVIEW PRIMARY
> KEY (PK1,PK2)) " +
> "AS SELECT * FROM DUMMY WHERE KEY_PREFIX = '123'");
> // create index
> stmt.execute("CREATE INDEX DUMMY_INDEX ON DUMMY_VIEW (PK2, PK1) INCLUDE
> (NON_PK1, NON_PK2)");
> // drop column
> stmt.execute("ALTER VIEW DUMMY_VIEW DROP COLUMN IF EXISTS NON_PK1");
> {code}
> {code:java}
> org.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703): ERROR 504
> (42703): Undefined column. columnName=0:NON_PK2
> DUMMY_VIEWorg.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703):
> ERROR 504 (42703): Undefined column. columnName=0:NON_PK2 DUMMY_VIEW at
> org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:114) at
> org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:88) at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2823)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.dropColumn(MetaDataEndpointImpl.java:3026)
> at
> org.apache.phoenix.coprocessor.generated.MetaDataProtos$MetaDataService.callMethod(MetaDataProtos.java:17253)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:8523)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:2282)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:2264)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36808)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2399) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291)Caused
> by: org.apache.phoenix.schema.ColumnNotFoundException: ERROR 504 (42703):
> Undefined column. columnName=0:NON_PK2 at
> org.apache.phoenix.schema.PColumnFamilyImpl.getPColumnForColumnNameBytes(PColumnFamilyImpl.java:86)
> at org.apache.phoenix.util.MetaDataUtil.getColumn(MetaDataUtil.java:982) at
> org.apache.phoenix.coprocessor.DropColumnMutator.validateAndAddMetadata(DropColumnMutator.java:184)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2719)
> ... 10 more
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6011) ServerCacheClient throw NullPointerException
[ https://issues.apache.org/jira/browse/PHOENIX-6011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160840#comment-17160840 ] Hudson commented on PHOENIX-6011: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4059 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4059/]) PHOENIX-6011:ServerCacheClient throw NullPointerException (#836) (github: rev 6a293496ba0bb264964ea9d124bc624c14db32ce) * (add) phoenix-core/src/test/java/org/apache/phoenix/cache/ServerCacheClientTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/cache/ServerCacheClient.java > ServerCacheClient throw NullPointerException > > > Key: PHOENIX-6011 > URL: https://issues.apache.org/jira/browse/PHOENIX-6011 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.13.1 >Reporter: Chao Wang >Assignee: Chao Wang >Priority: Major > Fix For: 4.x, master > > Attachments: 1.png, PHOENIX-6011-v1.patch, PHOENIX-6011-v2.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Throw NullPointerException in my product Environment now, As shown in the > following image. > !1.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6017) Hadoop QA Precommit build keeps failing with release audit warning for phoenix-server/dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/PHOENIX-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160426#comment-17160426
]
Hudson commented on PHOENIX-6017:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4058 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4058/])
PHOENIX-6017: Hadoop QA Precommit build keeps failing with release audit
(chinmayskulkarni: rev a79368664f04f460fdc1bbf41b223c984b5c257d)
* (edit) phoenix-server/pom.xml
> Hadoop QA Precommit build keeps failing with release audit warning for
> phoenix-server/dependency-reduced-pom.xml
>
>
> Key: PHOENIX-6017
> URL: https://issues.apache.org/jira/browse/PHOENIX-6017
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Major
> Labels: beginner, newbie, phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6017-4.x-v1.patch, PHOENIX-6017-4.x-v2.patch,
> PHOENIX-6017-4.x-v3.patch
>
>
> I believe this is introduced by some changes related to the maven-shaded
> plugin. We create a dependency-reduced-pom.xml which is considered during the
> license header check, thus always causing preCommit to fail on this step. We
> should prevent its creation perhaps via something like
> [this|https://stackoverflow.com/questions/11314182/maven-shade-plugin-adding-dependency-reduced-pom-xml-to-base-directory].
> Example of a failing build's error:
> {code:java}
> 1 Unknown Licenses
> *
> Files with unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-server/dependency-reduced-pom.xml
> *
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6017) Hadoop QA Precommit build keeps failing with release audit warning for phoenix-server/dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/PHOENIX-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160419#comment-17160419
]
Hudson commented on PHOENIX-6017:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4057 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4057/])
PHOENIX-6017: Hadoop QA Precommit build keeps failing with release audit
(chinmayskulkarni: rev a79368664f04f460fdc1bbf41b223c984b5c257d)
* (edit) phoenix-server/pom.xml
> Hadoop QA Precommit build keeps failing with release audit warning for
> phoenix-server/dependency-reduced-pom.xml
>
>
> Key: PHOENIX-6017
> URL: https://issues.apache.org/jira/browse/PHOENIX-6017
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Major
> Labels: beginner, newbie, phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6017-4.x-v1.patch, PHOENIX-6017-4.x-v2.patch,
> PHOENIX-6017-4.x-v3.patch
>
>
> I believe this is introduced by some changes related to the maven-shaded
> plugin. We create a dependency-reduced-pom.xml which is considered during the
> license header check, thus always causing preCommit to fail on this step. We
> should prevent its creation perhaps via something like
> [this|https://stackoverflow.com/questions/11314182/maven-shade-plugin-adding-dependency-reduced-pom-xml-to-base-directory].
> Example of a failing build's error:
> {code:java}
> 1 Unknown Licenses
> *
> Files with unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-server/dependency-reduced-pom.xml
> *
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5924) RVC Offset does not handle variable length fields exclusive scan boundary correctly
[
https://issues.apache.org/jira/browse/PHOENIX-5924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160270#comment-17160270
]
Hudson commented on PHOENIX-5924:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4053 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4053/])
PHOENIX-5924 RVC Offset does not handle variable length fields exclusive (xyan:
rev 28eb6980a668dc3d98d387692aedf7bec863b6c7)
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java
> RVC Offset does not handle variable length fields exclusive scan boundary
> correctly
> ---
>
> Key: PHOENIX-5924
> URL: https://issues.apache.org/jira/browse/PHOENIX-5924
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0, 4.14.3
>Reporter: Daniel Wong
>Assignee: Daniel Wong
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5924-4.x.patch, PHOENIX-5924-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The way exclusive boundary was handled by incrementing the key for variable
> length fields is incorrect in the scan boundary.
>
> In the following case we incrementing incorrectly from 0x490049 -> 0x490050
> ('1','1' -> '1','2')
> We should increment from 0x490049 -> 0x49004900 ('1','1' -> '1','1'\x00)
> @Test
> public void testScenario() throws Exception \{
> String TEST_DDL = "CREATE TABLE IF NOT EXISTS TEST_SCHEMA (\n"
> + "ORGANIZATION_ID VARCHAR(15), \n" + "TEST_ID
> VARCHAR(15), \n"
> + "CREATED_DATE DATE, \n" + "LAST_UPDATE DATE\n"
> + "CONSTRAINT TEST_SCHEMA_PK PRIMARY KEY (ORGANIZATION_ID,
> TEST_ID) \n" + ")";
> try (Statement statement = conn.createStatement()) {
> statement.execute(TEST_DDL);
> }
> //setup
> List upserts = new ArrayList<>();
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('1','1')");
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('1','10')");
> upserts.add("UPSERT INTO TEST_SCHEMA(ORGANIZATION_ID,TEST_ID) VALUES
> ('2','2')");
> for(String sql : upserts) \{
> try (Statement statement = conn.createStatement()) {
> statement.execute(sql);
> }
> }
> conn.commit();
> String query1 = "SELECT * FROM TEST_SCHEMA";
> String query2 = "SELECT * FROM TEST_SCHEMA OFFSET
> (ORGANIZATION_ID,TEST_ID) = ('1','1')";
> try (Statement statement = conn.createStatement() ; ResultSet rs1 =
> statement.executeQuery(query1) ) \{
> TestUtil.printResultSet(rs1);
> }
> try (Statement statement = conn.createStatement() ; ResultSet rs2 =
> statement.executeQuery(query2) ) \{
> TestUtil.printResultSet(rs2);
> }
> }
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5933) Rename VIEW_TTL property to be PHOENIX_TTL
[ https://issues.apache.org/jira/browse/PHOENIX-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160269#comment-17160269 ] Hudson commented on PHOENIX-5933: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4053 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4053/]) PHOENIX-5933 Rename VIEW_TTL property to be PHOENIX_TTL (xyan: rev 8f9ee5015f013de173a26161f34a270d68a9d2f9) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/generated/PTableProtos.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PTable.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/DelegateTable.java * (edit) phoenix-protocol/src/main/PTable.proto * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/TableProperty.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewTTLIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java > Rename VIEW_TTL property to be PHOENIX_TTL > -- > > Key: PHOENIX-5933 > URL: https://issues.apache.org/jira/browse/PHOENIX-5933 > Project: Phoenix > Issue Type: Sub-task >Reporter: Jacob Isaac >Assignee: Jacob Isaac >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-5933.4.x.001.patch, PHOENIX-5933.master.001.patch > > Time Spent: 2.5h > Remaining Estimate: 0h > > As there is more interest in extending the TTL feature to all Phoenix > entities (tables and views) > More specifically separate the usage of Phoenix application-level TTL > (row-based) and HBase level TTL (Store/Column Family-based). > It makes sense to rename the Phoenix Table property to be PHOENIX_TTL -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159532#comment-17159532 ] Hudson commented on PHOENIX-5981: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4047 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4047/]) PHOENIX-5981: Wrong multiple counting of resultSetTimeMs and (chinmayskulkarni: rev 07f1fea40804a9c65e04e336afbeecab534372e0) * (add) phoenix-core/src/test/java/org/apache/phoenix/monitoring/OverAllQueryMetricsTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricsStopWatch.java > Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in > OverallQueryMetrics > - > > Key: PHOENIX-5981 > URL: https://issues.apache.org/jira/browse/PHOENIX-5981 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Labels: metrics, phoenix-hardening, quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5981-4.x-v1.patch, PHOENIX-5981-4.x-v2.patch, > PHOENIX-5981-4.x-v3.patch, PHOENIX-5981-4.x-v4.patch, > PHOENIX-5981-master-v1.patch > > Time Spent: 40m > Remaining Estimate: 0h > > We update wallClockTimeMS and resultSetTimeMS when we reach the last row in > our ResultSet iterations (see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L878-L881]). > However, this is also called inside PhoenixResultSet.close(), see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L214-L215]. > The problem is, these calls in-turn add elapsedTime again > ([endQuery|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L86] > and > [stopResultsetWatch|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L95]) > and so these metrics get 2X the value they should. Ideally we should change > the metrics only if the stopWatch was running before calling stopWatch.stop > or else we will count it multiple times. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6000) Client side DELETEs should use local indexes for filtering
[ https://issues.apache.org/jira/browse/PHOENIX-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159531#comment-17159531 ] Hudson commented on PHOENIX-6000: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4047 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4047/]) PHOENIX-6000 Client side DELETEs should use local indexes for filtering. (Lars: rev 02c9d5d15be727efaba8ce922857b4ba8d6f129b) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java * (add) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java.orig * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexOptimizationIT.java > Client side DELETEs should use local indexes for filtering > -- > > Key: PHOENIX-6000 > URL: https://issues.apache.org/jira/browse/PHOENIX-6000 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 5.0.1, 4.16.0 > > Attachments: 6000-4.x-HBase-1.5-v2.txt, 6000-4.x-HBase-1.5.txt, > 6000-4.x-v3.txt, 6000-4.x-v4.txt > > > I just noticed that client side DELETEs do not use local indexes for > filtering if they do not cover all keys of all other indexes. > Unless I am missing something this is not necessary, for local indexes we > have the data available in the region and can fill back the uncovered column > (just like we do for SELECTs) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5981) Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in OverallQueryMetrics
[ https://issues.apache.org/jira/browse/PHOENIX-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159513#comment-17159513 ] Hudson commented on PHOENIX-5981: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4048 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4048/]) PHOENIX-5981: Wrong multiple counting of resultSetTimeMs and (chinmayskulkarni: rev 07f1fea40804a9c65e04e336afbeecab534372e0) * (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java * (add) phoenix-core/src/test/java/org/apache/phoenix/monitoring/OverAllQueryMetricsTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricsStopWatch.java > Wrong multiple counting of resultSetTimeMs and wallclockTimeMs in > OverallQueryMetrics > - > > Key: PHOENIX-5981 > URL: https://issues.apache.org/jira/browse/PHOENIX-5981 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Labels: metrics, phoenix-hardening, quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5981-4.x-v1.patch, PHOENIX-5981-4.x-v2.patch, > PHOENIX-5981-4.x-v3.patch, PHOENIX-5981-4.x-v4.patch, > PHOENIX-5981-master-v1.patch > > Time Spent: 40m > Remaining Estimate: 0h > > We update wallClockTimeMS and resultSetTimeMS when we reach the last row in > our ResultSet iterations (see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L878-L881]). > However, this is also called inside PhoenixResultSet.close(), see > [this|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java#L214-L215]. > The problem is, these calls in-turn add elapsedTime again > ([endQuery|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L86] > and > [stopResultsetWatch|https://github.com/apache/phoenix/blob/dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78/phoenix-core/src/main/java/org/apache/phoenix/monitoring/OverAllQueryMetrics.java#L95]) > and so these metrics get 2X the value they should. Ideally we should change > the metrics only if the stopWatch was running before calling stopWatch.stop > or else we will count it multiple times. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6000) Client side DELETEs should use local indexes for filtering
[ https://issues.apache.org/jira/browse/PHOENIX-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159512#comment-17159512 ] Hudson commented on PHOENIX-6000: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4048 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4048/]) PHOENIX-6000 Client side DELETEs should use local indexes for filtering. (Lars: rev 02c9d5d15be727efaba8ce922857b4ba8d6f129b) * (add) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java.orig * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexOptimizationIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java > Client side DELETEs should use local indexes for filtering > -- > > Key: PHOENIX-6000 > URL: https://issues.apache.org/jira/browse/PHOENIX-6000 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl >Priority: Major > Fix For: 5.0.1, 4.16.0 > > Attachments: 6000-4.x-HBase-1.5-v2.txt, 6000-4.x-HBase-1.5.txt, > 6000-4.x-v3.txt, 6000-4.x-v4.txt > > > I just noticed that client side DELETEs do not use local indexes for > filtering if they do not cover all keys of all other indexes. > Unless I am missing something this is not necessary, for local indexes we > have the data available in the region and can fill back the uncovered column > (just like we do for SELECTs) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5935) Select with non primary keys and PHOENIX_ROW_TIMESTAMP() in where clause fails
[ https://issues.apache.org/jira/browse/PHOENIX-5935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158720#comment-17158720 ] Hudson commented on PHOENIX-5935: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4037 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4037/]) PHOENIX-5935 Select with non primary keys and PHOENIX_ROW_TIMESTAMP() in (yanxinyi: rev 22a46f7233c4169ff4bb815cf3cdb1c44ca6b100) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRowTimestampFunctionIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java > Select with non primary keys and PHOENIX_ROW_TIMESTAMP() in where clause fails > -- > > Key: PHOENIX-5935 > URL: https://issues.apache.org/jira/browse/PHOENIX-5935 > Project: Phoenix > Issue Type: Bug >Reporter: Jacob Isaac >Assignee: Jacob Isaac >Priority: Major > Fix For: 4.x > > Attachments: PHOENIX-5935.4.x.003.patch > > > This fails when COLUMN_ENCODED_BYTES != NON_ENCODED_QUALIFIERS > Steps to reproduce:- > CREATE TABLE IF NOT EXISTS N01 (PK1 INTEGER NOT NULL, PK2 DATE NOT NULL, > KV1 VARCHAR, KV2 VARCHAR CONSTRAINT PK PRIMARY KEY(PK1, PK2)) > COLUMN_ENCODED_BYTES = 1,IMMUTABLE_STORAGE_SCHEME = ONE_CELL_PER_COLUMN > > SELECT COUNT(*) FROM N01 WHERE PHOENIX_ROW_TIMESTAMP() > PK2 AND KV1 = > 'KV1_1'"; > > Fails with the following exception - > Caused by: java.util.NoSuchElementExceptionCaused by: > java.util.NoSuchElementException at > org.apache.phoenix.filter.MultiEncodedCQKeyValueComparisonFilter$FilteredKeyValueHolder.getCellAtIndex(MultiEncodedCQKeyValueComparisonFilter.java:151) > at > org.apache.phoenix.filter.MultiEncodedCQKeyValueComparisonFilter$EncodedCQIncrementalResultTuple.getValue(MultiEncodedCQKeyValueComparisonFilter.java:311) > at > org.apache.phoenix.expression.function.PhoenixRowTimestampFunction.evaluate(PhoenixRowTimestampFunction.java:98) > at > org.apache.phoenix.expression.ComparisonExpression.evaluate(ComparisonExpression.java:330) > at > org.apache.phoenix.expression.AndOrExpression.evaluate(AndOrExpression.java:75) > at > org.apache.phoenix.filter.BooleanExpressionFilter.evaluate(BooleanExpressionFilter.java:93) > at > org.apache.phoenix.filter.MultiEncodedCQKeyValueComparisonFilter.filterKeyValue(MultiEncodedCQKeyValueComparisonFilter.java:233) > at > org.apache.hadoop.hbase.regionserver.querymatcher.UserScanQueryMatcher.matchColumn(UserScanQueryMatcher.java:122) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5967) phoenix-client transitively pulling in phoenix-core
[ https://issues.apache.org/jira/browse/PHOENIX-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157615#comment-17157615 ] Hudson commented on PHOENIX-5967: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4035 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4035/]) PHOENIX-5967 phoenix-client transitively pulling in phoenix-core (stoty: rev fc9027fb01898397373e62830d859f0d30e5a9b9) * (edit) phoenix-assembly/pom.xml * (edit) phoenix-client/pom.xml * (edit) phoenix-assembly/src/build/components/all-common-dependencies.xml * (edit) phoenix-assembly/src/build/components/all-common-jars.xml * (edit) pom.xml * (edit) phoenix-server/pom.xml > phoenix-client transitively pulling in phoenix-core > --- > > Key: PHOENIX-5967 > URL: https://issues.apache.org/jira/browse/PHOENIX-5967 > Project: Phoenix > Issue Type: Bug >Reporter: Josh Elser >Assignee: Istvan Toth >Priority: Critical > Fix For: 5.1.0, 4.16.0 > > > Looks like something happened in master where phoenix-client is now > transitively pulling in phoenix-core, even though all of phoenix-core and its > dependencies are included in the phoenix-client shaded artifact. > 4.15.0 looks OK, so maybe something inadvertent with the hbase version > classifier stuff, [~stoty]? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5996) IndexRebuildRegionScanner.prepareIndexMutationsForRebuild may incorrectly delete index row when a delete and put mutation with the same timestamp
[
https://issues.apache.org/jira/browse/PHOENIX-5996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157104#comment-17157104
]
Hudson commented on PHOENIX-5996:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4034 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/4034/])
PHOENIX-5996 IndexRebuildRegionScanner.prepareIndexMutationsForRebuild
(chenglei: rev 29fe870ecc908ee053c7821e39bab14e7c68703c)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebuildTest.java
> IndexRebuildRegionScanner.prepareIndexMutationsForRebuild may incorrectly
> delete index row when a delete and put mutation with the same timestamp
> -
>
> Key: PHOENIX-5996
> URL: https://issues.apache.org/jira/browse/PHOENIX-5996
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.1.0, 4.16.0
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With PHOENIX-5748,
> {{IndexRebuildRegionScanner.prepareIndexMutationsForRebuild}} is responsible
> for generating index table mutations for rebuild.
> In the processing of data table mutations list, there can be a delete and put
> mutation with the same timestamp. If so, the delete and put are processed
> together in one iteration. First, the delete mutation is applied on the put
> mutation and current row state, and then the modified put mutation is
> processed.
> But when the {{modified put mutation}} is empty , even the current row state
> is not empty after the delete mutation is applied, the whole index row is
> deleted, just as following line 1191 in
> {{IndexRebuildRegionScanner.prepareIndexMutationsForRebuild}}:
> {code:java}
> 1189 } else {
> 1190if (currentDataRowState != null) {
> 1191Mutation del =
> indexMaintainer.buildRowDeleteMutation(indexRowKeyForCurrentDataRow,
> 1192IndexMaintainer.DeleteType.ALL_VERSIONS,
> ts);
> 1193indexMutations.add(del);
> 1194// For the next iteration of the for loop
> 1195currentDataRowState = null;
> 1196indexRowKeyForCurrentDataRow = null;
> 1197}
> 1198 }
> {code}
> I think above logical is wrong, when the current row state is not empty after
> the delete mutation is applied, we can not delete the whole index row, but
> instead we should reuse the logical of applying a delete mutation on current
> row state. I wrote a unit test in {{PrepareIndexMutationsForRebuildTest}} to
> produce the case:
> {code:java}
> @Test
> public void testPutDeleteOnSameTimeStampAndPutNullifiedByDelete() throws
> Exception {
> SetupInfo info = setup(
> TABLE_NAME,
> INDEX_NAME,
> "ROW_KEY VARCHAR, CF1.C1 VARCHAR, CF2.C2 VARCHAR",
> "CF2.C2",
> "ROW_KEY",
> "");
> Put dataPut = new Put(Bytes.toBytes(ROW_KEY));
> addCellToPutMutation(
> dataPut,
> Bytes.toBytes("CF2"),
> Bytes.toBytes("C2"),
> 1,
> Bytes.toBytes("v2"));
> addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 1);
>
> addCellToPutMutation(
> dataPut,
> Bytes.toBytes("CF1"),
> Bytes.toBytes("C1"),
> 2,
> Bytes.toBytes("v1"));
> addEmptyColumnToDataPutMutation(dataPut, info.pDataTable, 2);
> Delete dataDel = new Delete(Bytes.toBytes(ROW_KEY));
> addCellToDelMutation(
> dataDel,
> Bytes.toBytes("CF1"),
> null,
> 2,
> KeyValue.Type.DeleteFamily);
> List actualIndexMutations =
> IndexRebuildRegionScanner.prepareIndexMutationsForRebuild(
> info.indexMaintainer,
> dataPut,
> dataDel);
> List expectedIndexMutations = new ArrayList<>();
> byte[] idxKeyBytes = generateIndexRowKey("v2");
>
> Put idxPut1 = new Put(idxKeyBytes);
> addEmptyColumnToIndexPutMutation(idxPut1, info.indexMaintainer, 1);
> expectedIndexMutations.add(idxPut1);
>
> Put idxPut2 = new Put(idxKeyBytes);
> addEmptyColumnToIndexPutMutation(idxPut2, info.indexMaintainer, 2);
>
[jira] [Commented] (PHOENIX-5983) Set Hadoop dependencies as provided in phoenix-server
[ https://issues.apache.org/jira/browse/PHOENIX-5983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157105#comment-17157105 ] Hudson commented on PHOENIX-5983: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4034 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4034/]) PHOENIX-5983 Set Hadoop dependencies as provided in phoenix-server (stoty: rev 0979d7be731d6455c84226b7672dd53efc19832e) * (edit) phoenix-server/pom.xml * (edit) pom.xml > Set Hadoop dependencies as provided in phoenix-server > - > > Key: PHOENIX-5983 > URL: https://issues.apache.org/jira/browse/PHOENIX-5983 > Project: Phoenix > Issue Type: Improvement > Components: core >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5983.master.v1, PHOENIX-5983.master.v2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > There are some Hadoop dependencies that are shaded into phoenix-server. > Mark these as provided. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6001) Incremental rebuild/verification can result in missing rows and false positives
[ https://issues.apache.org/jira/browse/PHOENIX-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156476#comment-17156476 ] Hudson commented on PHOENIX-6001: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4030 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4030/]) PHOENIX-6001 Incremental rebuild/verification can result in missing rows (achouhan: rev aafc4810bec9a9176410e463aca79f46fa59f409) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java > Incremental rebuild/verification can result in missing rows and false > positives > > > Key: PHOENIX-6001 > URL: https://issues.apache.org/jira/browse/PHOENIX-6001 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.16.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Critical > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-6001-4.x.patch, PHOENIX-6001-master.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case of incremental rebuild/verify we prepare a skip scan using page size > constraints first and then use it for rebuild, however when using this skip > scan we constraint the number of indexmutations we're going to build/verify > also on the page size. In the case where we have multiple index mutations for > single dataTableRow, we can return back to the client without scanning all > the rows of the skip scan filter, when the client does next, we resume > incorrectly from the row after the last of the previous skip scan when infact > we hadn't exhausted it fully. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5997) Phoenix Explain Plan for Deletes does not clearly differentiate between server side and client side paths.
[ https://issues.apache.org/jira/browse/PHOENIX-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156475#comment-17156475 ] Hudson commented on PHOENIX-5997: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4030 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4030/]) PHOENIX-5997 Phoenix Explain Plan for Deletes does not clearly (yanxinyi: rev 3ea9558d2be3f85e41dd829691667e667e20be34) * (add) phoenix-core/src/test/java/org/apache/phoenix/query/ExplainPlanTextTest.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/CostBasedDecisionIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java > Phoenix Explain Plan for Deletes does not clearly differentiate between > server side and client side paths. > -- > > Key: PHOENIX-5997 > URL: https://issues.apache.org/jira/browse/PHOENIX-5997 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 4.16.0 >Reporter: Daniel Wong >Assignee: Daniel Wong >Priority: Minor > Fix For: 4.16.0 > > Attachments: PHOENIX-5997-v2-4.x.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Phoenix Explain Plan for Deletes does not clearly differentiate between > server side and client side paths. > Currently a server side and client side delete explain plans look like: -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5995) Index Rebuild page size is not honored in case of point deletes
[ https://issues.apache.org/jira/browse/PHOENIX-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17155729#comment-17155729 ] Hudson commented on PHOENIX-5995: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4025 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4025/]) PHOENIX-5995 Index Rebuild page size is not honored in case of point (achouhan: rev e75e2f9e959036f6ea602c3c085f7c850c14fb84) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java > Index Rebuild page size is not honored in case of point deletes > --- > > Key: PHOENIX-5995 > URL: https://issues.apache.org/jira/browse/PHOENIX-5995 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5995-4.x.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5988) Bump HBase and Hadoop versions to latest working patch level on master
[ https://issues.apache.org/jira/browse/PHOENIX-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154261#comment-17154261 ] Hudson commented on PHOENIX-5988: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4021 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4021/]) PHOENIX-5988 Bump HBase and Hadoop versions to latest working patch (stoty: rev f5ebf2aaa337d0b4b935f10917cee3d99d621c98) * (edit) pom.xml > Bump HBase and Hadoop versions to latest working patch level on master > -- > > Key: PHOENIX-5988 > URL: https://issues.apache.org/jira/browse/PHOENIX-5988 > Project: Phoenix > Issue Type: Improvement > Components: core >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5988.master.v1.patch > > Time Spent: 50m > Remaining Estimate: 0h > > We should keep up-to-date with the new HBase and Hadoop patch releases. > We should update to HBase 2.1.9 and 2.2.5 (or whatever is the latest when > making the commit) > I believe that we should also update the Hadoop version to at least 3.0.3. > According to the HBase compatibility matrix, even 3.0.3 is unsupported with > HBase 2.2, so we may want to update to Hadoop 3.1.3 instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5973) IndexToolForNonTxGlobalIndexIT - Stabilize and speed up
[ https://issues.apache.org/jira/browse/PHOENIX-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154260#comment-17154260 ] Hudson commented on PHOENIX-5973: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4021 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4021/]) PHOENIX-5973 - Stabilize and speed up IndexToolForNonTxGlobalIndexIT … (github: rev 02da811ba9c31a8d1dcae3af7f89a3084f4b201e) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRepository.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationResultRepositoryIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java > IndexToolForNonTxGlobalIndexIT - Stabilize and speed up > --- > > Key: PHOENIX-5973 > URL: https://issues.apache.org/jira/browse/PHOENIX-5973 > Project: Phoenix > Issue Type: Test >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5973-4.x.v1.patch, > PHOENIX-5973-addendum-4.x.v1.patch, PHOENIX-5973.v1.patch > > Time Spent: 2h 20m > Remaining Estimate: 0h > > The many IndexTool test suites have clearly had some bad performance > regressions recently, which is a part of why the overall Phoenix pre commit > builds are timing out. We should investigate why and fix. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5716) Remove or update HBase 2.0 support
[ https://issues.apache.org/jira/browse/PHOENIX-5716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152384#comment-17152384 ] Hudson commented on PHOENIX-5716: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4016 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4016/]) PHOENIX-5716 Remove HBase 2.0 support (stoty: rev 339d51ceba252fcd4277308c0a144f02f5d589ce) * (delete) phoenix-hbase-compat-2.0.1/src/main/java/org/apache/phoenix/compat/hbase/CompatPhoenixRpcScheduler.java * (delete) phoenix-hbase-compat-2.0.1/src/main/java/org/apache/phoenix/compat/hbase/CompatUtil.java * (delete) phoenix-hbase-compat-2.0.1/pom.xml * (delete) phoenix-hbase-compat-2.0.1/src/main/java/org/apache/phoenix/compat/hbase/CompatPermissionUtil.java * (edit) pom.xml * (delete) phoenix-hbase-compat-2.0.1/src/main/java/org/apache/phoenix/compat/hbase/test/DelegateCell.java * (delete) phoenix-hbase-compat-2.0.1/src/main/java/org/apache/phoenix/compat/hbase/OffsetCell.java > Remove or update HBase 2.0 support > -- > > Key: PHOENIX-5716 > URL: https://issues.apache.org/jira/browse/PHOENIX-5716 > Project: Phoenix > Issue Type: Task >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5716.master.v1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Since HBase 2.0 is EOM, we could remove support for it from master. > If we are not ready to do that, we could update it to work with 2.0.6 release. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17152385#comment-17152385 ] Hudson commented on PHOENIX-5779: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4016 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4016/]) PHOENIX-5779 SplitSystemCatalogIT tests fail with Multiple Regions error (stoty: rev 837cf4f1cc119c6f86be9f3518e774e48faaa049) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewMetadataIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIT.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SplitSystemCatalogIT.java > SplitSystemCatalogIT tests fail with Multiple Regions error > --- > > Key: PHOENIX-5779 > URL: https://issues.apache.org/jira/browse/PHOENIX-5779 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.0 >Reporter: Sandeep Guggilam >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5779-addendum.master.v1.patch, > PHOENIX-5779-addendum.master.v2.patch, PHOENIX-5779.addendum.master.v3.patch, > PHOENIX-5779.addendum.master.v4.patch, PHOENIX-5779.master.v1.patch > > > I see the SplitSystemCatalogIT tests failing on master branch complaining > with the error " Multiple regions on server" when it tries to split the > system catalog. > > Sample builds where it failed: > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3560//testReport/] > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3571//testReport/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5779) SplitSystemCatalogIT tests fail with Multiple Regions error
[ https://issues.apache.org/jira/browse/PHOENIX-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149372#comment-17149372 ] Hudson commented on PHOENIX-5779: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4009 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4009/]) PHOENIX-5779 SplitSystemCatalogIT tests fail with Multiple Regions error (stoty: rev 713c8d953596f7a002502b7298a393414766a87e) * (edit) phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java > SplitSystemCatalogIT tests fail with Multiple Regions error > --- > > Key: PHOENIX-5779 > URL: https://issues.apache.org/jira/browse/PHOENIX-5779 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.0 >Reporter: Sandeep Guggilam >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5779.master.v1.patch > > > I see the SplitSystemCatalogIT tests failing on master branch complaining > with the error " Multiple regions on server" when it tries to split the > system catalog. > > Sample builds where it failed: > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3560//testReport/] > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3571//testReport/] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5975) Index rebuild/verification page size should be configurable from IndexTool
[ https://issues.apache.org/jira/browse/PHOENIX-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149204#comment-17149204 ] Hudson commented on PHOENIX-5975: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4008 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4008/]) PHOENIX-5975 Index rebuild/verification page size should be configurable (achouhan: rev 81e9a1927a6cf7cf171f6d0544d657509aa8a867) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/ServerBuildIndexCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixServerBuildIndexMapper.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java > Index rebuild/verification page size should be configurable from IndexTool > -- > > Key: PHOENIX-5975 > URL: https://issues.apache.org/jira/browse/PHOENIX-5975 > Project: Phoenix > Issue Type: Improvement >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5975-4.x.001.patch, PHOENIX-5975-4.x.002.patch, > PHOENIX-5975-4.x.patch, PHOENIX-5975-master.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5937) Order by on nullable column sometimes filters rows
[ https://issues.apache.org/jira/browse/PHOENIX-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147820#comment-17147820 ] Hudson commented on PHOENIX-5937: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #4002 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/4002/]) PHOENIX-5937 Order by on nullable column sometimes filters rows (stoty: rev 0bbe2faddce0b9b550a8efd558536bb03cfb133f) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseOrderByIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java > Order by on nullable column sometimes filters rows > -- > > Key: PHOENIX-5937 > URL: https://issues.apache.org/jira/browse/PHOENIX-5937 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 4.x, master >Reporter: Istvan Toth >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5937.master.v1.patch, > PHOENIX-5937.master.v2.patch, PHOENIX-5937.master.v3.patch, > PHOENIX-5937.master.v4.patch > > > When selecting using order by on a nullable column, the rows where the order > column is null are sometimes not returned. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5898) Phoenix function CURRENT_TIME() returns wrong result when view indexes are used.
[ https://issues.apache.org/jira/browse/PHOENIX-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146777#comment-17146777 ] Hudson commented on PHOENIX-5898: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3996 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3996/]) PHOENIX-5898 Phoenix function CURRENT_TIME() returns wrong result when (yanxinyi: rev e6fc80cf706518214c36a92189ab1c5dbb24a9ba) * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificViewIndexIT.java > Phoenix function CURRENT_TIME() returns wrong result when view indexes are > used. > > > Key: PHOENIX-5898 > URL: https://issues.apache.org/jira/browse/PHOENIX-5898 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Jacob Isaac >Assignee: Jacob Isaac >Priority: Major > Fix For: 5.1.0, 4.16.0, 4.x > > Attachments: PHOENIX-5898.4.x.002.patch, SampleTest.java > > > Here is a sample test. > [^SampleTest.java] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5910) IndexTool verification-only runs should have counters for unverified rows
[ https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145823#comment-17145823 ] Hudson commented on PHOENIX-5910: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3989 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3989/]) PHOENIX-5910 IndexTool verification-only runs should have counters for (kozdemir: rev ae227bcb7f06a10d08eec06ec216c5756dd160a4) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexToolJobCounters.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java PHOENIX-5910 Addendum (kozdemir: rev cea5200e94187f8c8e49ef9d17af07c088c6000e) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java > IndexTool verification-only runs should have counters for unverified rows > - > > Key: PHOENIX-5910 > URL: https://issues.apache.org/jira/browse/PHOENIX-5910 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.14.3 >Reporter: Kadir OZDEMIR >Assignee: Kadir OZDEMIR >Priority: Major > Attachments: PHOENIX-5910.4.x.001.patch, PHOENIX-5910.4.x.002.patch > > Time Spent: 2h > Remaining Estimate: 0h > > An index row is considered unverified if the empty column value does not > exist or has a value other than "verified". Although an unverified index row > can be repaired and if so, it is considered a valid row, it is desirable to > have counters for the unverified rows and report them during IndexTool > only-verification runs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5897) SingleKeyValueTuple.toString() returns unexpected result
[
https://issues.apache.org/jira/browse/PHOENIX-5897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142881#comment-17142881
]
Hudson commented on PHOENIX-5897:
-
ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3984 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3984/])
PHOENIX-5897 SingleKeyValueTuple.toString() returns unexpected result.
(chenglei: rev 4d6a67d5ef30bf73a5ac4feddf09969c884e226a)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/schema/tuple/SingleKeyValueTuple.java
* (add)
phoenix-core/src/test/java/org/apache/phoenix/schema/tuple/SingleKeyValueTupleTest.java
> SingleKeyValueTuple.toString() returns unexpected result
>
>
> Key: PHOENIX-5897
> URL: https://issues.apache.org/jira/browse/PHOENIX-5897
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 5.0.0-alpha
>Reporter: Chen Feng
>Assignee: Chen Feng
>Priority: Minor
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5897-v1.patch, PHOENIX-5897_v1-4.x.patch
>
>
> In SingleKeyValueTuple.toString(), the code is shown as follows.
> return "SingleKeyValueTuple[" + cell == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" :
> Bytes.toStringBinary(keyPtr.get(),keyPtr.getOffset(),keyPtr.getLength()) :
> cell.toString() + "]";
> actually, the code runs in the following order.
> ("SingleKeyValueTuple[" + cell) == null ? keyPtr.get() ==
> UNITIALIZED_KEY_BUFFER ? "null" : Bytes.toStringBinary() : (cell.toString() +
> "]");
> Therefore the result is weird.
> BTW, value = condition1 ? condition2 ? X : Y : Z is also confusing, using if
> can be more clear.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5970) ViewUtil.dropChildViews may cause HConnection leak which may cause ITtests hange
[
https://issues.apache.org/jira/browse/PHOENIX-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142882#comment-17142882
]
Hudson commented on PHOENIX-5970:
-
ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3984 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3984/])
PHOENIX-5970 ViewUtil.dropChildViews may cause HConnection leak (chenglei: rev
658464545971c6c7d051c1f8046928725e1aed12)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java
> ViewUtil.dropChildViews may cause HConnection leak which may cause ITtests
> hange
>
>
> Key: PHOENIX-5970
> URL: https://issues.apache.org/jira/browse/PHOENIX-5970
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5970_v1-4.x.patch
>
>
> After PHOENIX-5962, the ITtests still hange , I noticed the RegionServer is
> blocked as follows : (by 4.x branch and HBase1.4.10) :
> {code:java}
> Thread 31512: (state = BLOCKED)
> - java.lang.Thread.sleep(long) @bci=0 (Compiled frame; information may be
> imprecise)
> - java.lang.Thread.sleep(long, int) @bci=57, line=340 (Compiled frame)
> - java.util.concurrent.TimeUnit.sleep(long) @bci=23, line=386 (Compiled
> frame)
> - org.apache.hadoop.hbase.util.RetryCounter.sleepUntilNextRetry() @bci=110,
> line=158 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.getData(java.lang.String,
> org.apache.zookeeper.Watcher, org.apache.zookeeper.data.Stat) @bci=180,
> line=367 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.ZKUtil.getData(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> java.lang.String) @bci=11, line=629 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.MetaTableLocator.getMetaRegionState(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> int) @bci=23, line=487 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.MetaTableLocator.getMetaRegionLocation(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> int) @bci=6, line=168 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.MetaTableLocator.blockUntilAvailable(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> int, long) @bci=63, line=607 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.MetaTableLocator.blockUntilAvailable(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> long) @bci=9, line=588 (Compiled frame)
> -
> org.apache.hadoop.hbase.zookeeper.MetaTableLocator.blockUntilAvailable(org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher,
> long, org.apache.hadoop.conf.Configuration) @bci=34, line=561 (Compiled
> frame)
> - org.apache.hadoop.hbase.client.ZooKeeperRegistry.getMetaRegionLocation()
> @bci=94, line=61 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateMeta(org.apache.hadoop.hbase.TableName,
> boolean, int) @bci=205, line=1266 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(org.apache.hadoop.hbase.TableName,
> byte[], boolean, boolean, int) @bci=119, line=1227 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.CoprocessorHConnection.locateRegion(org.apache.hadoop.hbase.TableName,
> byte[], boolean, boolean, int) @bci=13, line=41 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.relocateRegion(org.apache.hadoop.hbase.TableName,
> byte[], int) @bci=93, line=1201 (Interpreted frame)
> -
> org.apache.hadoop.hbase.client.CoprocessorHConnection.relocateRegion(org.apache.hadoop.hbase.TableName,
> byte[], int) @bci=9, line=41 (Interpreted frame)
> -
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegionInMeta(org.apache.hadoop.hbase.TableName,
> byte[], boolean, boolean, int) @bci=1668, line=1419 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.locateRegion(org.apache.hadoop.hbase.TableName,
> byte[], boolean, boolean, int) @bci=138, line=1230 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.CoprocessorHConnection.locateRegion(org.apache.hadoop.hbase.TableName,
> byte[], boolean, boolean, int) @bci=13, line=41 (Compiled frame)
> -
> org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.getRegionLocations(boolean,
> int, org.apache.hadoop.hbase.client.ClusterConnection,
> org.apache.hadoop.hbase.TableName, byte[]) @bci=22, line=356 (Compiled frame)
> - org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(int)
> @bci=164, line=153 (Compiled frame)
> - org.apache.hadoop.hbase.client.ScannerCallableWithReplicas.call(int)
> @bci=6,
[jira] [Commented] (PHOENIX-5968) Undeclared org.apache.commons.lang dependency
[ https://issues.apache.org/jira/browse/PHOENIX-5968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141209#comment-17141209 ] Hudson commented on PHOENIX-5968: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3982 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3982/]) PHOENIX-5968 Undeclared org.apache.commons.lang dependency (#807) (github: rev e41fc51507ea17c73b519e3d5b574f97c4f567f0) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java > Undeclared org.apache.commons.lang dependency > - > > Key: PHOENIX-5968 > URL: https://issues.apache.org/jira/browse/PHOENIX-5968 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-5968.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > mvn verify/install fails because of org.apache.commons.lang being used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5793) Support parallel init and fast null return for SortMergeJoinPlan.
[ https://issues.apache.org/jira/browse/PHOENIX-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141208#comment-17141208 ] Hudson commented on PHOENIX-5793: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3982 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3982/]) PHOENIX-5793 Support parallel init and fast null return for (chenglei: rev d48e3624d71427707759928830b42e1bd42cea90) * (edit) phoenix-core/src/test/java/org/apache/phoenix/execute/SortMergeJoinTest.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java > Support parallel init and fast null return for SortMergeJoinPlan. > - > > Key: PHOENIX-5793 > URL: https://issues.apache.org/jira/browse/PHOENIX-5793 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Chen Feng >Assignee: Chen Feng >Priority: Minor > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5793-v2.patch, PHOENIX-5793-v3.patch, > PHOENIX-5793-v4.patch, PHOENIX-5793-v5.patch, PHOENIX-5793_v1-4.x.patch > > > For a join sql like A join B. The implementation of SortMergeJoinPlan > currently inits the two iterators A and B one by one. > By initializing A and B in parallel, we can improve performance in two > aspects. > 1) By overlapping the time in initializing. > 2) If one child query is null, the other child query can be canceled since > the final result must be null. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5962) Stabilize builds
[ https://issues.apache.org/jira/browse/PHOENIX-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140973#comment-17140973 ] Hudson commented on PHOENIX-5962: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3979 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3979/]) PHOENIX-5962 Stabilize builds (stoty: rev 82241d4e152023d87bf4cd400942d1c0c2df6562) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexBuildTimestampIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/EnvironmentEdgeManager.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/NonParameterizedIndexScrutinyToolIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationOutputRepositoryIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexVerificationOldDesignIT.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/VerifySingleIndexRowTest.java * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java > Stabilize builds > > > Key: PHOENIX-5962 > URL: https://issues.apache.org/jira/browse/PHOENIX-5962 > Project: Phoenix > Issue Type: Task >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5962.4.x.v1.patch, PHOENIX-5962.master.v1.patch, > PHOENIX-5962.master.v2.patch, PHOENIX-5962.master.v3.patch, > PHOENIX-5962.master.v4.patch, PHOENIX-5962.master.v5.patch, > PHOENIX-5962.master.v6.patch > > > Last 2 build was aborted because Build timed out (after 360 minutes). > Search the possible cause of the problem and try to fix it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5905) Reset user to hbase by changing rpc context before getting user permissions on access controller service
[ https://issues.apache.org/jira/browse/PHOENIX-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139331#comment-17139331 ] Hudson commented on PHOENIX-5905: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3975 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3975/]) PHOENIX-5905 Reset user to hbase by changing rpc context before getting (rajeshbabu chintaguntla: rev b15468e6784a0626bd140ed0c95b317d96efd052) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java > Reset user to hbase by changing rpc context before getting user permissions > on access controller service > - > > Key: PHOENIX-5905 > URL: https://issues.apache.org/jira/browse/PHOENIX-5905 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5905.4.x.patch, > PHOENIX-5905.master.addendum2.patch, PHOENIX-5905.master.addendum3.patch, > PHOENIX-5905.patch, PHOENIX-5905_addendum.patch, PHOENIX-5905_addendum2.patch > > > Currently we are calling getUserPermissions with hbase user directly on > access controller service which is not a rpc call. If we don't reset user > system user will be considered and might expect extra privileges to return > the user permissions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5956) Optimize LeftSemiJoin For SortMergeJoin
[
https://issues.apache.org/jira/browse/PHOENIX-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139286#comment-17139286
]
Hudson commented on PHOENIX-5956:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3976 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3976/])
PHOENIX-5956 Optimize LeftSemiJoin For SortMergeJoin (chenglei: rev
11c24925ec29f91970c36322cf3d7a00a32efc40)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java
* (add)
phoenix-core/src/test/java/org/apache/phoenix/execute/SortMergeJoinTest.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/SortMergeJoinMoreIT.java
> Optimize LeftSemiJoin For SortMergeJoin
>
>
> Key: PHOENIX-5956
> URL: https://issues.apache.org/jira/browse/PHOENIX-5956
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0
>Reporter: chenglei
>Assignee: chenglei
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5956_v1-4.x.patch
>
>
> When LHS left semi join RHS through {{SortMergeJoinPlan}}, if RHS is end and
> returns null, then the left semi join could end early, but for
> {{SortMergeJoinPlan.SemiAntiJoinIterator}} , it would continue until LHS is
> exhausted even if RHS returns null, which is unnecessary.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5783) Implement starttime in IndexTool for rebuild and verification
[ https://issues.apache.org/jira/browse/PHOENIX-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138917#comment-17138917 ] Hudson commented on PHOENIX-5783: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3974 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3974/]) PHOENIX-5783: Implement starttime in IndexTool for rebuild and (github: rev 6393462ced536efe1d88fda03421dc470ffb0990) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java > Implement starttime in IndexTool for rebuild and verification > - > > Key: PHOENIX-5783 > URL: https://issues.apache.org/jira/browse/PHOENIX-5783 > Project: Phoenix > Issue Type: Bug >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5783.4.x.001.patch, PHOENIX-5783.4.x.010.patch, > PHOENIX-5783.4.x.011.patch, PHOENIX-5783.4.x.100.patch, > PHOENIX-5783.4.x.v1.patch, PHOENIX-5783.4.x.v2.patch, > PHOENIX-5783.4.x.v3.patch, PHOENIX-5783.v1.patch > > Time Spent: 2h > Remaining Estimate: 0h > > IndexTool's inline verification and rebuild should be able to perform the > logic for a specified time range given by starttime parameters. > > This feature is only for indexes on non-transactional tables > . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5875) Optional logging for IndexTool verification
[ https://issues.apache.org/jira/browse/PHOENIX-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135068#comment-17135068 ] Hudson commented on PHOENIX-5875: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3961 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3961/]) PHOENIX-5875 - Optional logging for IndexTool verification (gjacoby: rev 2b9404c2d7dd3d6b5a4bddfa76a38f7a57baf738) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationOutputRepositoryIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/IndexToolTest.java > Optional logging for IndexTool verification > --- > > Key: PHOENIX-5875 > URL: https://issues.apache.org/jira/browse/PHOENIX-5875 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.14.3 >Reporter: Kadir OZDEMIR >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5875-4.x.v1.patch, PHOENIX-5875-4.x.v2.patch, > PHOENIX-5875-4.x.v3.patch, PHOENIX-5875.v1.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > IndexTool logs information about each row that has a verification failure. > The amount of logging can be excessive for large index tables. Also for some > runs, we may want to just do incremental repair, i.e., repair only the rows > that are broken, using -v BOTH or -v BEFORE, but not interested in the > details of how they are broken. Thus, IndexTool should have an option to > disable logging, something like, -dl (--disable-logging) BEFORE | AFTER | > BOTH where BEFORE, AFTER and BOTH indicate at the which phase (before or > after index repair or a both phases ) logging is disabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5884) Join query return empty result when filters for both the tables are present
[
https://issues.apache.org/jira/browse/PHOENIX-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135069#comment-17135069
]
Hudson commented on PHOENIX-5884:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3961 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3961/])
PHOENIX-5884 Join query return empty result when filters for both the (ankit:
rev 7e955ecbcf967e74fbb37e5d0c9c5556ebac5898)
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/WhereOptimizerForJoinFiltersIT.java
> Join query return empty result when filters for both the tables are present
> ---
>
> Key: PHOENIX-5884
> URL: https://issues.apache.org/jira/browse/PHOENIX-5884
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.14.0
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5884.master.v2.patch,
> PHOENIX-5884.master.v3.patch, PHOENIX-5884.master.v4.patch,
> PHOENIX-5884.master.v5.patch, PHOENIX-5884_v1.patch
>
>
> Let's assume DDL to be same for both the tables involved in a join
> {code}
> CREATE TABLE LeftTable (id1 CHAR(6) NOT NULL,id2 VARCHAR(22) NOT
> NULL,id3 VARCHAR(12) NOT NULL,id4 CHAR(2) NOT NULL,id5 CHAR(6)
> NOT NULL, id6 VARCHAR(200) NOT NULL,id7 VARCHAR(50) NOT NULL,ts
> TIMESTAMP ,CONSTRAINT PK_JOIN_AND_INTERSECTION_TABLE PRIMARY
> KEY(id1,id2,id3,id4,id5,id6,id7))
> {code}
> Following query return right results
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where r.id1 IN ('201904','201905') and r.id2 = 'ID2_VAL' and
> r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
> but When to optimize the query, filters for the left table are also added ,
> query returned empty result . Though the filters are based on join condition
> so semantically above query and below query should be same.
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where m.id1 IN ('201904','201905') and r.id1 IN
> ('201904','201905') and r.id2 = 'ID2_VAL' and m.id3 IN
> ('ID3_VAL','ID3_VAL2') and r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5932) View Index rebuild results in surplus rows from other view indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133501#comment-17133501 ] Hudson commented on PHOENIX-5932: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3954 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3954/]) PHOENIX-5932 View Index rebuild results in surplus rows from other view (achouhan: rev 3a8234659e38902177d08f5f9efee1214c0e74a9) * (add) phoenix-core/src/main/java/org/apache/phoenix/filter/DelegateFilter.java * (add) phoenix-core/src/main/java/org/apache/phoenix/filter/AllVersionsIndexRebuildFilter.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java > View Index rebuild results in surplus rows from other view indexes > -- > > Key: PHOENIX-5932 > URL: https://issues.apache.org/jira/browse/PHOENIX-5932 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.16.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5932-4.x.001.patch, PHOENIX-5932-4.x.001.patch, > PHOENIX-5932-4.x.patch, PHOENIX-5932-master.patch, > PHOENIX-5932-wip-4.x.001.patch, PHOENIX-5932-wip-4.x.patch, > PHOENIX-5932-wip-master.001.patch, PHOENIX-5932-wip-master.patch > > Time Spent: 2.5h > Remaining Estimate: 0h > > Steps to reproduce > # Create a table with PK as COL1, COL2 > # Create 2 views with different view constants on COL2. Also add other > columns > # Upsert rows into the views > # Create indexes on the views. Rebuild will result in each view index having > rows from other view also > This is because we set the filter on scan to null during rebuild > [here|[https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L1084]] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5942) ParameterizedIndexUpgradeIT is too slow
[ https://issues.apache.org/jira/browse/PHOENIX-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133503#comment-17133503 ] Hudson commented on PHOENIX-5942: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3954 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3954/]) PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow (#798) (gjacoby: rev 1080422e626c2451556dc4c3f66c6c0e1010693a) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java > ParameterizedIndexUpgradeIT is too slow > --- > > Key: PHOENIX-5942 > URL: https://issues.apache.org/jira/browse/PHOENIX-5942 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Minor > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5942-4.x.v1.patch > > Time Spent: 1h > Remaining Estimate: 0h > > The test creates the same tables and views for each test case, drops them > between, and recreates them. In addition each test case is doing index > upgrades / downgrades which requires disabling tables and rebuilding them. > Plus there are a lot of test cases, because of the cross-product of the > parameters. > According to [~achouhan], this is causing some builds to fail with timeouts, > and taking 20-30 min for me locally the last time I needed to add a test > case. Looks like it's time to refactor this test so it goes faster. > I suspect just having each test case create its own test-specific tables (so > no more dropping) would help, but that may not be enough. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5903) Mark more hbase dependency's scope as provided for phoenix-server
[ https://issues.apache.org/jira/browse/PHOENIX-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17133502#comment-17133502 ] Hudson commented on PHOENIX-5903: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3954 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3954/]) PHOENIX-5903 Mark more hbase dependency's scope as provided for (stoty: rev 1d515374ceec07a79e166bee0f995e3d2215a977) * (edit) phoenix-server/pom.xml * (edit) pom.xml > Mark more hbase dependency's scope as provided for phoenix-server > - > > Key: PHOENIX-5903 > URL: https://issues.apache.org/jira/browse/PHOENIX-5903 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.1.0 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5903.master.001.patch > > > The new phoenix-server-*.jar seems bigger than before. It include many hbase > classes from hbase dependency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5896) Implement incremental rebuild along the failed regions in IndexTool
[ https://issues.apache.org/jira/browse/PHOENIX-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129858#comment-17129858 ] Hudson commented on PHOENIX-5896: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3949 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3949/]) PHOENIX-5896: Implement incremental rebuild along the failed regions in (s.kadam: rev 1c2a23190069d10a25537c7ee6ed0ed1733fafc9) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixServerBuildIndexInputFormat.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtilTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexerRegionScanner.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/IndexToolTest.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/IndexUpgradeToolTest.java * (add) phoenix-core/src/test/java/org/apache/phoenix/index/ShouldVerifyTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRepository.java > Implement incremental rebuild along the failed regions in IndexTool > --- > > Key: PHOENIX-5896 > URL: https://issues.apache.org/jira/browse/PHOENIX-5896 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5896.4.x.add0.patch, PHOENIX-5896.4.x.v1.patch, > PHOENIX-5896.4.x.v2.patch, PHOENIX-5896.4.x.v3.patch, > PHOENIX-5896.4.x.v4.patch, PHOENIX-5896.v1.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > As we run the index tool on indexes to be rebuilt after the upgrade, it > spends some time in rescanning successful regions from the last rebuild. We > want to make the index tool a little smarter to not rebuild rows from the > regions that were found in the PIT_result table from the last rebuild. > PIT_result logs region info if it was successfully rebuilt in the last run. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5876) IndexTool updates the index state when it runs with ONLY option
[ https://issues.apache.org/jira/browse/PHOENIX-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128872#comment-17128872 ] Hudson commented on PHOENIX-5876: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3944 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3944/]) PHOENIX-5876 Let indexTool running with ONLY option not change index (s.kadam: rev 28525790a2c0851be201c8432c82044f1a1a614e) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java > IndexTool updates the index state when it runs with ONLY option > --- > > Key: PHOENIX-5876 > URL: https://issues.apache.org/jira/browse/PHOENIX-5876 > Project: Phoenix > Issue Type: Bug >Reporter: Weiming Wang >Assignee: Weiming Wang >Priority: Minor > Fix For: 4.16.0 > > Attachments: PHOENIX-5876.4.x.001.patch, PHOENIX-5876.4.x.001.patch, > PHOENIX-5876.4.x.001.patch > > > When IndexTool runs with ONLY option, it is NOT supposed to update the index > state, since it never rebuild the index. However current code is working the > opposite way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5876) IndexTool updates the index state when it runs with ONLY option
[ https://issues.apache.org/jira/browse/PHOENIX-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128871#comment-17128871 ] Hudson commented on PHOENIX-5876: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3943 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3943/]) PHOENIX-5876 Let indexTool running with ONLY option not change index (s.kadam: rev 28525790a2c0851be201c8432c82044f1a1a614e) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java > IndexTool updates the index state when it runs with ONLY option > --- > > Key: PHOENIX-5876 > URL: https://issues.apache.org/jira/browse/PHOENIX-5876 > Project: Phoenix > Issue Type: Bug >Reporter: Weiming Wang >Assignee: Weiming Wang >Priority: Minor > Fix For: 4.16.0 > > Attachments: PHOENIX-5876.4.x.001.patch, PHOENIX-5876.4.x.001.patch, > PHOENIX-5876.4.x.001.patch > > > When IndexTool runs with ONLY option, it is NOT supposed to update the index > state, since it never rebuild the index. However current code is working the > opposite way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5876) IndexTool updates the index state when it runs with ONLY option
[ https://issues.apache.org/jira/browse/PHOENIX-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128864#comment-17128864 ] Hudson commented on PHOENIX-5876: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3945 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3945/]) PHOENIX-5876 Let indexTool running with ONLY option not change index (s.kadam: rev 28525790a2c0851be201c8432c82044f1a1a614e) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java > IndexTool updates the index state when it runs with ONLY option > --- > > Key: PHOENIX-5876 > URL: https://issues.apache.org/jira/browse/PHOENIX-5876 > Project: Phoenix > Issue Type: Bug >Reporter: Weiming Wang >Assignee: Weiming Wang >Priority: Minor > Fix For: 4.16.0 > > Attachments: PHOENIX-5876.4.x.001.patch, PHOENIX-5876.4.x.001.patch, > PHOENIX-5876.4.x.001.patch > > > When IndexTool runs with ONLY option, it is NOT supposed to update the index > state, since it never rebuild the index. However current code is working the > opposite way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5931) PhoenixIndexFailurePolicy throws NPE if cause of IOE is null
[ https://issues.apache.org/jira/browse/PHOENIX-5931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126410#comment-17126410 ] Hudson commented on PHOENIX-5931: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3937 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3937/]) PHOENIX-5931 PhoenixIndexFailurePolicy throws NPE if cause of IOE is (achouhan: rev 77c6cb32fce04b912b7c502dc170d86af8293fe6) * (edit) phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixIndexFailurePolicy.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java > PhoenixIndexFailurePolicy throws NPE if cause of IOE is null > > > Key: PHOENIX-5931 > URL: https://issues.apache.org/jira/browse/PHOENIX-5931 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.16.0 >Reporter: Abhishek Singh Chouhan >Assignee: Abhishek Singh Chouhan >Priority: Minor > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5931-4.x.001.patch, PHOENIX-5931-4.x.patch, > PHOENIX-5931-master.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5905) Reset user to hbase by changing rpc context before getting user permissions on access controller service
[ https://issues.apache.org/jira/browse/PHOENIX-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126306#comment-17126306 ] Hudson commented on PHOENIX-5905: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3933 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3933/]) PHOENIX-5905 Reset user to hbase by changing rpc context before getting (rajeshbabu chintaguntla: rev 73277b153e80ab0b187055ac8bf82e24f3baa770) * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/PermissionNSDisabledWithCustomAccessControllerIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/PermissionNSEnabledWithCustomAccessControllerIT.java > Reset user to hbase by changing rpc context before getting user permissions > on access controller service > - > > Key: PHOENIX-5905 > URL: https://issues.apache.org/jira/browse/PHOENIX-5905 > Project: Phoenix > Issue Type: Bug >Reporter: Rajeshbabu Chintaguntla >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5905.master.addendum2.patch, PHOENIX-5905.patch, > PHOENIX-5905_addendum.patch, PHOENIX-5905_addendum2.patch > > > Currently we are calling getUserPermissions with hbase user directly on > access controller service which is not a rpc call. If we don't reset user > system user will be considered and might expect extra privileges to return > the user permissions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5884) Join query return empty result when filters for both the tables are present
[
https://issues.apache.org/jira/browse/PHOENIX-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123913#comment-17123913
]
Hudson commented on PHOENIX-5884:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3919 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3919/])
PHOENIX-5884 Join query return empty result when filters for both the (stoty:
rev 02047c0a25e9375b43679c690d45d51a4ba8ba2d)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java
* (add)
phoenix-core/src/it/java/org/apache/phoenix/end2end/join/WhereOptimizerForJoinFiltersIT.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/InListIT.java
> Join query return empty result when filters for both the tables are present
> ---
>
> Key: PHOENIX-5884
> URL: https://issues.apache.org/jira/browse/PHOENIX-5884
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.14.0
>Reporter: Ankit Singhal
>Assignee: Ankit Singhal
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5884.master.v2.patch,
> PHOENIX-5884.master.v3.patch, PHOENIX-5884.master.v4.patch,
> PHOENIX-5884.master.v5.patch, PHOENIX-5884_v1.patch
>
>
> Let's assume DDL to be same for both the tables involved in a join
> {code}
> CREATE TABLE LeftTable (id1 CHAR(6) NOT NULL,id2 VARCHAR(22) NOT
> NULL,id3 VARCHAR(12) NOT NULL,id4 CHAR(2) NOT NULL,id5 CHAR(6)
> NOT NULL, id6 VARCHAR(200) NOT NULL,id7 VARCHAR(50) NOT NULL,ts
> TIMESTAMP ,CONSTRAINT PK_JOIN_AND_INTERSECTION_TABLE PRIMARY
> KEY(id1,id2,id3,id4,id5,id6,id7))
> {code}
> Following query return right results
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where r.id1 IN ('201904','201905') and r.id2 = 'ID2_VAL' and
> r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
> but When to optimize the query, filters for the left table are also added ,
> query returned empty result . Though the filters are based on join condition
> so semantically above query and below query should be same.
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where m.id1 IN ('201904','201905') and r.id1 IN
> ('201904','201905') and r.id2 = 'ID2_VAL' and m.id3 IN
> ('ID3_VAL','ID3_VAL2') and r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5922) IndexUpgradeTool should always re-enable tables on failure
[ https://issues.apache.org/jira/browse/PHOENIX-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120040#comment-17120040 ] Hudson commented on PHOENIX-5922: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3904 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3904/]) PHOENIX-5922 - IndexUpgradeTool should always re-enable tables on (gjacoby: rev 1c6d2afb72c1f39f376b4ac11734964ade30dee1) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java > IndexUpgradeTool should always re-enable tables on failure > -- > > Key: PHOENIX-5922 > URL: https://issues.apache.org/jira/browse/PHOENIX-5922 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5922-4.x.v1.patch, PHOENIX-5922.v1.patch > > Time Spent: 50m > Remaining Estimate: 0h > > If an error occurs while doing an index upgrade, the IndexUpgradeTool will > try to rollback the upgrade operations to leave the cluster in its initial > state. However, if the rollback fails, it will give up. This can leave tables > disabled for long periods until operators manually re-enable them. > If rollback fails, the IndexUpgradeTool should always re-enable the affected > tables at the HBase level. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5922) IndexUpgradeTool should always re-enable tables on failure
[ https://issues.apache.org/jira/browse/PHOENIX-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119312#comment-17119312 ] Hudson commented on PHOENIX-5922: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3902 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3902/]) Revert "PHOENIX-5922 - IndexUpgradeTool should always re-enable tables (elserj: rev 18b219d7d270d546d7be29164229161531bd9330) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java > IndexUpgradeTool should always re-enable tables on failure > -- > > Key: PHOENIX-5922 > URL: https://issues.apache.org/jira/browse/PHOENIX-5922 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5922-4.x.v1.patch, PHOENIX-5922.v1.patch > > Time Spent: 50m > Remaining Estimate: 0h > > If an error occurs while doing an index upgrade, the IndexUpgradeTool will > try to rollback the upgrade operations to leave the cluster in its initial > state. However, if the rollback fails, it will give up. This can leave tables > disabled for long periods until operators manually re-enable them. > If rollback fails, the IndexUpgradeTool should always re-enable the affected > tables at the HBase level. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5921) Phoenix Index verification logging Exception with huge huge row
[
https://issues.apache.org/jira/browse/PHOENIX-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119109#comment-17119109
]
Hudson commented on PHOENIX-5921:
-
ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3900 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3900/])
PHOENIX-5921 Shorten verification phase fail log line and add a metric
(giskender: rev dcc88af8acc2ba8df10d2e9d498ab3646fdf0a78)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MutationMetricQueue.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/monitoring/BasePhoenixMetricsIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java
> Phoenix Index verification logging Exception with huge huge row
> ---
>
> Key: PHOENIX-5921
> URL: https://issues.apache.org/jira/browse/PHOENIX-5921
> Project: Phoenix
> Issue Type: Bug
>Reporter: Gokcen Iskender
>Assignee: Gokcen Iskender
>Priority: Minor
> Attachments: PHOENIX-5921.4.x.001.patch, PHOENIX-5921.master.001.patch
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> 3ppnx`20200523045831.177``4142`0`0``4aeb16f3f1064824`0```fT:020`224.22.5```Ignoring
> exception that happened during setting index verified value to verified=TRUE
> {org.apache.phoenix.execute.MutationState$TableInfo
>
> This logging line is huge
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5922) IndexUpgradeTool should always re-enable tables on failure
[ https://issues.apache.org/jira/browse/PHOENIX-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119110#comment-17119110 ] Hudson commented on PHOENIX-5922: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3900 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3900/]) PHOENIX-5922 - IndexUpgradeTool should always re-enable tables on (gjacoby: rev 45929b5a74feddb647571c7d7c057142973b45b0) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java > IndexUpgradeTool should always re-enable tables on failure > -- > > Key: PHOENIX-5922 > URL: https://issues.apache.org/jira/browse/PHOENIX-5922 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5922-4.x.v1.patch > > Time Spent: 50m > Remaining Estimate: 0h > > If an error occurs while doing an index upgrade, the IndexUpgradeTool will > try to rollback the upgrade operations to leave the cluster in its initial > state. However, if the rollback fails, it will give up. This can leave tables > disabled for long periods until operators manually re-enable them. > If rollback fails, the IndexUpgradeTool should always re-enable the affected > tables at the HBase level. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5804) Implement strong verification with -v ONLY option for old design of secondary indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118264#comment-17118264 ] Hudson commented on PHOENIX-5804: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3899 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3899/]) PHOENIX-5804: Implement strong verification with -v ONLY option for old (s.kadam: rev 85724aae4bbe1420333a3301861668549a772c83) * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java * (add) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexerRegionScanner.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexVerificationOldDesignIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolForNonTxGlobalIndexIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/VerifySingleIndexRowTest.java * (add) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java * (add) phoenix-core/src/main/java/org/apache/phoenix/util/ManualEnvironmentEdge.java > Implement strong verification with -v ONLY option for old design of secondary > indexes > - > > Key: PHOENIX-5804 > URL: https://issues.apache.org/jira/browse/PHOENIX-5804 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5804.4.x.v1.patch, PHOENIX-5804.4.x.v2.patch, > PHOENIX-5804.4.x.v3.patch, PHOENIX-5804.4.x.v4.patch, > PHOENIX-5804.4.x.v5.patch, PHOENIX-5804.v1.patch, PHOENIX-5804.v2.patch > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently, with -v ONLY option we get weak verification i.e. we find out if > index row is present or not. It does not provide information on if the values > have mismatch when executed with old design. > We attempt to provide scrutiny like implementation but way faster. The > verification will be done only one the latest version of the row. > This will help us in quantifying the success of new self-consistent secondary > indexes design. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5890) Port PHOENIX-5799 to master
[ https://issues.apache.org/jira/browse/PHOENIX-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117343#comment-17117343 ] Hudson commented on PHOENIX-5890: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3894 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3894/]) PHOENIX-5890: Port Phoenix-5799 to master (#787) (github: rev 5a9ec5552fb63fdf640e0c9adbb81eb6eec0ccae) * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRepository.java * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRow.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationOutputRepositoryIT.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationResultRepositoryIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ByteUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java > Port PHOENIX-5799 to master > --- > > Key: PHOENIX-5890 > URL: https://issues.apache.org/jira/browse/PHOENIX-5890 > Project: Phoenix > Issue Type: Improvement >Reporter: Geoffrey Jacoby >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5890.v1.patch > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5799) Inline Index Verification Output API
[ https://issues.apache.org/jira/browse/PHOENIX-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117344#comment-17117344 ] Hudson commented on PHOENIX-5799: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3894 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3894/]) PHOENIX-5890: Port Phoenix-5799 to master (#787) (github: rev 5a9ec5552fb63fdf640e0c9adbb81eb6eec0ccae) * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRepository.java * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationOutputRow.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (add) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexVerificationResultRepository.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationOutputRepositoryIT.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexVerificationResultRepositoryIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/ByteUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java > Inline Index Verification Output API > > > Key: PHOENIX-5799 > URL: https://issues.apache.org/jira/browse/PHOENIX-5799 > Project: Phoenix > Issue Type: Bug >Reporter: Geoffrey Jacoby >Assignee: Geoffrey Jacoby >Priority: Major > Fix For: 4.16.0 > > Attachments: PHOENIX-5799-4.x.v1.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Followup from PHOENIX-5773 -- split out the logic in > IndexRebuildRegionScanner that writes to the output table into its own class, > plus add read methods and tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5892) Add code coverage steps in build documentation
[ https://issues.apache.org/jira/browse/PHOENIX-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107498#comment-17107498 ] Hudson commented on PHOENIX-5892: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3854 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3854/]) PHOENIX-5892 Add code coverage steps in build documentation (chinmayskulkarni: rev 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a) * (edit) BUILDING.md > Add code coverage steps in build documentation > -- > > Key: PHOENIX-5892 > URL: https://issues.apache.org/jira/browse/PHOENIX-5892 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5892.4.x.v1.patch, PHOENIX-5892.master.v1.patch > > > We need to add the steps for code coverage feature as part of build > documentation. The feature is introduced as part of PHOENIX-5842 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5891) Ensure that code coverage does not drop with subsequent commits
[ https://issues.apache.org/jira/browse/PHOENIX-5891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107497#comment-17107497 ] Hudson commented on PHOENIX-5891: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3854 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3854/]) PHOENIX-5891: Ensure that code coverage does not drop with subsequent (chinmayskulkarni: rev c5be82757930b4c256c95947b11487b7a686212b) * (edit) pom.xml * (edit) phoenix-pherf/pom.xml > Ensure that code coverage does not drop with subsequent commits > --- > > Key: PHOENIX-5891 > URL: https://issues.apache.org/jira/browse/PHOENIX-5891 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5891-master-v1.patch > > > With [PHOENIX-5842|https://issues.apache.org/jira/browse/PHOENIX-5842], we > added Jacoco code coverage to Hadoop QA precommit runs. We should add a check > to test-patch.sh to ensure that the code coverage numbers do not drop when > applying a new patch. > This can also check that overall code coverage is above a fixed threshold as > well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5842) Code Coverage tool for Phoenix
[ https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106828#comment-17106828 ] Hudson commented on PHOENIX-5842: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3853 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3853/]) (Addendum) PHOENIX-5842 Check for absence of system property to (chinmayskulkarni: rev 753895fda79da19cd35e098e63abcab7310ca204) * (edit) pom.xml > Code Coverage tool for Phoenix > -- > > Key: PHOENIX-5842 > URL: https://issues.apache.org/jira/browse/PHOENIX-5842 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch, > PHOENIX-5842.master.v1.patch, PHOENIX-5842_addendum.4.x.patch, > PHOENIX-5842_addendum.patch > > > Currently we don't have any code coverage tool for Phoenix. This is required > for us to measure the test coverage and helps us in improving the test suite > further till we reach may be 80% coverage > The test coverage results can also be integrated into the Hadoop QA run of > the precommit build such that the reviewers could take a look at the report > and see if the added code doesn't have enough coverage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-4753) Remove the need for users to have Write access to the Phoenix SYSTEM STATS TABLE to drop tables
[
https://issues.apache.org/jira/browse/PHOENIX-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105125#comment-17105125
]
Hudson commented on PHOENIX-4753:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3842 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3842/])
PHOENIX-4753 Remove the need for users to have Write access to the (rajeshbabu
chintaguntla: rev 1740409a56a621452b32771ca80d16b61f25c4a7)
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java
> Remove the need for users to have Write access to the Phoenix SYSTEM STATS
> TABLE to drop tables
> ---
>
> Key: PHOENIX-4753
> URL: https://issues.apache.org/jira/browse/PHOENIX-4753
> Project: Phoenix
> Issue Type: Bug
>Reporter: Saumil Mayani
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Labels: SFDC, namespaces, security
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-4753.patch, PHOENIX-4753_v2.patch,
> PHOENIX-4753_v3.patch
>
>
> Problem statement:-
> With [PHOENIX-4198|https://issues.apache.org/jira/browse/PHOENIX-4198] a user
> only needs RX permissions for SYSTEM CATALOG Table, however, it required to
> have a write permission to SYSTEM STATS Table when performing drop operation
> on a table. This is a security concern as they can create/alter/drop/corrupt
> STATS data of any other table without proper access to the corresponding
> physical tables.
> STEPS TO REPRODUCE:
> 1. Set the following properties in hbase-site.xml:
>
> {code:java}
> # File: hbase-site.xml
>
> # Properties=value
> hbase.security.authorization=true
> hbase.coprocessor.master.classes=org.apache.hadoop.hbase.security.access.AccessController
> hbase.coprocessor.region.classes=org.apache.hadoop.hbase.security.access.AccessController,
> org.apache.hadoop.hbase.security.token.TokenProvider,
> org.apache.hadoop.hbase.security.access.SecureBulkLoadEndpoint
> hbase.coprocessor.regionserver.classes=org.apache.hadoop.hbase.security.access.AccessController
> phoenix.acls.enabled=true
> phoenix.schema.isNamespaceMappingEnabled=true
> phoenix.schema.mapSystemTablesToNamespace=true
> {code}
>
> 2. Grant READ permission on SYSTEM Namespace and RWXCA on the user
> Namespace, to the user:
>
> {code:java}
> # Example: user01t01 belong to tenant01
>
> # Grant a user read permission to "SYSTEM" Namespace
> > grant 'user01t01', 'RX' , '@SYSTEM'
>
> # Grant respective 'RWXCA' [READ('R'), WRITE('W'), EXEC('X'),
> CREATE('C'), ADMIN('A')] permissions on user namespace
> > grant 'user01t01', 'RWXCA' , '@TENANT01'
> {code}
>
> 3. Login as 'user01t01' and perform the operations. to create table, add data
> , update statistics and drop table.
>
> {code:java}
> # Login as the user 'user01t01'
> kinit user01t01
> # create table under namespace / schema tenant01
> create table tenant01.test (mykey integer not null primary key, mycolumn
> varchar);
> # Insert some data
> upsert into tenant01.test values (1,'Hello');
> upsert into tenant01.test values (2,'World!');
> # select / read back the data inserted.
> select * from tenant01.test;
> # check if the STATS table has information for "tenant01.test"
> select * from SYSTEM.STATS where PHYSICAL_NAME='TENANT01:TEST';
> # If no record in SYSTEM.STATS, update stats.
> update statistics tenant01.test;
> # Drop the table
> drop table tenant01.test;
> {code}
>
>
> Following Error gets reported, although the Table is dropped from
> SYSTEM:CATALOG Table, but the record exist in SYSTEM:STATS Table.
>
> {code:java}
> Error: org.apache.phoenix.exception.PhoenixIOException:
> org.apache.hadoop.hbase.security.AccessDeniedException: Insufficient
> permissions (user=user01...@example.com, scope=SYSTEM:STATS, family=0:,
> params=[table=SYSTEM:STATS,family=0:],action=WRITE)
> at
> org.apache.hadoop.hbase.security.access.AccessController.preDelete(AccessController.java:1701)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$33.call(RegionCoprocessorHost.java:941)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$RegionOperation.call(RegionCoprocessorHost.java:1660)
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.execOperation(RegionCoprocessorHost.java:1734)
> at
>
[jira] [Commented] (PHOENIX-5842) Code Coverage tool for Phoenix
[ https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105126#comment-17105126 ] Hudson commented on PHOENIX-5842: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3842 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3842/]) PHOENIX-5842 Code Coverage tool for Phoenix (chinmayskulkarni: rev 8fd11783cd132817604f9e84a4e4b8d716042e0e) * (edit) dev/test-patch.sh * (edit) pom.xml > Code Coverage tool for Phoenix > -- > > Key: PHOENIX-5842 > URL: https://issues.apache.org/jira/browse/PHOENIX-5842 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Labels: quality-improvement > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch, > PHOENIX-5842.master.v1.patch, PHOENIX-5842_addendum.patch > > > Currently we don't have any code coverage tool for Phoenix. This is required > for us to measure the test coverage and helps us in improving the test suite > further till we reach may be 80% coverage > The test coverage results can also be integrated into the Hadoop QA run of > the precommit build such that the reviewers could take a look at the report > and see if the added code doesn't have enough coverage -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5543) Implement show schemas / show tables SQL commands
[
https://issues.apache.org/jira/browse/PHOENIX-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102269#comment-17102269
]
Hudson commented on PHOENIX-5543:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3841 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3841/])
PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands (gjacoby: rev
116b9bd667b0cf0e22a45c42e878e97c20c1fc58)
* (edit)
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/PhoenixUtil.java
* (add) phoenix-core/src/main/java/org/apache/phoenix/parse/ShowStatement.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java
* (edit) phoenix-core/src/main/antlr3/PhoenixSQL.g
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java
* (add)
phoenix-core/src/main/java/org/apache/phoenix/parse/ShowTablesStatement.java
* (add)
phoenix-core/src/main/java/org/apache/phoenix/parse/ShowSchemasStatement.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java
* (edit) phoenix-core/src/main/java/org/apache/phoenix/util/QueryUtil.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java
> Implement show schemas / show tables SQL commands
> -
>
> Key: PHOENIX-5543
> URL: https://issues.apache.org/jira/browse/PHOENIX-5543
> Project: Phoenix
> Issue Type: Improvement
>Affects Versions: 4.15.0, 5.1.0
>Reporter: Bharath Vissapragada
>Assignee: Bharath Vissapragada
>Priority: Minor
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5543-4.x.v1.patch, PHOENIX-5543.master.v1.patch,
> PHOENIX-5543.master.v2.patch, PHOENIX-5543.master.v3.patch
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Currently users rely on {{!tables}} and {{!schemas}} commands provided by
> sqlline which pulls the information using the standard JDBC metadata calls
> like {{getTables()}} and {{getSchemas()}}.
> Most other databases (like mysql[1,2]) implement these as first class SQL
> commands that gives the user more flexibility in querying by adding necessary
> filters and looking up for table information in specific schemas. The ask
> here is to implement the following SQL commands.
> {noformat}
> SHOW SCHEMAS [LIKE '']
> SHOW TABLES [IN ] [LIKE '']
> {noformat}
> [1] https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
> [2] https://dev.mysql.com/doc/refman/8.0/en/show-databases.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5580) Wrong values seen when updating a view for a table that has an index
[
https://issues.apache.org/jira/browse/PHOENIX-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100305#comment-17100305
]
Hudson commented on PHOENIX-5580:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3811 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3811/])
PHOENIX-5580 Wrong values seen when updating a view for a table that has
(achouhan: rev 364b62c34547a3a4e4b5496e1e50eee1d6daa514)
* (edit) phoenix-protocol/src/main/ServerCachingService.proto
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
* (edit)
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/generated/ServerCachingProtos.java
> Wrong values seen when updating a view for a table that has an index
>
>
> Key: PHOENIX-5580
> URL: https://issues.apache.org/jira/browse/PHOENIX-5580
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.14.1, 4.14.3
>Reporter: Swaroopa Kadam
>Assignee: Sandeep Guggilam
>Priority: Major
> Labels: indexing, phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5580.4.x.v1.patch, PHOENIX-5580.4.x.v2.patch,
> PHOENIX-5580.4.x.v3.patch, PHOENIX-5580.master.v1.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> {code:sql}
> CREATE TABLE IF NOT EXISTS TEST (ID INTEGER NOT NULL PRIMARY KEY, HOST
> VARCHAR(10));
> CREATE INDEX I ON TEST(HOST);
> -- create updatable view (equality condition in where clause)
> CREATE VIEW V1 (col1 INTEGER) AS SELECT * FROM TEST WHERE ID=15;
> UPSERT INTO V1(ID, HOST, col1) VALUES (15, 'this', 7);
> SELECT * FROM TEST;
> -- Wrong results, but correct results when using the NO_INDEX hint
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5808) Improve shaded artifact naming convetions
[ https://issues.apache.org/jira/browse/PHOENIX-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093683#comment-17093683 ] Hudson commented on PHOENIX-5808: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3792 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3792/]) PHOENIX-5808 Improve shaded artifact naming convetions (stoty: rev 490c18d7fe59b2199d4d3aacf350c8c2e393c258) * (edit) phoenix-assembly/pom.xml * (edit) phoenix-server/pom.xml * (edit) phoenix-assembly/src/build/components/all-common-jars.xml * (edit) phoenix-client/pom.xml * (edit) bin/phoenix_utils.py * (edit) pom.xml > Improve shaded artifact naming convetions > - > > Key: PHOENIX-5808 > URL: https://issues.apache.org/jira/browse/PHOENIX-5808 > Project: Phoenix > Issue Type: Improvement > Components: core >Affects Versions: 5.1.0, 4.x >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5808.master.v1.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > As suggested by [~elserj] in the dev list, there is room for improvment in > the naming of the shaded phoenix artifacts: > * We are creating useless unshaded client and server artifacts, which should > be removed > * This would free up the filenames for adding unversioned symlinks to the > shaded client and server JARS in the assembly named (where xx is _client_ or > _server_, and version is the phoenix version): > ** phoenix-xx-version.jar > ** phoenix-xx.jar > * We should consider removing the legacy phoenix-verson-xx.jar symlinks to > the same -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5789) try to standardize on a JSON library
[ https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093357#comment-17093357 ] Hudson commented on PHOENIX-5789: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3791 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3791/]) PHOENIX-5789 try to standardize on a JSON library (addendum: use single (stoty: rev 07bd1c5a1df0b7cded9fd2ff0177afd792a714b2) * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/bulkload/TargetTableRefFunctions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/IndexRebuildTask.java * (add) phoenix-core/src/main/java/org/apache/phoenix/util/JacksonUtil.java * (edit) phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/automation/PhoenixMRJobSubmitter.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/JsonToKeyValueMapper.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java > try to standardize on a JSON library > > > Key: PHOENIX-5789 > URL: https://issues.apache.org/jira/browse/PHOENIX-5789 > Project: Phoenix > Issue Type: Improvement > Components: core >Reporter: Istvan Toth >Assignee: Richard Antal >Priority: Minor > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5789.4.x.v1.patch, PHOENIX-5789.4.x.v3.patch, > PHOENIX-5789.4.x.v4.patch, PHOENIX-5789.4.x.v5.patch, > PHOENIX-5789.4.x.v6.patch, PHOENIX-5789.4.x.v7.patch, > PHOENIX-5789.master.addendum.patch, PHOENIX-5789.master.addendum.v2.patch, > PHOENIX-5789.master.addendum.v3.patch, PHOENIX-5789.master.v1.patch, > PHOENIX-5789.master.v2.patch, PHOENIX-5789.master.v3.patch, > PHOENIX-5789.master.v4.patch > > > Phoenix uses at least the following JSON libraries: > * gson > * jackson > * jettison > Of these, only the jackson usage is performance critical, as it is used > during bulk loading. > Try to standardize on a single one to reduce dependency hell. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5864) RuleGeneratorTest unit test seem to be failing
[ https://issues.apache.org/jira/browse/PHOENIX-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093356#comment-17093356 ] Hudson commented on PHOENIX-5864: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3791 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3791/]) PHOENIX-5864: RuleGeneratorTest unit test seem to be failing (chinmayskulkarni: rev b29d201581bbfff3765c2e6bd17f514a4c46ec20) * (edit) phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java * (delete) phoenix-pherf/src/test/resources/scenario/timeout_test_scenario.xml * (add) phoenix-pherf/src/test/resources/scenario/scenario_with_query_timeouts.xml * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/RuleGeneratorTest.java * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java > RuleGeneratorTest unit test seem to be failing > -- > > Key: PHOENIX-5864 > URL: https://issues.apache.org/jira/browse/PHOENIX-5864 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Sandeep Guggilam >Assignee: Chinmay Kulkarni >Priority: Major > Labels: pherf > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5864-v1.patch > > > Looks to be related to this commit : > [https://github.com/apache/phoenix/commit/8ee78e2be4858f3ed230dff2328269ebe67e1f03] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5841) When data columns get TTLed, we need inline index validation to publish a metric for this
[ https://issues.apache.org/jira/browse/PHOENIX-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091043#comment-17091043 ] Hudson commented on PHOENIX-5841: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3785 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3785/]) PHOENIX-5841 add a counter for mismatching num of columns (giskender: rev 0b3c8a378a2ebb7cbbb6bcc3e6b308c37da1e358) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/VerifySingleIndexRowTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexToolJobCounters.java > When data columns get TTLed, we need inline index validation to publish a > metric for this > - > > Key: PHOENIX-5841 > URL: https://issues.apache.org/jira/browse/PHOENIX-5841 > Project: Phoenix > Issue Type: Improvement >Reporter: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-5841.4.x.001.patch, PHOENIX-5841.4.x.002.patch, > PHOENIX-5841.4.x.003.patch, PHOENIX-5841.master.001.patch, > PHOENIX-5841.master.002.patch, PHOENIX-5841.master.003.patch > > Time Spent: 2.5h > Remaining Estimate: 0h > > We do index writes as full row writes. This means all columns keep get > re-written to index and they have a current timestamp. > However, if there is a column that did not get updated for a long time (like > Created_By type of columns that don't change) index inline validation marks > these as "Index has extra columns". We need to publish an extra metric to > distinguish these cases since they are expected to be not matching rows. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-4521) Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted
[ https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088588#comment-17088588 ] Hudson commented on PHOENIX-4521: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3774 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3774/]) PHOENIX-4521: Allow Pherf scenario to define per query max allowed query (chinmayskulkarni: rev dccc260413591a7ab3133f8040b8547b8e993750) * (add) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Query.java * (edit) phoenix-pherf/pom.xml * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedDiffer.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QueryResult.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ThreadTime.java * (add) phoenix-pherf/src/test/resources/datamodel/timeout_test_schema.sql * (edit) phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java * (add) phoenix-pherf/src/test/resources/scenario/timeout_test_scenario.xml * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/file/Header.java * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/ResultTest.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java > Allow Pherf scenario to define per query max allowed query execution duration > after which thread is interrupted > --- > > Key: PHOENIX-4521 > URL: https://issues.apache.org/jira/browse/PHOENIX-4521 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: James R. Taylor >Assignee: Christine Feng >Priority: Major > Labels: phoenix-hardening > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-4521.4.x.v1.patch, PHOENIX-4521.4.x.v2.patch, > PHOENIX-4521.master.v1.patch, PHOENIX-4521.master.v2.patch, > PHOENIX-4521.master.v2.patch, PHOENIX-4521.master.v3.patch, > PHOENIX-4521.master.v4.patch, PHOENIX-4521.master.v5.patch, > PHOENIX-4521.master.v6.patch, PHOENIX-4521.master.v7.patch > > Time Spent: 12h 50m > Remaining Estimate: 0h > > Some clients interrupt the client thread if it doesn't complete in a required > amount of time. It would be good if Pherf supported setting this up so we > mimic client behavior more closely, as we're theorizing this may be causing > some issues. > > PLAN > # Make necessary changes so new timeoutDuration property is recognized and > parsed correctly from the scenario .xml file (completed) > # Implement a per-query, per-iteration timeout > # Write ITs and UTs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-4521) Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted
[ https://issues.apache.org/jira/browse/PHOENIX-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088589#comment-17088589 ] Hudson commented on PHOENIX-4521: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3773 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3773/]) PHOENIX-4521: Allow Pherf scenario to define per query max allowed query (chinmayskulkarni: rev dccc260413591a7ab3133f8040b8547b8e993750) * (add) phoenix-pherf/src/test/resources/scenario/timeout_test_scenario.xml * (add) phoenix-pherf/src/test/resources/datamodel/timeout_test_schema.sql * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Query.java * (edit) phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java * (edit) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/ResultTest.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultithreadedDiffer.java * (add) phoenix-pherf/src/test/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ThreadTime.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QueryResult.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/file/Header.java * (edit) phoenix-pherf/pom.xml * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java > Allow Pherf scenario to define per query max allowed query execution duration > after which thread is interrupted > --- > > Key: PHOENIX-4521 > URL: https://issues.apache.org/jira/browse/PHOENIX-4521 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 5.0.0, 4.15.0, 4.14.3 >Reporter: James R. Taylor >Assignee: Christine Feng >Priority: Major > Labels: phoenix-hardening > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-4521.4.x.v1.patch, PHOENIX-4521.4.x.v2.patch, > PHOENIX-4521.master.v1.patch, PHOENIX-4521.master.v2.patch, > PHOENIX-4521.master.v2.patch, PHOENIX-4521.master.v3.patch, > PHOENIX-4521.master.v4.patch, PHOENIX-4521.master.v5.patch, > PHOENIX-4521.master.v6.patch, PHOENIX-4521.master.v7.patch > > Time Spent: 12h 50m > Remaining Estimate: 0h > > Some clients interrupt the client thread if it doesn't complete in a required > amount of time. It would be good if Pherf supported setting this up so we > mimic client behavior more closely, as we're theorizing this may be causing > some issues. > > PLAN > # Make necessary changes so new timeoutDuration property is recognized and > parsed correctly from the scenario .xml file (completed) > # Implement a per-query, per-iteration timeout > # Write ITs and UTs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5496) Ensure that we handle all server-side mutation codes on the client
[ https://issues.apache.org/jira/browse/PHOENIX-5496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086373#comment-17086373 ] Hudson commented on PHOENIX-5496: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3768 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3768/]) PHOENIX-5496 Ensure that we handle all server-side mutation codes on the (s.kadam: rev c627f94b50802bde493bfef1a2a090d9568eff6f) * (edit) phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java * (add) phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java > Ensure that we handle all server-side mutation codes on the client > -- > > Key: PHOENIX-5496 > URL: https://issues.apache.org/jira/browse/PHOENIX-5496 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.15.0, 5.1.0 >Reporter: Chinmay Kulkarni >Assignee: Neha Gupta >Priority: Major > Fix For: 4.15.1, 5.1.1 > > Attachments: PHOENIX-5496.4.x.patch, PHOENIX-5496.master.patch > > Time Spent: 4h 20m > Remaining Estimate: 0h > > There are many instances throughout wherein we set a certain error mutation > code in the RPC callback, however we do not handle these mutation codes on > the client. > For example: > If the metadata rows for a tableKey are no longer in that SYSCAT region, > checkTableKeyInRegion() fails, the metadata for this table is not written to > SYSCAT and [the TABLE_NOT_IN_REGION mutation code is > set|https://github.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095d/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1785-L1790]. > This is handled for 1 retry inside > [CQSI.metaDataCoprocessorExec|https://github.com/apache/phoenix/blob/11997d48d1957cf613526f01c5ccbe2812cf095d/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L1568-L1570], > but if this happens again, it is returned back to the client where it goes > to the default case and succeeds. > Apart from the fact that partial metadata updates are possible leading to > orphan metadata rows in system tables, this also wrongly returns success for > clients even though there is no record of that table/view being created > inside Phoenix's system tables. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5840) IndexTool inline verification should not fail with -v ONLY option
[ https://issues.apache.org/jira/browse/PHOENIX-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085204#comment-17085204 ] Hudson commented on PHOENIX-5840: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3760 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3760/]) PHOENIX-5840: IndexTool inline verification should not fail with -v ONLY (github: rev 7b4db73b37d8a67fb0238e405abcf4e5f160a103) * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/parse/PhoenixRowTimestampFunctionTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java > IndexTool inline verification should not fail with -v ONLY option > - > > Key: PHOENIX-5840 > URL: https://issues.apache.org/jira/browse/PHOENIX-5840 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Major > Attachments: PHOENIX-5840.4.x.patch, PHOENIX-5840.4.x.v1.patch, > PHOENIX-5840.4.x.v2.patch, PHOENIX-5840.master.patch > > Time Spent: 1h > Remaining Estimate: 0h > > IndexTool inline verification should not fail with -v ONLY option even if > verification fails. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-578) Cut a 2.0.2 release
[ https://issues.apache.org/jira/browse/PHOENIX-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083322#comment-17083322 ] Hudson commented on PHOENIX-578: FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3748 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3748/]) PHOENIX-578 try to standardize on a JSON library (stoty: rev dec131d8a4de666c06dabc332383fd7e75c2d3aa) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexRebuildTaskIT.java * (edit) phoenix-core/src/it/resources/compatible_client_versions.json * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/automation/PhoenixMRJobSubmitter.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixMRJobUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java * (edit) pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/IndexRebuildTask.java * (edit) phoenix-core/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java > Cut a 2.0.2 release > --- > > Key: PHOENIX-578 > URL: https://issues.apache.org/jira/browse/PHOENIX-578 > Project: Phoenix > Issue Type: Task >Reporter: Andrew Kyle Purtell >Assignee: Mujtaba Chohan > > It looks like [BIGTOP-993](https://issues.apache.org/jira/browse/BIGTOP-993) > might be committed soon. > I propose to create a new branch '2.0.2' which is the '2.0.1' branch plus the > fix committed somewhere to 'master' for this compilation problem against > recent HBase 0.94 versions: > [ERROR] > /usr/src/Hadoop/bigtop/output/phoenix/phoenix-2.0.1/src/main/java/com/salesforce/phoenix/query/ConnectionQueryServicesImpl.java:[137,39] > > allTableRegions(org.apache.hadoop.conf.Configuration,org.apache.hadoop.hbase.client.HConnection,byte[],boolean) > in org.apache.hadoop.hbase.client.MetaScanner cannot be applied to > (org.apache.hadoop.conf.Configuration,byte[],boolean) > [ERROR] > /usr/src/Hadoop/bigtop/output/phoenix/phoenix-2.0.1/src/main/java/com/salesforce/phoenix/query/ConnectionQueryServicesImpl.java:[716,78] > > allTableRegions(org.apache.hadoop.conf.Configuration,org.apache.hadoop.hbase.client.HConnection,byte[],boolean) > in org.apache.hadoop.hbase.client.MetaScanner cannot be applied to > (org.apache.hadoop.conf.Configuration,byte[],boolean) > What do you think? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5629) Phoenix Function to Return HBase row timestamp
[ https://issues.apache.org/jira/browse/PHOENIX-5629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082844#comment-17082844 ] Hudson commented on PHOENIX-5629: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3746 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3746/]) PHOENIX-5629 Phoenix Function to Return HBase row timestamp (yanxinyi: rev ed0ca183fe6e54aa83ad826e4cf3e77267a0b306) * (edit) phoenix-core/src/main/java/org/apache/phoenix/expression/ExpressionType.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixRowTimestampFunctionIT.java * (add) phoenix-core/src/main/java/org/apache/phoenix/expression/function/PhoenixRowTimestampFunction.java * (add) phoenix-core/src/main/java/org/apache/phoenix/parse/PhoenixRowTimestampParseNode.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/TupleProjector.java * (add) phoenix-core/src/test/java/org/apache/phoenix/parse/PhoenixRowTimestampFunctionTest.java * (delete) phoenix-core/src/it/java/org/apache/phoenix/end2end/RowTimestampStringFunctionIT.java * (delete) phoenix-core/src/main/java/org/apache/phoenix/expression/function/RowTimestampStringFunction.java > Phoenix Function to Return HBase row timestamp > -- > > Key: PHOENIX-5629 > URL: https://issues.apache.org/jira/browse/PHOENIX-5629 > Project: Phoenix > Issue Type: New Feature >Reporter: Geoffrey Jacoby >Assignee: Jacob Isaac >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5629-addendum.4.x-HBase-1.3.002.patch, > PHOENIX-5629.4.x-HBase-1.3.v1.patch, PHOENIX-5629.4.x-HBase-1.3.v2.patch, > PHOENIX-5629.master.v1.patch, PHOENIX-5629.master.v2.patch > > Time Spent: 8.5h > Remaining Estimate: 0h > > t's occasionally useful when diagnosing an issue with Phoenix to be able to > easily look up the HBase timestamp of the HBase Cell returned by a Phoenix > query. > For example: > SELECT ROW_TIMESTAMP(Column1) FROM Table1 WHERE Column1 = 'SomeValue' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5811) Synchronise Phoenix dependencies to match Hbase dependency versions
[ https://issues.apache.org/jira/browse/PHOENIX-5811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079433#comment-17079433 ] Hudson commented on PHOENIX-5811: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3735 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3735/]) PHOENIX-5811 Synchronise Phoenix dependencies to match Hbase dependency (stoty: rev 39a34b8fae743c63f634ef0366c2de130a621bbe) * (edit) pom.xml > Synchronise Phoenix dependencies to match Hbase dependency versions > --- > > Key: PHOENIX-5811 > URL: https://issues.apache.org/jira/browse/PHOENIX-5811 > Project: Phoenix > Issue Type: Task >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5811.master.v1.patch, > PHOENIX-5811.master.v2.patch, PHOENIX-5811.master.v3.patch, > PHOENIX-5811.master.v4.patch > > > Phoenix uses an older version of some dependencies. > We could reduce the number of dependencies by using the same versions as > Hbase. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5825) Remove PhoenixCanaryTool and CanaryTestResult from phoenix repo
[ https://issues.apache.org/jira/browse/PHOENIX-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079308#comment-17079308 ] Hudson commented on PHOENIX-5825: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3734 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3734/]) PHOENIX-5825 Remove PhoenixCanaryTool and CanaryTestResult from phoenix (stoty: rev 95dab00ed285927d4d00fb3c6b31dc376eb40db9) * (delete) phoenix-core/src/main/java/org/apache/phoenix/tool/PhoenixCanaryTool.java * (delete) phoenix-core/src/test/java/org/apache/phoenix/tool/ParameterizedPhoenixCanaryToolIT.java * (delete) phoenix-core/src/main/java/org/apache/phoenix/tool/CanaryTestResult.java * (edit) phoenix-core/pom.xml * (delete) phoenix-core/src/test/java/org/apache/phoenix/tool/PhoenixCanaryToolTest.java * (edit) pom.xml > Remove PhoenixCanaryTool and CanaryTestResult from phoenix repo > --- > > Key: PHOENIX-5825 > URL: https://issues.apache.org/jira/browse/PHOENIX-5825 > Project: Phoenix > Issue Type: Task > Components: core, queryserver >Affects Versions: 5.1.0, queryserver-1.0.0, 4.16.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5825.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > In Phoenix-5824 I move these classes to queryserver-orchestrator, as they are > not used anywhere else. > Once that is committed, these files are redundant in the main repo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5810) PhoenixMRJobSubmitter is not working on a cluster with a single yarn RM
[
https://issues.apache.org/jira/browse/PHOENIX-5810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077100#comment-17077100
]
Hudson commented on PHOENIX-5810:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3728 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3728/])
PHOENIX-5810 PhoenixMRJobSubmitter is not working on a cluster with a (stoty:
rev e10642686314804030ffa4c151155f5483e97db4)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/util/PhoenixMRJobUtil.java
* (add)
phoenix-core/src/test/java/org/apache/phoenix/util/PhoenixMRJobUtilTest.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/automation/PhoenixMRJobSubmitter.java
> PhoenixMRJobSubmitter is not working on a cluster with a single yarn RM
> ---
>
> Key: PHOENIX-5810
> URL: https://issues.apache.org/jira/browse/PHOENIX-5810
> Project: Phoenix
> Issue Type: Bug
>Reporter: Richard Antal
>Assignee: Richard Antal
>Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5810.master.v1.patch,
> PHOENIX-5810.master.v2.patch, PHOENIX-5810.master.v3.patch,
> PHOENIX-5810.master.v4.patch, PHOENIX-5810.master.v5.patch
>
>
> {code:java}
> Exception in thread "main"
> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode =
> NoNode for /yarn-leader-election{code}
> The error happens when we want to run scheduleIndexBuilds. In
> getSubmittedYarnApps, getActiveResourceManagerHost uses zookeeper to
> determine the active Resource Manager.
> But /yarn-leader-election only exists if yarn is in HA mode.
> I think this function should work well when we have single yarn RM and read
> its address from the config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5798) IndexUpgrade tool command line improvements
[ https://issues.apache.org/jira/browse/PHOENIX-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076773#comment-17076773 ] Hudson commented on PHOENIX-5798: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3725 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3725/]) PHOENIX-5798 IndexUpgrade tool command line improvements (s.kadam: rev bb1db520d0be1a19f1c62c2a0fb78aaad1d30ac4) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java * (edit) phoenix-core/src/test/java/org/apache/phoenix/index/IndexUpgradeToolTest.java > IndexUpgrade tool command line improvements > --- > > Key: PHOENIX-5798 > URL: https://issues.apache.org/jira/browse/PHOENIX-5798 > Project: Phoenix > Issue Type: Improvement >Reporter: Tanuj Khurana >Assignee: Tanuj Khurana >Priority: Minor > Attachments: PHOENIX-5798.4.x.v1.patch, PHOENIX-5798.4.x.v2.patch, > PHOENIX-5798.master.v1.patch, PHOENIX-5798.master.v2.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > * IndexUpgrade tool should optionally rebuild indexes. By default, rebuilding > index should be skipped. > * Add a placeholder option to index upgrade tool to passthrough the option > value to the index tool -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5794) Create a threshold for non async index creation, that can be modified in configs
[ https://issues.apache.org/jira/browse/PHOENIX-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076774#comment-17076774 ] Hudson commented on PHOENIX-5794: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3725 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3725/]) PHOENIX-5794 Create a threshold for non async index creation, that can (rajeshbabu: rev b3497876a404828c6486ffc1e2e1957a007abeb6) * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/query/QueryServices.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java * (edit) pom.xml * (add) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexAsyncThresholdIT.java > Create a threshold for non async index creation, that can be modified in > configs > > > Key: PHOENIX-5794 > URL: https://issues.apache.org/jira/browse/PHOENIX-5794 > Project: Phoenix > Issue Type: Improvement >Reporter: Richard Antal >Assignee: Richard Antal >Priority: Major > Attachments: PHOENIX-5794.master.v1.patch, > PHOENIX-5794.master.v10.patch, PHOENIX-5794.master.v2.patch, > PHOENIX-5794.master.v3.patch, PHOENIX-5794.master.v4.patch, > PHOENIX-5794.master.v5.patch, PHOENIX-5794.master.v6.patch, > PHOENIX-5794.master.v7.patch, PHOENIX-5794.master.v8.patch, > PHOENIX-5794.master.v9.patch > > > Issue: > When user try to create an index on a huge phoenix table the region servers > crashed which led to multiple regions going in RIT state. > > Solution: > If the expected byte read size is higher than the limit we raise an exception > to notify the user that the index should be created asynchronously. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5780) Add mvn dependency:analyze to build process
[ https://issues.apache.org/jira/browse/PHOENIX-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076722#comment-17076722 ] Hudson commented on PHOENIX-5780: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3722 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3722/]) PHOENIX-5780 Add mvn dependency:analyze to build process (stoty: rev bd736137354b5e60ad7678e9c53f2f503a106b0f) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/parse/UpdateStatisticsStatement.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java * (edit) phoenix-pherf/pom.xml * (edit) phoenix-hbase-compat-2.2.1/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/QueryBuilder.java * (edit) phoenix-tracing-webapp/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/JDBCUtil.java * (edit) phoenix-server/pom.xml * (edit) phoenix-client/pom.xml * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexExtendedIT.java * (edit) phoenix-hbase-compat-2.0.1/pom.xml * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/salted/SaltedTableVarLengthRowKeyIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/LazyParallelWriterIndexCommitter.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/DateUtil.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java * (edit) phoenix-hbase-compat-2.1.6/pom.xml * (edit) pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/AbstractParallelWriterIndexCommitter.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java * (edit) BUILDING.md * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/OrphanViewTool.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WorkloadExecutor.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParallelStatsDisabledIT.java * (edit) phoenix-core/pom.xml > Add mvn dependency:analyze to build process > --- > > Key: PHOENIX-5780 > URL: https://issues.apache.org/jira/browse/PHOENIX-5780 > Project: Phoenix > Issue Type: Task > Components: core >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5780.master.v1.patch, > PHOENIX-5780.master.v2.patch, PHOENIX-5780.master.v3.patch, > PHOENIX-5780.master.v4.patch, PHOENIX-5780.master.v5.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > mvn dependency:analyze has shown that the dependency definitions in Phoenix > are in a bad shape. > Include it in the build process, so that we can keep the dependencies true > and up to date. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5780) Add mvn dependency:analyze to build process
[ https://issues.apache.org/jira/browse/PHOENIX-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076486#comment-17076486 ] Hudson commented on PHOENIX-5780: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3721 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3721/]) PHOENIX-5780 Add mvn dependency:analyze to build process (stoty: rev bd736137354b5e60ad7678e9c53f2f503a106b0f) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/trace/util/Tracing.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/DateUtil.java * (edit) phoenix-pherf/pom.xml * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/JDBCUtil.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexExtendedIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/OrphanViewTool.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/util/QueryBuilder.java * (edit) BUILDING.md * (edit) phoenix-core/pom.xml * (edit) phoenix-client/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java * (edit) phoenix-hbase-compat-2.1.6/pom.xml * (edit) phoenix-hbase-compat-2.2.1/pom.xml * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ResultUtil.java * (edit) phoenix-tracing-webapp/pom.xml * (edit) phoenix-server/pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/LazyParallelWriterIndexCommitter.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WorkloadExecutor.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/parse/UpdateStatisticsStatement.java * (edit) pom.xml * (edit) phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ParallelStatsDisabledIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/log/QueryLogger.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/write/AbstractParallelWriterIndexCommitter.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java * (edit) phoenix-hbase-compat-2.0.1/pom.xml * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/salted/SaltedTableVarLengthRowKeyIT.java > Add mvn dependency:analyze to build process > --- > > Key: PHOENIX-5780 > URL: https://issues.apache.org/jira/browse/PHOENIX-5780 > Project: Phoenix > Issue Type: Task > Components: core >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-5780.master.v1.patch, > PHOENIX-5780.master.v2.patch, PHOENIX-5780.master.v3.patch, > PHOENIX-5780.master.v4.patch, PHOENIX-5780.master.v5.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > mvn dependency:analyze has shown that the dependency definitions in Phoenix > are in a bad shape. > Include it in the build process, so that we can keep the dependencies true > and up to date. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5719) testIndexRebuildTask test is failing on pre-commit and master build
[ https://issues.apache.org/jira/browse/PHOENIX-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075013#comment-17075013 ] Hudson commented on PHOENIX-5719: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3719 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3719/]) PHOENIX-5719 IndexRebuildTaskIT sometimes fails (giskender: rev 6bad8b4a6653f9fa78bd5fcbb3787408fae989f6) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexRebuildTaskIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java > testIndexRebuildTask test is failing on pre-commit and master build > --- > > Key: PHOENIX-5719 > URL: https://issues.apache.org/jira/browse/PHOENIX-5719 > Project: Phoenix > Issue Type: Test >Reporter: Xinyi Yan >Assignee: Gokcen Iskender >Priority: Major > Attachments: PHOENIX-5719.4.x-HBase-1.4.001.patch, > PHOENIX-5719.master.001.patch, PHOENIX-5719.master.002.patch, > PHOENIX-5719.master.003.patch, PHOENIX-5719.master.004.patch > > Time Spent: 10m > Remaining Estimate: 0h > > testIndexRebuildTask has been failing for a few days on PreCommit build, as > well as master build(first failing on Jan 31). > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3401/testReport/] > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3393/] > [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3400/] > [https://builds.apache.org/view/M-R/view/Phoenix/job/Phoenix-master/2638/] > [https://builds.apache.org/view/M-R/view/Phoenix/job/Phoenix-master/2639/testReport/] > Can someone take a look at this flapper test, thanks > [~kadir] [~gjacoby] [~swaroopa] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5817) Prepatch script is a psycho killer
[ https://issues.apache.org/jira/browse/PHOENIX-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075012#comment-17075012 ] Hudson commented on PHOENIX-5817: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3719 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3719/]) PHOENIX-5817 Prepatch script is a psycho killer (stoty: rev a61248556d5f143f7c56dffdfb962d73409c7807) * (edit) dev/test-patch.sh > Prepatch script is a psycho killer > -- > > Key: PHOENIX-5817 > URL: https://issues.apache.org/jira/browse/PHOENIX-5817 > Project: Phoenix > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Blocker > Fix For: 5.1.0 > > Attachments: PHOENIX-5817.master.v1.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > The prepatch script assumes that it is the only test on a machine, and kills > other copies of itself, as well as unrelated maven tests runs. > Looking at the times, it's obvious that > https://builds.apache.org/job/PreCommit-PHOENIX-Build/3712/ > was killed by > https://builds.apache.org/job/PreCommit-PHOENIX-Build/3713/ > What's worse, it also kills ANY maven surefire/failsafe process, so not only > does it sabotage other copies of itself, it also sabotages other projects' > tests that share the ASF infrastructure. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5814) disable trimStackTrace
[ https://issues.apache.org/jira/browse/PHOENIX-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074121#comment-17074121 ] Hudson commented on PHOENIX-5814: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3706 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3706/]) PHOENIX-5814 disable trimStackTrace (stoty: rev 40bcc0184d3f7257ba2ce98b045d6e8a41f58a00) * (edit) pom.xml > disable trimStackTrace > -- > > Key: PHOENIX-5814 > URL: https://issues.apache.org/jira/browse/PHOENIX-5814 > Project: Phoenix > Issue Type: Improvement > Components: connectors, core, omid, queryserver, tephra >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > The default trimStackTrace=true maven setting is quite effective at making > test output useless for all but the trivial failures. > I propose setting it to false everywhere (i.e all five repos) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5816) IndexToolTimeRangeIT hangs forever
[ https://issues.apache.org/jira/browse/PHOENIX-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073802#comment-17073802 ] Hudson commented on PHOENIX-5816: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3704 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3704/]) PHOENIX-5816 IndexToolTimeRangeIT hangs forever (stoty: rev b9985d9bb63baf339b8699842e6c2df851291eea) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolTimeRangeIT.java > IndexToolTimeRangeIT hangs forever > -- > > Key: PHOENIX-5816 > URL: https://issues.apache.org/jira/browse/PHOENIX-5816 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Blocker > Fix For: 5.1.0, 4.x > > Attachments: PHOENIX-5816.4.x.v1.patch, PHOENIX-5816.4.x.v2.patch, > PHOENIX-5816.master.v1.patch, PHOENIX-5816.master.v2.patch > > Time Spent: 20m > Remaining Estimate: 0h > > IndexToolTimeRangeIT hangs when executing. > This makes all mvn verify runs to time out as well, including all Jenkins > jobs. > I have identified two problems: > * The indextool CLI argument name is off > * The environmentEdgeManager used for the completely hoses HBase ( at least > 2.2) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5807) Index rows without empty column should be treated as unverified
[ https://issues.apache.org/jira/browse/PHOENIX-5807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071451#comment-17071451 ] Hudson commented on PHOENIX-5807: - ABORTED: Integrated in Jenkins build PreCommit-PHOENIX-Build #3683 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3683/]) PHOENIX-5807 Index rows without empty column should be treated as (kadir: rev 54f2c93176ce57a077769a6f9740345c1da3ac45) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/index/GlobalIndexChecker.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java > Index rows without empty column should be treated as unverified > --- > > Key: PHOENIX-5807 > URL: https://issues.apache.org/jira/browse/PHOENIX-5807 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.14.3 >Reporter: Kadir OZDEMIR >Assignee: Kadir OZDEMIR >Priority: Major > Attachments: PHOENIX-5807.4.x.001.patch > > Time Spent: 1h > Remaining Estimate: 0h > > In the new index design, an index row is composed of cells with the same > timestamp and the empty column cell holds the verify status of the row. > However, it is possible that the empty column of an index row can be > compacted away if the row is made unverified due to a failed data table > overwrite. This failed overwrite will make the existing verified row index > row unverified by overwriting the existing row with the empty column cell > with the unverified status. If this row is not scanned before the next major > compaction, the empty column cell of the overwritten index row can be removed > by the compaction since there will be more than one version of it. If this > row is retrieved via an SCN connection, then the returned row will not > include the empty column cell. Not having empty column is treated as an > exception currently. Instead, the row without an empty column should be > treated as an unverified row and it should be repaired. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5748) Simplify index update generation code for consistent global indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070198#comment-17070198 ] Hudson commented on PHOENIX-5748: - SUCCESS: Integrated in Jenkins build PreCommit-PHOENIX-Build #3678 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3678/]) PHOENIX-5748 Simplify index update generation code for consistent global (kadir: rev 9dd7d9d8a720c1f98bbe1564f5cfee16b8c5d507) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/ServerBuildIndexCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsExtendedIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java * (add) phoenix-core/src/test/java/org/apache/phoenix/index/PrepareIndexMutationsForRebuildTest.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixIndexImportDirectReducer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/ConcurrentMutationsIT.java * (add) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexToolVerificationResult.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java * (add) phoenix-core/src/test/java/org/apache/phoenix/index/VerifySingleIndexRowTest.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java > Simplify index update generation code for consistent global indexes > > > Key: PHOENIX-5748 > URL: https://issues.apache.org/jira/browse/PHOENIX-5748 > Project: Phoenix > Issue Type: Improvement >Reporter: Kadir OZDEMIR >Assignee: Kadir OZDEMIR >Priority: Major > Fix For: 5.1.1, 4.14.4, 4.16.0 > > Attachments: PHOENIX-5748-4.x-HBase-1.5.001.patch, > PHOENIX-5748-4.x.001.patch, PHOENIX-5748.master.001.patch > > > The implementation of the new global index design by PHOENIX-5156 essentially > introduced two coprocessors, IndexRegionObserver and GlobalIndexChecker. > IndexRegionObserver is the counterpart of the existing Indexer coprocessor > that the previous global indexing feature uses. It implements the indexing > write path. GlobalIndexChecker implements the read verification and read > repair that happens on the read path. One of the main objectives of the > design behind new global indexing was to leverage as much existing indexing > code as possible. This objective has been achieved greatly as the entire > index table update generation code implemented by various classes (including > PhoenixIndexBuilder, CachedLocalTable, NonTxIndexBuilder, IndexUpdateManager, > LocalTableState, ScannerBuilder, IndexMemStore and PhoenixIndexCodec) is > leveraged as it is mainly. This objective has served us well to deliver the > new indexing feature quickly. The leveraged code is very complex, over > engineered, and inefficient, and is not bug free. It is very hard to > maintain. It is time to replace the complex set of classes with something > drastically simpler and more efficient for the new design. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5802) Connection leaks in UPSERT SELECT/DELETE paths due to MutatingParallelIteratorFactory iterator not being closed
[
https://issues.apache.org/jira/browse/PHOENIX-5802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069392#comment-17069392
]
Hudson commented on PHOENIX-5802:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3674 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3674/])
PHOENIX-5802: Connection leaks in UPSERT SELECT/DELETE paths due to
(chinmayskulkarni: rev affa9e889efcc2ad7dac009a0d294b09447d281e)
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java
> Connection leaks in UPSERT SELECT/DELETE paths due to
> MutatingParallelIteratorFactory iterator not being closed
> ---
>
> Key: PHOENIX-5802
> URL: https://issues.apache.org/jira/browse/PHOENIX-5802
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.0.0, 4.15.0
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Major
> Labels: phoenix-hardening
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5802-4.x-v1.patch, PHOENIX-5802-4.x-v2.patch
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> During an UPSERT SELECT query or client-side DELETE, we clone the existing
> Phoenix connection and call
> [mutate|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java#L59]
> which eventually calls either
> [upsertSelect|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L178]
> or
> [deleteRows|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java#L126].
> When getting iterators, if we encounter any exception, then on calling
> [close|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1377],
> we attempt to cancel any queued work, while [accumulating already-started
> task
> futures|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1453].
>
> Later we attempt to block on getting the result (iterator) of
> already-started tasks and [close each
> iterator|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1464-L1465].
> Here however, if any of the upsert-select or client-side delete tasks had
> thrown an exception _E_, we wouldn't be able to close the underlying iterator
> (which in-turn would've [closed the cloned
> connection|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/compile/MutatingParallelIteratorFactory.java#L101]).
> This manifests as [these
> logs|https://github.com/apache/phoenix/blob/73a86be9b588353457cd2c9de41239211330e7a7/phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java#L1470]:
> {code:java}
> "Failed to execute task during cancel",
> {code}
> This is leading to a connection leak. Because we use CQSI to create the
> Phoenix Connection here, it also gets accounted for during open Phoenix
> connection throttling, thus leaving the client application with less
> connections that can be opened.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-5801) Connection leak when creating a view with a where condition
[ https://issues.apache.org/jira/browse/PHOENIX-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069182#comment-17069182 ] Hudson commented on PHOENIX-5801: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3670 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3670/]) PHOENIX-5801: Connection leak when creating a view with a where (chinmayskulkarni: rev 8247029ea8e415d82610c55b9ab3515c3f176ac2) * (edit) phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/coprocessor/WhereConstantParser.java > Connection leak when creating a view with a where condition > --- > > Key: PHOENIX-5801 > URL: https://issues.apache.org/jira/browse/PHOENIX-5801 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.0.0, 4.15.0 >Reporter: Chinmay Kulkarni >Assignee: Chinmay Kulkarni >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5801-4.x-v1.patch, PHOENIX-5801-4.x-v2.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > When you create a view with a where condition, we open a connection-less > Phoenix connection, which is never closed. This is a connection leak and also > unnecessarily contributes to the GLOBAL_OPEN_PHOENIX_CONNECTIONS metric > (which is incremented on opening any PhoenixConnection). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5776) Phoenix pherf unit tests failing
[ https://issues.apache.org/jira/browse/PHOENIX-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068268#comment-17068268 ] Hudson commented on PHOENIX-5776: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3663 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3663/]) PHOENIX-5776 Phoenix pherf unit tests failing (chinmayskulkarni: rev d04ba4eb945ba502652888220097ebca44f4a4dd) * (edit) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java > Phoenix pherf unit tests failing > > > Key: PHOENIX-5776 > URL: https://issues.apache.org/jira/browse/PHOENIX-5776 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.0, 4.16.0 >Reporter: Sandeep Guggilam >Assignee: Sandeep Guggilam >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5776.master.v1.patch > > > Phoenix Pherf unit tests ResourceTest and PherfTest are failing with "could > not load resources /datamodel/query_more.sql" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5698) Phoenix Query with RVC IN list expression generates wrong scan with non-pk ordered pks
[
https://issues.apache.org/jira/browse/PHOENIX-5698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067268#comment-17067268
]
Hudson commented on PHOENIX-5698:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3660 (See
[https://builds.apache.org/job/PreCommit-PHOENIX-Build/3660/])
PHOENIX-5698 Phoenix Query with RVC IN list expression generates wrong
(yanxinyi: rev 14a17d8f9b23089bea4c2a910430a73c669bc0fb)
* (edit) phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java
* (edit)
phoenix-core/src/main/java/org/apache/phoenix/expression/InListExpression.java
* (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/InListIT.java
* (edit)
phoenix-core/src/test/java/org/apache/phoenix/expression/InListExpressionTest.java
> Phoenix Query with RVC IN list expression generates wrong scan with non-pk
> ordered pks
> --
>
> Key: PHOENIX-5698
> URL: https://issues.apache.org/jira/browse/PHOENIX-5698
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.15.0, 4.14.3
>Reporter: Daniel Wong
>Assignee: Xinyi Yan
>Priority: Major
> Labels: DESC
> Attachments: PHOENIX-5698-4.14-HBase-1.3.patch,
> PHOENIX-5698-4.x-HBase-1.3.patch, PHOENIX-5698-4.x.patch,
> PHOENIX-5698-4.x.v3.patch, PHOENIX-5698-4.x.v4.patch,
> PHOENIX-5698-4.x.v5.patch, PHOENIX-5698-4.x.v6.patch,
> PHOENIX-5698-master.v2.patch, PHOENIX-5698.patch
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> In the code below ideally we'd expect a SINGLE ROW DELETE plan client side.
> However, this generates an incorrect scan with range ['tenant1
> 0CY005xx01Sv6o'). If the order of the RVCs is changed to row key order
> Phoenix correctly generates a SINGLE ROW SCAN. As we provide the full PK
> this we expect a either tightly bounded range scan or a client side delete.
> Instead we get a range scan on composite leading edge
> TENANT_ID,KEY_PREFIX,ID1.
>
> {code:java}
> @Test
> public void testInListExpressionWithDescAgain() throws Exception {
> String fullTableName = generateUniqueName();
> String fullViewName = generateUniqueName();
> String tenantView = generateUniqueName();
> // create base table and global view using global connection
> try (Connection conn = DriverManager.getConnection(getUrl()))
> { conn.setAutoCommit(true); Statement stmt = conn.createStatement();
> stmt.execute("CREATE TABLE " + fullTableName + "(\n" + " TENANT_ID CHAR(15)
> NOT NULL,\n" + " KEY_PREFIX CHAR(3) NOT NULL,\n" + " CONSTRAINT PK PRIMARY
> KEY (\n" + " TENANT_ID," + " KEY_PREFIX" + ")) MULTI_TENANT=TRUE");
> stmt.execute("CREATE VIEW " + fullViewName + "(\n" + " ID1 VARCHAR NOT
> NULL,\n" + " ID2 VARCHAR NOT NULL,\n" + " EVENT_DATE DATE NOT NULL,\n" + "
> CONSTRAINT PKVIEW PRIMARY KEY\n" + " (\n" + " ID1, ID2 DESC, EVENT_DATE
> DESC\n" + ")) AS SELECT * FROM " + fullTableName + " WHERE KEY_PREFIX =
> '0CY'"); }
> // create and use a tenant specific view to write data
> try (Connection viewConn = DriverManager.getConnection(TENANT_SPECIFIC_URL1)
> ) {
> viewConn.setAutoCommit(true); //need autocommit for serverside deletion
> Statement stmt = viewConn.createStatement();
> stmt.execute("CREATE VIEW IF NOT EXISTS " + tenantView + " AS SELECT * FROM
> " + fullViewName );
> viewConn.createStatement().execute("UPSERT INTO " + tenantView + "(ID1, ID2,
> EVENT_DATE) VALUES ('005xx01Sv6o', '300', 153245823)");
> viewConn.createStatement().execute("UPSERT INTO " + tenantView + "(ID1, ID2,
> EVENT_DATE) VALUES ('005xx01Sv6o', '400', 153245824)");
> viewConn.createStatement().execute("UPSERT INTO " + tenantView + "(ID1, ID2,
> EVENT_DATE) VALUES ('005xx01Sv6o', '500', 153245825)");
> viewConn.commit();
> ResultSet rs = stmt.executeQuery("SELECT ID1, ID2, EVENT_DATE FROM " +
> tenantView );
> printResultSet(rs);
> System.out.println("Delete Start");
> rs = stmt.executeQuery("EXPLAIN DELETE FROM " + tenantView + " WHERE (ID1,
> EVENT_DATE, ID2) IN (('005xx01Sv6o', 153245824,
> '400'),('005xx01Sv6o', 153245823, '300'))");
> printResultSet(rs); // THIS SHOULD BE A SINGLE ROW SCAN
> stmt.execute("DELETE FROM " + tenantView + " WHERE (ID1, EVENT_DATE, ID2) IN
> (('005xx01Sv6o', 153245824, '400'),('005xx01Sv6o',
> 153245823, '300'))");
> viewConn.commit();
> System.out.println("Delete End");
> rs = stmt.executeQuery("SELECT ID1, ID2, EVENT_DATE FROM " + tenantView );
> printResultSet(rs);
> }
> }
> private void printResultSet(ResultSet rs) throws SQLException {
> StringBuilder builder = new StringBuilder();
> while(rs.next()) {
> for(int i = 0; i < rs.getMetaData().getColumnCount(); i++) {
[jira] [Commented] (PHOENIX-5797) RVC Offset does not work with tenant views on global indexes
[ https://issues.apache.org/jira/browse/PHOENIX-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066596#comment-17066596 ] Hudson commented on PHOENIX-5797: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3651 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3651/]) PHOENIX-5797 RVC Offset does not work with tenant views on global (yanxinyi: rev 61589a903f8c5176ce46e5af0a83729f4f4c90ec) * (edit) phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/RowValueConstructorOffsetIT.java > RVC Offset does not work with tenant views on global indexes > > > Key: PHOENIX-5797 > URL: https://issues.apache.org/jira/browse/PHOENIX-5797 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.16.0 >Reporter: Daniel Wong >Assignee: Daniel Wong >Priority: Minor > Attachments: PHOENIX-5797_4.x.patch > > > Found this during use of RVC Offset in Phoenix-4845. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-5751) Remove redundant IndexUtil#isGlobalIndexCheckEnabled() calls for immutable data tables
[ https://issues.apache.org/jira/browse/PHOENIX-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066418#comment-17066418 ] Hudson commented on PHOENIX-5751: - FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #3650 (See [https://builds.apache.org/job/PreCommit-PHOENIX-Build/3650/]) PHOENIX-5751 Remove redundant IndexUtil#isGlobalIndexCheckEnabled() (achouhan: rev 0f9ed7aa13d1d2b195ab1c315265ccebce037b80) * (edit) phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java * (edit) phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java > Remove redundant IndexUtil#isGlobalIndexCheckEnabled() calls for immutable > data tables > -- > > Key: PHOENIX-5751 > URL: https://issues.apache.org/jira/browse/PHOENIX-5751 > Project: Phoenix > Issue Type: Improvement >Affects Versions: 4.15.0, 4.14.3 >Reporter: Swaroopa Kadam >Assignee: Abhishek Singh Chouhan >Priority: Major > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-5751-4.14-HBase-1.3.patch, > PHOENIX-5751-4.14-HBase-1.3.patch, PHOENIX-5751-master.001.patch, > PHOENIX-5751-master.001.patch, PHOENIX-5751-master.patch > > > We don't need to add and check if globalIndexChecker is enabled on data table. -- This message was sent by Atlassian Jira (v8.3.4#803005)
