[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484502#comment-17484502 ] ASF GitHub Bot commented on PHOENIX-6064: - stoty closed pull request #1375: URL: https://github.com/apache/phoenix/pull/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17484501#comment-17484501 ] ASF GitHub Bot commented on PHOENIX-6064: - stoty closed pull request #1376: URL: https://github.com/apache/phoenix/pull/1376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483186#comment-17483186 ] ASF GitHub Bot commented on PHOENIX-6064: - stoty opened a new pull request #1376: URL: https://github.com/apache/phoenix/pull/1376 build with -Dwithout.tephra to omit Tephra from the artifacts (also fixed phoenix-pherf compilation problem) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17483144#comment-17483144 ] ASF GitHub Bot commented on PHOENIX-6064: - stoty opened a new pull request #1375: URL: https://github.com/apache/phoenix/pull/1375 build with -Dwithout.tephra to omit Tephra from the artifacts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463007#comment-17463007 ] Lars Hofhansl commented on PHOENIX-6064: Turns out this actually break Tephra completely and nobody even noticed. Not blaming this change, but Phoenix and associated projects have started to bitrot it seems. Anyway... I don't work on this more, was just trying something unrelated. Which then turned in a few hours getting Tephra to build without no longer supported JDKs following by the realization that Phoenix cannot even load the TephraTransactionProvider anymore. Not sure why I even care - and if this sounds frustrated is because I am. > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 5.1.0 > > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 20m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184646#comment-17184646
]
Josh Elser commented on PHOENIX-6064:
-
{quote}
I do not agree with that statement. At all!
Next time we find a hard problem with (say) local indexes we also just going to
make them optional?
{quote}
We're not talking about a core feature of Phoenix. We're talking about a
thirdparty library which the development community has disappeared. I don't
think this is a fair analogy.
> Make Tephra support optional
>
>
> Key: PHOENIX-6064
> URL: https://issues.apache.org/jira/browse/PHOENIX-6064
> Project: Phoenix
> Issue Type: Improvement
> Components: core, tephra
>Affects Versions: 5.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6064.master.v1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Tephra has and old Guava dependency, that cannot be removed due to Twill
> depending on it. Removing the Twill dependency from Tephra is possible, but
> not trivial.
> This Guava has CVEs, which will show up in static analysis tools, which will
> cause some potential users not to adopt Phoenix.
> Provide an option to build Phoenix without Tephra, and its problematic
> dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183415#comment-17183415
]
Lars Hofhansl commented on PHOENIX-6064:
{quote}Anyone who wants to make Tephra work can show up and do the work to make
it happen. Same operating model we've always followed.
{quote}
I do not agree with that statement. At all!
Next time we find a hard problem with (say) local indexes we also just going
to make them optional?
If things are broken we should fix them, not make them optional.
I do agree that an expedient - temporary - workaround here is OK.
> Make Tephra support optional
>
>
> Key: PHOENIX-6064
> URL: https://issues.apache.org/jira/browse/PHOENIX-6064
> Project: Phoenix
> Issue Type: Improvement
> Components: core, tephra
>Affects Versions: 5.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6064.master.v1.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Tephra has and old Guava dependency, that cannot be removed due to Twill
> depending on it. Removing the Twill dependency from Tephra is possible, but
> not trivial.
> This Guava has CVEs, which will show up in static analysis tools, which will
> cause some potential users not to adopt Phoenix.
> Provide an option to build Phoenix without Tephra, and its problematic
> dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183000#comment-17183000 ] Istvan Toth commented on PHOENIX-6064: -- I've noticed that I mixed up Tephra and Guava in my previous reply. Edited it to make more sense. > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175691#comment-17175691 ] Josh Elser commented on PHOENIX-6064: - bq. Isn't that a cop-out? It just means that Tephra will de facto not be supported going forward. Anyone who wants to make Tephra work can show up and do the work to make it happen. Same operating model we've always followed. > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175356#comment-17175356 ] Istvan Toth commented on PHOENIX-6064: -- [~larsh] Yes, it is a cop-out, as a quicker alternative to factoring out Twill from Tephra. However, as the default option is to build with Guava, and omitting Guava has to be explicitly specified, I don't agree that it means dropping Tephra support. It does diminish the incentive to bring Tephra to the standard of the rest of the components wrt Phoenix-thirdparty. > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[ https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175130#comment-17175130 ] Lars Hofhansl commented on PHOENIX-6064: Hmm... Isn't that a cop-out? It just means that Tephra will de facto not be supported going forward. > Make Tephra support optional > > > Key: PHOENIX-6064 > URL: https://issues.apache.org/jira/browse/PHOENIX-6064 > Project: Phoenix > Issue Type: Improvement > Components: core, tephra >Affects Versions: 5.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Attachments: PHOENIX-6064.master.v1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Tephra has and old Guava dependency, that cannot be removed due to Twill > depending on it. Removing the Twill dependency from Tephra is possible, but > not trivial. > This Guava has CVEs, which will show up in static analysis tools, which will > cause some potential users not to adopt Phoenix. > Provide an option to build Phoenix without Tephra, and its problematic > dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6064) Make Tephra support optional
[
https://issues.apache.org/jira/browse/PHOENIX-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174414#comment-17174414
]
Hadoop QA commented on PHOENIX-6064:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13009380/PHOENIX-6064.master.v1.patch
against master branch at commit ffeddf55328ac69dac6ee565abec34e1f7002d13.
ATTACHMENT ID: 13009380
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+for (TransactionFactory.Provider aprovider :
TransactionFactory.Provider.available()) {
+private static final NotAvailableTransactionProvider INSTANCE = new
NotAvailableTransactionProvider();
+public PhoenixTransactionContext getTransactionContext(PhoenixConnection
connection) throws SQLException {
+public PhoenixTransactionClient getTransactionClient(Configuration config,
ConnectionInfo connectionInfo) {
+public PhoenixTransactionService getTransactionService(Configuration
config, ConnectionInfo connInfo, int port) {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4090//console
This message is automatically generated.
> Make Tephra support optional
>
>
> Key: PHOENIX-6064
> URL: https://issues.apache.org/jira/browse/PHOENIX-6064
> Project: Phoenix
> Issue Type: Improvement
> Components: core, tephra
>Affects Versions: 5.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
> Attachments: PHOENIX-6064.master.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Tephra has and old Guava dependency, that cannot be removed due to Twill
> depending on it. Removing the Twill dependency from Tephra is possible, but
> not trivial.
> This Guava has CVEs, which will show up in static analysis tools, which will
> cause some potential users not to adopt Phoenix.
> Provide an option to build Phoenix without Tephra, and its problematic
> dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
