[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365741#comment-17365741 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty closed pull request #1252: URL: https://github.com/apache/phoenix/pull/1252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365728#comment-17365728 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty closed pull request #1251: URL: https://github.com/apache/phoenix/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365727#comment-17365727 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1251: URL: https://github.com/apache/phoenix/pull/1251#issuecomment-863945504 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 25s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 5.1 Compile Tests _ | | +0 :ok: | mvndep | 5m 56s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 10m 51s | 5.1 passed | | +0 | hbaserecompile | 24m 38s | HBase recompiled. | | +1 :green_heart: | compile | 1m 34s | 5.1 passed | | +1 :green_heart: | checkstyle | 1m 8s | 5.1 passed | | +1 :green_heart: | javadoc | 1m 12s | 5.1 passed | | +0 :ok: | spotbugs | 3m 5s | phoenix-core in 5.1 has 954 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in 5.1 has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 8m 1s | the patch passed | | +0 | hbaserecompile | 16m 24s | HBase recompiled. | | +1 :green_heart: | compile | 1m 35s | the patch passed | | +1 :green_heart: | javac | 1m 35s | the patch passed | | -1 :x: | checkstyle | 0m 50s | phoenix-core: The patch generated 2 new + 702 unchanged - 3 fixed = 704 total (was 705) | | -1 :x: | checkstyle | 0m 21s | phoenix-tools: The patch generated 11 new + 215 unchanged - 4 fixed = 226 total (was 219) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 9s | the patch passed | | +1 :green_heart: | spotbugs | 4m 10s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 108m 31s | phoenix-core in the patch failed. | | +1 :green_heart: | unit | 3m 56s | phoenix-tools in the patch passed. | | +1 :green_heart: | asflicense | 1m 12s | The patch does not generate ASF License warnings. | | | | 178m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1251 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml | | uname | Linux 69a8c3a73210 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 5.1 / e6d8f40 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/testReport/ | | Max. process+thread count | 13996 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1251/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365724#comment-17365724 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1252: URL: https://github.com/apache/phoenix/pull/1252#issuecomment-863943640 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.16 Compile Tests _ | | +0 :ok: | mvndep | 6m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 7s | 4.16 passed | | +1 :green_heart: | compile | 1m 36s | 4.16 passed | | +1 :green_heart: | checkstyle | 0m 56s | 4.16 passed | | +1 :green_heart: | javadoc | 1m 1s | 4.16 passed | | +0 :ok: | spotbugs | 3m 20s | phoenix-core in 4.16 has 944 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 45s | phoenix-tools in 4.16 has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 16s | the patch passed | | +1 :green_heart: | compile | 1m 37s | the patch passed | | +1 :green_heart: | javac | 1m 37s | the patch passed | | -1 :x: | checkstyle | 0m 42s | phoenix-core: The patch generated 2 new + 712 unchanged - 3 fixed = 714 total (was 715) | | -1 :x: | checkstyle | 0m 13s | phoenix-tools: The patch generated 34 new + 193 unchanged - 31 fixed = 227 total (was 224) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 3s | the patch passed | | +1 :green_heart: | spotbugs | 4m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 131m 4s | phoenix-core in the patch passed. | | +1 :green_heart: | unit | 3m 31s | phoenix-tools in the patch passed. | | +1 :green_heart: | asflicense | 0m 19s | The patch does not generate ASF License warnings. | | | | 174m 29s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1252/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1252 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 9643bbeca052 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.16 / 7cb4a05 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1252/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1252/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1252/1/testReport/ | | Max. process+thread count | 6016 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1252/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL:
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365718#comment-17365718 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty opened a new pull request #1252: URL: https://github.com/apache/phoenix/pull/1252 …maintain the order of PK and other columns (#1212) Co-authored-by: Swaroopa Kadam -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365706#comment-17365706 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty opened a new pull request #1251: URL: https://github.com/apache/phoenix/pull/1251 …maintain the order of PK and other columns (#1218) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365498#comment-17365498 ] Istvan Toth commented on PHOENIX-6271: -- Backported to 5.1 and 4.16 branches > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17365291#comment-17365291 ] Istvan Toth commented on PHOENIX-6271: -- Without the SchemaUtil fixes in patch SchemaTool is mostly unusable, as it fails on the default shema, so this is really needed on the maintenance branches. > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352369#comment-17352369 ] Viraj Jasani commented on PHOENIX-6271: --- +1 for 5.1 backport (4.16 too if required). > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344830#comment-17344830 ] Lars Hofhansl commented on PHOENIX-6271: Looks like this be merged into 5.1.2 (branch 5.1) as well, no? > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.17.0, 5.2.0 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17339269#comment-17339269 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1218: URL: https://github.com/apache/phoenix/pull/1218#issuecomment-832194150 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 3s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 5m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 13m 6s | master passed | | +0 | hbaserecompile | 26m 27s | HBase recompiled. | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | checkstyle | 0m 59s | master passed | | +1 :green_heart: | javadoc | 1m 9s | master passed | | +0 :ok: | spotbugs | 3m 16s | phoenix-core in master has 959 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in master has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 9m 55s | the patch passed | | +0 | hbaserecompile | 17m 2s | HBase recompiled. | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | -1 :x: | checkstyle | 0m 43s | phoenix-core: The patch generated 9 new + 702 unchanged - 10 fixed = 711 total (was 712) | | -1 :x: | checkstyle | 0m 16s | phoenix-tools: The patch generated 34 new + 191 unchanged - 27 fixed = 225 total (was 218) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | | +1 :green_heart: | spotbugs | 4m 22s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 114m 22s | phoenix-core in the patch failed. | | +1 :green_heart: | unit | 3m 31s | phoenix-tools in the patch passed. | | +1 :green_heart: | asflicense | 1m 15s | The patch does not generate ASF License warnings. | | | | 183m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1218 | | JIRA Issue | PHOENIX-6271 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile xml | | uname | Linux f10ebe8ad762 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 55aeb15 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/testReport/ | | Max. process+thread count | 10805 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338746#comment-17338746 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1218: URL: https://github.com/apache/phoenix/pull/1218#issuecomment-831679072 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 4m 54s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 12m 41s | master passed | | +0 | hbaserecompile | 24m 40s | HBase recompiled. | | +1 :green_heart: | compile | 1m 45s | master passed | | +1 :green_heart: | checkstyle | 0m 58s | master passed | | +1 :green_heart: | javadoc | 1m 9s | master passed | | +0 :ok: | spotbugs | 3m 19s | phoenix-core in master has 959 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 42s | phoenix-tools in master has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 9m 58s | root in the patch failed. | | +0 | hbaserecompile | 17m 4s | HBase recompiled. | | +1 :green_heart: | compile | 1m 32s | the patch passed | | +1 :green_heart: | javac | 1m 32s | the patch passed | | -1 :x: | checkstyle | 0m 43s | phoenix-core: The patch generated 2 new + 709 unchanged - 3 fixed = 711 total (was 712) | | -1 :x: | checkstyle | 0m 16s | phoenix-tools: The patch generated 34 new + 191 unchanged - 27 fixed = 225 total (was 218) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 10s | the patch passed | | +1 :green_heart: | spotbugs | 4m 25s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 230m 51s | phoenix-core in the patch passed. | | -1 :x: | unit | 2m 59s | phoenix-tools in the patch failed. | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 294m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1218 | | JIRA Issue | PHOENIX-6271 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 777534dd1cfd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 55aeb15 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/artifact/yetus-general-check/output/patch-unit-phoenix-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/testReport/ | | Max. process+thread count | 11400 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1218/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338681#comment-17338681 ] ASF GitHub Bot commented on PHOENIX-6271: - swaroopak opened a new pull request #1218: URL: https://github.com/apache/phoenix/pull/1218 …maintain the order of PK and other columns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.1, 4.16.1 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335734#comment-17335734 ] ASF GitHub Bot commented on PHOENIX-6271: - swaroopak commented on pull request #1212: URL: https://github.com/apache/phoenix/pull/1212#issuecomment-829475542 Thank you for the review @gjacoby126 @gokceni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.1, 4.16.1 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335735#comment-17335735 ] ASF GitHub Bot commented on PHOENIX-6271: - swaroopak merged pull request #1212: URL: https://github.com/apache/phoenix/pull/1212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.1, 4.16.1 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[
https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335705#comment-17335705
]
ASF GitHub Bot commented on PHOENIX-6271:
-
gjacoby126 commented on a change in pull request #1212:
URL: https://github.com/apache/phoenix/pull/1212#discussion_r623244632
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java
##
@@ -47,6 +47,7 @@
import javax.annotation.Nullable;
+import com.google.common.base.Strings;
Review comment:
Remember that you'll have to use the shaded version when you port to
master.
##
File path:
phoenix-tools/src/it/java/org/apache/phoenix/schema/SchemaExtractionToolIT.java
##
@@ -317,19 +321,104 @@ public void testCreateTableWithMultipleCFProperties()
throws Exception {
Assert.assertTrue(compareProperties(simplifiedProperties,
getProperties(result)));
}
+@Test
+public void testColumnAndPKOrdering() throws Exception {
+String table = "CREATE TABLE IF NOT EXISTS MY_SCHEMA.MY_DATA_TABLE (\n"
++ "ORGANIZATION_ID CHAR(15) NOT NULL, \n"
++ "KEY_PREFIX CHAR(3) NOT NULL,\n"
++ "CREATED_DATE DATE,\n"
++ "CREATED_BY CHAR(15) \n"
++ "CONSTRAINT PK PRIMARY KEY (\n"
++ "ORGANIZATION_ID, \n"
++ "KEY_PREFIX\n" + ")\n"
++ ") VERSIONS=1, IMMUTABLE_ROWS=true, MULTI_TENANT=true,
REPLICATION_SCOPE=1";
+
+String view = "CREATE VIEW IF NOT EXISTS MY_SCHEMA.MY_DATA_VIEW (\n"
++ "DATE_TIME1 DATE NOT NULL,\n"
++ "TEXT1 VARCHAR NOT NULL,\n"
++ "INT1 BIGINT NOT NULL,\n"
++ "DOUBLE1 DECIMAL(12, 3),\n"
++ "DOUBLE2 DECIMAL(12, 3),\n"
++ "DOUBLE3 DECIMAL(12, 3),\n"
++ "CONSTRAINT PKVIEW PRIMARY KEY\n" + "(\n"
++ "DATE_TIME1, TEXT1, INT1\n" + ")\n" + ")\n"
++ "AS SELECT * FROM MY_SCHEMA.MY_DATA_TABLE WHERE KEY_PREFIX =
'9Yj'";
+
+String index = "CREATE INDEX IF NOT EXISTS MY_VIEW_INDEX\n"
++ "ON MY_SCHEMA.MY_DATA_VIEW (TEXT1, DATE_TIME1 DESC,
DOUBLE1)\n"
++ "INCLUDE (CREATED_BY, CREATED_DATE)";
+List queries = new ArrayList(){};
+
+queries.add(table);
+queries.add(view);
+queries.add(index);
+
+String expectedIndex = "CREATE INDEX MY_VIEW_INDEX "
++ "ON MY_SCHEMA.MY_DATA_VIEW(TEXT1, DATE_TIME1 DESC, DOUBLE1,
INT1)"
Review comment:
Talked with @swaroopak about this offline, and she proved that this is
OK, and added tests to that effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Effective DDL generated by SchemaExtractionTool should maintain the order of
> PK and other columns
> -
>
> Key: PHOENIX-6271
> URL: https://issues.apache.org/jira/browse/PHOENIX-6271
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Swaroopa Kadam
>Assignee: Swaroopa Kadam
>Priority: Minor
> Fix For: 5.1.1, 4.16.1
>
>
> SchemaExtractionTool is used to generate effective DDL which can be then
> compared with the DDL on the cluster to perform schema monitoring.
> This won't affect the monitoring part but would be good to have the PR order
> in place so that effective DDL can be used for creating the entity for the
> first time in a new environment.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335130#comment-17335130 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1212: URL: https://github.com/apache/phoenix/pull/1212#issuecomment-828923122 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 7s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 9m 19s | 4.x passed | | +1 :green_heart: | compile | 1m 32s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 2s | 4.x passed | | +1 :green_heart: | javadoc | 1m 0s | 4.x passed | | +0 :ok: | spotbugs | 3m 0s | phoenix-core in 4.x has 946 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 45s | phoenix-tools in 4.x has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 6m 2s | the patch passed | | +1 :green_heart: | compile | 1m 32s | the patch passed | | +1 :green_heart: | javac | 1m 32s | the patch passed | | -1 :x: | checkstyle | 0m 45s | phoenix-core: The patch generated 2 new + 719 unchanged - 3 fixed = 721 total (was 722) | | -1 :x: | checkstyle | 0m 15s | phoenix-tools: The patch generated 34 new + 192 unchanged - 31 fixed = 226 total (was 223) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 57s | the patch passed | | +1 :green_heart: | spotbugs | 4m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 211m 55s | phoenix-core in the patch passed. | | +1 :green_heart: | unit | 4m 18s | phoenix-tools in the patch passed. | | +1 :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 254m 27s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1212 | | JIRA Issue | PHOENIX-6271 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 0820657ae601 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / c3f166e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/2/testReport/ | | Max. process+thread count | 5094 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL:
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[
https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334981#comment-17334981
]
ASF GitHub Bot commented on PHOENIX-6271:
-
swaroopak commented on a change in pull request #1212:
URL: https://github.com/apache/phoenix/pull/1212#discussion_r622502623
##
File path:
phoenix-tools/src/it/java/org/apache/phoenix/schema/SchemaExtractionToolIT.java
##
@@ -160,12 +160,13 @@ public void testCreateViewIndexStatement() throws
Exception {
queries.add(createView);
queries.add(createView1);
queries.add(createIndexStatement);
+String expected = "CREATE INDEX "+indexName+" ON " +childviewName
+"(ID1, K, ID2, ID3 DESC) INCLUDE (V1)";
Review comment:
I tested this locally.
Effective DDL executed correctly and at sys cat level they both are exactly
same including column ordering
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Effective DDL generated by SchemaExtractionTool should maintain the order of
> PK and other columns
> -
>
> Key: PHOENIX-6271
> URL: https://issues.apache.org/jira/browse/PHOENIX-6271
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Swaroopa Kadam
>Assignee: Swaroopa Kadam
>Priority: Minor
> Fix For: 5.1.1, 4.16.1
>
>
> SchemaExtractionTool is used to generate effective DDL which can be then
> compared with the DDL on the cluster to perform schema monitoring.
> This won't affect the monitoring part but would be good to have the PR order
> in place so that effective DDL can be used for creating the entity for the
> first time in a new environment.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[
https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334377#comment-17334377
]
ASF GitHub Bot commented on PHOENIX-6271:
-
gjacoby126 commented on a change in pull request #1212:
URL: https://github.com/apache/phoenix/pull/1212#discussion_r620700431
##
File path:
phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaExtractionProcessor.java
##
@@ -107,40 +103,58 @@ private String getIndexedColumnsString(PTable
indexPTable, PTable dataPTable, St
List indexPK = indexPTable.getPKColumns();
List dataPK = dataPTable.getPKColumns();
-Set indexPkSet = new HashSet<>();
-Set dataPkSet = new HashSet<>();
-Map sortOrderMap = new HashMap<>();
+List indexPKName = new ArrayList<>();
+List dataPKName = new ArrayList<>();
+Map indexSortOrderMap = new HashMap<>();
StringBuilder indexedColumnsBuilder = new StringBuilder();
+
for (PColumn indexedColumn : indexPK) {
String indexColumn =
extractIndexColumn(indexedColumn.getName().getString(), defaultCF);
if(indexColumn.equalsIgnoreCase(MetaDataUtil.VIEW_INDEX_ID_COLUMN_NAME)) {
continue;
}
-indexPkSet.add(indexColumn);
-sortOrderMap.put(indexColumn, indexedColumn.getSortOrder());
+indexPKName.add(indexColumn);
+indexSortOrderMap.put(indexColumn, indexedColumn.getSortOrder());
}
-
for(PColumn pColumn : dataPK) {
-dataPkSet.add(pColumn.getName().getString());
+dataPKName.add(pColumn.getName().getString());
}
-Set effectivePK = Sets.symmetricDifference(indexPkSet,
dataPkSet);
-if (effectivePK.isEmpty()) {
-effectivePK = indexPkSet;
+// This is added because of PHOENIX-2340
+if (dataPTable.isMultiTenant() &&
indexPKName.contains(dataPKName.get(0))) {
Review comment:
nit: can we have a String tenantId = dataPKName.get(0); line and use
that in the checks? I worry that if we ever implement PHOENIX-5248 that the
current logic here will be too subtle for the implementer to realize that it
needs to be changed if we can't depend on first column == tenantId.
##
File path:
phoenix-tools/src/it/java/org/apache/phoenix/schema/SchemaExtractionToolIT.java
##
@@ -160,12 +160,13 @@ public void testCreateViewIndexStatement() throws
Exception {
queries.add(createView);
queries.add(createView1);
queries.add(createIndexStatement);
+String expected = "CREATE INDEX "+indexName+" ON " +childviewName
+"(ID1, K, ID2, ID3 DESC) INCLUDE (V1)";
Review comment:
I'm confused why the output should include K, ID2, and ID3. This seems
incorrect (even though they're implicitly at the end of the view index's PK
because they're the PK of the view)
Isn't the goal to be reproducing the CREATE INDEX statement as you'd
actually want to run it? That wouldn't have the extra PKs on it, right, because
you'd rerun it _in context_ with rerunning the base table and view first?
(otherwise the view index create would fail anyway)
##
File path:
phoenix-tools/src/it/java/org/apache/phoenix/schema/SchemaExtractionToolIT.java
##
@@ -317,19 +321,104 @@ public void testCreateTableWithMultipleCFProperties()
throws Exception {
Assert.assertTrue(compareProperties(simplifiedProperties,
getProperties(result)));
}
+@Test
+public void testColumnAndPKOrdering() throws Exception {
+String table = "CREATE TABLE IF NOT EXISTS MY_SCHEMA.MY_DATA_TABLE (\n"
++ "ORGANIZATION_ID CHAR(15) NOT NULL, \n"
++ "KEY_PREFIX CHAR(3) NOT NULL,\n"
++ "CREATED_DATE DATE,\n"
++ "CREATED_BY CHAR(15) \n"
++ "CONSTRAINT PK PRIMARY KEY (\n"
++ "ORGANIZATION_ID, \n"
++ "KEY_PREFIX\n" + ")\n"
++ ") VERSIONS=1, IMMUTABLE_ROWS=true, MULTI_TENANT=true,
REPLICATION_SCOPE=1";
+
+String view = "CREATE VIEW IF NOT EXISTS MY_SCHEMA.MY_DATA_VIEW (\n"
++ "DATE_TIME1 DATE NOT NULL,\n"
++ "TEXT1 VARCHAR NOT NULL,\n"
++ "INT1 BIGINT NOT NULL,\n"
++ "DOUBLE1 DECIMAL(12, 3),\n"
++ "DOUBLE2 DECIMAL(12, 3),\n"
++ "DOUBLE3 DECIMAL(12, 3),\n"
++ "CONSTRAINT PKVIEW PRIMARY KEY\n" + "(\n"
++ "DATE_TIME1, TEXT1, INT1\n" + ")\n" + ")\n"
++ "AS SELECT * FROM MY_SCHEMA.MY_DATA_TABLE WHERE KEY_PREFIX =
'9Yj'";
+
+String index = "CREATE INDEX IF NOT EXISTS MY_VIEW_INDEX\n"
++ "ON MY_SCHEMA.MY_DATA_VIEW (TEXT1, DATE_TIME1 DESC,
DOUBLE1)\n"
+
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[
https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332917#comment-17332917
]
ASF GitHub Bot commented on PHOENIX-6271:
-
gokceni commented on a change in pull request #1212:
URL: https://github.com/apache/phoenix/pull/1212#discussion_r620837511
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java
##
@@ -1275,15 +1275,21 @@ public static String getPTableFullNameWithQuotes(String
pSchemaName, String pTab
pTableName = "\""+pTableName+"\"";
}
if(tableNameNeedsQuotes || schemaNameNeedsQuotes) {
-pTableFullName = pSchemaName + "." + pTableName;
+if (pSchemaName != null && !pSchemaName.isEmpty()) {
Review comment:
nit: Strings.isNullOrEmpty
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java
##
@@ -1275,15 +1275,21 @@ public static String getPTableFullNameWithQuotes(String
pSchemaName, String pTab
pTableName = "\""+pTableName+"\"";
}
if(tableNameNeedsQuotes || schemaNameNeedsQuotes) {
-pTableFullName = pSchemaName + "." + pTableName;
+if (pSchemaName != null && !pSchemaName.isEmpty()) {
+return String.format("%s.%s", pSchemaName, pTableName);
+} else {
+return pTableName;
+}
}
-
return pTableFullName;
}
private static boolean isQuotesNeeded(String name) {
// first char numeric or non-underscore
-if(!Character.isAlphabetic(name.charAt(0)) && name.charAt(0)!='_') {
+if (name == null || name.isEmpty()) {
Review comment:
nit: Strings.isNullOrEmpty
##
File path: phoenix-core/src/main/java/org/apache/phoenix/util/SchemaUtil.java
##
@@ -1275,15 +1275,21 @@ public static String getPTableFullNameWithQuotes(String
pSchemaName, String pTab
pTableName = "\""+pTableName+"\"";
}
if(tableNameNeedsQuotes || schemaNameNeedsQuotes) {
-pTableFullName = pSchemaName + "." + pTableName;
+if (pSchemaName != null && !pSchemaName.isEmpty()) {
Review comment:
Also do you need to think about namespaceenabled? I am guessing no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Effective DDL generated by SchemaExtractionTool should maintain the order of
> PK and other columns
> -
>
> Key: PHOENIX-6271
> URL: https://issues.apache.org/jira/browse/PHOENIX-6271
> Project: Phoenix
> Issue Type: Improvement
>Reporter: Swaroopa Kadam
>Assignee: Swaroopa Kadam
>Priority: Minor
> Fix For: 5.1.1, 4.16.1
>
>
> SchemaExtractionTool is used to generate effective DDL which can be then
> compared with the DDL on the cluster to perform schema monitoring.
> This won't affect the monitoring part but would be good to have the PR order
> in place so that effective DDL can be used for creating the entity for the
> first time in a new environment.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332845#comment-17332845 ] ASF GitHub Bot commented on PHOENIX-6271: - stoty commented on pull request #1212: URL: https://github.com/apache/phoenix/pull/1212#issuecomment-827268088 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 55s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 5m 28s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 11m 11s | 4.x passed | | +1 :green_heart: | compile | 1m 48s | 4.x passed | | +1 :green_heart: | checkstyle | 0m 58s | 4.x passed | | +1 :green_heart: | javadoc | 1m 12s | 4.x passed | | +0 :ok: | spotbugs | 3m 57s | phoenix-core in 4.x has 946 extant spotbugs warnings. | | +0 :ok: | spotbugs | 0m 50s | phoenix-tools in 4.x has 3 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 7m 16s | the patch passed | | +1 :green_heart: | compile | 1m 54s | the patch passed | | +1 :green_heart: | javac | 1m 54s | the patch passed | | -1 :x: | checkstyle | 0m 45s | phoenix-core: The patch generated 2 new + 719 unchanged - 3 fixed = 721 total (was 722) | | -1 :x: | checkstyle | 0m 16s | phoenix-tools: The patch generated 11 new + 215 unchanged - 8 fixed = 226 total (was 223) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 1m 7s | the patch passed | | +1 :green_heart: | spotbugs | 5m 31s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 241m 55s | phoenix-core in the patch passed. | | +1 :green_heart: | unit | 4m 10s | phoenix-tools in the patch passed. | | +1 :green_heart: | asflicense | 0m 20s | The patch does not generate ASF License warnings. | | | | 292m 15s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1212 | | JIRA Issue | PHOENIX-6271 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux c6050475172b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / c3f166e | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-tools.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/1/testReport/ | | Max. process+thread count | 4725 (vs. ulimit of 3) | | modules | C: phoenix-core phoenix-tools U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1212/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL:
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332760#comment-17332760 ] ASF GitHub Bot commented on PHOENIX-6271: - swaroopak opened a new pull request #1212: URL: https://github.com/apache/phoenix/pull/1212 …maintain the order of PK and other columns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 5.1.1, 4.16.1 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6271) Effective DDL generated by SchemaExtractionTool should maintain the order of PK and other columns
[ https://issues.apache.org/jira/browse/PHOENIX-6271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251330#comment-17251330 ] Swaroopa Kadam commented on PHOENIX-6271: - FYI [~tkhurana] [~kozdemir] > Effective DDL generated by SchemaExtractionTool should maintain the order of > PK and other columns > - > > Key: PHOENIX-6271 > URL: https://issues.apache.org/jira/browse/PHOENIX-6271 > Project: Phoenix > Issue Type: Improvement >Reporter: Swaroopa Kadam >Assignee: Swaroopa Kadam >Priority: Minor > Fix For: 4.16.0 > > > SchemaExtractionTool is used to generate effective DDL which can be then > compared with the DDL on the cluster to perform schema monitoring. > This won't affect the monitoring part but would be good to have the PR order > in place so that effective DDL can be used for creating the entity for the > first time in a new environment. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
