[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17352095#comment-17352095 ] Sandeep Pal commented on PHOENIX-6447: -- [~larsh] Thank you very much, I got side tracked from this :) > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351991#comment-17351991 ] Lars Hofhansl commented on PHOENIX-6447: I cherry-picked the change in. All done. All good :) > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 5.1.2, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351988#comment-17351988 ] Lars Hofhansl commented on PHOENIX-6447: [~sandeep.pal] did you get a chance yet? If the change applies you can also just cherry-pick from master into the 5.1 branch. > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344341#comment-17344341 ] Sandeep Pal commented on PHOENIX-6447: -- I will create a PR for 5.1. > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344339#comment-17344339 ] Viraj Jasani commented on PHOENIX-6447: --- Updated fixVersion as it is not included in 4.16.1 RC. > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344338#comment-17344338
]
Viraj Jasani commented on PHOENIX-6447:
---
{quote}Should this one be in branch-5.1 (i.e. Phoenix 5.1.2)?
{quote}
I think so because this is present on 4.x and 4.16 both.
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.1, 4.17.0, 5.2.0
>
>
> In order to replicate system tables, we have a special filter for system
> catalog table to just replicate tenant owner data in order NOT to mess up the
> system catalog at the sink cluster. In 4.16, there is a new table getting
> added (SYSTEM.CHILD_LINK) which will not be replicated completely from our
> existing filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344242#comment-17344242 ] Lars Hofhansl commented on PHOENIX-6447: Should this one be in branch-5.1 (i.e. Phoenix 5.1.2)? > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.1, 4.17.0, 5.2.0 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17332717#comment-17332717 ] ASF GitHub Bot commented on PHOENIX-6447: - gjacoby126 merged pull request #1207: URL: https://github.com/apache/phoenix/pull/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order NOT to mess up the > system catalog at the sink cluster. In 4.16, there is a new table getting > added (SYSTEM.CHILD_LINK) which will not be replicated completely from our > existing filter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331807#comment-17331807 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1207: URL: https://github.com/apache/phoenix/pull/1207#issuecomment-826050379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 42s | master passed | | +0 | hbaserecompile | 23m 1s | HBase recompiled. | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | checkstyle | 0m 31s | master passed | | +1 :green_heart: | javadoc | 0m 50s | master passed | | +0 :ok: | spotbugs | 3m 2s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 11s | the patch passed | | +0 | hbaserecompile | 17m 32s | HBase recompiled. | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | checkstyle | 0m 33s | phoenix-core: The patch generated 2 new + 4 unchanged - 8 fixed = 6 total (was 12) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | | +1 :green_heart: | spotbugs | 3m 15s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 112m 8s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 165m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1207 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0dfbf625c62f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / d1f26c7 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/testReport/ | | Max. process+thread count | 14870 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331164#comment-17331164 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1207: URL: https://github.com/apache/phoenix/pull/1207#issuecomment-826050379 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 42s | master passed | | +0 | hbaserecompile | 23m 1s | HBase recompiled. | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | checkstyle | 0m 31s | master passed | | +1 :green_heart: | javadoc | 0m 50s | master passed | | +0 :ok: | spotbugs | 3m 2s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 11s | the patch passed | | +0 | hbaserecompile | 17m 32s | HBase recompiled. | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | -1 :x: | checkstyle | 0m 33s | phoenix-core: The patch generated 2 new + 4 unchanged - 8 fixed = 6 total (was 12) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | | +1 :green_heart: | spotbugs | 3m 15s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 112m 8s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 165m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1207 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 0dfbf625c62f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / d1f26c7 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/testReport/ | | Max. process+thread count | 14870 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/3/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > > In order to replicate system tables, we have a special filter for system > catalog table to just replicate tenant owner data in order
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331142#comment-17331142 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1207: URL: https://github.com/apache/phoenix/pull/1207#issuecomment-826033747 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 15m 47s | master passed | | +0 | hbaserecompile | 22m 28s | HBase recompiled. | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | checkstyle | 0m 32s | master passed | | +1 :green_heart: | javadoc | 0m 50s | master passed | | +0 :ok: | spotbugs | 3m 3s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 5s | the patch passed | | +0 | hbaserecompile | 18m 8s | HBase recompiled. | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | -1 :x: | checkstyle | 0m 32s | phoenix-core: The patch generated 4 new + 4 unchanged - 8 fixed = 8 total (was 12) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | | -1 :x: | spotbugs | 3m 15s | phoenix-core generated 1 new + 960 unchanged - 0 fixed = 961 total (was 960) | ||| _ Other Tests _ | | -1 :x: | unit | 110m 51s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. | | | | 163m 56s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Unread field:field be static? At SystemCatalogWALEntryFilter.java:[line 49] | | Failed junit tests | phoenix.replication.SystemCatalogWALEntryFilterIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1207 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux 5f414ca64b75 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / d1f26c7 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/testReport/ | | Max. process+thread count | 15048 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter >
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331127#comment-17331127 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1207: URL: https://github.com/apache/phoenix/pull/1207#issuecomment-826016942 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 53s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 17m 8s | master passed | | +0 | hbaserecompile | 24m 11s | HBase recompiled. | | +1 :green_heart: | compile | 1m 5s | master passed | | +1 :green_heart: | checkstyle | 0m 31s | master passed | | +1 :green_heart: | javadoc | 0m 51s | master passed | | +0 :ok: | spotbugs | 3m 24s | phoenix-core in master has 960 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 52s | the patch passed | | +0 | hbaserecompile | 20m 12s | HBase recompiled. | | +1 :green_heart: | compile | 1m 6s | the patch passed | | +1 :green_heart: | javac | 1m 6s | the patch passed | | -1 :x: | checkstyle | 0m 31s | phoenix-core: The patch generated 4 new + 4 unchanged - 8 fixed = 8 total (was 12) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 53s | the patch passed | | -1 :x: | spotbugs | 3m 30s | phoenix-core generated 1 new + 960 unchanged - 0 fixed = 961 total (was 960) | ||| _ Other Tests _ | | -1 :x: | unit | 114m 32s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 35s | The patch does not generate ASF License warnings. | | | | 176m 49s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Unread field:field be static? At SystemCatalogWALEntryFilter.java:[line 49] | | Failed junit tests | phoenix.replication.SystemCatalogWALEntryFilterIT | | | phoenix.end2end.index.IndexMetadataIT | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1207 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile | | uname | Linux af2fe4f457d5 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / fb5c08f | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/testReport/ | | Max. process+thread count | 11242 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1207/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter >
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331089#comment-17331089 ] ASF GitHub Bot commented on PHOENIX-6447: - sandeepvinayak commented on pull request #1207: URL: https://github.com/apache/phoenix/pull/1207#issuecomment-825984271 @gjacoby126 this is the PR for the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331088#comment-17331088 ] ASF GitHub Bot commented on PHOENIX-6447: - sandeepvinayak opened a new pull request #1207: URL: https://github.com/apache/phoenix/pull/1207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329324#comment-17329324 ] ASF GitHub Bot commented on PHOENIX-6447: - gjacoby126 merged pull request #1201: URL: https://github.com/apache/phoenix/pull/1201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329316#comment-17329316 ] ASF GitHub Bot commented on PHOENIX-6447: - sandeepvinayak commented on pull request #1201: URL: https://github.com/apache/phoenix/pull/1201#issuecomment-825050250 @gjacoby126 changed the commit message -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329289#comment-17329289 ] ASF GitHub Bot commented on PHOENIX-6447: - gjacoby126 commented on pull request #1201: URL: https://github.com/apache/phoenix/pull/1201#issuecomment-825033253 @sandeepvinayak - could you please change your commit message to match the JIRA name (with the JIRA number). Then this looks good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327117#comment-17327117 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1201: URL: https://github.com/apache/phoenix/pull/1201#issuecomment-824556099 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.16 Compile Tests _ | | +1 :green_heart: | mvninstall | 13m 54s | 4.16 passed | | +1 :green_heart: | compile | 1m 0s | 4.16 passed | | +1 :green_heart: | checkstyle | 0m 26s | 4.16 passed | | +1 :green_heart: | javadoc | 0m 44s | 4.16 passed | | +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.16 has 944 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 41s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | -1 :x: | checkstyle | 0m 27s | phoenix-core: The patch generated 4 new + 4 unchanged - 7 fixed = 8 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 45s | the patch passed | | -1 :x: | spotbugs | 3m 12s | phoenix-core generated 1 new + 944 unchanged - 0 fixed = 945 total (was 944) | ||| _ Other Tests _ | | +1 :green_heart: | unit | 127m 50s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 159m 30s | | | Reason | Tests | |---:|:--| | FindBugs | module:phoenix-core | | | Unread field:field be static? At SystemCatalogWALEntryFilter.java:[line 49] | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1201 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 1c2d68d8a757 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.16 / 0a79cb6 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/4/testReport/ | | Max. process+thread count | 5643 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/4/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327002#comment-17327002
]
ASF GitHub Bot commented on PHOENIX-6447:
-
gjacoby126 commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617954920
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,64 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return doesKeyHaveLeadingSeparatorByte(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
-// rows in system.catalog that aren't tenant-owned
+ /**
+ * does the cell key have leading separator byte
+ * @param cell hbase cell
+ * @return true if the cell has leading separator byte
+ */
+ private boolean doesKeyHaveLeadingSeparatorByte(final Cell cell) {
+// rows in system.catalog or system child that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned. Besides the non empty
+ * tenant id, system.child_link table have tenant owned data for parent child
+ * links. In this case, the column qualifier is
+ * {@code PhoenixDatabaseMetaData#LINK_TYPE_BYTES} and value is
+ * {@code PTable.LinkType.CHILD_TABLE}.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+boolean isTenantRowCell = doesKeyHaveLeadingSeparatorByte(cell);
+
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+boolean isChildLinkToTenantView = false;
+if (!isTenantRowCell) {
+ ImmutableBytesWritable cq = new ImmutableBytesWritable(
+cell.getQualifierArray(), cell.getQualifierOffset(),
+cell.getQualifierLength());
+ boolean isChildLink =
+cq.compareTo(PhoenixDatabaseMetaData.LINK_TYPE_BYTES) == 0;
+ if (isChildLink) {
+ImmutableBytesWritable columnValue = new ImmutableBytesWritable(
+ cell.getValueArray(), cell.getValueOffset(), cell.getValueLength());
+if (columnValue.compareTo(CHILD_TABLE_BYTES) == 0) {
Review comment:
nit: can use CellUtil.matchingValue
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,64 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return doesKeyHaveLeadingSeparatorByte(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
-// rows in system.catalog that aren't tenant-owned
+ /**
+ * does the cell key have leading separator byte
+ * @param cell hbase cell
+ * @return true if the cell has leading separator byte
+ */
+ private boolean doesKeyHaveLeadingSeparatorByte(final Cell cell) {
+// rows in system.catalog or system child that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned. Besides the non empty
+ * tenant id, system.child_link table have tenant owned data for parent child
+ * links. In this case, the column qualifier is
+ * {@code PhoenixDatabaseMetaData#LINK_TYPE_BYTES} and value is
+ * {@code PTable.LinkType.CHILD_TABLE}.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+boolean isTenantRowCell = doesKeyHaveLeadingSeparatorByte(cell);
+
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+boolean isChildLinkToTenantView = false;
+if (!isTenantRowCell) {
+ ImmutableBytesWritable cq = new ImmutableBytesWritable(
+cell.getQualifierArray(), cell.getQualifierOffset(),
Review comment:
nit: can use CellUtil.matchingQualifier.
--
This is an automated message from the Apache Git Service.
To respond
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326934#comment-17326934
]
ASF GitHub Bot commented on PHOENIX-6447:
-
sandeepvinayak commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617881142
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,63 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return isTenantRowCellSystemCatalog(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
+ /**
+ * is the cell for system catalog a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemCatalog(final Cell cell) {
// rows in system.catalog that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+//rows in system.catalog that aren't tenant-owned will
+// have a leading separator byte
+boolean isTenantRowCell =
Review comment:
The schema remains the same but the system catalog table is not supposed
to have tenant-owned data with empty tenant id anymore. Thus, I believe we need
different methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326929#comment-17326929
]
ASF GitHub Bot commented on PHOENIX-6447:
-
ankitjain64 commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617879145
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,63 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return isTenantRowCellSystemCatalog(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
+ /**
+ * is the cell for system catalog a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemCatalog(final Cell cell) {
// rows in system.catalog that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+//rows in system.catalog that aren't tenant-owned will
+// have a leading separator byte
+boolean isTenantRowCell =
Review comment:
Does the schema for system.child_link table the same as that for
system.catalog? and does this assumption of leading separator byte holds true
there as well? If so we can refactor `isTenantRowCellSystemCatalog` and reuse
the same function here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326928#comment-17326928
]
ASF GitHub Bot commented on PHOENIX-6447:
-
ankitjain64 commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617879145
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,63 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return isTenantRowCellSystemCatalog(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
+ /**
+ * is the cell for system catalog a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemCatalog(final Cell cell) {
// rows in system.catalog that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+//rows in system.catalog that aren't tenant-owned will
+// have a leading separator byte
+boolean isTenantRowCell =
Review comment:
Does the schema for system.child_link table the same as that for
system.catalog? and does this assumption of leading separator byte holds true
there as well? If so we can `isTenantRowCellSystemCatalog` and reuse the same
function here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326925#comment-17326925
]
ASF GitHub Bot commented on PHOENIX-6447:
-
ankitjain64 commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617878268
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilter.java
##
@@ -58,13 +64,63 @@ public Cell filterCell(final WAL.Entry entry, final Cell
cell) {
if (skipCellFilter) {
return cell;
}
-return isTenantRowCell(cell) ? cell : null;
+
+if (SchemaUtil.isMetaTable(entry.getKey().getTablename().getName())) {
+ return isTenantRowCellSystemCatalog(cell) ? cell : null;
+} else {
+ return isTenantRowCellSystemChildLink(cell) ? cell : null;
+}
}
- private boolean isTenantRowCell(Cell cell) {
+ /**
+ * is the cell for system catalog a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemCatalog(final Cell cell) {
// rows in system.catalog that aren't tenant-owned
// will have a leading separator byte
return cell.getRowArray()[cell.getRowOffset()]
-!= QueryConstants.SEPARATOR_BYTE;
+ != QueryConstants.SEPARATOR_BYTE;
+ }
+
+ /**
+ * is the cell for system child link a tenant owned.
+ * @param cell hbase cell
+ * @return true if the cell is tenant owned
+ */
+ private boolean isTenantRowCellSystemChildLink(final Cell cell) {
+ImmutableBytesWritable key = new ImmutableBytesWritable(
+ cell.getRowArray(), cell.getRowOffset(), cell.getRowLength());
+//rows in system.catalog that aren't tenant-owned will
Review comment:
nit: Remove system.catalog from comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[
https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326877#comment-17326877
]
ASF GitHub Bot commented on PHOENIX-6447:
-
gjacoby126 commented on a change in pull request #1201:
URL: https://github.com/apache/phoenix/pull/1201#discussion_r617834873
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/replication/SystemCatalogWALEntryFilterIT.java
##
@@ -90,6 +91,7 @@ public static synchronized void setup() throws Exception {
catalogTable = PhoenixRuntime.getTable(connection,
PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME);
childLinkTable = PhoenixRuntime.getTable(connection,
PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME);
walKey = new WALKey(REGION,
TableName.valueOf(PhoenixDatabaseMetaData.SYSTEM_CATALOG_NAME), 0, 0, uuid);
+ walKey = new WALKey(REGION,
TableName.valueOf(PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME), 0, 0, uuid);
Review comment:
Doesn't this make the previous line unnecessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
> --
>
> Key: PHOENIX-6447
> URL: https://issues.apache.org/jira/browse/PHOENIX-6447
> Project: Phoenix
> Issue Type: Bug
> Components: core
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 4.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326229#comment-17326229 ] ASF GitHub Bot commented on PHOENIX-6447: - stoty commented on pull request #1201: URL: https://github.com/apache/phoenix/pull/1201#issuecomment-823748056 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.16 Compile Tests _ | | +1 :green_heart: | mvninstall | 13m 40s | 4.16 passed | | +1 :green_heart: | compile | 1m 0s | 4.16 passed | | +1 :green_heart: | checkstyle | 0m 27s | 4.16 passed | | +1 :green_heart: | javadoc | 0m 45s | 4.16 passed | | +0 :ok: | spotbugs | 2m 59s | phoenix-core in 4.16 has 944 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 41s | the patch passed | | +1 :green_heart: | compile | 1m 2s | the patch passed | | +1 :green_heart: | javac | 1m 2s | the patch passed | | -1 :x: | checkstyle | 0m 27s | phoenix-core: The patch generated 19 new + 4 unchanged - 7 fixed = 23 total (was 11) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 44s | the patch passed | | +1 :green_heart: | spotbugs | 3m 11s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 127m 36s | phoenix-core in the patch passed. | | +1 :green_heart: | asflicense | 0m 11s | The patch does not generate ASF License warnings. | | | | 164m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1201 | | JIRA Issue | PHOENIX-6447 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux b45fec623579 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.16 / 0a79cb6 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/1/testReport/ | | Max. process+thread count | 5623 (vs. ulimit of 3) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1201/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326179#comment-17326179 ] ASF GitHub Bot commented on PHOENIX-6447: - sandeepvinayak commented on pull request #1201: URL: https://github.com/apache/phoenix/pull/1201#issuecomment-823692598 @gjacoby126 @yanxinyi can you please review this to add system child link table in systemcatalog wal entry filter for replication. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (PHOENIX-6447) Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter
[ https://issues.apache.org/jira/browse/PHOENIX-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326178#comment-17326178 ] ASF GitHub Bot commented on PHOENIX-6447: - sandeepvinayak opened a new pull request #1201: URL: https://github.com/apache/phoenix/pull/1201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add support for SYSTEM.CHILD_LINK table in systemcatalogwalentryfilter > -- > > Key: PHOENIX-6447 > URL: https://issues.apache.org/jira/browse/PHOENIX-6447 > Project: Phoenix > Issue Type: Bug > Components: core >Reporter: Sandeep Pal >Assignee: Sandeep Pal >Priority: Major > Fix For: 4.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
