[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471057#comment-17471057 ] ASF GitHub Bot commented on PHOENIX-6615: - stoty closed pull request #1370: URL: https://github.com/apache/phoenix/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.3 > > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470428#comment-17470428 ] ASF GitHub Bot commented on PHOENIX-6615: - stoty closed pull request #1370: URL: https://github.com/apache/phoenix/pull/1370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Assignee: Istvan Toth >Priority: Major > Fix For: 5.2.0, 5.1.3 > > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470170#comment-17470170 ] Lars Hofhansl commented on PHOENIX-6615: Thanks! Just approved the PR. Happy to merge unless you want to that. > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Assignee: Istvan Toth >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[
https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467870#comment-17467870
]
Istvan Toth commented on PHOENIX-6615:
--
I've made a PR from your patch, and set you as the author [~larsh].
before:
{noformat}
[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.643
s - in org.apache.phoenix.tx.TransactionIT
{noformat}
after:
{noformat}
[INFO] Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 169.053
s - in org.apache.phoenix.tx.TransactionIT
{noformat}
> The Tephra transaction processor cannot be loaded anymore.
> --
>
> Key: PHOENIX-6615
> URL: https://issues.apache.org/jira/browse/PHOENIX-6615
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.1.2
>Reporter: Lars Hofhansl
>Priority: Major
> Attachments: 6615.txt
>
>
> See
> # TransactionFactory
> # TephraTransactionProvider
> Can you spot the problem? :) (Hint: The constructor is private.)
> Broken since PHOENIX-6064. [~stoty] .
> Can I just say... Unless I am missing something... How could we not have
> noticed that one of the transaction processors has not been working since
> August (in 5.x at least)? Is really nobody using the transaction engines?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463377#comment-17463377 ] Lars Hofhansl commented on PHOENIX-6615: I guess the breakage was hard to notice, since the tests are (necessarily) disabled for the NotAvailableTransactionProvider. > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463376#comment-17463376 ] Lars Hofhansl commented on PHOENIX-6615: Thanks [~stoty] . I agree the bitrot is around Tephra, not Phoenix. And the job you do maintaining Tephra is appreciated! Omid and Tephra have different pros and cons. Tephra has no (or negligible) per row cost, but a higher per transaction cost (since all failed or rolled-back transactions have to be sent to all future transaction until they are collected), Omid on the other hand has a fairly high per row cost (as the shadow columns need to be updated) but no lasting per transactions cost (once the shadow columns are updated no further information is needed). So I'd use Omid for many small transactions, and Tephra for few but large transactions... And maybe it's really not worth it. :) I agree with you that maintaining the perception that a project is maintained is worth than ripping it out. As for transactions in general... Phoenix is the only engine I know that supports OLTP like interactions (JDBC et al), and high-volume interactions (via regions, guideposts and M/R, Spark, and Trino integrations), and transactions. It's something that really sets Phoenix apart. It would be just a shame to let that rot. Yes, let's take it up on the dev list. My priorities have since changed more into the bigger ecosystem of data (Trino, Iceberg, Spark, Federation, Real-time Ingestion, M/L, Governance, etc). That said, Phoenix has still a place in that ecosystem as I mentioned before, and so I am still interested at that level. > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463052#comment-17463052 ] Istvan Toth commented on PHOENIX-6615: -- On transaction support generally: Yes, I do get the feeling that very few people are using it, and if they do, they are not telling. Even before I broke it in PHOENIX-6064 Tephra support has been broken more than not, as Tephra needs a new release for every HBase minor version, otherwise it will fail to start. The last release supports up to HBase 2.4 and 1.6 IIRC. (The IT suite doesn't catch the missing HBase support, either) The glass is actually half-full, as we do support Omid + Phoenix at dayjob, and if you check the commit log, Rajeshbabu and I ironed out quite a few kinks out of that in the past year (like Kerberos not working at all), so we know that Omid and Phoenix + Omid is in a workable state (at least on our branch, which is basically Omid HEAD, minus the incompatible maven changes). We are also regularly running some (basic) E2E tests for it. (Omid needs a new release to get the rest of those fixes and improvements officially out, BTW) We did have two Omid contributors, who are not on the #dayjob team in the last year, with some much needed Omid build system improvements, but not even any bug reports on Tephra. We have worked on Tephra, mostly to keep Tephra working with newer HBase minore releases, and to somewhat isolate us from the CVEs in it, but more out of wanting the keep Phoenix CVE free (check) and intact (fail), than because we had any plans for Tephra beyond that. In other words, the work we do on Tephra relates more to keeping the rest of Phoenix building and safe than keeping Tephra working (much less improving it). All that I know about Tephra and Tephra support in Phoenix points to it being abandoned at this point. As any unmaintained code, Tephra is a liability, (hence PHOENIX-6064), and making Tephra secure is a non-trivial amount of work. (need to rip out and replace Twill, and update Guava at least, and fix any JVM incompatibilities that you've mentioned) I estimate that it'd take about 1-3 weeks depending on familiarity with Twill, Guava and ZK. I'm of course going to test and apply your fix to PHOENIX-6064 (thanks again), and I may make Tephra point releases for new HBase minor versions (1.7 support is known to be missing), but if no maintainer steps up for Tephra (who actually cares about it, and can commit time to it), then we need to revisit the previous discussion on the long-term viability of Tephra. I'm beginning to doubt that the half-hearted job I do at maintaining Tephra (i.e. adding support for new HBase releases) is beneficial, as it may give the illusion of a properly maintained project to an outside observer. Should we take the Tephra discussion to the dev/user list next year ? > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463030#comment-17463030 ] Istvan Toth commented on PHOENIX-6615: -- Thank you [~larsh], yes, that was the idea. Sorry about the breakage, I will look at this after the holidays. > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors has not been working since > August (in 5.x at least)? Is really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6615) The Tephra transaction processor cannot be loaded anymore.
[ https://issues.apache.org/jira/browse/PHOENIX-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463016#comment-17463016 ] Lars Hofhansl commented on PHOENIX-6615: I guess something like this is what you wanted... Attempt to load the singleton via reflection. > The Tephra transaction processor cannot be loaded anymore. > -- > > Key: PHOENIX-6615 > URL: https://issues.apache.org/jira/browse/PHOENIX-6615 > Project: Phoenix > Issue Type: Bug >Affects Versions: 5.1.2 >Reporter: Lars Hofhansl >Priority: Major > Attachments: 6615.txt > > > See > # TransactionFactory > # TephraTransactionProvider > Can you spot the problem? :) (Hint: The constructor is private.) > Broken since PHOENIX-6064. [~stoty] . > Can I just say... Unless I am missing something... How could we not have > noticed that one of the transaction processors does not work since August? Is > really nobody using the transaction engines? > -- This message was sent by Atlassian Jira (v8.20.1#820001)
