[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550626#comment-17550626 ] Geoffrey Jacoby commented on PHOENIX-6636: -- [~stoty]- can this be closed (since I believe we later decided to move to log4j2?) > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499082#comment-17499082 ] Lars Hofhansl commented on PHOENIX-6636: Thanks. Works fine now. > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498414#comment-17498414 ] Istvan Toth commented on PHOENIX-6636: -- Fixed the scripts. It turns out that on the 4.% branches some scripts were still using the non-embedded client JAR, I synced those 5.% BTW the third party changes are not used yet, we'll have to make a phoenix-thirdparty release first. (I just can't seem to be able to get around to doing it) > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498354#comment-17498354 ] Lars Hofhansl commented on PHOENIX-6636: (y) > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498319#comment-17498319 ] Istvan Toth commented on PHOENIX-6636: -- Thanks [~larsh] , Seems like forgot to update the logging backend jar name pattern in the Python startup scripts. I'm gonna push an addendum on Monday at the latest. > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498305#comment-17498305 ] Lars Hofhansl commented on PHOENIX-6636: Hmm... Getting this now when starting Phoenix (hbase 2.4 and hadoop 3.3.x profile). This used to work before. Might be due to the this, or the new 3rd party dependency. [~stoty] {code:java} WARNING: Exception thrown by removal listener java.lang.NoClassDefFoundError: Could not initialize class org.apache.phoenix.monitoring.GlobalClientMetrics at org.apache.phoenix.query.ConnectionQueryServicesImpl.close(ConnectionQueryServicesImpl.java:569) at org.apache.phoenix.jdbc.PhoenixDriver$2.onRemoval(PhoenixDriver.java:163) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache.processPendingNotifications(LocalCache.java:1808) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache$Segment.runUnlockedCleanup(LocalCache.java:3379) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache$Segment.postWriteCleanup(LocalCache.java:3355) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache$Segment.remove(LocalCache.java:2989) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache.remove(LocalCache.java:4104) at org.apache.phoenix.thirdparty.com.google.common.cache.LocalCache$LocalManualCache.invalidate(LocalCache.java:4739) at org.apache.phoenix.jdbc.PhoenixDriver.getConnectionQueryServices(PhoenixDriver.java:270) at org.apache.phoenix.jdbc.PhoenixEmbeddedDriver.createConnection(PhoenixEmbeddedDriver.java:144) at org.apache.phoenix.jdbc.PhoenixDriver.connect(PhoenixDriver.java:221) at sqlline.DatabaseConnection.connect(DatabaseConnection.java:135) at sqlline.DatabaseConnection.getConnection(DatabaseConnection.java:192) at sqlline.Commands.connect(Commands.java:1364) at sqlline.Commands.connect(Commands.java:1244) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at sqlline.ReflectiveCommandHandler.execute(ReflectiveCommandHandler.java:38) at sqlline.SqlLine.dispatch(SqlLine.java:730) at sqlline.SqlLine.initArgs(SqlLine.java:410) at sqlline.SqlLine.begin(SqlLine.java:515) at sqlline.SqlLine.start(SqlLine.java:267) at sqlline.SqlLine.main(SqlLine.java:206) java.lang.NoClassDefFoundError: org/apache/log4j/AppenderSkeleton at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1017) at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174) at java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800) at java.base/jdk.internal.loader.BuiltinClassLoader.findClassOnClassPathOrNull(BuiltinClassLoader.java:698) at java.base/jdk.internal.loader.BuiltinClassLoader.loadClassOrNull(BuiltinClassLoader.java:621) at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:579) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) at org.apache.hadoop.metrics2.source.JvmMetrics.getEventCounters(JvmMetrics.java:288) at org.apache.hadoop.metrics2.source.JvmMetrics.getMetrics(JvmMetrics.java:157) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:200) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:183) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:156) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getNewMBeanClassName(DefaultMBeanServerInterceptor.java:329) at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:315) at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:100) at org.apache.hadoop.metrics2.util.MBeans.register(MBeans.java:73) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.startMBeans(MetricsSourceAdapter.java:222) at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.start(MetricsSourceAdapter.java:101) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.registerSource(MetricsSystemImpl.java:268) at org.apache.hadoop.metrics2.impl.MetricsSystemImpl.register(MetricsSystemImpl.java:233) at org.apache.hadoop.metrics2.source.JvmMetrics.create(JvmMetrics.java:123) at org.apache.hadoop.metrics2.source.JvmMetrics$Singleton.init(JvmMetrics.java:63) at
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498108#comment-17498108 ] ASF GitHub Bot commented on PHOENIX-6636: - stoty closed pull request #1379: URL: https://github.com/apache/phoenix/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 4.17.0, 5.2.0, 4.16.2, 5.1.3 > > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (PHOENIX-6636) Replace bundled log4j libraries with reload4j
[ https://issues.apache.org/jira/browse/PHOENIX-6636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498104#comment-17498104 ] Istvan Toth commented on PHOENIX-6636: -- Committed to all active branches of the Phoenxi repo. Thanks for the review [~gjacoby] . Keeping the ticket open, as need to update/review the other repos. > Replace bundled log4j libraries with reload4j > - > > Key: PHOENIX-6636 > URL: https://issues.apache.org/jira/browse/PHOENIX-6636 > Project: Phoenix > Issue Type: Bug > Components: connectors, core, queryserver >Affects Versions: 5.2.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > To reduce the number of dependecies with unresolved CVEs, replace the bundled > log4j libraries with reload4j ([https://reload4j.qos.ch/).] > This will also require bumping the slf4j version. > This is a quick fix, and does not preclude moving to some different backend > later (like log4j2 or logback) -- This message was sent by Atlassian Jira (v8.20.1#820001)