Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]
dbwong commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1881912052 I think my questions are on the same lines as @stoty . Can this just be pushed into Conection::getTable as well? In general I dislike the spread/increase use of PhoenixRuntime as much as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]
kadirozde commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1875071311 > > > Also, I wonder if we should make this functionalitiy available from the Connection object as a new method. > > > > > > Ideally yes we should. We tried that before while working on [PHOENIX-6761](https://issues.apache.org/jira/browse/PHOENIX-6761). However, there are tests that expect TableNotFoundException from PhoenixConnection#getTable. So, we gave up on that. > > What is your opinion on renaming the current getTable to something like getCachedTable or getTableFromCache, and adding a fixed getTable to handles tables not in the cache ? That would not break the tests (and current code that relies on the bahviour), and would make the method names better match the behaviour ? I will look into unifying get table and related methods and possibly remove them from PhoenixRuntime to simply the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]
stoty commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1874877216 > > Also, I wonder if we should make this functionalitiy available from the Connection object as a new method. > > Ideally yes we should. We tried that before while working on [PHOENIX-6761](https://issues.apache.org/jira/browse/PHOENIX-6761). However, there are tests that expect TableNotFoundException from PhoenixConnection#getTable. So, we gave up on that. What is your opinion on renaming the current getTable to something like getCachedTable or getTableFromCache, and adding a fixed getTable to handles tables not in the cache ? That would not break the tests (and current code that relies on the bahviour), and would make the method names better match the behaviour ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]
kadirozde commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1874356302 > Also, I wonder if we should make this functionalitiy available from the Connection object as a new method. Ideally yes we should. We tired that before while working on PHOENIX-6761. However, there are tests that expect TableNotFoundException from PhoenixConnection#getTable. So, we gave up on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7165 Compilers should use PhoenixRuntime#getTable [phoenix]
stoty commented on PR #1777: URL: https://github.com/apache/phoenix/pull/1777#issuecomment-1874348286 Also, I wonder if we should make this functionalitiy available from the Connection object as a new method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
