Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
stoty commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1884744868 merged manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
stoty closed pull request #1785: PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… URL: https://github.com/apache/phoenix/pull/1785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
stoty commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1884727509 I've run the full test suite successfully locally both for 2.4 and 2.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
virajjasani commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1883642533 > and I don't recall seeing it fail before. yes, me neither. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
stoty commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1883460412 At least I assume that that is the problem, as the TestPerRegionIndexWriteCache doesn't fail for me locally, and I don't recall seeing it fail before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
stoty commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1883456581 The problem is that I added an optimization to the Yetus personality to only rebuild HBase once at the start, and Yetus won't rebuild the new HBase version when we change the HBase version. This wouldn't be very hard to fix, I just haven't gotten around to doing it. https://issues.apache.org/jira/browse/PHOENIX-6593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
virajjasani commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1883433340 I wonder if this should be part of IT test so that it won't block all ITs from running https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1785/2/testReport/junit/org.apache.phoenix.hbase.index.write.recovery/TestPerRegionIndexWriteCache/testMultipleRegions/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7173 Update default HBase versions to 2.4.17 and 2.5.7 respec… [phoenix]
virajjasani commented on PR #1785: URL: https://github.com/apache/phoenix/pull/1785#issuecomment-1883434511 Otherwise if tests have already been verified locally, +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
