[jira] [Resolved] (RATIS-52) Refactor RaftUtils into different classes

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze resolved RATIS-52.
--
   Resolution: Fixed
Fix Version/s: 0.1.0-alpha

+1 the v2 patch looks good.

I have committed this.  Thanks, Enis!

> Refactor RaftUtils into different classes
> -
>
> Key: RATIS-52
> URL: https://issues.apache.org/jira/browse/RATIS-52
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-52_v1.patch, ratis-52_v2.patch
>
>
> Ideally we should not have a generic {{RaftUtils}} class. The code should be 
> broken up into at least: 
> {code}
> ReflectionUtils -> All reflection, construction, initialization logic 
> IOUtils -> Add buffer and IO logic 
> SystemUtils or PlatformUtils -> OS type detection, etc 
> Preconditions (or something like that) -> assertTrue, etc 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Jing Zhao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao resolved RATIS-57.

   Resolution: Fixed
Fix Version/s: 0.1.0-alpha

+1. I've committed this.

> Fix pom.xml for mvn release:prepare
> ---
>
> Key: RATIS-57
> URL: https://issues.apache.org/jira/browse/RATIS-57
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Fix For: 0.1.0-alpha
>
> Attachments: r57_20170330.patch
>
>
> According to [Prepare your POMs for 
> release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
>  the following command can test the pom.
> {code}
> mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
> {code}
> The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-61) QuorumSupplier

2017-03-30 Thread Enis Soztutar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated RATIS-61:
---
Attachment: ratis-61-v1.patch

v1 patch. Added a unit test, and some infrastructure for test utilities.  

> QuorumSupplier
> --
>
> Key: RATIS-61
> URL: https://issues.apache.org/jira/browse/RATIS-61
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-61-v1.patch
>
>
> Replicated map is like zookeper, where there is a fixed set of known-hosts in 
> the quorum. No reconfiguration yet. 
> {code}
> QuorumSupplier::List getQuorum()
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RATIS-61) QuorumSupplier

2017-03-30 Thread Enis Soztutar (JIRA) 
Enis Soztutar created RATIS-61:
--

 Summary: QuorumSupplier
 Key: RATIS-61
 URL: https://issues.apache.org/jira/browse/RATIS-61
 Project: Ratis
  Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Enis Soztutar
 Fix For: 0.1.0-alpha


Replicated map is like zookeper, where there is a fixed set of known-hosts in 
the quorum. No reconfiguration yet. 

{code}
QuorumSupplier::List getQuorum()
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-60) Allow direct PB support for Message and SMLogEntry

2017-03-30 Thread Enis Soztutar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated RATIS-60:
---
Attachment: ratis-60-v0.patch

This v0 patch is what I have in the patch from the parent RATIS-40. However, it 
does not fix the problem, just allows us to have PB-based Message objects. Just 
attaching for illustrating the problem. 

> Allow direct PB support for Message and SMLogEntry
> --
>
> Key: RATIS-60
> URL: https://issues.apache.org/jira/browse/RATIS-60
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-60-v0.patch
>
>
> Right now, for flexibility, both Message and SMLogEntry are ByteStrings. This 
> allows using custom serialization formats other than PB (or maybe use a 
> different  version of PB). 
> However, this is very inefficient for the common case where both the messages 
> and SM Log Entries are themselves PB objects. We unnecessarily serialize 
> twice. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-58) Add rmap.proto

2017-03-30 Thread Jing Zhao (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949810#comment-15949810
 ] 

Jing Zhao commented on RATIS-58:


+1

> Add rmap.proto
> --
>
> Key: RATIS-58
> URL: https://issues.apache.org/jira/browse/RATIS-58
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-58-v1.patch
>
>
> The PB file for the replicated map RPC. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-59) bin/ script changes for rmap

2017-03-30 Thread Enis Soztutar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated RATIS-59:
---
Attachment: ratis-59-v1.patch

v1 patch. Need RATIS-29 to go in first. 

> bin/ script changes for rmap
> 
>
> Key: RATIS-59
> URL: https://issues.apache.org/jira/browse/RATIS-59
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-59-v1.patch
>
>
> Changes to bin/ scripts for the Rmap server and CLI. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-58) Add rmap.proto

2017-03-30 Thread Enis Soztutar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated RATIS-58:
---
Attachment: ratis-58-v1.patch

> Add rmap.proto
> --
>
> Key: RATIS-58
> URL: https://issues.apache.org/jira/browse/RATIS-58
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Fix For: 0.1.0-alpha
>
> Attachments: ratis-58-v1.patch
>
>
> The PB file for the replicated map RPC. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RATIS-58) Add rmap.proto

2017-03-30 Thread Enis Soztutar (JIRA) 
Enis Soztutar created RATIS-58:
--

 Summary: Add rmap.proto
 Key: RATIS-58
 URL: https://issues.apache.org/jira/browse/RATIS-58
 Project: Ratis
  Issue Type: Sub-task
Reporter: Enis Soztutar
Assignee: Enis Soztutar


The PB file for the replicated map RPC. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (RATIS-55) Add missing license headers

2017-03-30 Thread Jing Zhao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao resolved RATIS-55.

   Resolution: Fixed
Fix Version/s: 0.1.0-alpha

+1. I've committed this. Thanks Nicholas!

> Add missing license headers
> ---
>
> Key: RATIS-55
> URL: https://issues.apache.org/jira/browse/RATIS-55
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Fix For: 0.1.0-alpha
>
> Attachments: r55_20170330.patch
>
>
> {{mvn apache-rat:check}} reports that a few files do not have the license 
> header. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-8) Avoid using Optional for data fields in TransactionContext

2017-03-30 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949753#comment-15949753
 ] 

Enis Soztutar commented on RATIS-8:
---

+1 for returning null.

> Avoid using Optional for data fields in TransactionContext
> --
>
> Key: RATIS-8
> URL: https://issues.apache.org/jira/browse/RATIS-8
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Hugo Louro
> Attachments: RATIS-8.patch
>
>
> It's usually not recommended to use {{Optional}} as class fields. Let's use 
> this jira to revisit the {{Optional}} usage in {{TransactionContext}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Jing Zhao (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949748#comment-15949748
 ] 

Jing Zhao edited comment on RATIS-57 at 3/30/17 8:31 PM:
-

[~enis], I guess the purpose of the this patch is the following step in the 
Apache doc?
{code}
Diff the original file pom.xml with the one called pom.xml.tag to see if the 
license or any other info has been removed. This has been known to happen if 
the starting  tag is not on a single line. The only things that should 
be different between these files are the  and  elements. Any 
other changes you must backport yourself to the original pom.xml file and 
commit before proceeding with the release.
{code}


was (Author: jingzhao):
I guess the purpose of the this patch is the following step in the Apache doc?
{code}
Diff the original file pom.xml with the one called pom.xml.tag to see if the 
license or any other info has been removed. This has been known to happen if 
the starting  tag is not on a single line. The only things that should 
be different between these files are the  and  elements. Any 
other changes you must backport yourself to the original pom.xml file and 
commit before proceeding with the release.
{code}

> Fix pom.xml for mvn release:prepare
> ---
>
> Key: RATIS-57
> URL: https://issues.apache.org/jira/browse/RATIS-57
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r57_20170330.patch
>
>
> According to [Prepare your POMs for 
> release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
>  the following command can test the pom.
> {code}
> mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
> {code}
> The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Jing Zhao (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949748#comment-15949748
 ] 

Jing Zhao commented on RATIS-57:


I guess the purpose of the this patch is the following step in the Apache doc?
{code}
Diff the original file pom.xml with the one called pom.xml.tag to see if the 
license or any other info has been removed. This has been known to happen if 
the starting  tag is not on a single line. The only things that should 
be different between these files are the  and  elements. Any 
other changes you must backport yourself to the original pom.xml file and 
commit before proceeding with the release.
{code}

> Fix pom.xml for mvn release:prepare
> ---
>
> Key: RATIS-57
> URL: https://issues.apache.org/jira/browse/RATIS-57
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r57_20170330.patch
>
>
> According to [Prepare your POMs for 
> release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
>  the following command can test the pom.
> {code}
> mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
> {code}
> The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-52) Refactor RaftUtils into different classes

2017-03-30 Thread Enis Soztutar (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-52?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Enis Soztutar updated RATIS-52:
---
Attachment: ratis-52_v2.patch

Thanks Nicholas. 
Attaching v2 patch which addresses the review. I've kept the PlatformUtils and 
ReflectionUtils as classes because they indeed have private methods which are 
better kept as private. 


> Refactor RaftUtils into different classes
> -
>
> Key: RATIS-52
> URL: https://issues.apache.org/jira/browse/RATIS-52
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Enis Soztutar
>Assignee: Enis Soztutar
> Attachments: ratis-52_v1.patch, ratis-52_v2.patch
>
>
> Ideally we should not have a generic {{RaftUtils}} class. The code should be 
> broken up into at least: 
> {code}
> ReflectionUtils -> All reflection, construction, initialization logic 
> IOUtils -> Add buffer and IO logic 
> SystemUtils or PlatformUtils -> OS type detection, etc 
> Preconditions (or something like that) -> assertTrue, etc 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-8) Avoid using Optional for data fields in TransactionContext

2017-03-30 Thread Jing Zhao (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949734#comment-15949734
 ] 

Jing Zhao commented on RATIS-8:
---

I think returning null here should be fine.

> Avoid using Optional for data fields in TransactionContext
> --
>
> Key: RATIS-8
> URL: https://issues.apache.org/jira/browse/RATIS-8
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Hugo Louro
> Attachments: RATIS-8.patch
>
>
> It's usually not recommended to use {{Optional}} as class fields. Let's use 
> this jira to revisit the {{Optional}} usage in {{TransactionContext}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-30 Thread Jing Zhao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated RATIS-17:
---
Attachment: RATIS-17.006.patch

> Add basic retry cache implementation for Raft Server
> 
>
> Key: RATIS-17
> URL: https://issues.apache.org/jira/browse/RATIS-17
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Jing Zhao
> Attachments: RATIS-17.000.patch, RATIS-17.001.patch, 
> RATIS-17.002.patch, RATIS-17.003.patch, RATIS-17.004.patch, 
> RATIS-17.005.patch, RATIS-17.006.patch
>
>
> This jira will add the basic data structure definition for the retry cache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-17) Add basic retry cache implementation for Raft Server

2017-03-30 Thread Jing Zhao (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949686#comment-15949686
 ] 

Jing Zhao commented on RATIS-17:


Thanks for the comments, Nicholas.

bq. For #2, should we just return the exception back to client, instead of a 
real retry?
Yes, currently for #2 the patch always returns the exception back to client, 
i.e., if the request gets committed in raft group, we always treat it as 
success even if finally the state machine throws an exception while applying 
it. Please see javadoc in {{CacheEntry}}.

bq. For #1, should we never cache the failure in Raft in the retry cache since 
it won't be useful anyway?
If the failure is caught before the retry cache entry gets added, we will not 
create the entry. This is the case of the first {{checkLeaderState}} call in 
{{submitClientRequestAsync}}. However, if the failure is hit after adding the 
entry, we only mark the entry as failed and depend on the retry cache's 
eviction/expiration policy or the next retry attempt to evict the failed entry. 
Because the failure can be hit in different places (replication failure, log 
append failure, leader reelection etc.), in this way we can avoid manipulating 
retry cache from a lot of other places. 

bq. In RaftServerImpl.replyPendingRequest, cacheEntry.updateResult(r) expects 
!replyFuture.isDone(). So, cacheEntry = retryCache.getOrCreateEntry(..) 
actually must be creating a new entry.
For leader, the entry should already be there but its process is still pending 
(until the txn gets applied to the state machine), thus the entry is not newly 
created but the future is still pending. For followers we will create new 
entries here.

I will update a new patch to address other comments.

> Add basic retry cache implementation for Raft Server
> 
>
> Key: RATIS-17
> URL: https://issues.apache.org/jira/browse/RATIS-17
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Jing Zhao
>Assignee: Jing Zhao
> Attachments: RATIS-17.000.patch, RATIS-17.001.patch, 
> RATIS-17.002.patch, RATIS-17.003.patch, RATIS-17.004.patch, RATIS-17.005.patch
>
>
> This jira will add the basic data structure definition for the retry cache.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-8) Avoid using Optional for data fields in TransactionContext

2017-03-30 Thread Hugo Louro (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949605#comment-15949605
 ] 

Hugo Louro commented on RATIS-8:


[~enis] which of the alternatives I mentioned earlier comment do you favor ?

> Avoid using Optional for data fields in TransactionContext
> --
>
> Key: RATIS-8
> URL: https://issues.apache.org/jira/browse/RATIS-8
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Hugo Louro
> Attachments: RATIS-8.patch
>
>
> It's usually not recommended to use {{Optional}} as class fields. Let's use 
> this jira to revisit the {{Optional}} usage in {{TransactionContext}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-8) Avoid using Optional for data fields in TransactionContext

2017-03-30 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949584#comment-15949584
 ] 

Enis Soztutar commented on RATIS-8:
---

Patch looks good. However, can you also get rid of Optionals from the method 
return signatures as well. {{TransactionContext}} is a core data structure, 
which we are expected to be creating tens of thousands per second. Better to 
get rid of extra object creations. 

> Avoid using Optional for data fields in TransactionContext
> --
>
> Key: RATIS-8
> URL: https://issues.apache.org/jira/browse/RATIS-8
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Hugo Louro
> Attachments: RATIS-8.patch
>
>
> It's usually not recommended to use {{Optional}} as class fields. Let's use 
> this jira to revisit the {{Optional}} usage in {{TransactionContext}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949535#comment-15949535
 ] 

Enis Soztutar commented on RATIS-57:


I don't see any changes other than formatting, am I missing something? 

> Fix pom.xml for mvn release:prepare
> ---
>
> Key: RATIS-57
> URL: https://issues.apache.org/jira/browse/RATIS-57
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r57_20170330.patch
>
>
> According to [Prepare your POMs for 
> release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
>  the following command can test the pom.
> {code}
> mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
> {code}
> The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-54) Bump maven.min.version to 3.3.9

2017-03-30 Thread Enis Soztutar (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15949501#comment-15949501
 ] 

Enis Soztutar commented on RATIS-54:


requiring the latest version is a bit aggressive, but I did not try with an 
earlier 3.3 release. I know that we have problems with 3.2. Let's go with this 
for now. 
Do you mind changing the line in BUILDING.md: 
{code}
Apache Ratis uses Apache Maven for the builds. A 3.2+ version of Maven is 
required as well as
{code}

> Bump maven.min.version to 3.3.9
> ---
>
> Key: RATIS-54
> URL: https://issues.apache.org/jira/browse/RATIS-54
> Project: Ratis
>  Issue Type: Task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r54_20170330.patch
>
>
> [~enis] found that some earlier Maven 3.x version does not work well; see 
> [this 
> comment|https://issues.apache.org/jira/browse/RATIS-47?focusedCommentId=15935648=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15935648].
> Maven 3.3.9 is the latest stable release, released on 2015-11-14; see 
> https://maven.apache.org/docs/history.html
> It seems reasonable to require Maven 3.3.9.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-57:
-
Attachment: r57_20170330.patch

r57_20170330.patch: 1st patch.

> Fix pom.xml for mvn release:prepare
> ---
>
> Key: RATIS-57
> URL: https://issues.apache.org/jira/browse/RATIS-57
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r57_20170330.patch
>
>
> According to [Prepare your POMs for 
> release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
>  the following command can test the pom.
> {code}
> mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
> {code}
> The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RATIS-57) Fix pom.xml for mvn release:prepare

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 
Tsz Wo Nicholas Sze created RATIS-57:


 Summary: Fix pom.xml for mvn release:prepare
 Key: RATIS-57
 URL: https://issues.apache.org/jira/browse/RATIS-57
 Project: Ratis
  Issue Type: Sub-task
Reporter: Tsz Wo Nicholas Sze


According to [Prepare your POMs for 
release|http://www.apache.org/dev/publishing-maven-artifacts.html#prepare-poms],
 the following command can test the pom.
{code}
mvn release:prepare -DdryRun=true -DautoVersionSubmodules=true
{code}
The JIRA is to fix the unexpected diff between pom.xml and pom.xml.tag.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-8) Avoid using Optional for data fields in TransactionContext

2017-03-30 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/RATIS-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948538#comment-15948538
 ] 

ASF GitHub Bot commented on RATIS-8:


GitHub user hmcl opened a pull request:

https://github.com/apache/incubator-ratis/pull/1

RATIS-8: Avoid using Optional for data fields in TransactionContex



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hmcl/incubator-ratis RATIS-8_Optional

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-ratis/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 290369e244eaf5504f471c01812bc1f18eca981b
Author: Hugo Louro 
Date:   2017-03-30T05:54:44Z

RATIS-8: Avoid using Optional for data fields in TransactionContex




> Avoid using Optional for data fields in TransactionContext
> --
>
> Key: RATIS-8
> URL: https://issues.apache.org/jira/browse/RATIS-8
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Hugo Louro
> Attachments: RATIS-8.patch
>
>
> It's usually not recommended to use {{Optional}} as class fields. Let's use 
> this jira to revisit the {{Optional}} usage in {{TransactionContext}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RATIS-56) Update project version to 0.1.0-alpha

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 
Tsz Wo Nicholas Sze created RATIS-56:


 Summary: Update project version to 0.1.0-alpha
 Key: RATIS-56
 URL: https://issues.apache.org/jira/browse/RATIS-56
 Project: Ratis
  Issue Type: Sub-task
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze
 Attachments: r56_20170330.patch

We may use the following command to update the project version from 
0.1-SNAPSHOT to 0.1.0-alpha.
{code}
find . -name pom.xml | xargs sed -i.old "s/0.1-SNAPSHOT/0.1.0-alpha/g" 
{code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-56) Update project version to 0.1.0-alpha

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-56:
-
Attachment: r56_20170330.patch

r56_20170330.patch: 1st patch.

> Update project version to 0.1.0-alpha
> -
>
> Key: RATIS-56
> URL: https://issues.apache.org/jira/browse/RATIS-56
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r56_20170330.patch
>
>
> We may use the following command to update the project version from 
> 0.1-SNAPSHOT to 0.1.0-alpha.
> {code}
> find . -name pom.xml | xargs sed -i.old "s/0.1-SNAPSHOT/0.1.0-alpha/g" 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-55) Add missing license headers

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-55:
-
Parent Issue: RATIS-53  (was: RATIS-54)

> Add missing license headers
> ---
>
> Key: RATIS-55
> URL: https://issues.apache.org/jira/browse/RATIS-55
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r55_20170330.patch
>
>
> {{mvn apache-rat:check}} reports that a few files do not have the license 
> header. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RATIS-55) Add missing license headers

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-55:
-
Attachment: r55_20170330.patch

r55_20170330.patch:
- adds license header for the .md files;
- changes the clean-shade profile to remove dependency-reduced-pom.xml.

Note that please run {{mvn clean -Pclean-shade}} before {{mvn 
apache-rat:check}}.


> Add missing license headers
> ---
>
> Key: RATIS-55
> URL: https://issues.apache.org/jira/browse/RATIS-55
> Project: Ratis
>  Issue Type: Sub-task
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r55_20170330.patch
>
>
> {{mvn apache-rat:check}} reports that a few files do not have the license 
> header. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RATIS-55) Add missing license headers

2017-03-30 Thread Tsz Wo Nicholas Sze (JIRA) 
Tsz Wo Nicholas Sze created RATIS-55:


 Summary: Add missing license headers
 Key: RATIS-55
 URL: https://issues.apache.org/jira/browse/RATIS-55
 Project: Ratis
  Issue Type: Sub-task
Reporter: Tsz Wo Nicholas Sze
Assignee: Tsz Wo Nicholas Sze


{{mvn apache-rat:check}} reports that a few files do not have the license 
header. 




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)