[jira] [Updated] (RATIS-105) Server should check group id for client requests
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-105: -- Attachment: r105_20170821.patch > Server should check group id for client requests > - > > Key: RATIS-105 > URL: https://issues.apache.org/jira/browse/RATIS-105 > Project: Ratis > Issue Type: Improvement >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Attachments: r105_20170814.patch, r105_20170815.patch, > r105_20170821.patch > > > In RATIS-100, we found a bug that a server may response to another server > with different group so that a cluster with multiple groups may not work > correctly. The solution is to check the group id for each server request > before responding to it. > In this JIRA, we add a similar group id check for the client requests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-105) Server should check group id for client requests
[ https://issues.apache.org/jira/browse/RATIS-105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-105: -- Attachment: r105_20170821.patch r105_20170821.patch: updates with the current patch in RATIS-100. > Server should check group id for client requests > - > > Key: RATIS-105 > URL: https://issues.apache.org/jira/browse/RATIS-105 > Project: Ratis > Issue Type: Improvement >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze > Attachments: r105_20170814.patch, r105_20170815.patch, > r105_20170821.patch > > > In RATIS-100, we found a bug that a server may response to another server > with different group so that a cluster with multiple groups may not work > correctly. The solution is to check the group id for each server request > before responding to it. > In this JIRA, we add a similar group id check for the client requests. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-100) Fix bugs for running multiple raft groups with a state machine
[
https://issues.apache.org/jira/browse/RATIS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-100:
--
Attachment: r100_20170821b.patch
r100_20170821b.patch: some minor changes.
> Fix bugs for running multiple raft groups with a state machine
> --
>
> Key: RATIS-100
> URL: https://issues.apache.org/jira/browse/RATIS-100
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r100_20170804.patch, r100_20170809b.patch,
> r100_20170809c.patch, r100_20170809.patch, r100_20170810.patch,
> r100_20170811.patch, r100_20170821b.patch, r100_20170821.patch,
> r100_no_leader_case.log
>
>
> We found the following bugs when trying to add a test similar to
> ReinitializationBaseTest.runTestReinitializeMultiGroups(..) with a state
> machine.
> - In PendingRequests, the {{last}} PendingRequest is not updated in
> addConfRequest(..).
> - In RaftServerImpl, it should check if the group in the request is the same
> as the group in the server.
> - In StateMachineUpdater, it should join the updater thread in stop().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-100) Fix bugs for running multiple raft groups with a state machine
[
https://issues.apache.org/jira/browse/RATIS-100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-100:
--
Description:
We found the following bugs when trying to add a test similar to
ReinitializationBaseTest.runTestReinitializeMultiGroups(..) with a state
machine.
- In PendingRequests, the {{last}} PendingRequest is not updated in
addConfRequest(..).
- In RaftServerImpl, it should check if the group in the request is the same as
the group in the server.
- In StateMachineUpdater, it should join the updater thread in stop().
was:We propose to add a test similar to
ReinitializationBaseTest.runTestReinitializeMultiGroups(..) with a state
machine so that it can test if the states are recorded correctly.
Issue Type: Bug (was: Test)
Summary: Fix bugs for running multiple raft groups with a state machine
(was: Test multiple raft groups with a state machine)
> Fix bugs for running multiple raft groups with a state machine
> --
>
> Key: RATIS-100
> URL: https://issues.apache.org/jira/browse/RATIS-100
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
> Attachments: r100_20170804.patch, r100_20170809b.patch,
> r100_20170809c.patch, r100_20170809.patch, r100_20170810.patch,
> r100_20170811.patch, r100_20170821.patch, r100_no_leader_case.log
>
>
> We found the following bugs when trying to add a test similar to
> ReinitializationBaseTest.runTestReinitializeMultiGroups(..) with a state
> machine.
> - In PendingRequests, the {{last}} PendingRequest is not updated in
> addConfRequest(..).
> - In RaftServerImpl, it should check if the group in the request is the same
> as the group in the server.
> - In StateMachineUpdater, it should join the updater thread in stop().
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-109) Improve the log messages in RaftServerImpl and the related code
[ https://issues.apache.org/jira/browse/RATIS-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-109: -- Summary: Improve the log messages in RaftServerImpl and the related code (was: Improve the log messages in RaftServerImpl and some other related code.) > Improve the log messages in RaftServerImpl and the related code > --- > > Key: RATIS-109 > URL: https://issues.apache.org/jira/browse/RATIS-109 > Project: Ratis > Issue Type: Improvement >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r109_20170821.patch > > > In RATIS-100, a large part of the patch is just code refactoring and > improving log messages. We separate them to this JIRA. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (RATIS-108) Add a timeout for all the tests
[ https://issues.apache.org/jira/browse/RATIS-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze resolved RATIS-108. --- Resolution: Fixed Fix Version/s: 0.2.0-alpha Thanks Chen for reviewing the patch! I have committed this. > Add a timeout for all the tests > --- > > Key: RATIS-108 > URL: https://issues.apache.org/jira/browse/RATIS-108 > Project: Ratis > Issue Type: Test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Fix For: 0.2.0-alpha > > Attachments: r108_20170817.patch, r108_20170821b.patch, > r108_20170821.patch > > > As the title suggested, all tests should have a timeout. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-108) Add a timeout for all the tests
[ https://issues.apache.org/jira/browse/RATIS-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-108: -- Attachment: r108_20170821.patch > Add a timeout for all the tests > --- > > Key: RATIS-108 > URL: https://issues.apache.org/jira/browse/RATIS-108 > Project: Ratis > Issue Type: Test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r108_20170817.patch, r108_20170821.patch > > > As the title suggested, all tests should have a timeout. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-108) Add a timeout for all the tests
[ https://issues.apache.org/jira/browse/RATIS-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-108: -- Attachment: (was: r108_20170821.patch) > Add a timeout for all the tests > --- > > Key: RATIS-108 > URL: https://issues.apache.org/jira/browse/RATIS-108 > Project: Ratis > Issue Type: Test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r108_20170817.patch, r108_20170821.patch > > > As the title suggested, all tests should have a timeout. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RATIS-108) Add a timeout for all the tests
[ https://issues.apache.org/jira/browse/RATIS-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-108: -- Attachment: r108_20170821.patch r108_20170821.patch: changes TestStateMachine to extend BaseTest. > Add a timeout for all the tests > --- > > Key: RATIS-108 > URL: https://issues.apache.org/jira/browse/RATIS-108 > Project: Ratis > Issue Type: Test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r108_20170817.patch, r108_20170821.patch > > > As the title suggested, all tests should have a timeout. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
