[jira] [Commented] (RATIS-641) Change RaftPeerId to extend RaftId
[
https://issues.apache.org/jira/browse/RATIS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895647#comment-16895647
]
Hadoop QA commented on RATIS-641:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
57s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
8s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} root: The patch generated 0 new + 2 unchanged - 2
fixed = 2 total (was 4) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 59m 27s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 22s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.TestMultiRaftGroup |
| | ratis.examples.arithmetic.TestArithmetic |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestGroupManagementWithSimulatedRpc |
| | ratis.statemachine.TestStateMachine |
| | ratis.server.raftlog.TestRaftLogMetrics |
| | ratis.server.simulation.TestGroupInfoWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.server.impl.TestRaftServerJmx |
| | ratis.TestRaftServerNoLeaderTimeout |
| | ratis.grpc.TestRaftWithGrpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestLogAppenderWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.grpc.TestLeaderElectionWithGrpc |
| | ratis.netty.TestLeaderElectionWithNetty |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.server.simulation.TestRetryCacheWithSimulatedRpc |
| | ratis.netty.TestRaftSnapshotWithNetty |
| | ratis.grpc.TestRaftReconfigurationWithGrpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
| | ratis.server.simulation.TestRaftExceptionWithSimulation |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.1 Server=19.03.1 Image:yetus/ratis:date2019-07-29 |
| JIRA Issue | RATIS-641 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976148/r641_20190729.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux 08b993ab9928 4.4.0-138-generic #164-Ubuntu SMP Tue
[jira] [Commented] (RATIS-641) Change RaftPeerId to extend RaftId
[ https://issues.apache.org/jira/browse/RATIS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895621#comment-16895621 ] Tsz Wo Nicholas Sze commented on RATIS-641: --- r641_20190729.patch: fixes unit test failures. > Change RaftPeerId to extend RaftId > -- > > Key: RATIS-641 > URL: https://issues.apache.org/jira/browse/RATIS-641 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r641_20190726.patch, r641_20190729.patch > > > RaftPeerId currently does not extend RaftId so that it is not consistent with > ClientId and RaftGroupId. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (RATIS-641) Change RaftPeerId to extend RaftId
[ https://issues.apache.org/jira/browse/RATIS-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-641: -- Attachment: r641_20190729.patch > Change RaftPeerId to extend RaftId > -- > > Key: RATIS-641 > URL: https://issues.apache.org/jira/browse/RATIS-641 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Attachments: r641_20190726.patch, r641_20190729.patch > > > RaftPeerId currently does not extend RaftId so that it is not consistent with > ClientId and RaftGroupId. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Comment Edited] (RATIS-642) Bump the copyright year of the NOTICE.txt
[ https://issues.apache.org/jira/browse/RATIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895540#comment-16895540 ] Tsz Wo Nicholas Sze edited comment on RATIS-642 at 7/29/19 7:31 PM: - Sorry that we have another NOTICE file ratis-assembly/src/main/resources/NOTICE - The year range should be 2017-2019 according to http://www.apache.org/legal/src-headers.html#notice. bq. ... year(s) of distribution of the current and past versions of the product ... was (Author: szetszwo): - Sorry that we have another NOTICE file atis-assembly/src/main/resources/NOTICE - The year range should be 2017-2019 according to http://www.apache.org/legal/src-headers.html#notice. bq. ... year(s) of distribution of the current and past versions of the product ... > Bump the copyright year of the NOTICE.txt > - > > Key: RATIS-642 > URL: https://issues.apache.org/jira/browse/RATIS-642 > Project: Ratis > Issue Type: Bug > Components: documentation >Affects Versions: 0.3.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Fix For: 0.4.0 > > Attachments: RATIS-642.001.patch > > > Update ratis notice to reflect latest timestamps i.e. to 2019. > Thanks [~jghoman] for noticing this during 0.4.0 rc0 vote. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-642) Bump the copyright year of the NOTICE.txt
[ https://issues.apache.org/jira/browse/RATIS-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895540#comment-16895540 ] Tsz Wo Nicholas Sze commented on RATIS-642: --- - Sorry that we have another NOTICE file atis-assembly/src/main/resources/NOTICE - The year range should be 2017-2019 according to http://www.apache.org/legal/src-headers.html#notice. bq. ... year(s) of distribution of the current and past versions of the product ... > Bump the copyright year of the NOTICE.txt > - > > Key: RATIS-642 > URL: https://issues.apache.org/jira/browse/RATIS-642 > Project: Ratis > Issue Type: Bug > Components: documentation >Affects Versions: 0.3.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Fix For: 0.4.0 > > Attachments: RATIS-642.001.patch > > > Update ratis notice to reflect latest timestamps i.e. to 2019. > Thanks [~jghoman] for noticing this during 0.4.0 rc0 vote. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-630) Implement flow control in Ratis
[ https://issues.apache.org/jira/browse/RATIS-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895154#comment-16895154 ] Lokesh Jain commented on RATIS-630: --- > For lagging behind, the follower may or may not be able to catch up. If it > can catch up, we probably should not fail/reject the client requests. [~szetszwo] I agree. I was thinking of adding configurations to determine if a follower would be able to catch up with leader? The configurations could be something like a hard limit on number of pending commits or pending apply transactions. > Is there any design doc you could share? [~jingc] I am working on it. I will share it as soon as possible. > Implement flow control in Ratis > --- > > Key: RATIS-630 > URL: https://issues.apache.org/jira/browse/RATIS-630 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Lokesh Jain >Priority: Major > Labels: ozone > > The aim of the Jira is to add flow control in Ratis in order to handle > slowness of LogWorker, LogAppender and StateMachine. The idea is to propagate > indexes like commit index(LogAppender) and lastAppliedIndex(StateMachine) > from followers to leader. The leader can use these indices to determine > slowness of a follower and handle client requests accordingly. For instance > if one of the follower is lagging behind then client requests demanding > commit by all nodes can be rejected by leader. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
