[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913518#comment-16913518 ] Hadoop QA commented on RATIS-125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 20s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 57s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 37s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 26m 10s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.netty.TestRaftReconfigurationWithNetty | | | ratis.grpc.TestRaftAsyncWithGrpc | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/ratis:date2019-08-22 | | JIRA Issue | RATIS-125 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12978282/RATIS-125.002.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux 17ccfa3e8f58 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / f401c7a | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_222 | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/938/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/938/testReport/ | | Max. process+thread count | 2012 (vs. ulimit of 5000) | | modules | C: ratis-proto ratis-common ratis-client U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/938/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > The cause in a StateMachineException is not sent to client > -- > > Key:
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913152#comment-16913152 ] Mukul Kumar Singh commented on RATIS-125: - Thanks for working on this [~nandakumar131], will it be possible to add a simple test for this ? > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Labels: ozone > Attachments: RATIS-125.000.patch, RATIS-125.001.patch, > RATIS-125.002.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908113#comment-16908113 ] Hadoop QA commented on RATIS-125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 56s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 57s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 13s{color} | {color:orange} root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 21s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 25m 40s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.grpc.TestRaftAsyncWithGrpc | | | ratis.netty.TestGroupInfoWithNetty | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.1 Server=19.03.1 Image:yetus/ratis:date2019-08-15 | | JIRA Issue | RATIS-125 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12977708/RATIS-125.001.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux af6a60c9ec97 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 2739b4e | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_222 | | checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/932/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/932/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/932/testReport/ | | Max. process+thread count | 1655 (vs. ulimit of 5000) | | modules | C: ratis-proto ratis-common ratis-client U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/932/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908091#comment-16908091 ] Nanda kumar commented on RATIS-125: --- Uploaded [^RATIS-125.001.patch] > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Labels: ozone > Attachments: RATIS-125.000.patch, RATIS-125.001.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896968#comment-16896968 ] Shashikant Banerjee commented on RATIS-125: --- Thanks [~nandakumar131] for working on this. The path does not apply anymore. Can you please rebase? > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Labels: ozone > Attachments: RATIS-125.000.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874972#comment-16874972 ] Hadoop QA commented on RATIS-125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 21s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 12s{color} | {color:orange} root: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 9m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2019-06-28 | | JIRA Issue | RATIS-125 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12973178/RATIS-125.000.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux e5867c08447b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 2337318 | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/877/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/877/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/877/testReport/ | | Max. process+thread count | 95 (vs. ulimit of 5000) | | modules | C: ratis-proto ratis-common ratis-client U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/877/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > The cause in a StateMachineException is not sent to client >
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874959#comment-16874959 ] Nanda kumar commented on RATIS-125: --- Rebased the patch. > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Attachments: RATIS-125.000.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874943#comment-16874943 ] Hadoop QA commented on RATIS-125: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color} | {color:red} RATIS-125 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.8.0/precommit-patchnames for help. {color} | \\ \\ || Subsystem || Report/Notes || | JIRA Issue | RATIS-125 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12973175/RATIS-125.000.patch | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/876/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Attachments: RATIS-125.000.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874941#comment-16874941 ] Nanda kumar commented on RATIS-125: --- Client side exception trace with [^RATIS-125.000.patch] {noformat} org.apache.ratis.protocol.StateMachineException: java.util.concurrent.CompletionException from Server s1. Caused by: java.util.concurrent.CompletionException: java.io.IOException: Failed create(foo, false) @s1:1 at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292) at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308) at java.util.concurrent.CompletableFuture.biApply(CompletableFuture.java:1088) at java.util.concurrent.CompletableFuture$BiApply.tryFire(CompletableFuture.java:1070) at java.util.concurrent.CompletableFuture.biApplyStage(CompletableFuture.java:1123) at java.util.concurrent.CompletableFuture.thenCombineAsync(CompletableFuture.java:2037) at org.apache.ratis.examples.filestore.FileInfo$UnderConstruction.submitCommit(FileInfo.java:305) at org.apache.ratis.examples.filestore.FileStore.submitCommit(FileStore.java:185) at org.apache.ratis.examples.filestore.FileStoreStateMachine.writeCommit(FileStoreStateMachine.java:190) at org.apache.ratis.examples.filestore.FileStoreStateMachine.applyTransaction(FileStoreStateMachine.java:176) at org.apache.ratis.server.impl.RaftServerImpl.applyLogToStateMachine(RaftServerImpl.java:1274) at org.apache.ratis.server.impl.StateMachineUpdater.applyLog(StateMachineUpdater.java:210) at org.apache.ratis.server.impl.StateMachineUpdater.run(StateMachineUpdater.java:144) at java.lang.Thread.run(Thread.java:748) Caused by: java.io.IOException: Failed create(foo, false) @s1:1 at org.apache.ratis.examples.filestore.FileInfo$UnderConstruction.lambda$submitWrite$4(FileInfo.java:220) at org.apache.ratis.util.TaskQueue.lambda$submit$0(TaskQueue.java:112) at org.apache.ratis.util.LogUtils.runAndLog(LogUtils.java:50) at org.apache.ratis.util.LogUtils$1.run(LogUtils.java:91) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ... 1 more Caused by: java.io.IOException: Fake exception: foo at org.apache.ratis.examples.filestore.FileStore.resolve(FileStore.java:131) at org.apache.ratis.examples.filestore.FileInfo$UnderConstruction.lambda$submitCreate$1(FileInfo.java:199) at org.apache.ratis.util.LogUtils.supplyAndLog(LogUtils.java:70) at org.apache.ratis.util.LogUtils$3.get(LogUtils.java:120) at org.apache.ratis.util.TaskQueue.lambda$submit$0(TaskQueue.java:110) ... 7 more {noformat} > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement > Components: proto >Reporter: Tsz Wo Nicholas Sze >Assignee: Nanda kumar >Priority: Major > Attachments: RATIS-125.000.patch > > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-125) The cause in a StateMachineException is not sent to client
[ https://issues.apache.org/jira/browse/RATIS-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238186#comment-16238186 ] Tsz Wo Nicholas Sze commented on RATIS-125: --- Below adds a fake exception to RATIS-122 in order to show that the cause is not sent to client. {code} +++ b/ratis-examples/src/main/java/org/apache/ratis/examples/filestore/FileStore.java @@ -118,6 +118,9 @@ public class FileStore implements Closeable { throw new IOException("The file path " + relative + " resolved to " + full + " is not a sub-path under root directory " + root); } +if (relative.startsWith("foo")) { + throw new IOException("Fake exception: " + relative); +} return full; } +++ b/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java @@ -923,6 +923,7 @@ public class RaftServerImpl implements RaftServerProtocol, // reply as a StateMachineException final StateMachineException e = new StateMachineException(getId(), exception); r = new RaftClientReply(clientId, serverId, groupId, callId, false, null, e); +LOG.error("Failed client request: " + r, e); } // update retry cache cacheEntry.updateResult(r); {code} > The cause in a StateMachineException is not sent to client > -- > > Key: RATIS-125 > URL: https://issues.apache.org/jira/browse/RATIS-125 > Project: Ratis > Issue Type: Improvement >Reporter: Tsz Wo Nicholas Sze > > StateMachineExceptionProto only has class name, message and stack trace but > not the cause. > In the client side, it cannot see the real cause of the exception. -- This message was sent by Atlassian JIRA (v6.4.14#64029)