[jira] [Commented] (RATIS-149) TestRaftStream.testSimpleWrite may fail
[
https://issues.apache.org/jira/browse/RATIS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16263114#comment-16263114
]
Tsz Wo Nicholas Sze commented on RATIS-149:
---
Continue the thoughts above:
In order to keep the client simple, let's make server to handle out-of-order
requests so that client could just send and retry. Client does not need any
queues to maintain request ordering.
> TestRaftStream.testSimpleWrite may fail
> ---
>
> Key: RATIS-149
> URL: https://issues.apache.org/jira/browse/RATIS-149
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Jing Zhao
>
> Two different failure cases:
> - {code}
> java.lang.AssertionError: expected:<500> but was:<350>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:106)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
> - {code}
> org.junit.internal.ArrayComparisonFailure: arrays first differed at element
> [0]; expected:<63> but was:<-81>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:114)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-149) TestRaftStream.testSimpleWrite may fail
[
https://issues.apache.org/jira/browse/RATIS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1626#comment-1626
]
Tsz Wo Nicholas Sze commented on RATIS-149:
---
[~jingzhao], thanks for working on this.
Here is some thoughts: Once we have fixed RATIS-140 and RATIS-141, grpc server
would be able to support any async client requests with in-order guarantee.
Then, we don't really need AppendStreamer (and the data queue and ack queue)
anymore since RaftOutputStream could just use the async api directly.
We also has RATIS-143 for limiting client async requests.
> TestRaftStream.testSimpleWrite may fail
> ---
>
> Key: RATIS-149
> URL: https://issues.apache.org/jira/browse/RATIS-149
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Jing Zhao
>
> Two different failure cases:
> - {code}
> java.lang.AssertionError: expected:<500> but was:<350>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:106)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
> - {code}
> org.junit.internal.ArrayComparisonFailure: arrays first differed at element
> [0]; expected:<63> but was:<-81>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:114)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-149) TestRaftStream.testSimpleWrite may fail
[
https://issues.apache.org/jira/browse/RATIS-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258725#comment-16258725
]
Tsz Wo Nicholas Sze commented on RATIS-149:
---
It seems easier to reproduce the failure of TestRaftStream if the
AppendStreamer.LOG is turned off.
{code}
+++ b/ratis-grpc/src/test/java/org/apache/ratis/grpc/TestRaftStream.java
@@ -46,7 +46,7 @@ import static org.junit.Assert.fail;
public class TestRaftStream extends BaseTest {
static {
-LogUtils.setLogLevel(AppendStreamer.LOG, Level.ALL);
+//LogUtils.setLogLevel(AppendStreamer.LOG, Level.ALL);
}
{code}
With the script in RATIS-147, run
{code}
./dev-support/run-test-repeatedly.sh TestRaftStream#testSimpleWrite
{code}
> TestRaftStream.testSimpleWrite may fail
> ---
>
> Key: RATIS-149
> URL: https://issues.apache.org/jira/browse/RATIS-149
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>
> Two different failure cases:
> - {code}
> java.lang.AssertionError: expected:<500> but was:<350>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:106)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
> - {code}
> org.junit.internal.ArrayComparisonFailure: arrays first differed at element
> [0]; expected:<63> but was:<-81>
> at
> org.apache.ratis.grpc.TestRaftStream.checkLog(TestRaftStream.java:114)
> at
> org.apache.ratis.grpc.TestRaftStream.testSimpleWrite(TestRaftStream.java:100)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
