[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16300986#comment-16300986 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- Patch looks good. Just a question: - Is there a reason that the new com.google.auto.service dependency is optional but the others are not? I think we should change them to optional as well. > Update Grpc version in Ratis. > - > > Key: RATIS-168 > URL: https://issues.apache.org/jira/browse/RATIS-168 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Attachments: RATIS-168.001.patch, RATIS-168.002.patch, > RATIS-168.003.patch > > > Ratis is using grpc version 1.0.1, This version should be updated to a later > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294480#comment-16294480 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- There are more relocations than before. Let me try to understand them. > Update Grpc version in Ratis. > - > > Key: RATIS-168 > URL: https://issues.apache.org/jira/browse/RATIS-168 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Attachments: RATIS-168.001.patch, RATIS-168.002.patch, > RATIS-168.003.patch > > > Ratis is using grpc version 1.0.1, This version should be updated to a later > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[
https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284600#comment-16284600
]
Tsz Wo Nicholas Sze commented on RATIS-168:
---
And also
{code}
[INFO] Including com.google.api.grpc:proto-google-common-protos:jar:0.1.9 in
the shaded jar.
{code}
> Update Grpc version in Ratis.
> -
>
> Key: RATIS-168
> URL: https://issues.apache.org/jira/browse/RATIS-168
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-168.001.patch, RATIS-168.002.patch
>
>
> Ratis is using grpc version 1.0.1, This version should be updated to a later
> version.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[
https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284595#comment-16284595
]
Tsz Wo Nicholas Sze commented on RATIS-168:
---
It seems that all the following should be excluded.
{code}
[INFO] Including com.google.instrumentation:instrumentation-api:jar:0.4.3 in
the shaded jar.
[INFO] Including io.opencensus:opencensus-api:jar:0.6.0 in the shaded jar.
[INFO] Including org.conscrypt:conscrypt-openjdk-uber:jar:1.0.0.RC9 in the
shaded jar.
[INFO] Including com.fasterxml:aalto-xml:jar:1.0.0 in the shaded jar.
[INFO] Including org.codehaus.woodstox:stax2-api:jar:4.0.0 in the shaded jar.
{code}
> Update Grpc version in Ratis.
> -
>
> Key: RATIS-168
> URL: https://issues.apache.org/jira/browse/RATIS-168
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-168.001.patch, RATIS-168.002.patch
>
>
> Ratis is using grpc version 1.0.1, This version should be updated to a later
> version.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[
https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284593#comment-16284593
]
Tsz Wo Nicholas Sze commented on RATIS-168:
---
Thanks, the latest version is 1.7.1 for grpc-java.
After the 002 patch, there are extra directories in the shaded source directory
{code}
$ls -l ratis-proto-shaded/src/main/java/
total 0
drwxr-xr-x 4 szetszwo staff 128 Dec 9 12:46 com
drwxr-xr-x 3 szetszwo staff 96 Dec 9 12:46 io
drwxr-xr-x 4 szetszwo staff 128 Dec 9 12:46 org
drwxr-xr-x 18 szetszwo staff 576 Dec 9 12:46 test
{code}
Before the patch, all the shaded sources are under.
{code}
ratis-proto-shaded/src/main/java/org/apache/ratis/shaded/
{code}
It seems that these extra sources should excluded.
> Update Grpc version in Ratis.
> -
>
> Key: RATIS-168
> URL: https://issues.apache.org/jira/browse/RATIS-168
> Project: Ratis
> Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-168.001.patch, RATIS-168.002.patch
>
>
> Ratis is using grpc version 1.0.1, This version should be updated to a later
> version.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (RATIS-168) Update Grpc version in Ratis.
[ https://issues.apache.org/jira/browse/RATIS-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283336#comment-16283336 ] Tsz Wo Nicholas Sze commented on RATIS-168: --- Question: Why 1.5.0 but not the latest, which is 1.7.3? > Update Grpc version in Ratis. > - > > Key: RATIS-168 > URL: https://issues.apache.org/jira/browse/RATIS-168 > Project: Ratis > Issue Type: Bug >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh > Attachments: RATIS-168.001.patch > > > Ratis is using grpc version 1.0.1, This version should be updated to a later > version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
