[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[ https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332066#comment-16332066 ] Tsz Wo Nicholas Sze commented on RATIS-192: --- All example tests can pass in my machine. > TestFileStoreWithGrpc is failing > - > > Key: RATIS-192 > URL: https://issues.apache.org/jira/browse/RATIS-192 > Project: Ratis > Issue Type: Bug >Reporter: Tsz Wo Nicholas Sze >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-192.001.patch, RATIS-192.002.patch, > r192_20180119.patch > > > After RATIS-183, TestFileStoreWithGrpc starts to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[ https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332065#comment-16332065 ] Tsz Wo Nicholas Sze commented on RATIS-192: --- +1 the 002 looks good. > TestFileStoreWithGrpc is failing > - > > Key: RATIS-192 > URL: https://issues.apache.org/jira/browse/RATIS-192 > Project: Ratis > Issue Type: Bug >Reporter: Tsz Wo Nicholas Sze >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-192.001.patch, RATIS-192.002.patch, > r192_20180119.patch > > > After RATIS-183, TestFileStoreWithGrpc starts to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[ https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332031#comment-16332031 ] Mukul Kumar Singh commented on RATIS-192: - Hi [~szetszwo], The idea looks good to me, I have modified the patch a bit to avoid special handling inside thenCombine. > TestFileStoreWithGrpc is failing > - > > Key: RATIS-192 > URL: https://issues.apache.org/jira/browse/RATIS-192 > Project: Ratis > Issue Type: Bug >Reporter: Tsz Wo Nicholas Sze >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-192.001.patch, RATIS-192.002.patch, > r192_20180119.patch > > > After RATIS-183, TestFileStoreWithGrpc starts to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[
https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331961#comment-16331961
]
Hadoop QA commented on RATIS-192:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
6s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 13s{color} | {color:orange} root: The patch generated 6 new + 28 unchanged -
1 fixed = 34 total (was 29) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 4m 24s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 9m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-01-19
|
| JIRA Issue | RATIS-192 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12906781/r192_20180119.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 479be29492ad 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 5b4bc0e |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/99/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/99/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/99/testReport/ |
| modules | C: ratis-grpc U: ratis-grpc |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/99/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> TestFileStoreWithGrpc is failing
> -
>
> Key: RATIS-192
> URL: https://issues.apache.org/jira/browse/RATIS-192
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-192.001.patch, r192_20180119.patch
>
>
> After RATIS-183, TestFileStoreWithGrpc starts to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[ https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331939#comment-16331939 ] Tsz Wo Nicholas Sze commented on RATIS-192: --- r192_20180119.patch: waits for the previous appendEntriesAsync before reply. TestFileStoreWithGrpc just have passed in my machine. Will test the patch more. > TestFileStoreWithGrpc is failing > - > > Key: RATIS-192 > URL: https://issues.apache.org/jira/browse/RATIS-192 > Project: Ratis > Issue Type: Bug >Reporter: Tsz Wo Nicholas Sze >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-192.001.patch, r192_20180119.patch > > > After RATIS-183, TestFileStoreWithGrpc starts to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[
https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331916#comment-16331916
]
Tsz Wo Nicholas Sze commented on RATIS-192:
---
{code}
// patch from RATIS-183
@@ -65,8 +65,7 @@ public class RaftServerProtocolService extends
RaftServerProtocolServiceImplBase
@Override
public void onNext(AppendEntriesRequestProto request) {
try {
- final AppendEntriesReplyProto reply = server.appendEntries(request);
- responseObserver.onNext(reply);
+
server.appendEntriesAsync(request).thenAccept(responseObserver::onNext);
} catch (Throwable e) {
if (LOG.isDebugEnabled()) {
{code}
[~msingh], I have a different idea to fix the bug. In gRPC, onNext is already
in-order. The bug seems that the thenAccept in
appendEntriesAsync(request).thenAccept(..) may be out-of-order. I think we can
change it to also depend of the previous appendEntries.
Let me try this idea and post a patch.
> TestFileStoreWithGrpc is failing
> -
>
> Key: RATIS-192
> URL: https://issues.apache.org/jira/browse/RATIS-192
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-192.001.patch
>
>
> After RATIS-183, TestFileStoreWithGrpc starts to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[ https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330205#comment-16330205 ] Tsz Wo Nicholas Sze commented on RATIS-192: --- BTW, the QA build did not run TestFileStoreWithGrpc (and all other ratis-example tests). https://builds.apache.org/job/PreCommit-RATIS-Build/96/testReport/ It was because TestLeaderElectionWithHadoopRpc was failed and ratis-example depended on ratis-hadoop. So, all the tests in ratis-example were not executed. We need to run it manually. > TestFileStoreWithGrpc is failing > - > > Key: RATIS-192 > URL: https://issues.apache.org/jira/browse/RATIS-192 > Project: Ratis > Issue Type: Bug >Reporter: Tsz Wo Nicholas Sze >Assignee: Mukul Kumar Singh >Priority: Major > Attachments: RATIS-192.001.patch > > > After RATIS-183, TestFileStoreWithGrpc starts to fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[
https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330197#comment-16330197
]
Tsz Wo Nicholas Sze commented on RATIS-192:
---
Just have tried running TestFileStoreWithGrpc with the patch but it has failed.
{code}
018-01-18 15:41:33,325 ERROR storage.RaftLogWorker
(ExitUtils.java:terminate(86)) - Terminating with exit status 1:
s2-RaftLogWorker failed.
java.lang.IllegalStateException: lastWrittenIndex == 7410, entry == term: 3
index: 7412
{code}
It expects lastWrittenIndex + 1 == entry.getIndex() but lastWrittenIndex ==
7410 and entry.getIndex() == 7412.
> TestFileStoreWithGrpc is failing
> -
>
> Key: RATIS-192
> URL: https://issues.apache.org/jira/browse/RATIS-192
> Project: Ratis
> Issue Type: Bug
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Mukul Kumar Singh
>Priority: Major
> Attachments: RATIS-192.001.patch
>
>
> After RATIS-183, TestFileStoreWithGrpc starts to fail.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-192) TestFileStoreWithGrpc is failing
[
https://issues.apache.org/jira/browse/RATIS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329937#comment-16329937
]
Hadoop QA commented on RATIS-192:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 20s{color} | {color:orange} root: The patch generated 31 new + 588 unchanged
- 3 fixed = 619 total (was 591) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 54s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 16m 0s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.hadooprpc.TestLeaderElectionWithHadoopRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-01-18
|
| JIRA Issue | RATIS-192 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12906535/RATIS-192.001.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 57d4c28bf087 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 8cac9d5 |
| Default Java | 1.8.0_151 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/96/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/96/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/96/testReport/ |
| modules | C: ratis-proto-shaded ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/96/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> TestFileStoreWithGrpc is failing
> -
>
> Key: RATIS-192
> URL:
