[jira] [Commented] (RATIS-26) Make shaded source compilation as a default action

[Enis Soztutar (JIRA)]

[ 
https://issues.apache.org/jira/browse/RATIS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879723#comment-15879723
 ] 

Enis Soztutar commented on RATIS-26:


Actually I need to make bigger changes in this patch: 
 - Flatten out the maven structure. It should not be like the hadoop's layout 
with -project and -project-dist, etc. Keep it simple. 
 - Some cleanup in poms 
 - compile + shade by default

Some things to do after this patch: 
 - Add missing sections (developers, mailing lists, etc) to pom. 
 - Clean up dependencies
 - Fix assembly, tarball, etc 


> Make shaded source compilation as a default action
> --
>
> Key: RATIS-26
> URL: https://issues.apache.org/jira/browse/RATIS-26
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Enis Soztutar
> Attachments: RATIS-26.000.patch
>
>
> Currently developers need to enter the ratis-proto-shaded directory and run 
> "mvn package -Dcompile-protobuf" to compile shaded sources. This is not 
> convenient when updating protobuf definitions. We can make this step a 
> default step.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RATIS-26) Make shaded source compilation as a default action

[Jing Zhao (JIRA)]

[ 
https://issues.apache.org/jira/browse/RATIS-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879601#comment-15879601
 ] 

Jing Zhao commented on RATIS-26:


[~szetszwo] pointed out that this patch made "mvn clean" and "-DskipShade" 
conflict. 

Since [~enis] is working on a more systematic solution, reassign this jira to 
him.

> Make shaded source compilation as a default action
> --
>
> Key: RATIS-26
> URL: https://issues.apache.org/jira/browse/RATIS-26
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Jing Zhao
> Attachments: RATIS-26.000.patch
>
>
> Currently developers need to enter the ratis-proto-shaded directory and run 
> "mvn package -Dcompile-protobuf" to compile shaded sources. This is not 
> convenient when updating protobuf definitions. We can make this step a 
> default step.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)