[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605635#comment-16605635
]
Hadoop QA commented on RATIS-303:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 7 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 46s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 48s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-09-06
|
| JIRA Issue | RATIS-303 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12938621/RATIS-303.02.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 66e86d8c4138 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / acd507e |
| Default Java | 1.8.0_181 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/325/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/325/testReport/ |
| modules | C: ratis-server ratis-grpc ratis-netty ratis-hadoop ratis-examples
U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/325/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
>
[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605535#comment-16605535
]
Shashikant Banerjee commented on RATIS-303:
---
Thanks [~szetszwo], for the review. patch v1 moves
TestRaftStateMachineException tests to ratis-server and adds the subclasses for
the rpcs.
...Could you describe how the patch fix NullPointerException?
The Null pointer exception was caused because in the TestStateMachine, a fake
exception is thrown during preAppendTransaction. This leads to leader stepping
down so subsequent client call with leader set to null fails with null pointer
exception. Since the single cluster instance was shared among all the tests ,
leader being set to null intermittently lead to the failure of other tests as
well.
The exception is addressed by waiting for the leader to come up and sending the
next request to the proper leader after the stateMachine exception is thrown in
testRetryOnExceptionDuringReplication.
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.02.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604878#comment-16604878
]
Tsz Wo Nicholas Sze commented on RATIS-303:
---
Thanks [~shashikant].
- Could you describe how the patch fix NullPointerException? It is not easy to
see from the patch.
- For the new TestRetryOnStateMachineException, could you move it from
ratis-example to ratis-server and add subclasses for the RPCs. See
RaftExceptionBaseTest and its subclasses. It was a mistake to put the
non-example test in ratis-example. It would be great if you could also move
TestRaftStateMachineException.
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.01.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602673#comment-16602673
]
Shashikant Banerjee commented on RATIS-303:
---
Thanks [~msingh], for the review. patch v1 addresses your review comments.
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.01.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
