[jira] [Commented] (RATIS-635) Add an API to get the min replicated logIndex for a raftGroup in raftServer
[
https://issues.apache.org/jira/browse/RATIS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901513#comment-16901513
]
Tsz Wo Nicholas Sze commented on RATIS-635:
---
The static helper function would look like the one line method below.
Honestly, it seems not very useful.
{code:java}
static Long min(Collection commitInfos) {
return
commitInfos.stream().map(CommitInfoProto::getCommitIndex).min(Long::compareTo).orElse(null);
}
{code}
> Add an API to get the min replicated logIndex for a raftGroup in raftServer
> ---
>
> Key: RATIS-635
> URL: https://issues.apache.org/jira/browse/RATIS-635
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.4.0
>Reporter: Shashikant Banerjee
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.4.0
>
> Attachments: RATIS-635.000.patch
>
>
> This feature is required by Ozone(HDDS-1753) to figure the min replicated
> index across all servers of a RaftGroup.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (RATIS-635) Add an API to get the min replicated logIndex for a raftGroup in raftServer
[ https://issues.apache.org/jira/browse/RATIS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901278#comment-16901278 ] Mukul Kumar Singh commented on RATIS-635: - Hi [~szetszwo], lets add a helper static function so that we can get leastReplicatedIndex by calculating a min of all the indexes on all the nodes. > Add an API to get the min replicated logIndex for a raftGroup in raftServer > --- > > Key: RATIS-635 > URL: https://issues.apache.org/jira/browse/RATIS-635 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Labels: ozone > Fix For: 0.4.0 > > Attachments: RATIS-635.000.patch > > > This feature is required by Ozone(HDDS-1753) to figure the min replicated > index across all servers of a RaftGroup. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-635) Add an API to get the min replicated logIndex for a raftGroup in raftServer
[ https://issues.apache.org/jira/browse/RATIS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899181#comment-16899181 ] Tsz Wo Nicholas Sze commented on RATIS-635: --- [~shashikant], thanks for working on this. - We already have a getGroupInfo(..) method in AdminProtocol/AdminAsynchronousProtocol. The GroupInfoReply has all the commit infos. Let's make it work for local calls (it may be already working) so that Ozone can use it? > Add an API to get the min replicated logIndex for a raftGroup in raftServer > --- > > Key: RATIS-635 > URL: https://issues.apache.org/jira/browse/RATIS-635 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.4.0 >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Labels: ozone > Fix For: 0.4.0 > > Attachments: RATIS-635.000.patch > > > This feature is required by Ozone(HDDS-1753) to figure the min replicated > index across all servers of a RaftGroup. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (RATIS-635) Add an API to get the min replicated logIndex for a raftGroup in raftServer
[
https://issues.apache.org/jira/browse/RATIS-635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898083#comment-16898083
]
Hadoop QA commented on RATIS-635:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 27m 46s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
17s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 37m 12s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.netty.TestRaftStateMachineExceptionWithNetty |
| | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestServerRestartWithGrpc |
| | ratis.netty.TestRaftReconfigurationWithNetty |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.grpc.TestRaftSnapshotWithGrpc |
| | ratis.logservice.TestLogServiceWithNetty |
| | ratis.logservice.server.TestMetaServer |
| | ratis.logservice.TestLogServiceWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithGrpc |
| | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 Image:yetus/ratis:date2019-08-01 |
| JIRA Issue | RATIS-635 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12976435/RATIS-635.000.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile |
| uname | Linux d9271d45f42e 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 81644cc |
| maven | version: Apache Maven 3.6.0
(97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/918/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/918/testReport/ |
| Max. process+thread count | 1418 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/918/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Add
