[jira] [Updated] (RATIS-135) Closed segments contribute to leaked memory as eviction policies are not honoured

2017-11-08 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated RATIS-135:
--

+1

> Closed segments contribute to leaked memory as eviction policies are not 
> honoured
> -
>
> Key: RATIS-135
> URL: https://issues.apache.org/jira/browse/RATIS-135
> Project: Ratis
>  Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-135.001.patch, RATIS-135.002.patch
>
>
> Closed segments leak memory as eviction does not remove these segments from 
> closed segments list.
> {code}
>  void evictCache(long[] followerIndices, long flushedIndex,
>   long lastAppliedIndex) {
> List toEvict = evictionPolicy.evict(followerIndices,
> flushedIndex, lastAppliedIndex, closedSegments, maxCachedSegments);
> for (LogSegment s : toEvict) {
>   s.evictCache();
> }
> {code}
> After the segments have been marked for eviction, they should be removed from 
> queue as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RATIS-135) Closed segments contribute to leaked memory as eviction policies are not honoured

2017-11-08 Thread Mukul Kumar Singh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mukul Kumar Singh updated RATIS-135:

Attachment: RATIS-135.002.patch

patch v2 fixes the unit test failure.

> Closed segments contribute to leaked memory as eviction policies are not 
> honoured
> -
>
> Key: RATIS-135
> URL: https://issues.apache.org/jira/browse/RATIS-135
> Project: Ratis
>  Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-135.001.patch, RATIS-135.002.patch
>
>
> Closed segments leak memory as eviction does not remove these segments from 
> closed segments list.
> {code}
>  void evictCache(long[] followerIndices, long flushedIndex,
>   long lastAppliedIndex) {
> List toEvict = evictionPolicy.evict(followerIndices,
> flushedIndex, lastAppliedIndex, closedSegments, maxCachedSegments);
> for (LogSegment s : toEvict) {
>   s.evictCache();
> }
> {code}
> After the segments have been marked for eviction, they should be removed from 
> queue as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (RATIS-135) Closed segments contribute to leaked memory as eviction policies are not honoured

2017-11-05 Thread Mukul Kumar Singh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RATIS-135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mukul Kumar Singh updated RATIS-135:

Attachment: RATIS-135.001.patch

> Closed segments contribute to leaked memory as eviction policies are not 
> honoured
> -
>
> Key: RATIS-135
> URL: https://issues.apache.org/jira/browse/RATIS-135
> Project: Ratis
>  Issue Type: Bug
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
> Attachments: RATIS-135.001.patch
>
>
> Closed segments leak memory as eviction does not remove these segments from 
> closed segments list.
> {code}
>  void evictCache(long[] followerIndices, long flushedIndex,
>   long lastAppliedIndex) {
> List toEvict = evictionPolicy.evict(followerIndices,
> flushedIndex, lastAppliedIndex, closedSegments, maxCachedSegments);
> for (LogSegment s : toEvict) {
>   s.evictCache();
> }
> {code}
> After the segments have been marked for eviction, they should be removed from 
> queue as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)