[jira] [Commented] (ROCKETMQ-168) Duplicated calls of life cycle in Maven.
[
https://issues.apache.org/jira/browse/ROCKETMQ-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004096#comment-16004096
]
Karl Heinz Marbaise commented on ROCKETMQ-168:
--
The point is you need to add the supplemental call of maven-assembly-plugin
goal call {{assembly:assembly}} apart from being deprecated and better being
integrated into the build to use simply {{mvn -Prelease-all -DskipTests clean
install}} and should be reduced to to {{mvn -Prelease-all clean install}}...
> Duplicated calls of life cycle in Maven.
>
>
> Key: ROCKETMQ-168
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-168
> Project: Apache RocketMQ
> Issue Type: Improvement
>Affects Versions: 4.0.0-incubating
>Reporter: Karl Heinz Marbaise
>Assignee: yukon
>Priority: Minor
> Fix For: 4.1.0-incubating
>
>
> Current the [build
> documentation|http://rocketmq.incubator.apache.org/docs/quick-start/] states
> to build via:
> {code}
> mvn clean package install -Prelease-all assembly:assembly -U
> {code}
> Only the following is neccessary:
> {code}
> mvn clean install -Prelease-all assembly:assembly -U
> {code}
> otherwise several parts of the build life cycle are repeated...furthermore
> the questions is why you use a call to {{assembly:assembly}} which is
> deprecated and best it should be done simply by using:
> {code}
> mvn clean deploy -Prelease-all
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-166) onException callback may capture compressed message body
[
https://issues.apache.org/jira/browse/ROCKETMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004026#comment-16004026
]
ASF GitHub Bot commented on ROCKETMQ-166:
-
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115651498
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage(//
final SendMessageContext context, // 11
final DefaultMQProducerImpl producer // 12
) throws RemotingException, MQBrokerException, InterruptedException {
+
+byte[] msgBody = msg.getBody();
+Integer sysFlag = requestHeader.getSysFlag();
+if (null != sysFlag && ((sysFlag & MessageSysFlag.COMPRESSED_FLAG)
== MessageSysFlag.COMPRESSED_FLAG)) {
+try {
+msgBody = UtilAll.compress(msgBody, zipCompressLevel);
+} catch (IOException e) {
+
requestHeader.setSysFlag(MessageSysFlag.clearCompressedFlag(sysFlag));
+log.error("tryToCompressMessage exception", e);
--- End diff --
Got your point.
1. The code is moved here, and same log level should be applied IMO.
@vongosling @vintagewang any particular reason behind this?
> onException callback may capture compressed message body
>
>
> Key: ROCKETMQ-166
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-166
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.1.0-incubating
>
>
> If message body size exceeds specified threshold, client would try to
> compress the message body.
> Here there are two issues: 1) current implementation changes message body
> directly, which is not a good practice; 2) if asynchronous send method is
> employed to deliver message, when onException is invoked, the callback may
> capture the compressed message body before the finally block restores it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-168) Duplicated calls of life cycle in Maven.
[
https://issues.apache.org/jira/browse/ROCKETMQ-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004012#comment-16004012
]
Zhanhui Li commented on ROCKETMQ-168:
-
Current command does not generate a distribution package.
$ mvn -Prelease-all -DskipTests clean install -U
IMO, we need package phase included here.
> Duplicated calls of life cycle in Maven.
>
>
> Key: ROCKETMQ-168
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-168
> Project: Apache RocketMQ
> Issue Type: Improvement
>Affects Versions: 4.0.0-incubating
>Reporter: Karl Heinz Marbaise
>Assignee: yukon
>Priority: Minor
> Fix For: 4.1.0-incubating
>
>
> Current the [build
> documentation|http://rocketmq.incubator.apache.org/docs/quick-start/] states
> to build via:
> {code}
> mvn clean package install -Prelease-all assembly:assembly -U
> {code}
> Only the following is neccessary:
> {code}
> mvn clean install -Prelease-all assembly:assembly -U
> {code}
> otherwise several parts of the build life cycle are repeated...furthermore
> the questions is why you use a call to {{assembly:assembly}} which is
> deprecated and best it should be done simply by using:
> {code}
> mvn clean deploy -Prelease-all
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-166) onException callback may capture compressed message body
[
https://issues.apache.org/jira/browse/ROCKETMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004009#comment-16004009
]
ASF GitHub Bot commented on ROCKETMQ-166:
-
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650526
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage(//
final SendMessageContext context, // 11
final DefaultMQProducerImpl producer // 12
) throws RemotingException, MQBrokerException, InterruptedException {
+
+byte[] msgBody = msg.getBody();
+Integer sysFlag = requestHeader.getSysFlag();
+if (null != sysFlag && ((sysFlag & MessageSysFlag.COMPRESSED_FLAG)
== MessageSysFlag.COMPRESSED_FLAG)) {
+try {
+msgBody = UtilAll.compress(msgBody, zipCompressLevel);
+} catch (IOException e) {
+
requestHeader.setSysFlag(MessageSysFlag.clearCompressedFlag(sysFlag));
+log.error("tryToCompressMessage exception", e);
--- End diff --
I just wonder why both WARN and ERROR are needed.
> onException callback may capture compressed message body
>
>
> Key: ROCKETMQ-166
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-166
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.1.0-incubating
>
>
> If message body size exceeds specified threshold, client would try to
> compress the message body.
> Here there are two issues: 1) current implementation changes message body
> directly, which is not a good practice; 2) if asynchronous send method is
> employed to deliver message, when onException is invoked, the callback may
> capture the compressed message body before the finally block restores it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-166) onException callback may capture compressed message body
[
https://issues.apache.org/jira/browse/ROCKETMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004006#comment-16004006
]
ASF GitHub Bot commented on ROCKETMQ-166:
-
Github user lizhanhui commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/89#discussion_r115650129
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -306,6 +310,19 @@ public SendResult sendMessage(//
final SendMessageContext context, // 11
final DefaultMQProducerImpl producer // 12
) throws RemotingException, MQBrokerException, InterruptedException {
+
+byte[] msgBody = msg.getBody();
+Integer sysFlag = requestHeader.getSysFlag();
+if (null != sysFlag && ((sysFlag & MessageSysFlag.COMPRESSED_FLAG)
== MessageSysFlag.COMPRESSED_FLAG)) {
+try {
+msgBody = UtilAll.compress(msgBody, zipCompressLevel);
+} catch (IOException e) {
+
requestHeader.setSysFlag(MessageSysFlag.clearCompressedFlag(sysFlag));
+log.error("tryToCompressMessage exception", e);
--- End diff --
You mean why we log error on failing to compress message body?
> onException callback may capture compressed message body
>
>
> Key: ROCKETMQ-166
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-166
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
> Fix For: 4.1.0-incubating
>
>
> If message body size exceeds specified threshold, client would try to
> compress the message body.
> Here there are two issues: 1) current implementation changes message body
> directly, which is not a good practice; 2) if asynchronous send method is
> employed to deliver message, when onException is invoked, the callback may
> capture the compressed message body before the finally block restores it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-174) Spelling Fix
[ https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003952#comment-16003952 ] ASF GitHub Bot commented on ROCKETMQ-174: - Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115645553 --- Diff: client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java --- @@ -907,10 +907,10 @@ public void queryMessage( final QueryMessageRequestHeader requestHeader, final long timeoutMillis, final InvokeCallback invokeCallback, -final Boolean isUnqiueKey +final Boolean isUnqueKey --- End diff -- Thanks for point it out, unique key. > Spelling Fix > > > Key: ROCKETMQ-174 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-174 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Zhanhui Li >Assignee: Zhanhui Li >Priority: Trivial > Fix For: 4.1.0-incubating > > Time Spent: 168h > Remaining Estimate: 0h > > Existing code base contains many spelling issues, this is to fix them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-178) Broker -m -p options are broken
[ https://issues.apache.org/jira/browse/ROCKETMQ-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003948#comment-16003948 ] ASF GitHub Bot commented on ROCKETMQ-178: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 > Any trouble is still ? No. It's a trivial change and should have been merged/closed. > Broker -m -p options are broken > --- > > Key: ROCKETMQ-178 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-178 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-broker >Affects Versions: 4.1.0-incubating >Reporter: Zhanhui Li >Assignee: Zhanhui Li > Fix For: 4.1.0-incubating > > > Broker command line are supposed to support -m -p options to print out > important settings. Now the logger is set as null, thus, no output at all. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-191) Fix incorret socket option
[ https://issues.apache.org/jira/browse/ROCKETMQ-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003944#comment-16003944 ] ASF GitHub Bot commented on ROCKETMQ-191: - Github user lizhanhui closed the pull request at: https://github.com/apache/incubator-rocketmq/pull/100 > Fix incorret socket option > -- > > Key: ROCKETMQ-191 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-191 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-remoting >Affects Versions: 4.1.0-incubating >Reporter: Zhanhui Li >Assignee: Zhanhui Li > Fix For: 4.1.0-incubating > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-191) Fix incorret socket option
[ https://issues.apache.org/jira/browse/ROCKETMQ-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003943#comment-16003943 ] ASF GitHub Bot commented on ROCKETMQ-191: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/100 Merged. > Fix incorret socket option > -- > > Key: ROCKETMQ-191 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-191 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-remoting >Affects Versions: 4.1.0-incubating >Reporter: Zhanhui Li >Assignee: Zhanhui Li > Fix For: 4.1.0-incubating > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-114) Add javadoc to codebase
[ https://issues.apache.org/jira/browse/ROCKETMQ-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003931#comment-16003931 ] ASF GitHub Bot commented on ROCKETMQ-114: - Github user lizhanhui commented on the issue: https://github.com/apache/incubator-rocketmq/pull/80 Let's close this PR for now and merge parts of docs which helps. > Add javadoc to codebase > --- > > Key: ROCKETMQ-114 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-114 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Zhanhui Li >Assignee: vongosling > Fix For: 4.1.0-incubating > > > Quality documentation is critically important to develop and maintain a > project. The better the documentation is, the > easier it will be for other participants to understand and respond properly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-161) Update runbroker.sh and runserver.sh to support user defined jvm memory flag
[
https://issues.apache.org/jira/browse/ROCKETMQ-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003918#comment-16003918
]
ASF GitHub Bot commented on ROCKETMQ-161:
-
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@shroman I insist on using JAVA_OPT_EXT, for that we may not only want to
override -Xms -Xmx -Xmn, but also other jvm flags.
We could use JAVA_OPT_EXT once and for all.
> Update runbroker.sh and runserver.sh to support user defined jvm memory flag
>
>
> Key: ROCKETMQ-161
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-161
> Project: Apache RocketMQ
> Issue Type: Improvement
>Reporter: dongeforever
>Assignee: dongeforever
> Fix For: 4.1.0-incubating
>
>
> JVM mem flag is hard coded in runbroker.sh as follows:
> JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
> If one want to change such flag, he has to change the script, this is not
> friendly, especially in docker environment.
> Instead, it is able to use an environment variable to handle user defined
> flag, like:
> if [ -z $BROKER_MEM_OPS ]; then
> BROKER_MEM_OPS = "-Xms8g -Xmx8g -Xmn4g"
> fi
> JAVA_OPT="${JAVA_OPT} -server $BROKER_MEM_OPS"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-189) Misleading tip on consumeTimestamp and wrong consumeTimestamp exception message
[
https://issues.apache.org/jira/browse/ROCKETMQ-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003902#comment-16003902
]
ASF GitHub Bot commented on ROCKETMQ-189:
-
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/97
IMO,if we could polish here. we 'd better tell what's wrong with your input
and what's a valid input ,right ?
> Misleading tip on consumeTimestamp and wrong consumeTimestamp exception
> message
> ---
>
> Key: ROCKETMQ-189
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-189
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
>Affects Versions: 4.0.0-incubating
> Environment: macos,jdk8
>Reporter: lindzh
>Assignee: Xiaorui Wang
> Labels: easyfix
> Fix For: 4.1.0-incubating
>
> Original Estimate: 12h
> Remaining Estimate: 12h
>
> When I want to consume message,I use the following code,
> {quote}
> consumer.setConsumeFromWhere(ConsumeFromWhere.CONSUME_FROM_FIRST_OFFSET);
> consumer.setConsumeTimestamp("2017_0422_235500");
> {quote}
> and I got the tip as following:
> {quote}
> Exception in thread "main"
> org.apache.rocketmq.client.exception.MQClientException: consumeTimestamp is
> invalid, _MMDD_HHMMSS
> See http://rocketmq.apache.org/docs/faq/ for further details.
> at
> org.apache.rocketmq.client.impl.consumer.DefaultMQPushConsumerImpl.checkConfig(DefaultMQPushConsumerImpl.java:661)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-161) Update runbroker.sh and runserver.sh to support user defined jvm memory flag
[
https://issues.apache.org/jira/browse/ROCKETMQ-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003847#comment-16003847
]
ASF GitHub Bot commented on ROCKETMQ-161:
-
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@dongeforever I see, thank you!
How about just changing the code to
```
if [ -z "$JVM_OPTS" ] ; then
#default_options
JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
fi
```
?
But if you guys think we need `JAVA_OPT_EXT`, please go ahead ;)
> Update runbroker.sh and runserver.sh to support user defined jvm memory flag
>
>
> Key: ROCKETMQ-161
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-161
> Project: Apache RocketMQ
> Issue Type: Improvement
>Reporter: dongeforever
>Assignee: dongeforever
> Fix For: 4.1.0-incubating
>
>
> JVM mem flag is hard coded in runbroker.sh as follows:
> JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
> If one want to change such flag, he has to change the script, this is not
> friendly, especially in docker environment.
> Instead, it is able to use an environment variable to handle user defined
> flag, like:
> if [ -z $BROKER_MEM_OPS ]; then
> BROKER_MEM_OPS = "-Xms8g -Xmx8g -Xmn4g"
> fi
> JAVA_OPT="${JAVA_OPT} -server $BROKER_MEM_OPS"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-114) Add javadoc to codebase
[ https://issues.apache.org/jira/browse/ROCKETMQ-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003824#comment-16003824 ] ASF GitHub Bot commented on ROCKETMQ-114: - Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/80 @vongosling I suggest to create JIRA issues for all TODOs and FIXMEs here to make sure they are fixed someday. It's not critical though, if you want to merge, please go ahead ;) > Add javadoc to codebase > --- > > Key: ROCKETMQ-114 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-114 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Zhanhui Li >Assignee: vongosling > Fix For: 4.1.0-incubating > > > Quality documentation is critically important to develop and maintain a > project. The better the documentation is, the > easier it will be for other participants to understand and respond properly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-187) Measure the code coverage for Integration Tests
[ https://issues.apache.org/jira/browse/ROCKETMQ-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002899#comment-16002899 ] ASF subversion and git services commented on ROCKETMQ-187: -- Commit f5a2ee0a8fecff48064f19ea242c233475e9635f in incubator-rocketmq's branch refs/heads/develop from [~zander] [ https://git-wip-us.apache.org/repos/asf?p=incubator-rocketmq.git;h=f5a2ee0 ] [ROCKETMQ-187] Measure the code coverage for Integration Tests, and add sonar-apache profile, closes apache/incubator-rocketmq#96 > Measure the code coverage for Integration Tests > --- > > Key: ROCKETMQ-187 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-187 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: dongeforever >Assignee: dongeforever > > Now we could browse the Unit Tests and IT Tests at > https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all > But the IT Test coverage is not correct. It should cover the original sources > instead of the the classes in test module. > As for as I known, the coverage report is generated by matching the > collected data(often using java agent) against a set of classes (the module > classes compiled from src/main/). you could refer to: > http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/ > So we could match the jacoco-it.exec to each module's source classes to get > the correct IT coverage report. > By the way, we'd better exclude the classes in the test module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-114) Add javadoc to codebase
[ https://issues.apache.org/jira/browse/ROCKETMQ-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002809#comment-16002809 ] ASF GitHub Bot commented on ROCKETMQ-114: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/80 What's wrong with this PR. if no other polish, suggest close it:-) > Add javadoc to codebase > --- > > Key: ROCKETMQ-114 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-114 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Zhanhui Li >Assignee: vongosling > Fix For: 4.1.0-incubating > > > Quality documentation is critically important to develop and maintain a > project. The better the documentation is, the > easier it will be for other participants to understand and respond properly. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-178) Broker -m -p options are broken
[ https://issues.apache.org/jira/browse/ROCKETMQ-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002803#comment-16002803 ] ASF GitHub Bot commented on ROCKETMQ-178: - Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq/pull/93 Any trouble is still ? > Broker -m -p options are broken > --- > > Key: ROCKETMQ-178 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-178 > Project: Apache RocketMQ > Issue Type: Bug > Components: rocketmq-broker >Affects Versions: 4.1.0-incubating >Reporter: Zhanhui Li >Assignee: Zhanhui Li > Fix For: 4.1.0-incubating > > > Broker command line are supposed to support -m -p options to print out > important settings. Now the logger is set as null, thus, no output at all. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-187) Measure the code coverage for Integration Tests
[ https://issues.apache.org/jira/browse/ROCKETMQ-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002670#comment-16002670 ] ASF GitHub Bot commented on ROCKETMQ-187: - Github user dongeforever commented on the issue: https://github.com/apache/incubator-rocketmq/pull/96 The PR is better not to be merged by the original author. @lizhanhui @zhouxinyu @shroman please help merge this PR. > Measure the code coverage for Integration Tests > --- > > Key: ROCKETMQ-187 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-187 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: dongeforever >Assignee: dongeforever > > Now we could browse the Unit Tests and IT Tests at > https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all > But the IT Test coverage is not correct. It should cover the original sources > instead of the the classes in test module. > As for as I known, the coverage report is generated by matching the > collected data(often using java agent) against a set of classes (the module > classes compiled from src/main/). you could refer to: > http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/ > So we could match the jacoco-it.exec to each module's source classes to get > the correct IT coverage report. > By the way, we'd better exclude the classes in the test module. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[
https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002639#comment-16002639
]
ASF GitHub Bot commented on ROCKETMQ-194:
-
Github user lindzh commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115482388
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j/RocketmqLog4jAppender.java
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.logappender.log4j;
+
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.logappender.common.ProducerInstance;
+import org.apache.log4j.AppenderSkeleton;
+import org.apache.log4j.helpers.LogLog;
+import org.apache.log4j.spi.ErrorCode;
+import org.apache.log4j.spi.LoggingEvent;
+import org.apache.rocketmq.client.producer.MQProducer;
+
+/**
+ * Log4j Appender Component
+ */
+public class RocketmqLog4jAppender extends AppenderSkeleton {
+
+/**
+ * appended message tag define
--- End diff --
ok
> log appender useing rocketmq
>
>
> Key: ROCKETMQ-194
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-194
> Project: Apache RocketMQ
> Issue Type: New Feature
>Affects Versions: 4.1.0-incubating
> Environment: jdk7
>Reporter: lindzh
>Assignee: vongosling
> Labels: features
> Fix For: 4.1.0-incubating
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As Rocketmq is widely used,A log appender is also necessary.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002638#comment-16002638 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115482303 --- Diff: style/rmq_checkstyle.xml --- @@ -30,6 +30,12 @@ + + + + --- End diff -- Old check style is not supported When we add a file such as properties config file. > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-174) Spelling Fix
[
https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002623#comment-16002623
]
ASF GitHub Bot commented on ROCKETMQ-174:
-
Github user vsair commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478015
--- Diff:
common/src/main/java/org/apache/rocketmq/common/protocol/route/TopicRouteData.java
---
@@ -27,23 +27,23 @@
public class TopicRouteData extends RemotingSerializable {
private String orderTopicConf;
-private List queueDatas;
-private List brokerDatas;
+private List queueDataList;
+private List brokerDataList;
--- End diff --
It is modification of protocol, IMO, it's improper for upgrade of server or
client.
> Spelling Fix
>
>
> Key: ROCKETMQ-174
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-174
> Project: Apache RocketMQ
> Issue Type: Improvement
>Reporter: Zhanhui Li
>Assignee: Zhanhui Li
>Priority: Trivial
> Fix For: 4.1.0-incubating
>
> Time Spent: 168h
> Remaining Estimate: 0h
>
> Existing code base contains many spelling issues, this is to fix them.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-174) Spelling Fix
[ https://issues.apache.org/jira/browse/ROCKETMQ-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002625#comment-16002625 ] ASF GitHub Bot commented on ROCKETMQ-174: - Github user vsair commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/91#discussion_r115478367 --- Diff: common/src/main/java/org/apache/rocketmq/common/protocol/header/QueryMessageResponseHeader.java --- @@ -28,7 +28,7 @@ @CFNotNull private Long indexLastUpdateTimestamp; @CFNotNull -private Long indexLastUpdatePhyoffset; +private Long indexLastUpdatePhyOffset; --- End diff -- Protocol modification. > Spelling Fix > > > Key: ROCKETMQ-174 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-174 > Project: Apache RocketMQ > Issue Type: Improvement >Reporter: Zhanhui Li >Assignee: Zhanhui Li >Priority: Trivial > Fix For: 4.1.0-incubating > > Time Spent: 168h > Remaining Estimate: 0h > > Existing code base contains many spelling issues, this is to fix them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002593#comment-16002593 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471708 --- Diff: logappender/README.md --- @@ -0,0 +1,64 @@ +# RocketMQ-LogAppender [](https://travis-ci.org/rocketmq/rocketmq-logappender) [](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master) + + +## Introduction +RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and logback.Taking Apache RocketMQ as broker. +All logs loged will be send to the topic you define. + +## Examples + + log4j example + +> config detail + +```xml + + + + + + + + + + + + + + --- End diff -- why not use single label as above? > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002587#comment-16002587 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115473097 --- Diff: style/rmq_checkstyle.xml --- @@ -30,6 +30,12 @@ + + + + --- End diff -- Why change this rule~ > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[
https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002590#comment-16002590
]
ASF GitHub Bot commented on ROCKETMQ-194:
-
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472087
--- Diff: logappender/pom.xml ---
@@ -0,0 +1,122 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+org.apache.rocketmq
+rocketmq-all
+4.1.0-incubating-SNAPSHOT
+
+4.0.0
+rocketmq-logappender
+ jar
+rocketmq-logappender ${project.version}
+
+
+UTF-8
+false
--- End diff --
Redundant config. we can extend from parent module.
> log appender useing rocketmq
>
>
> Key: ROCKETMQ-194
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-194
> Project: Apache RocketMQ
> Issue Type: New Feature
>Affects Versions: 4.1.0-incubating
> Environment: jdk7
>Reporter: lindzh
>Assignee: vongosling
> Labels: features
> Fix For: 4.1.0-incubating
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As Rocketmq is widely used,A log appender is also necessary.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002589#comment-16002589 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471844 --- Diff: logappender/README.md --- @@ -0,0 +1,64 @@ +# RocketMQ-LogAppender [](https://travis-ci.org/rocketmq/rocketmq-logappender) [](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master) + + +## Introduction +RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and logback.Taking Apache RocketMQ as broker. +All logs loged will be send to the topic you define. + +## Examples + + log4j example + +> config detail + +```xml + + + + + + + + + + + + + + + + + + + + + +``` + + logback example + +```xml + +log1 +TopicTest +logback +127.0.0.1:9876 + +%date %p %t - %m%n + + + + +1024 +80 +2000 +true + + + + + + +``` + +More example,like log4j2,please see Test case. --- End diff -- Could we give the example link for user ? > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002588#comment-16002588 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115470775 --- Diff: logappender/README.md --- @@ -0,0 +1,64 @@ +# RocketMQ-LogAppender [](https://travis-ci.org/rocketmq/rocketmq-logappender) [](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master) --- End diff -- Could we remove it if we want it into parent modue, we can reuse rocektmq existing infra. > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002586#comment-16002586 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471504 --- Diff: logappender/README.md --- @@ -0,0 +1,64 @@ +# RocketMQ-LogAppender [](https://travis-ci.org/rocketmq/rocketmq-logappender) [](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master) + + +## Introduction +RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and logback.Taking Apache RocketMQ as broker. +All logs loged will be send to the topic you define. + +## Examples + + log4j example + +> config detail + +```xml + + --- End diff -- case-insensitive name ,right ? > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[
https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002591#comment-16002591
]
ASF GitHub Bot commented on ROCKETMQ-194:
-
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472199
--- Diff: logappender/pom.xml ---
@@ -0,0 +1,122 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+org.apache.rocketmq
+rocketmq-all
+4.1.0-incubating-SNAPSHOT
+
+4.0.0
+rocketmq-logappender
+ jar
+rocketmq-logappender ${project.version}
+
+
+UTF-8
+false
+true
+1.7
+1.7
+
+
+
+
+
+org.slf4j
+slf4j-api
+1.7.7
+true
+
+
+
+log4j
+log4j
+1.2.17
+true
+
+
+
+org.apache.logging.log4j
+log4j-core
+2.7
+true
+
+
+
+
+ch.qos.logback
+logback-core
+1.1.2
--- End diff --
The latest version ?
> log appender useing rocketmq
>
>
> Key: ROCKETMQ-194
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-194
> Project: Apache RocketMQ
> Issue Type: New Feature
>Affects Versions: 4.1.0-incubating
> Environment: jdk7
>Reporter: lindzh
>Assignee: vongosling
> Labels: features
> Fix For: 4.1.0-incubating
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As Rocketmq is widely used,A log appender is also necessary.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[
https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002592#comment-16002592
]
ASF GitHub Bot commented on ROCKETMQ-194:
-
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115472704
--- Diff:
logappender/src/main/java/org/apache/rocketmq/logappender/log4j/RocketmqLog4jAppender.java
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.rocketmq.logappender.log4j;
+
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.logappender.common.ProducerInstance;
+import org.apache.log4j.AppenderSkeleton;
+import org.apache.log4j.helpers.LogLog;
+import org.apache.log4j.spi.ErrorCode;
+import org.apache.log4j.spi.LoggingEvent;
+import org.apache.rocketmq.client.producer.MQProducer;
+
+/**
+ * Log4j Appender Component
+ */
+public class RocketmqLog4jAppender extends AppenderSkeleton {
+
+/**
+ * appended message tag define
--- End diff --
Capitalize the first letter~
> log appender useing rocketmq
>
>
> Key: ROCKETMQ-194
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-194
> Project: Apache RocketMQ
> Issue Type: New Feature
>Affects Versions: 4.1.0-incubating
> Environment: jdk7
>Reporter: lindzh
>Assignee: vongosling
> Labels: features
> Fix For: 4.1.0-incubating
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> As Rocketmq is widely used,A log appender is also necessary.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002585#comment-16002585 ] ASF GitHub Bot commented on ROCKETMQ-194: - Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/101#discussion_r115471296 --- Diff: logappender/README.md --- @@ -0,0 +1,64 @@ +# RocketMQ-LogAppender [](https://travis-ci.org/rocketmq/rocketmq-logappender) [](https://coveralls.io/github/rocketmq/rocketmq-logappender?branch=master) + + +## Introduction +RocketMQ-LogAppender is a logging component implement of log4j,log4j2 and logback.Taking Apache RocketMQ as broker. --- End diff -- What is "implement of " It's confused. IMO, this project is used to send log message using RocektMQ. while log4j, log4j2 and logback is just a adapter for SL4J > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq
[ https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002348#comment-16002348 ] ASF GitHub Bot commented on ROCKETMQ-194: - GitHub user lindzh opened a pull request: https://github.com/apache/incubator-rocketmq/pull/101 [ROCKETMQ-194] log appender support As Rocketmq is widely used,A log appender is also necessary. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lindzh/incubator-rocketmq log_appender Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-rocketmq/pull/101.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #101 > log appender useing rocketmq > > > Key: ROCKETMQ-194 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 > Project: Apache RocketMQ > Issue Type: New Feature >Affects Versions: 4.1.0-incubating > Environment: jdk7 >Reporter: lindzh >Assignee: vongosling > Labels: features > Fix For: 4.1.0-incubating > > Original Estimate: 72h > Remaining Estimate: 72h > > As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ROCKETMQ-194) log appender useing rocketmq
lindzh created ROCKETMQ-194: --- Summary: log appender useing rocketmq Key: ROCKETMQ-194 URL: https://issues.apache.org/jira/browse/ROCKETMQ-194 Project: Apache RocketMQ Issue Type: New Feature Affects Versions: 4.1.0-incubating Environment: jdk7 Reporter: lindzh Assignee: vongosling Fix For: 4.1.0-incubating As Rocketmq is widely used,A log appender is also necessary. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
