[jira] [Commented] (ROCKETMQ-289) getBrokerRuntimeInfo method may be output fileReservedTime value

2017-09-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167472#comment-16167472
 ] 

ASF GitHub Bot commented on ROCKETMQ-289:
-

Github user zhouxinyu commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/163
  
Hi, thanks for your contribution. We could get FileReservedTime through 
`GetBrokerConfigCommand`, there is no need to add it to `runtimeInfo `.


> getBrokerRuntimeInfo method may be output fileReservedTime value 
> -
>
> Key: ROCKETMQ-289
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-289
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 
> 4.3.0-incubating
>Reporter: yubaofu
>Assignee: yukon
> Fix For: 4.2.0-incubating, 4.3.0-incubating
>
>
> for some reasons, getBrokerRuntimeInfo method may be output fileReservedTime 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (ROCKETMQ-289) getBrokerRuntimeInfo method may be output fileReservedTime value

2017-09-12 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164148#comment-16164148
 ] 

ASF GitHub Bot commented on ROCKETMQ-289:
-

Github user coveralls commented on the issue:

https://github.com/apache/incubator-rocketmq/pull/163
  

[![Coverage 
Status](https://coveralls.io/builds/13246332/badge)](https://coveralls.io/builds/13246332)

Coverage increased (+0.1%) to 38.851% when pulling 
**c8079c3048c67b11ba9d78320a702be62aace523 on fuyou001:ROCKETMQ-289** into 
**368e7c86a0b06099f336c81672112dcb5143cf9e on apache:develop**.



> getBrokerRuntimeInfo method may be output fileReservedTime value 
> -
>
> Key: ROCKETMQ-289
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-289
> Project: Apache RocketMQ
>  Issue Type: Bug
>  Components: rocketmq-broker
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 
> 4.3.0-incubating
>Reporter: yubaofu
>Assignee: yukon
> Fix For: 4.2.0-incubating, 4.3.0-incubating
>
>
> for some reasons, getBrokerRuntimeInfo method may be output fileReservedTime 
> value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)