[jira] [Updated] (ROCKETMQ-209) Duplicated code in class MQClientAPIImpl

[binzhaomobile (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ROCKETMQ-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

binzhaomobile updated ROCKETMQ-209:
---
Description: 
In class MQClientAPIImpl, the two functions 
getDefaultTopicRouteInfoFromNameServer and getTopicRouteInfoFromNameServer 
almost have the same code. The only difference is the way to handle the 
situation when topic does not exist. Suggestion to fix this issue:
1) Add a new function: public TopicRouteData 
getTopicRouteInfoFromNameServer(final String topic, final long timeoutMillis, 
boolean allowTopicNotExist).
2) Merge the code from getDefaultTopicRouteInfoFromNameServer and 
getTopicRouteInfoFromNameServer into the new function so that it can handle 
both case.
3) Change getDefaultTopicRouteInfoFromNameServer and 
getTopicRouteInfoFromNameServer to call the new function with   
allowTopicNotExist parameter true or false.

  was:
In class MQClientAPIImpl, the two functions 
getDefaultTopicRouteInfoFromNameServer and getTopicRouteInfoFromNameServer 
almost have the same code. The only difference is the way to handle the 
situation when topic does not exist. Suggestion to fix this issue:
1) Add a new function: public TopicRouteData 
getTopicRouteInfoFromNameServer(final String topic, final long timeoutMillis, 
boolean allowTopicNotExist).
2) Move the code from getDefaultTopicRouteInfoFromNameServer and 
getTopicRouteInfoFromNameServer into the new function so that it can handle 
both case.
3) Change getDefaultTopicRouteInfoFromNameServer and 
getTopicRouteInfoFromNameServer to call the new function with   
allowTopicNotExist parameter true or false.


> Duplicated code in class MQClientAPIImpl
> 
>
> Key: ROCKETMQ-209
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-209
> Project: Apache RocketMQ
>  Issue Type: Improvement
>  Components: rocketmq-client
>Affects Versions: 4.0.0-incubating, 4.1.0-incubating, 4.2.0-incubating, 
> 4.3.0-incubating
> Environment: All Environments
>Reporter: binzhaomobile
>Assignee: Xiaorui Wang
>Priority: Minor
>
> In class MQClientAPIImpl, the two functions 
> getDefaultTopicRouteInfoFromNameServer and getTopicRouteInfoFromNameServer 
> almost have the same code. The only difference is the way to handle the 
> situation when topic does not exist. Suggestion to fix this issue:
> 1) Add a new function: public TopicRouteData 
> getTopicRouteInfoFromNameServer(final String topic, final long timeoutMillis, 
> boolean allowTopicNotExist).
> 2) Merge the code from getDefaultTopicRouteInfoFromNameServer and 
> getTopicRouteInfoFromNameServer into the new function so that it can handle 
> both case.
> 3) Change getDefaultTopicRouteInfoFromNameServer and 
> getTopicRouteInfoFromNameServer to call the new function with   
> allowTopicNotExist parameter true or false.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ROCKETMQ-194) log appender useing rocketmq

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ROCKETMQ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036467#comment-16036467
 ] 

ASF GitHub Bot commented on ROCKETMQ-194:
-

Github user lindzh closed the pull request at:

https://github.com/apache/incubator-rocketmq/pull/101


> log appender useing rocketmq
> 
>
> Key: ROCKETMQ-194
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-194
> Project: Apache RocketMQ
>  Issue Type: New Feature
>Affects Versions: 4.1.0-incubating
> Environment: jdk7
>Reporter: lindzh
>Assignee: vongosling
>  Labels: features
> Fix For: 4.1.0-incubating
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> As Rocketmq is widely used,A log appender is also necessary.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)