[GitHub] [royale-asjs] Harbs commented on issue #1217: js-debug vs js-release

2022-12-22 Thread GitBox


Harbs commented on issue #1217:
URL: https://github.com/apache/royale-asjs/issues/1217#issuecomment-1362553502

   It does probably make sense to not add the `min.` to the name for release. 
It doesn't really add anything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [royale-asjs] Harbs commented on issue #1217: js-debug vs js-release

2022-12-21 Thread GitBox


Harbs commented on issue #1217:
URL: https://github.com/apache/royale-asjs/issues/1217#issuecomment-1361256086

   Actually, here's what I have in my template file:
   ``
   
   `${application}.css` becomes MyApp.css in debug and MyApp.min.css in 
release. I have a build script which appends the build number for cache-busting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [royale-asjs] Harbs commented on issue #1217: js-debug vs js-release

2022-12-21 Thread GitBox


Harbs commented on issue #1217:
URL: https://github.com/apache/royale-asjs/issues/1217#issuecomment-1361251065

   Regarding your first point: What does your template html file look like? 
Make sure you have the `${head}` token. Your minified css file should be 
correctly linked.
   
   Regarding your second point, please read this page: 
https://apache.github.io/royale-docs/create-an-application/optimizations/minification


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org