[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-12 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-598552401
 
 
   I looked into the 4 calls.  It looks like "correct" behavior.  One of the 
inefficiencies in the test case is that the XMLListCollection's source is set 3 
times:
   1) set to null in the app's constructor to initialize jobListXmlCollection
   2) set to null to "unset" the XMLListAdapter from set in the app's 
constructor
   3) set to the actual final XMLList.
   
   Then, given that VGroup is used as the top tag in StateImageItem, 
ContainerDataBinding is running which evaluates data before it is set by the 
binding in the wrapping MXADGIR.
   And then it gets set one final time with the right value.
   
   It could improve performance to not initialize jobListXmlCollection and 
create the final XMLListCollection in the creationComplete handler.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-11 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-598018093
 
 
   I will try to remember to optimize it down to two or one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-11 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-598008829
 
 
   I altered resolveStatus to :
   ```
   public static function resolveStatus(data:Object):String {

var statu:int = XML(data).visualParams.statu;

// Alert.show("Vparams : " + data.visualParams);
// Alert.show("statu:" + statu + " image:" + 
imageList.getItemAt(statu));

return getStatuImage(statu) as String;
}
   ```
   
   And the IMG tag properly got its URL
   
   ```
   
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-11 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-598007941
 
 
   The example source is throwing a caught exception in the binding code 
because the list of items is never initialized.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-11 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-597878674
 
 
   In the email thread, I thought you said that resolveStatus gets called 
twice.  On the second call, ItemRendererDataBinding should be making the call.  
Add some debugging to verify that there is a second call and what resolveStatus 
returns, and also make sure you changed the method signature to return String 
instead of Class otherwise, no source will be assigned.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [royale-asjs] aharui commented on issue #755: Binding function is called after the static function in component

2020-03-11 Thread GitBox 
aharui commented on issue #755: Binding function is called after the static 
function in component
URL: https://github.com/apache/royale-asjs/issues/755#issuecomment-597871813
 
 
   The call stack shows that ContainerDataBinding is making the call.  We can 
optimize that away, but it should not be affecting your application.  What 
impact are you seeing?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services