[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-02 Thread GitBox


estanglerbm commented on pull request #1135:
URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457


   Merged develop, except the parts not needed on spark-dynamic-layout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-02 Thread GitBox


estanglerbm commented on pull request #1135:
URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457


   Merged develop, except the parts not needed on spark-dynamic-layout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-11-01 Thread GitBox


estanglerbm commented on pull request #1135:
URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-957112457


   Merged develop, except the parts not needed on spark-dynamic-layout.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-10-19 Thread GitBox


estanglerbm commented on pull request #1135:
URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-946495696


   @yishayw I went through the bugs to examine them real quick... some of them 
are actually working on develop, and another is not.  There are some things 
that ChildResize does not fix, in my tests (I can post later).  I still need to 
spend some time going through other tests and examining what is in ChildResize 
vs. PR #1135.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [royale-asjs] estanglerbm commented on pull request #1135: Spark dynamic container layout

2021-10-18 Thread GitBox


estanglerbm commented on pull request #1135:
URL: https://github.com/apache/royale-asjs/pull/1135#issuecomment-946284656


   @yishayw Well, I haven't had time to review exactly what's in ChildResize, 
but there were a lot more fundamental layout problems in SparkRoyale / MXRoyale 
than just what handling child resize events would fix.  (I explain some of it 
in the description above.)  I haven't had time yet to review all my tests to 
tell you exactly the differences in behavior between the two.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org