[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373869349
 
 
   I think it should be safe to update those two projects.  If you can see if 
they are missing in the parent pom that might be why they did not get 
auto-updated


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373860698
 
 
   Hi Carlos,
   
   Just like last time, that implies that your local changes are not used when 
compiling an example.  Do you remember what you did to get it working last time?
   
   Clear out the Royale jars from your local Maven repo and re-install the 
compiler and check file sizes and dates.
   
   Also check the console output and see where it is pulling the compiler.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373828990
 
 
   Hi Carlos,
   
   I forgot that Maven calls the execute() entry point in MXMLJSC and COMPJSC.  
Sorry about that.
   
   If you are getting println for the MXMLJSC and in  JSSCSSCompilationSession 
and CSSRGBaColorPropertyValue then try changing what those files output and 
make sure that is reflected in the output.
   
   -Alex


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373526917
 
 
   Yes, the test checks all 3 things.  We had a problem before where you had 
trouble picking up changes.  The responsibility is on you to validate that you 
have those changes.   Add a System.out.println to prove the changed code is 
being called.
   
   -Alex
   
   From: Carlos Rovira 
>
   Reply-To: apache/royale-compiler 
>
   Date: Thursday, March 15, 2018 at 1:09 PM
   To: apache/royale-compiler 
>
   Cc: aharui >, State change 
>
   Subject: Re: [apache/royale-compiler] [CSS] rgba is not valid in text-shadow 
(#25)
   
   
   Hi Alex,
   
   I put in my theme CSS the same line in the test :
   
   text-shadow: 0 -1px 0 rgba(0,0,0,0.70)
   
   And this makes the application build successful, but the problem is at 
runtime:
   
   this["textShadow"] = [0.0, -1.0, 0.0, unexpected value type: rgba(0, 0, 0, 
0.7)];
   
   Does the test a) checks if compiles?, then if b) compiles the app where is 
used? and then 3) if the output is valid is ok to work at runtime?. I think 1) 
and 2) are ok, but 3) is failing without doubt
   
   Thanks
   
   —
   You are receiving this because you modified the open/close state.
   Reply to this email directly, view it on 
GitHub,
 or mute the 
thread.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-373500322
 
 
   There is a test in the compiler-jx folder that is working.  See 
CSSTestSource.css.  Make that test fail and then I will take a look.  
Otherwise, verify you have correctly picked up the fix.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370950624
 
 
   You might need to output slightly different things for the App.js vs 
App.css.  App.css should be compliant CSS and use rgba().  The App.css should 
look like the input CSS.  But the data structure in App.js should be a valid 
ActionScript data structure with Arrays and Objects and values that resolve to 
something.  I suppose we could create a global rgba function, but I think you 
still need to output the array with commas instead of spaces, and converting 
the rgba to hex for App.js seems like the better answer.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370925374
 
 
   In the JS output, some CSS is output twice.  Once in App.js as a data 
structure for ValuesManager/SimpleCSSValuesImpl and the other in App.css for 
the browser.  There is some logic that tries to not output certain CSS to 
App.css because it is not CSS compliant like all of the ClassReferences for 
beads.  But I think other styles are output twice.  So yes, for sure, the 
output in App.css should be CSS compliant and be rgba(0,0,0,0.70), but the 
output in App.js needs to be a valid array of values that the framework will 
handle correctly.  Converting rgba to hex seems ok in this case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] aharui commented on issue #25: [CSS] rgba is not valid in text-shadow

[GitBox]

aharui commented on issue #25: [CSS] rgba is not valid in text-shadow
URL: https://github.com/apache/royale-compiler/issues/25#issuecomment-370854316
 
 
   This looks like it is Google Closure Compiler complaining about the text 
"unexpected value type:".  I think that text should not be in App.js.  That 
line should just read:
   
   this["textShadow"] = [0.0, -1.0, 0.0, rgba(0,0,0,0.70)];
   
   Or maybe leave it as a string to be handled by the framework at runtime:
   
   this["textShadow"] = [0.0, -1.0, 0.0, "rgba(0,0,0,0.70)"];
   
   Or the output should be something like:
   
   this["textShadow"] = [0.0, -1.0, 0.0, 0xC000];
   
   Because the compiler knows to convert rgba into hexadecimal with alpha in 
the higher bits.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services