[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15473433#comment-15473433 ] Colm O hEigeartaigh commented on SENTRY-996: Some of the tests in "sentry-service-server" appear to fail with this patch applied. > Faulty loop logic in HdfsHAClientInvocationHandler + > HAClientInvocationHandler > --- > > Key: SENTRY-996 > URL: https://issues.apache.org/jira/browse/SENTRY-996 > Project: Sentry > Issue Type: Bug >Reporter: Colm O hEigeartaigh >Assignee: Ke Jia > Attachments: SENTRY-996-002.patch, SENTRY-996.001.patch > > > As discussed on the review board here: https://reviews.apache.org/r/41349/ > Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a > while(true) loop that looks like it was designed to catch certain exceptions > + retry. However, the logic is faulty in that it will always return after the > first iteration, not matter what (as picked up by PMD). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434108#comment-15434108
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12824053/SENTRY-996-002.patch
against master.
{color:red}Overall:{color} -1 due to 3 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.tests.e2e.dbprovider.TestDbPrivilegesAtFunctionScope
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.tools.TestSentryShellSolr
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1977/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996-002.patch, SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432476#comment-15432476
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12824053/SENTRY-996-002.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1969/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996-002.patch, SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423815#comment-15423815
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12824053/SENTRY-996-002.patch
against master.
{color:red}Overall:{color} -1 due to 2 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1956/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996-002.patch, SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306182#comment-15306182
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1653/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303506#comment-15303506
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1649/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303502#comment-15303502
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1650/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303358#comment-15303358
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1646/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303322#comment-15303322
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1643/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301924#comment-15301924
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to build with patch (exit code 1)
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1639/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301638#comment-15301638
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to 3 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryWebServerWithSSL
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.thrift.TestSentryServiceFailureCase
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1638/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[
https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15301315#comment-15301315
]
Hadoop QA commented on SENTRY-996:
--
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12806107/SENTRY-996.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} mvn test exited 1
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/1630/console
This message is automatically generated.
> Faulty loop logic in HdfsHAClientInvocationHandler +
> HAClientInvocationHandler
> ---
>
> Key: SENTRY-996
> URL: https://issues.apache.org/jira/browse/SENTRY-996
> Project: Sentry
> Issue Type: Bug
>Reporter: Colm O hEigeartaigh
>Assignee: Ke Jia
> Attachments: SENTRY-996.001.patch
>
>
> As discussed on the review board here: https://reviews.apache.org/r/41349/
> Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a
> while(true) loop that looks like it was designed to catch certain exceptions
> + retry. However, the logic is faulty in that it will always return after the
> first iteration, not matter what (as picked up by PMD).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299720#comment-15299720 ] Colm O hEigeartaigh commented on SENTRY-996: No, please go ahead :-) > Faulty loop logic in HdfsHAClientInvocationHandler + > HAClientInvocationHandler > --- > > Key: SENTRY-996 > URL: https://issues.apache.org/jira/browse/SENTRY-996 > Project: Sentry > Issue Type: Bug >Reporter: Colm O hEigeartaigh >Assignee: Ke Jia > > As discussed on the review board here: https://reviews.apache.org/r/41349/ > Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a > while(true) loop that looks like it was designed to catch certain exceptions > + retry. However, the logic is faulty in that it will always return after the > first iteration, not matter what (as picked up by PMD). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-996) Faulty loop logic in HdfsHAClientInvocationHandler + HAClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299372#comment-15299372 ] Ke Jia commented on SENTRY-996: --- Hi [~cohei...@progress.com], Do you work on this jira? If not, I want to do this jira. > Faulty loop logic in HdfsHAClientInvocationHandler + > HAClientInvocationHandler > --- > > Key: SENTRY-996 > URL: https://issues.apache.org/jira/browse/SENTRY-996 > Project: Sentry > Issue Type: Bug >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh > > As discussed on the review board here: https://reviews.apache.org/r/41349/ > Both the HdfsHAClientInvocationHandler + HAClientInvocationHandler contain a > while(true) loop that looks like it was designed to catch certain exceptions > + retry. However, the logic is faulty in that it will always return after the > first iteration, not matter what (as picked up by PMD). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
