[jira] [Commented] (SCB-308) Vertx transport server timeout will cause VertxServerRequestToHttpServletRequest getRemoteAddress NullPointException

2018-01-27 Thread Willem Jiang (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342409#comment-16342409
 ] 

Willem Jiang commented on SCB-308:
--

If the server connection is broken, we should not still keep the address there.

I don't think it's a good solution that you keep the address in the 
ServletRequest even the connection is broken.

> Vertx transport server timeout will cause 
> VertxServerRequestToHttpServletRequest getRemoteAddress NullPointException
> 
>
> Key: SCB-308
> URL: https://issues.apache.org/jira/browse/SCB-308
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> VertxServerRequestToHttpServletRequest use the the vertx HttpServerRequest  
> socketAddress, this will call the netty channel to get remote addtess, but 
> server has timeout, so the remote address has been released and return null. 
> so we have to bind the socketaddress to the ServletRequest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-293) trace integration test has small probability lost data.

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342407#comment-16342407
 ] 

ASF GitHub Bot commented on SCB-293:


WillemJiang commented on a change in pull request #534: SCB-293 sleep before 
quering in tracing test
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/534#discussion_r164286913
 
 

 ##
 File path: 
integration-tests/test-common/src/test/java/org/apache/servicecomb/tests/tracing/TracingTestBase.java
 ##
 @@ -75,6 +75,15 @@ protected void 
assertThatSpansReceivedByZipkin(Collection logs, String..
 .map(this::extractIds)
 .collect(Collectors.toList());
 
+// Sleep for 5 seconds to wait the reporter finish posting to zipkin 
server.
 
 Review comment:
   Using the wait and try look up span id could be a reasonable way for 
checking the async report result.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> trace integration test has small probability lost data.
> ---
>
> Key: SCB-293
> URL: https://issues.apache.org/jira/browse/SCB-293
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: Yang Bo
>Priority: Major
>
> 05:06:38,161 [ebc2a9a79ef653e3/5c77469686c84d3f/1b6b1907ad44e15d] INFO 
> [pool-2-thread-3] tracing.TracedPojoImpl (TracedPojoImpl.java:31) - in /pojo
> Jan 22, 2018 5:06:38 AM okhttp3.mockwebserver.MockWebServer$3 
> processOneRequest
> INFO: MockWebServer[32871] received request: POST /api/v2/spans HTTP/1.1 and 
> responded: HTTP/1.1 202 OK
> 05:06:39,314 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:73) - Received log: 05:06:37,269 
> [ebc2a9a79ef653e3/ebc2a9a79ef653e3/] INFO [pool-2-thread-1] 
> tracing.SomeTracedController (SomeTracedController.java:47) - in /hello
> 05:06:39,315 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:73) - Received log: 05:06:37,293 
> [ebc2a9a79ef653e3/62b00f7ba98331ac/ebc2a9a79ef653e3] INFO [pool-2-thread-1] 
> tracing.SlowRepoImpl (SlowRepoImpl.java:34) - in /crawl
> 05:06:39,315 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:73) - Received log: 05:06:37,929 
> [ebc2a9a79ef653e3/1b6b1907ad44e15d/ebc2a9a79ef653e3] INFO [pool-2-thread-2] 
> tracing.TracedJaxrsController (TracedJaxrsController.java:51) - in /bonjour
> 05:06:39,316 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:73) - Received log: 05:06:38,161 
> [ebc2a9a79ef653e3/5c77469686c84d3f/1b6b1907ad44e15d] INFO [pool-2-thread-3] 
> tracing.TracedPojoImpl (TracedPojoImpl.java:31) - in /pojo
> 05:06:39,317 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:79) - rest 
> url:http://localhost:32871/api/v2/trace/\{traceId}
> 05:06:39,322 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:84) - Received trace json: 
> [\{"traceId":"ebc2a9a79ef653e3","parentId":"ebc2a9a79ef653e3","id":"62b00f7ba98331ac","name":"crawl","timestamp":1516597597292328,"duration":24877,"localEndpoint":{"serviceName":"tracing-service","ipv4":"10.20.0.41"},"tags":\{"call.path":"public
>  abstract java.lang.String 
> org.apache.servicecomb.tests.tracing.SlowRepo.crawl() throws 
> java.lang.InterruptedException"}},\{"traceId":"ebc2a9a79ef653e3","parentId":"1b6b1907ad44e15d","id":"5c77469686c84d3f","kind":"SERVER","name":"post","timestamp":1516597598138483,"duration":27967,"localEndpoint":{"serviceName":"tracing-service","ipv4":"10.20.0.41"},"tags":\{"http.path":"/pojo"}}]
> 05:06:39,326 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:89) - Received value public abstract java.lang.String 
> org.apache.servicecomb.tests.tracing.SlowRepo.crawl() throws 
> java.lang.InterruptedException
> 05:06:39,327 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:89) - Received value /pojo
> 05:06:39,327 [//] INFO [main] tracing.TracingTestBase 
> (TracingTestBase.java:90) - values: /hello,public abstract java.lang.String 
> org.apache.servicecomb.tests.tracing.SlowRepo.crawl() throws 
> java.lang.InterruptedException,/bonjour,/pojo
> Jan 22, 2018 5:06:39 AM okhttp3.mockwebserver.MockWebServer$3 
> processOneRequest
> INFO: MockWebServer[32871] received request: GET 
> /api/v2/trace/ebc2a9a79ef653e3 HTTP/1.1 and responded: HTTP/1.1 200 OK
> Jan 22, 2018 5:06:39 AM okhttp3.mockwebserver.MockWebServer$3 
> processOneRequest
> INFO: MockWebServer[32871] received request: POST /api/v2/spans HTTP/1.1 and 
> responded: HTTP/1.1 202 OK
> Jan 22, 2018 5:06:39 AM 

[jira] [Commented] (SCB-239) [pack] omega recovery

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342404#comment-16342404
 ] 

ASF GitHub Bot commented on SCB-239:


WillemJiang commented on issue #122: SCB-239 omega stateless
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/122#issuecomment-361032105
 
 
   @eric-lee-ltk  Could you the rebase work to resolve the conflicts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] omega recovery
> -
>
> Key: SCB-239
> URL: https://issues.apache.org/jira/browse/SCB-239
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> as a user, I want to have the pending data stored persistently and be able to 
> resume the execution of these data if omega fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-305) [pack] postIntercept should throw the exception when the timeout happens

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342403#comment-16342403
 ] 

ASF GitHub Bot commented on SCB-305:


WillemJiang closed pull request #130: SCB-305 postInterceptor should throw the 
exception when the timeout happens
URL: https://github.com/apache/incubator-servicecomb-saga/pull/130
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/EventAwareInterceptor.java
 
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/EventAwareInterceptor.java
index 5f8165f5..44259496 100644
--- 
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/EventAwareInterceptor.java
+++ 
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/EventAwareInterceptor.java
@@ -35,7 +35,7 @@ public void onError(String parentTxId, String 
compensationMethod, Throwable thro
 
   AlphaResponse preIntercept(String parentTxId, String compensationMethod, 
Object... message);
 
-  void postIntercept(String parentTxId, String compensationMethod);
+  void postIntercept(String parentTxId, String compensationMethod) throws 
Throwable;
 
   void onError(String parentTxId, String compensationMethod, Throwable 
throwable);
 }
diff --git 
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptor.java
 
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptor.java
index ca145512..2057fbc5 100644
--- 
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptor.java
+++ 
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptor.java
@@ -22,6 +22,7 @@
 class TimeAwareInterceptor implements EventAwareInterceptor {
   private final EventAwareInterceptor interceptor;
   private final AtomicReference interceptorRef;
+  private Throwable throwable = null;
 
   TimeAwareInterceptor(EventAwareInterceptor interceptor) {
 this.interceptor = interceptor;
@@ -34,9 +35,11 @@ public AlphaResponse preIntercept(String parentTxId, String 
signature, Object...
   }
 
   @Override
-  public void postIntercept(String parentTxId, String signature) {
+  public void postIntercept(String parentTxId, String signature) throws 
Throwable {
 if (interceptorRef.compareAndSet(interceptor, NO_OP_INTERCEPTOR)) {
   interceptor.postIntercept(parentTxId, signature);
+} else if (throwable != null) {
+  throw throwable;
 }
   }
 
@@ -50,6 +53,7 @@ public void onError(String parentTxId, String signature, 
Throwable throwable) {
   void onTimeout(String parentTxId, String signature, Throwable throwable) {
 if (interceptorRef.compareAndSet(interceptor, NO_OP_INTERCEPTOR)) {
   interceptor.onError(parentTxId, signature, throwable);
+  this.throwable = throwable;
 }
   }
 }
diff --git 
a/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/SagaStartAspectTest.java
 
b/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/SagaStartAspectTest.java
index 7316161c..1bc2b285 100644
--- 
a/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/SagaStartAspectTest.java
+++ 
b/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/SagaStartAspectTest.java
@@ -41,6 +41,7 @@
 import org.aspectj.lang.reflect.MethodSignature;
 import org.junit.Before;
 import org.junit.Test;
+import org.junit.rules.ExpectedException;
 import org.mockito.Mockito;
 
 public class SagaStartAspectTest {
@@ -129,11 +130,12 @@ public void sendsAbortEventOnTimeout() throws Throwable {
   return null;
 });
 
+ExpectedException exception = ExpectedException.none();
 executor.execute(() -> {
   try {
 aspect.advise(joinPoint, sagaStart);
   } catch (Throwable throwable) {
-fail(throwable.getMessage());
+exception.expect(OmegaTxTimeoutException.class);
   }
 });
 
diff --git 
a/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptorTest.java
 
b/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptorTest.java
index 9ff0214c..1136a450 100644
--- 
a/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptorTest.java
+++ 
b/omega/omega-transaction/src/test/java/org/apache/servicecomb/saga/omega/transaction/TimeAwareInterceptorTest.java
@@ -32,6 +32,7 @@
 

[jira] [Commented] (SCB-314) As a SDK user, i want to set the vertx compressd mode on rest transport so that I can use ServiceComb to compresse server date

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342122#comment-16342122
 ] 

ASF GitHub Bot commented on SCB-314:


wujimin commented on issue #537: SCB-314 support custom rest transport server 
compress and max header …
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/537#issuecomment-360983463
 
 
   what's the solution for servlet rest?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to set the vertx compressd mode on rest transport so 
> that I can use ServiceComb to compresse server date
> --
>
> Key: SCB-314
> URL: https://issues.apache.org/jira/browse/SCB-314
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>  Labels: consumer
>
> vertx can set server compressed mode, some one want to use this feature and 
> set the max header size 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SCB-278) [pack] acceptance test of transaction failure and successful compensation scenario

2018-01-27 Thread Yin Xiang (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yin Xiang resolved SCB-278.
---
Resolution: Fixed

> [pack] acceptance test of transaction failure and successful compensation 
> scenario
> --
>
> Key: SCB-278
> URL: https://issues.apache.org/jira/browse/SCB-278
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Saga
>Reporter: Yin Xiang
>Assignee: Yin Xiang
>Priority: Major
> Fix For: saga-0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-315) As a SDK user, i want to custom netty dns resovl properties so that the ServiceComb has to add config support

2018-01-27 Thread jeho0815 (JIRA)
jeho0815 created SCB-315:


 Summary: As a SDK user, i want to custom netty dns resovl 
properties so that the ServiceComb has to add config support
 Key: SCB-315
 URL: https://issues.apache.org/jira/browse/SCB-315
 Project: Apache ServiceComb
  Issue Type: New Feature
  Components: Java-Chassis
Affects Versions: java-chassis-1.0.0-m1
Reporter: jeho0815
Assignee: jeho0815


Default DNS resovl use the machine config, but sometimes the application want 
to set by themselves to adapt to diffrent local or cloud enviroments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-314) As a SDK user, i want to set the vertx compressd mode on rest transport so that I can use ServiceComb to compresse server date

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342066#comment-16342066
 ] 

ASF GitHub Bot commented on SCB-314:


jeho0815 opened a new pull request #537: SCB-314 support custom rest transport 
server compress and max header …
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/537
 
 
   …size
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a SDK user, i want to set the vertx compressd mode on rest transport so 
> that I can use ServiceComb to compresse server date
> --
>
> Key: SCB-314
> URL: https://issues.apache.org/jira/browse/SCB-314
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>  Labels: consumer
>
> vertx can set server compressed mode, some one want to use this feature and 
> set the max header size 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SCB-308) Vertx transport server timeout will cause VertxServerRequestToHttpServletRequest getRemoteAddress NullPointException

2018-01-27 Thread yangyongzheng (JIRA)

 [ 
https://issues.apache.org/jira/browse/SCB-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

yangyongzheng updated SCB-308:
--
Component/s: Java-Chassis

> Vertx transport server timeout will cause 
> VertxServerRequestToHttpServletRequest getRemoteAddress NullPointException
> 
>
> Key: SCB-308
> URL: https://issues.apache.org/jira/browse/SCB-308
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> VertxServerRequestToHttpServletRequest use the the vertx HttpServerRequest  
> socketAddress, this will call the netty channel to get remote addtess, but 
> server has timeout, so the remote address has been released and return null. 
> so we have to bind the socketaddress to the ServletRequest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-314) As a SDK user, i want to set the vertx compressd mode on rest transport so that I can use ServiceComb to compresse server date

2018-01-27 Thread jeho0815 (JIRA)
jeho0815 created SCB-314:


 Summary: As a SDK user, i want to set the vertx compressd mode on 
rest transport so that I can use ServiceComb to compresse server date
 Key: SCB-314
 URL: https://issues.apache.org/jira/browse/SCB-314
 Project: Apache ServiceComb
  Issue Type: New Feature
  Components: Java-Chassis
Reporter: jeho0815
Assignee: jeho0815


vertx can set server compressed mode, some one want to use this feature and set 
the max header size 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-269) Dependency use domain-project-env level lock

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342027#comment-16342027
 ] 

ASF GitHub Bot commented on SCB-269:


codecov-io commented on issue #258: SCB-269 remove lock for dependency handle
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/258#issuecomment-360014173
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=h1)
 Report
   > Merging 
[#258](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/eaee0005a10a4e2425be145ad640a952975d7d31?src=pr=desc)
 will **increase** coverage by `0.43%`.
   > The diff coverage is `81.25%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/graphs/tree.svg?width=650=150=pr=GAaF7zrg8R)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #258  +/-   ##
   ==
   + Coverage   69.78%   70.21%   +0.43% 
   ==
 Files  17   17  
 Lines3488 3465  -23 
   ==
   - Hits 2434 2433   -1 
   + Misses885  863  -22 
 Partials  169  169
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
 | `73.04% <0%> (-1.74%)` | :arrow_down: |
   | 
[server/service/microservices.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlcy5nbw==)
 | `74.05% <100%> (+0.33%)` | :arrow_up: |
   | 
[server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv)
 | `57.16% <84.61%> (+1.82%)` | :arrow_up: |
   | 
[server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv)
 | `71.38% <0%> (+0.16%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=footer).
 Last update 
[eaee000...6fee4e8](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/258?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dependency use domain-project-env level lock
> 
>
> Key: SCB-269
> URL: https://issues.apache.org/jira/browse/SCB-269
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-269) Dependency use domain-project-env level lock

2018-01-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SCB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342026#comment-16342026
 ] 

ASF GitHub Bot commented on SCB-269:


coveralls commented on issue #258: SCB-269 remove lock for dependency handle
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/258#issuecomment-360014249
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15248448/badge)](https://coveralls.io/builds/15248448)
   
   Coverage increased (+0.5%) to 73.83% when pulling 
**6fee4e87a196a7cc7c98f4fe4050a43aa6928a0b on aseTo2016:aseTo2016** into 
**eaee0005a10a4e2425be145ad640a952975d7d31 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dependency use domain-project-env level lock
> 
>
> Key: SCB-269
> URL: https://issues.apache.org/jira/browse/SCB-269
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)