[jira] [Commented] (SCB-373) As a developer, i want to do something around serialize/deserialize, so that we should make a aspect to eanable others can do this work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392543#comment-16392543
 ] 

ASF GitHub Bot commented on SCB-373:


wujimin commented on a change in pull request #578: SCB-373 change Rest args 
code/encoding to HttpClientFilter/HttpServer…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173383434
 
 

 ##
 File path: 
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ServerRestArgsFilter.java
 ##
 @@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.common.rest.filter.inner;
+
+import org.apache.servicecomb.common.rest.RestConst;
+import org.apache.servicecomb.common.rest.codec.RestCodec;
+import org.apache.servicecomb.common.rest.codec.produce.ProduceProcessor;
+import org.apache.servicecomb.common.rest.definition.RestOperationMeta;
+import org.apache.servicecomb.common.rest.filter.HttpServerFilter;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
+import org.apache.servicecomb.foundation.vertx.stream.BufferOutputStream;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
+import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
+
+import io.netty.buffer.Unpooled;
+
+public class ServerRestArgsFilter implements HttpServerFilter {
+
+  @Override
+  public int getOrder() {
+return -100;
+  }
+
+  @Override
+  public Response afterReceiveRequest(Invocation invocation, 
HttpServletRequestEx requestEx) {
+RestOperationMeta restOperationMeta = (RestOperationMeta) requestEx
+.getAttribute(RestConst.OPERATION_PARAMETERS);
+Object[] args = RestCodec.restToArgs(requestEx, restOperationMeta);
+invocation.setSwaggerArguments(args);
+return null;
+  }
+
+  @Override
+  public void beforeSendResponse(Invocation invocation, HttpServletResponseEx 
responseEx) {
+Response response = (Response) 
invocation.getHandlerContext().get(RestConst.INVOCATION_HANDLER_RESPONSE);
+ProduceProcessor produceProcessor = (ProduceProcessor) 
invocation.getHandlerContext()
+.get(RestConst.INVOCATION_HANDLER_PROCESSOR);
+Object body = response.getResult();
+if (response.isFailed()) {
+  body = ((InvocationException) body).getErrorData();
+}
+
+try (BufferOutputStream output = new 
BufferOutputStream(Unpooled.compositeBuffer())) {
+  produceProcessor.encodeResponse(output, body);
+
+  responseEx.setBodyBuffer(output.getBuffer());
+} catch (Exception e) {
 
 Review comment:
   it's better to catch throwable


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a developer, i want to do something around serialize/deserialize, so that 
> we should make a  aspect to eanable others can do this work
> 
>
> Key: SCB-373
> URL: https://issues.apache.org/jira/browse/SCB-373
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> somebody want to use Jackson StdDeserializer/StdSerializer to encode or 
> decode paramters， but the method can't send any parameters into it. So we can 
> only  use ThreadLocal to transfer. To support this, we may move RestCodec to 
> HttpServerFilter，other guys can do some work in their own Filters before this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-352) Support operation level flow control on provider side

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392534#comment-16392534
 ] 

ASF GitHub Bot commented on SCB-352:


coveralls commented on issue #577: [SCB-352] refactor QpsControllerManager, 
support operation level qps controll on provider side
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#issuecomment-371106161
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15889527/badge)](https://coveralls.io/builds/15889527)
   
   Coverage increased (+0.05%) to 87.235% when pulling 
**f0a54d32f6e639ef19d08964d069eacb8a60e794 on 
yhs0092:support_provider_operation_level_flow_control** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support operation level flow control on provider side
> -
>
> Key: SCB-352
> URL: https://issues.apache.org/jira/browse/SCB-352
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
> Attachments: compile_warning.PNG, compile_warning2.PNG
>
>
> At present our provider qps flow control only support microservice level.
> We need to support schema/operation level qps flow control like consumer side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-352) Support operation level flow control on provider side

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392514#comment-16392514
 ] 

ASF GitHub Bot commented on SCB-352:


yhs0092 commented on a change in pull request #577: [SCB-352] refactor 
QpsControllerManager, support operation level qps controll on provider side
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#discussion_r173378612
 
 

 ##
 File path: 
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
 ##
 @@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.qps;
+
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.regex.Pattern;
+
+import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.netflix.config.DynamicProperty;
+
+public class QpsControllerManager {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(QpsControllerManager.class);
+
+  private static final Pattern QUALIFIED_KEY_CHECKER = 
Pattern.compile("^[^.]+\\.[^.]+\\.[^.]+$");
+
+  /**
+   * Describe the relationship between configuration and qpsController.
+   */
+  protected final Map configQpsControllerMap = new 
ConcurrentHashMapEx<>();
+
+  /**
+   * Describe the relationship between qualifiedKey(format is 
"microservice.schema.operation") and qpsController.
+   */
+  protected final Map qualifiedNameControllerMap = new 
ConcurrentHashMapEx<>();
+
+  protected QpsController globalQpsController;
+
+  public static final String SEPARATOR = ".";
+
+  private String configKeyPrefix;
+
+  public QpsController getOrCreate(String key) {
+return qualifiedNameControllerMap.computeIfAbsent(key, this::create);
+  }
+
+  /**
+   * Create relevant qpsLimit dynamicProperty and watch the configuration 
change.
+   * Search and return a valid qpsController.
+   */
+  protected QpsController create(String qualifiedNameKey) {
+if (!QUALIFIED_KEY_CHECKER.matcher(qualifiedNameKey).matches()) {
+  throw new IllegalArgumentException("Unexpected qualified name: [" + 
qualifiedNameKey + "]");
+}
+// create "microservice"
+createQpsControllerIfNotExist(qualifiedNameKey.substring(0, 
qualifiedNameKey.indexOf(SEPARATOR)));
+// create "microservice.schema"
+createQpsControllerIfNotExist(qualifiedNameKey.substring(0, 
qualifiedNameKey.lastIndexOf(SEPARATOR)));
 
 Review comment:
   OK. I will add naming convention instructions in gitbook later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support operation level flow control on provider side
> -
>
> Key: SCB-352
> URL: https://issues.apache.org/jira/browse/SCB-352
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
> Attachments: compile_warning.PNG, compile_warning2.PNG
>
>
> At present our provider qps flow control only support microservice level.
> We need to support schema/operation level qps flow control like consumer side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392486#comment-16392486
 ] 

ASF GitHub Bot commented on SCB-29:
---

liubao68 commented on issue #579: [SCB-29] add README document for config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371726422
 
 
   The referenced manual still use io.servicecomb package， please changed it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-378) Add readme for samples so that users can run the samples code by just reading the readme doc

[Bo Li (JIRA)]

Bo Li created SCB-378:
-

 Summary: Add readme for samples so that users can run the samples 
code by just reading the readme doc
 Key: SCB-378
 URL: https://issues.apache.org/jira/browse/SCB-378
 Project: Apache ServiceComb
  Issue Type: Task
Reporter: Bo Li






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-210) Use map feature to design microservice yaml file to support control flag of config center

[Bo Li (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bo Li resolved SCB-210.
---
Resolution: Resolved

> Use map feature to design microservice yaml file to support control flag of 
> config center
> -
>
> Key: SCB-210
> URL: https://issues.apache.org/jira/browse/SCB-210
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
>
> check comment of wujimin at:
> https://github.com/apache/incubator-servicecomb-java-chassis/pull/489/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-6) ServiceComb Java Chassis Metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392413#comment-16392413
 ] 

ASF GitHub Bot commented on SCB-6:
--

coveralls commented on issue #580: [SCB-6] add metrics samples readme
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/580#issuecomment-371715156
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15888401/badge)](https://coveralls.io/builds/15888401)
   
   Coverage increased (+0.006%) to 87.189% when pulling 
**c44586f8514e9fb101f918f5d5fdb3865ad1ae48 on zhengyangyong:SCB-6-SampleDoc** 
into **e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ServiceComb Java Chassis Metrics
> 
>
> Key: SCB-6
> URL: https://issues.apache.org/jira/browse/SCB-6
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> As a microservice framework,servicecomb java chassis need support user 
> collect metrics such as tps,latency and system resource usage etc,then use 
> this collected data making some policy like scaling strategy further.
> The relation between Java Chassis and Java Chassis Metrics is similar to 
> Spring boot and Spring boot actuator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-6) ServiceComb Java Chassis Metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392399#comment-16392399
 ] 

ASF GitHub Bot commented on SCB-6:
--

zhengyangyong opened a new pull request #580: [SCB-6] add metrics samples readme
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/580
 
 
   Signed-off-by: zhengyangyong 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Add README.md for metrics health check sample and write metrics to file 
sample


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ServiceComb Java Chassis Metrics
> 
>
> Key: SCB-6
> URL: https://issues.apache.org/jira/browse/SCB-6
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> As a microservice framework,servicecomb java chassis need support user 
> collect metrics such as tps,latency and system resource usage etc,then use 
> this collected data making some policy like scaling strategy further.
> The relation between Java Chassis and Java Chassis Metrics is similar to 
> Spring boot and Spring boot actuator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-330) [pack] update documents of saga pack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392367#comment-16392367
 ] 

ASF GitHub Bot commented on SCB-330:


coveralls commented on issue #147: SCB-330 add guides to run executable alpha 
server
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/147#issuecomment-371706466
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887904/badge)](https://coveralls.io/builds/15887904)
   
   Coverage decreased (-0.4%) to 94.956% when pulling 
**86c953587d50ad13dc5b9d2162f616a43c7a2b1a on eric-lee-ltk:SCB-330** into 
**71187019021f42a2c8fd7f332edee1e456caa64c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] update documents of saga pack
> 
>
> Key: SCB-330
> URL: https://issues.apache.org/jira/browse/SCB-330
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> As a dev, I want to know how to use the Saga's new architecture pack. 
> Documents including README and quick start should contain details of its 
> usages, features and architecture.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392326#comment-16392326
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887521/badge)](https://coveralls.io/builds/15887521)
   
   Coverage decreased (-0.02%) to 87.166% when pulling 
**8d7cceeb51f446b418555ad0527a5166864a0ad9 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392319#comment-16392319
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887469/badge)](https://coveralls.io/builds/15887469)
   
   Coverage increased (+0.006%) to 87.189% when pulling 
**8d7cceeb51f446b418555ad0527a5166864a0ad9 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-330) [pack] update documents of saga pack

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392311#comment-16392311
 ] 

ASF GitHub Bot commented on SCB-330:


eric-lee-ltk opened a new pull request #147: SCB-330 add guides to run 
executable alpha server
URL: https://github.com/apache/incubator-servicecomb-saga/pull/147
 
 
   Signed-off-by: Eric Lee 
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [pack] update documents of saga pack
> 
>
> Key: SCB-330
> URL: https://issues.apache.org/jira/browse/SCB-330
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Eric Lee
>Assignee: Eric Lee
>Priority: Major
> Fix For: saga-0.1.0
>
>
> As a dev, I want to know how to use the Saga's new architecture pack. 
> Documents including README and quick start should contain details of its 
> usages, features and architecture.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392284#comment-16392284
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887129/badge)](https://coveralls.io/builds/15887129)
   
   Coverage remained the same at 87.183% when pulling 
**0f0dcb96261b58e93e76df52462ef78e29338145 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392279#comment-16392279
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887105/badge)](https://coveralls.io/builds/15887105)
   
   Coverage remained the same at 87.183% when pulling 
**0f0dcb96261b58e93e76df52462ef78e29338145 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-374) invocation publish life event

[wujimin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin updated SCB-374:

Summary: invocation publish life event  (was: collect invocation metrics)

> invocation publish life event
> -
>
> Key: SCB-374
> URL: https://issues.apache.org/jira/browse/SCB-374
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392276#comment-16392276
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887093/badge)](https://coveralls.io/builds/15887093)
   
   Coverage increased (+0.02%) to 87.206% when pulling 
**0f0dcb96261b58e93e76df52462ef78e29338145 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-29) Dynamic Configuration

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392274#comment-16392274
 ] 

ASF GitHub Bot commented on SCB-29:
---

coveralls commented on issue #579: [SCB-29] add README document for 
config-apollo
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/579#issuecomment-371690649
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15887078/badge)](https://coveralls.io/builds/15887078)
   
   Coverage decreased (-0.02%) to 87.166% when pulling 
**0f0dcb96261b58e93e76df52462ef78e29338145 on lijasonvip:config-doc** into 
**e1137b4002659d3a7e482d3ed4b7a6f226054798 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Dynamic Configuration
> -
>
> Key: SCB-29
> URL: https://issues.apache.org/jira/browse/SCB-29
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: mabin
>Priority: Major
>
> as a user, i want to update my microservice configurations from a centralized 
> server, so that i don't have restart and re-deploy each of my services.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-364) Prepare 1.0.0-m1 Release for Java-Chassis

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-364.
--
Resolution: Fixed

The patch was merged into master branch.

> Prepare 1.0.0-m1 Release for Java-Chassis
> -
>
> Key: SCB-364
> URL: https://issues.apache.org/jira/browse/SCB-364
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-372) support user set prometheus exporter address not only port

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-372:
-
Affects Version/s: (was: java-chassis-1.0.0-m1)

> support user set prometheus exporter address not only port
> --
>
> Key: SCB-372
> URL: https://issues.apache.org/jira/browse/SCB-372
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current user only can set metrics prometheus exporter port like :
> servicecomb.metrics.prometheus.port= 9696
> we may support user set full address like cse transport :
> servicecomb.metrics.prometheus.address= 0.0.0.0:9696
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-372) support user set prometheus exporter address not only port

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-372:
-
Fix Version/s: (was: java-chassis-1.0.0-m2)
   java-chassis-1.0.0-m1

> support user set prometheus exporter address not only port
> --
>
> Key: SCB-372
> URL: https://issues.apache.org/jira/browse/SCB-372
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current user only can set metrics prometheus exporter port like :
> servicecomb.metrics.prometheus.port= 9696
> we may support user set full address like cse transport :
> servicecomb.metrics.prometheus.address= 0.0.0.0:9696
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-324) Chassis must support network failure simulation, so that I can developers can enhance the robustness of the app

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-324:
-
Fix Version/s: (was: java-chassis-1.0.0-m1)
   java-chassis-1.0.0-m2

> Chassis must support network failure simulation, so that I can developers can 
> enhance the robustness of the app
> ---
>
> Key: SCB-324
> URL: https://issues.apache.org/jira/browse/SCB-324
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: sukesh
>Assignee: sukesh
>Priority: Minor
> Fix For: java-chassis-1.0.0-m2
>
>
> Add new handler for fault injection.
> 1) If handler 'fault-injection' is added in application property 
> file(microservice.yaml) then fault-injection handler should include in 
> handler chain.
> 2) When handler is called read the configuration and listen the configuration 
> event related to fault inject. The sample configuration file is in next slide.
> 3) The configuration mainly consist
>     -delay
>     -abort
>  *delay:*can set the delay for requests based on percentage configured. The 
> unit is ms. The delay percentage default value is 100%
>  *abort*: Abort the requests based on percentage configured. For rest 
> transport protocol error code can be configurable(500, 421) and highway 
> protocol does not support for error return. The abort percentage default 
> value is 100%
> 4) This features currently supports at consumer side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-370) Metrics timer (like latency) output precision must to nano level not milli level

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-370:
-
Fix Version/s: (was: java-chassis-1.0.0-m1)
   java-chassis-1.0.0-m2

> Metrics timer (like latency) output precision must to nano level not milli 
> level
> 
>
> Key: SCB-370
> URL: https://issues.apache.org/jira/browse/SCB-370
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> current metrics latency default unit is MILLISECONDS and low than 1 
> milliseconds like 0.5 will return 0,we need support higher accuracy and keep 
> value after the decimal point



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-372) support user set prometheus exporter address not only port

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-372:
-
Fix Version/s: (was: java-chassis-1.0.0-m1)
   java-chassis-1.0.0-m2

> support user set prometheus exporter address not only port
> --
>
> Key: SCB-372
> URL: https://issues.apache.org/jira/browse/SCB-372
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> current user only can set metrics prometheus exporter port like :
> servicecomb.metrics.prometheus.port= 9696
> we may support user set full address like cse transport :
> servicecomb.metrics.prometheus.address= 0.0.0.0:9696
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-350) Vertx ssl file config error execption approvement

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-350:
-
Fix Version/s: (was: java-chassis-1.0.0-m1)
   java-chassis-1.0.0-m2

> Vertx ssl file config error execption approvement
> -
>
> Key: SCB-350
> URL: https://issues.apache.org/jira/browse/SCB-350
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> if use a custom ssl DemoSSLCustom, in the class we give a error cert file 
> path, the server will hange up and not show any help message, developer are 
> confused! 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-372) support user set prometheus exporter address not only port

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-372.
--
Resolution: Fixed

This PR was merged into master branch.

> support user set prometheus exporter address not only port
> --
>
> Key: SCB-372
> URL: https://issues.apache.org/jira/browse/SCB-372
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current user only can set metrics prometheus exporter port like :
> servicecomb.metrics.prometheus.port= 9696
> we may support user set full address like cse transport :
> servicecomb.metrics.prometheus.address= 0.0.0.0:9696
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-252) Metrics support overwatch Integration

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-252:
-
Fix Version/s: (was: java-chassis-1.0.0-m1)
   java-chassis-1.0.0-m2

> Metrics support overwatch Integration
> -
>
> Key: SCB-252
> URL: https://issues.apache.org/jira/browse/SCB-252
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Minor
> Fix For: java-chassis-1.0.0-m2
>
>
> [Overwatch]([https://github.com/imdada/overwatch)] has a nice UI and very 
> suitable for show our ability，we can push metrics data to it in order to do 
> integration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-355) As a operator, when sdk config a fault ak/sk on HuaweiCloud, then will auth token fail, but it continues to register, will cause may fault in server

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-355:
-
Fix Version/s: java-chassis-1.0.0-m2

> As a operator, when sdk config a fault ak/sk on HuaweiCloud, then will auth 
> token fail, but it continues to register, will cause may fault in server
> 
>
> Key: SCB-355
> URL: https://issues.apache.org/jira/browse/SCB-355
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> service center/ config center auth failed, then do not call remote service 
> again, give a error log to user



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-346) Create the distribution kit for Saga

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-346.
--
Resolution: Fixed

Merged those PRs into master branch.

> Create the distribution kit for Saga
> 
>
> Key: SCB-346
> URL: https://issues.apache.org/jira/browse/SCB-346
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Saga
>Affects Versions: saga-0.1.0
>Reporter: Willem Jiang
>Assignee: Yang Bo
>Priority: Major
> Fix For: saga-0.1.0
>
>
> We need to create a binary distribution file which has all the jars file and 
> third party dependencies jars and demos.
> Current we need to wrap the pack components into the release kit and keep the 
> old saga module out of the release kit.
> For the Alpha server, we can pack the exec jar into the binary distribution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-360) make guava eventbus simpler and faster

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-360:
-
Fix Version/s: java-chassis-1.0.0-m2

> make guava eventbus simpler and faster
> --
>
> Key: SCB-360
> URL: https://issues.apache.org/jira/browse/SCB-360
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-359) metrics optimize

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-359:
-
Fix Version/s: java-chassis-1.0.0-m2

> metrics optimize
> 
>
> Key: SCB-359
> URL: https://issues.apache.org/jira/browse/SCB-359
> Project: Apache ServiceComb
>  Issue Type: Task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-369) support extract publish information from spectator measurement

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-369:
-
Fix Version/s: java-chassis-1.0.0-m2

> support extract publish information from spectator measurement
> --
>
> Key: SCB-369
> URL: https://issues.apache.org/jira/browse/SCB-369
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-374) collect invocation metrics

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-374:
-
Fix Version/s: java-chassis-1.0.0-m2

> collect invocation metrics
> --
>
> Key: SCB-374
> URL: https://issues.apache.org/jira/browse/SCB-374
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SCB-368) ServiceComb supports openssl engine for ssl communication

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang resolved SCB-368.
--
Resolution: Fixed

The PR was merged into master branch.

> ServiceComb supports openssl engine for ssl communication
> -
>
> Key: SCB-368
> URL: https://issues.apache.org/jira/browse/SCB-368
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: sukesh
>Assignee: sukesh
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> netty-tcnative provides openssl support for ssl communication which is easy 
> to integrate and offers better performance. ServiceComb should support new 
> configuration(microservice.yaml) item to select the ssl engine as below
> ssl.engine: openssl
> Default value : jdk



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-368) ServiceComb supports openssl engine for ssl communication

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-368:
-
Fix Version/s: (was: java-chassis-1.0.0-m2)
   java-chassis-1.0.0-m1

> ServiceComb supports openssl engine for ssl communication
> -
>
> Key: SCB-368
> URL: https://issues.apache.org/jira/browse/SCB-368
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Java-Chassis
>Reporter: sukesh
>Assignee: sukesh
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> netty-tcnative provides openssl support for ssl communication which is easy 
> to integrate and offers better performance. ServiceComb should support new 
> configuration(microservice.yaml) item to select the ssl engine as below
> ssl.engine: openssl
> Default value : jdk



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-352) Support operation level flow control on provider side

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-352:
-
Fix Version/s: java-chassis-1.0.0-m2

> Support operation level flow control on provider side
> -
>
> Key: SCB-352
> URL: https://issues.apache.org/jira/browse/SCB-352
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
> Attachments: compile_warning.PNG, compile_warning2.PNG
>
>
> At present our provider qps flow control only support microservice level.
> We need to support schema/operation level qps flow control like consumer side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SCB-373) As a developer, i want to do something around serialize/deserialize, so that we should make a aspect to eanable others can do this work

[Willem Jiang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SCB-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-373:
-
Fix Version/s: (was: Java-chassis-1.0.0)
   java-chassis-1.0.0-m2

> As a developer, i want to do something around serialize/deserialize, so that 
> we should make a  aspect to eanable others can do this work
> 
>
> Key: SCB-373
> URL: https://issues.apache.org/jira/browse/SCB-373
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> somebody want to use Jackson StdDeserializer/StdSerializer to encode or 
> decode paramters， but the method can't send any parameters into it. So we can 
> only  use ThreadLocal to transfer. To support this, we may move RestCodec to 
> HttpServerFilter，other guys can do some work in their own Filters before this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-373) As a developer, i want to do something around serialize/deserialize, so that we should make a aspect to eanable others can do this work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391256#comment-16391256
 ] 

ASF GitHub Bot commented on SCB-373:


coveralls commented on issue #578: SCB-373 change Rest args code/encoding to 
HttpClientFilter/HttpServer…
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#issuecomment-371492044
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15874053/badge)](https://coveralls.io/builds/15874053)
   
   Coverage increased (+0.04%) to 87.21% when pulling 
**5e52d4ac295009b3e83354a0f25e9db59e23beca on hwcse:SCB-373** into 
**c3010365254b64d344694277f777c43f5b02116c on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a developer, i want to do something around serialize/deserialize, so that 
> we should make a  aspect to eanable others can do this work
> 
>
> Key: SCB-373
> URL: https://issues.apache.org/jira/browse/SCB-373
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: Java-chassis-1.0.0
>
>
> somebody want to use Jackson StdDeserializer/StdSerializer to encode or 
> decode paramters， but the method can't send any parameters into it. So we can 
> only  use ThreadLocal to transfer. To support this, we may move RestCodec to 
> HttpServerFilter，other guys can do some work in their own Filters before this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-373) As a developer, i want to do something around serialize/deserialize, so that we should make a aspect to eanable others can do this work

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391165#comment-16391165
 ] 

ASF GitHub Bot commented on SCB-373:


jeho0815 opened a new pull request #578: SCB-373 change Rest args code/encoding 
to HttpClientFilter/HttpServer…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/578
 
 
   …Filter，so some body can do something through writing other Filters around 
args coding
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> As a developer, i want to do something around serialize/deserialize, so that 
> we should make a  aspect to eanable others can do this work
> 
>
> Key: SCB-373
> URL: https://issues.apache.org/jira/browse/SCB-373
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: Java-chassis-1.0.0
>
>
> somebody want to use Jackson StdDeserializer/StdSerializer to encode or 
> decode paramters， but the method can't send any parameters into it. So we can 
> only  use ThreadLocal to transfer. To support this, we may move RestCodec to 
> HttpServerFilter，other guys can do some work in their own Filters before this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-352) Support operation level flow control on provider side

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390981#comment-16390981
 ] 

ASF GitHub Bot commented on SCB-352:


liubao68 commented on a change in pull request #577: [SCB-352] refactor 
QpsControllerManager, support operation level qps controll on provider side
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/577#discussion_r173107595
 
 

 ##
 File path: 
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsControllerManager.java
 ##
 @@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.qps;
+
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.regex.Pattern;
+
+import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.netflix.config.DynamicProperty;
+
+public class QpsControllerManager {
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(QpsControllerManager.class);
+
+  private static final Pattern QUALIFIED_KEY_CHECKER = 
Pattern.compile("^[^.]+\\.[^.]+\\.[^.]+$");
+
+  /**
+   * Describe the relationship between configuration and qpsController.
+   */
+  protected final Map configQpsControllerMap = new 
ConcurrentHashMapEx<>();
+
+  /**
+   * Describe the relationship between qualifiedKey(format is 
"microservice.schema.operation") and qpsController.
+   */
+  protected final Map qualifiedNameControllerMap = new 
ConcurrentHashMapEx<>();
+
+  protected QpsController globalQpsController;
+
+  public static final String SEPARATOR = ".";
+
+  private String configKeyPrefix;
+
+  public QpsController getOrCreate(String key) {
+return qualifiedNameControllerMap.computeIfAbsent(key, this::create);
+  }
+
+  /**
+   * Create relevant qpsLimit dynamicProperty and watch the configuration 
change.
+   * Search and return a valid qpsController.
+   */
+  protected QpsController create(String qualifiedNameKey) {
+if (!QUALIFIED_KEY_CHECKER.matcher(qualifiedNameKey).matches()) {
+  throw new IllegalArgumentException("Unexpected qualified name: [" + 
qualifiedNameKey + "]");
+}
+// create "microservice"
+createQpsControllerIfNotExist(qualifiedNameKey.substring(0, 
qualifiedNameKey.indexOf(SEPARATOR)));
+// create "microservice.schema"
+createQpsControllerIfNotExist(qualifiedNameKey.substring(0, 
qualifiedNameKey.lastIndexOf(SEPARATOR)));
 
 Review comment:
   We need to add naming conventions to docs of service name, schema and 
operation 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support operation level flow control on provider side
> -
>
> Key: SCB-352
> URL: https://issues.apache.org/jira/browse/SCB-352
> Project: Apache ServiceComb
>  Issue Type: Task
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Attachments: compile_warning.PNG, compile_warning2.PNG
>
>
> At present our provider qps flow control only support microservice level.
> We need to support schema/operation level qps flow control like consumer side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-370) Metrics timer (like latency) output precision must to nano level not milli level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390973#comment-16390973
 ] 

ASF GitHub Bot commented on SCB-370:


yangbor commented on a change in pull request #572: [SCB-370] Improve latency 
and max precision
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/572#discussion_r173105633
 
 

 ##
 File path: 
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsUtils.java
 ##
 @@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.core;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.SortedMap;
+import java.util.TreeMap;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Function;
+
+import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.metrics.MetricsConst;
+
+import com.netflix.servo.monitor.MonitorConfig;
+import com.netflix.servo.tag.Tag;
+import com.netflix.servo.tag.TagList;
+import com.netflix.servo.tag.Tags;
+
+public class MetricsUtils {
 
 Review comment:
   XXXUtils suggests a bad design, later developers may put any unrelated 
things into this class.
   Move the getMonitorKey to MonitorManager and rename this class to 
MeasurementConversion or something suitable.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Metrics timer (like latency) output precision must to nano level not milli 
> level
> 
>
> Key: SCB-370
> URL: https://issues.apache.org/jira/browse/SCB-370
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current metrics latency default unit is MILLISECONDS and low than 1 
> milliseconds like 0.5 will return 0,we need support higher accuracy and keep 
> value after the decimal point



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-370) Metrics timer (like latency) output precision must to nano level not milli level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390968#comment-16390968
 ] 

ASF GitHub Bot commented on SCB-370:


yangbor commented on a change in pull request #572: [SCB-370] Improve latency 
and max precision
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/572#discussion_r173104487
 
 

 ##
 File path: 
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/MetricsUtils.java
 ##
 @@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.metrics.core;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.SortedMap;
+import java.util.TreeMap;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Function;
+
+import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
+import org.apache.servicecomb.foundation.metrics.MetricsConst;
+
+import com.netflix.servo.monitor.MonitorConfig;
+import com.netflix.servo.tag.Tag;
+import com.netflix.servo.tag.TagList;
+import com.netflix.servo.tag.Tags;
+
+public class MetricsUtils {
+
+  private static Map> convertFunctions;
+
+  static {
+//don't use TimeUnit convert method because it will return long and lost 
decimal part
+convertFunctions = new HashMap<>();
+convertFunctions.put(TimeUnit.NANOSECONDS, value -> value);
+convertFunctions.put(TimeUnit.MICROSECONDS, value -> value * 0.001);
+convertFunctions.put(TimeUnit.MILLISECONDS, value -> value * 0.001 * 
0.001);
+convertFunctions.put(TimeUnit.SECONDS, value -> value * 0.001 * 0.001 * 
0.001);
+  }
+
+  public static Map convertMeasurements(Map measurements, TimeUnit unit) {
+if (validateTimeUnit(unit)) {
+  Map metrics = new HashMap<>();
+  for (Entry measurement : measurements.entrySet()) 
{
+if (measurement.getKey().getTags().containsKey(MetricsConst.TAG_UNIT)) 
{
+  metrics.put(getMonitorKey(
+  
measurement.getKey().withAdditionalTag(Tags.newTag(MetricsConst.TAG_UNIT, 
String.valueOf(unit,
+  convertFunctions.get(unit).apply(measurement.getValue()));
+} else {
+  metrics.put(getMonitorKey(measurement.getKey()), 
measurement.getValue());
+}
+  }
+  return metrics;
+}
+//no need support MINUTES,HOURS,DAYS because latency under this unit is 
unsuitable
+throw new ServiceCombException(
+"illegal unit : " + String.valueOf(unit) + ", only support 
NANOSECONDS,MICROSECONDS,MILLISECONDS and SECONDS");
 
 Review comment:
   Metrics calculated in minutes or even hours is normal, we should support at 
least to hours.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Metrics timer (like latency) output precision must to nano level not milli 
> level
> 
>
> Key: SCB-370
> URL: https://issues.apache.org/jira/browse/SCB-370
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> current metrics latency default unit is MILLISECONDS and low than 1 
> milliseconds like 0.5 will return 0,we need support higher accuracy and keep 
> value after the decimal point



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390957#comment-16390957
 ] 

ASF GitHub Bot commented on SCB-317:


little-cui closed pull request #300: SCB-317 Merge frontend conf to app.conf 
and fix shebang line issue in sh files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 57d0464a..596b2bc7 100644
--- a/README.md
+++ b/README.md
@@ -17,6 +17,12 @@ Apache ServiceComb (incubating) service-center allows 
services to register their
  - **Metrics**: Able to expose Prometheus metric API automatically
  - **Tracing**: Able to report tracing data to Zipkin server
  
+## Documentation
+
+Project documentation is available on the [ServiceComb 
website][servicecomb-website]. You can also find some development guide 
[here](/docs).
+
+[servicecomb-website]: http://servicecomb.incubator.apache.org/
+
 ## Quick Start
 
 ### Getting Service Center
@@ -68,7 +74,6 @@ httpaddr = 127.0.0.1
 httpport = 30100
 ```
 
-
 ### Building & Running Service-Center from source
 
 Download the Code
@@ -108,11 +113,30 @@ This will bring up Service Center listening on ip/port 
127.0.0.1:30100 for servi
 
 [github-release]: https://github.com/servicecomb/service-center/releases/
 
-## Documentation
+### Running Frontend using the Release
+
+You can download our latest release from ServiceComb Website and then untar it 
and run start-frontend.sh/start-frontend.bat.
+This will bring up the Service-Center UI on 
[http://127.0.0.1:30103](http://127.0.0.1:30103).
+
+Windows(apache-incubator-servicecomb-service-center-XXX-windows-amd64.zip):
+```
+start-frontend.bat
+```
+
+Linux(apache-incubator-servicecomb-service-center--linux-amd64.tar.gz):
+```sh
+./start-frontend.sh
+```
+
+Note: By default frontend runs on 127.0.0.1, if you want to change this then 
you can change it in `conf/app.conf`. 
+```
+frontend_host_ip=127.0.0.1
+frontend_host_port=30103
+```
+You can also change the the IP of Service-Center to which Frontend is 
connected over here  `app/apiList/apiList.js`
 
-Project documentation is available on the [ServiceComb 
website][servicecomb-website]. You can also find some development guide 
[here](/docs)
 
-[servicecomb-website]: http://servicecomb.io/
+You can follow the guide over 
[here](frontend/Readme.md#running-ui-from-source-code) to run the Frontend from 
source.
   
 ## Contact
 
diff --git a/docs/release/rat-report/Rat-Report-2018-03-08.md 
b/docs/release/rat-report/Rat-Report-2018-03-08.md
new file mode 100644
index ..d26e69f9
--- /dev/null
+++ b/docs/release/rat-report/Rat-Report-2018-03-08.md
@@ -0,0 +1,280 @@
+```
+root@SZX1000272432:~/apache# java -jar apache-rat-0.12.jar -a -d 
incubator-servicecomb-service-center/ -e *.md *.MD .gitignore .gitmodules 
.travis.yml *.json *.yaml *.tmpl *.conf *.html *.pb.go services.proto  
broker.proto manifest **vendor** **licenses**
+
+*
+Summary
+---
+Generated at: 2018-03-08T16:38:30+08:00
+
+Notes: 5
+Binaries: 9
+Archives: 0
+Standards: 237
+
+Apache Licensed: 237
+Generated Documents: 0
+
+JavaDocs are generated, thus a license header is optional.
+Generated files do not require license headers.
+
+0 Unknown Licenses
+
+*
+  Files with Apache License headers will be marked AL
+  Binary files (which do not require any license headers) will be marked B
+  Compressed archives will be marked A
+  Notices, licenses etc. will be marked N
+  N incubator-servicecomb-service-center/DISCLAIMER
+  N incubator-servicecomb-service-center/LICENSE
+  N incubator-servicecomb-service-center/NOTICE
+  ALincubator-servicecomb-service-center/main.go
+  B incubator-servicecomb-service-center/docs/Service-Center-UI-Preview.gif
+  B incubator-servicecomb-service-center/docs/communication.PNG
+  B incubator-servicecomb-service-center/docs/onStartup.PNG
+  B incubator-servicecomb-service-center/docs/tracing-file.PNG
+  B incubator-servicecomb-service-center/docs/tracing-server.PNG
+  AL
incubator-servicecomb-service-center/examples/service_center/request/add_dependecy.sh
+  AL
incubator-servicecomb-service-center/examples/service_center/request/create_service.sh
+  AL
incubator-servicecomb-service-center/examples/service_center/request/delete_instance.sh
+  AL
incubator-servicecomb-service-center/examples/service_center/request/delete_service.sh
+  AL
incubator-servicecomb-service-center/examples/service_center/request/get_consumers.sh
+  AL

[jira] [Commented] (SCB-210) Use map feature to design microservice yaml file to support control flag of config center

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390952#comment-16390952
 ] 

ASF GitHub Bot commented on SCB-210:


lijasonvip opened a new pull request #41: [SCB-210] update document for apollo 
configuration item
URL: https://github.com/apache/incubator-servicecomb-website/pull/41
 
 
   Signed-off-by: lijasonvip 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use map feature to design microservice yaml file to support control flag of 
> config center
> -
>
> Key: SCB-210
> URL: https://issues.apache.org/jira/browse/SCB-210
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: Bo Li
>Assignee: Bo Li
>Priority: Major
>
> check comment of wujimin at:
> https://github.com/apache/incubator-servicecomb-java-chassis/pull/489/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390948#comment-16390948
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and 
fix shebang line issue in sh files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422212
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15870271/badge)](https://coveralls.io/builds/15870271)
   
   Coverage decreased (-0.05%) to 74.01% when pulling 
**e3f43d679059139a3cdc410bea4a800da2897c03 on asifdxtreme:master** into 
**cb48d5b1a84bfae3b111a34955664e30cb4b9f3f on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390934#comment-16390934
 ] 

ASF GitHub Bot commented on SCB-317:


coveralls commented on issue #300: SCB-317 Merge frontend conf to app.conf and 
fix shebang line issue in sh files
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/300#issuecomment-371422212
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15870098/badge)](https://coveralls.io/builds/15870098)
   
   Coverage remained the same at 74.063% when pulling 
**704e035c9b395fae8eb3d16ef46ed1f6247b14a1 on asifdxtreme:master** into 
**cb48d5b1a84bfae3b111a34955664e30cb4b9f3f on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-372) support user set prometheus exporter address not only port

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390929#comment-16390929
 ] 

ASF GitHub Bot commented on SCB-372:


WillemJiang closed pull request #574: [SCB-372] support user set metrics 
prometheus exporter address not only port
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/574
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsHttpPublisher.java
 
b/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsHttpPublisher.java
index 718746766..d2ea6de36 100644
--- 
a/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsHttpPublisher.java
+++ 
b/metrics/metrics-integration/metrics-prometheus/src/main/java/org/apache/servicecomb/metrics/prometheus/MetricsHttpPublisher.java
@@ -17,7 +17,6 @@
 
 package org.apache.servicecomb.metrics.prometheus;
 
-import java.io.IOException;
 import java.net.InetSocketAddress;
 
 import 
org.apache.servicecomb.foundation.common.exceptions.ServiceCombException;
@@ -37,21 +36,38 @@
 public class MetricsHttpPublisher implements 
ApplicationListener {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(MetricsHttpPublisher.class);
 
-  private static final String METRICS_PROMETHEUS_PORT = 
"servicecomb.metrics.prometheus.port";
+  private static final String METRICS_PROMETHEUS_ADDRESS = 
"servicecomb.metrics.prometheus.address";
 
   private HTTPServer httpServer;
 
   public MetricsHttpPublisher() {
 //prometheus default port allocation is here : 
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
-int publishPort = 
DynamicPropertyFactory.getInstance().getIntProperty(METRICS_PROMETHEUS_PORT, 
9696).get();
-MetricsCollector metricsCollector = new MetricsCollector();
-metricsCollector.register();
+this.init(
+
DynamicPropertyFactory.getInstance().getStringProperty(METRICS_PROMETHEUS_ADDRESS,
 "0.0.0.0:9696").get());
+  }
+
+  public MetricsHttpPublisher(String address) {
+this.init(address);
+  }
+
+  private void init(String address) {
 try {
-  this.httpServer = new HTTPServer(new InetSocketAddress(publishPort), 
CollectorRegistry.defaultRegistry, true);
-  LOGGER.info("Prometheus httpServer listened {}.", publishPort);
-} catch (IOException e) {
-  throw new ServiceCombException("create http publish server failed", e);
+  InetSocketAddress socketAddress = getSocketAddress(address);
+  MetricsCollector metricsCollector = new MetricsCollector();
+  metricsCollector.register();
+  this.httpServer = new HTTPServer(socketAddress, 
CollectorRegistry.defaultRegistry, true);
+  LOGGER.info("Prometheus httpServer listened : {}.", address);
+} catch (Exception e) {
+  throw new ServiceCombException("create http publish server failed,may 
bad address : " + address, e);
+}
+  }
+
+  private InetSocketAddress getSocketAddress(String address) {
+String[] hostAndPort = address.split(":");
+if (hostAndPort.length == 2) {
+  return new InetSocketAddress(hostAndPort[0], 
Integer.parseInt(hostAndPort[1]));
 }
+throw new ServiceCombException("create http publish server failed,bad 
address : " + address);
   }
 
   @Override
diff --git 
a/metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestMetricsHttpPublisher.java
 
b/metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestMetricsHttpPublisher.java
new file mode 100644
index 0..0f01e4650
--- /dev/null
+++ 
b/metrics/metrics-integration/metrics-prometheus/src/test/java/org/apache/servicecomb/metrics/prometheus/TestMetricsHttpPublisher.java
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing 

[jira] [Commented] (SCB-369) support extract publish information from spectator measurement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390927#comment-16390927
 ] 

ASF GitHub Bot commented on SCB-369:


coveralls commented on issue #575: [SCB-369] Extract info from spectator 
measurement
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#issuecomment-371080516
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15870056/badge)](https://coveralls.io/builds/15870056)
   
   Coverage increased (+0.08%) to 87.293% when pulling 
**b133e5c58e5123a02e672137a260f657cfbbf58a on 
wujimin:extract-info-from-spectator-measurement** into 
**83ae473e27889734d8cc0ecf428cd2538d26b1a4 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> support extract publish information from spectator measurement
> --
>
> Key: SCB-369
> URL: https://issues.apache.org/jira/browse/SCB-369
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SCB-376) Optimize validate parameter log print

[little-cui (JIRA)]

little-cui created SCB-376:
--

 Summary: Optimize validate parameter log print
 Key: SCB-376
 URL: https://issues.apache.org/jira/browse/SCB-376
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Service-Center
Affects Versions: service-center-1.0.0-m2
Reporter: little-cui
Assignee: little-cui






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-317) Prepare the release for Service-Center-1.0.0-m1

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390919#comment-16390919
 ] 

ASF GitHub Bot commented on SCB-317:


asifdxtreme opened a new pull request #300: SCB-317 Merge frontend conf to 
app.conf and fix shebang line issue in sh files
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/300
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Prepare the release for Service-Center-1.0.0-m1
> ---
>
> Key: SCB-317
> URL: https://issues.apache.org/jira/browse/SCB-317
> Project: Apache ServiceComb
>  Issue Type: Wish
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m1
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.0.0-m1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SCB-369) support extract publish information from spectator measurement

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SCB-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390902#comment-16390902
 ] 

ASF GitHub Bot commented on SCB-369:


wujimin commented on a change in pull request #575: [SCB-369] Extract info from 
spectator measurement
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/575#discussion_r173089137
 
 

 ##
 File path: 
foundations/foundation-metrics/src/test/java/org/apache/servicecomb/foundation/metrics/publish/spectator/TestMeasurementTree.java
 ##
 @@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.foundation.metrics.publish.spectator;
+
+import java.util.concurrent.TimeUnit;
+
+import org.hamcrest.Matchers;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.rules.ExpectedException;
+
+import com.netflix.spectator.api.ManualClock;
+import com.netflix.spectator.api.Registry;
+import com.netflix.spectator.api.Statistic;
+import com.netflix.spectator.api.Timer;
+import com.netflix.spectator.servo.ServoRegistry;
+
+public class TestMeasurementTree {
+  MeasurementTree tree = new MeasurementTree();
+
+  ManualClock clock = new ManualClock();
+
+  Registry registry = new ServoRegistry(clock);
+
+  Timer timer;
+
+  @Rule
+  public ExpectedException expectedException = ExpectedException.none();
+
+  @Before
+  public void setup() {
+System.setProperty("servo.pollers", "1000");
+timer = registry.timer("id",
+"g1",
+"g1v",
+"g2",
+"g2v",
+"t3",
+"t3v",
+"t4",
+"t4v");
+registry.counter("id_notCare");
+  }
+
+  @Test
+  public void from() {
+timer.record(10, TimeUnit.SECONDS);
+timer.record(2, TimeUnit.SECONDS);
+
+clock.setWallTime(clock.wallTime() + 1000);
+
+MeasurementGroupConfig config = new MeasurementGroupConfig("id", "g1", 
"g2", Statistic.count.key());
+tree.from(registry.iterator(), config);
+
+Assert.assertEquals(1, tree.getChildren().size());
+
+MeasurementNode node = tree.findChild("id", "g1v", "g2v");
+System.out.println(node.getMeasurements());
 
 Review comment:
   already add spectator information to license file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> support extract publish information from spectator measurement
> --
>
> Key: SCB-369
> URL: https://issues.apache.org/jira/browse/SCB-369
> Project: Apache ServiceComb
>  Issue Type: Sub-task
>  Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)