[jira] [Created] (SCB-673) Edge Service support calls from different ApplicationIds
miaoyanjie created SCB-673: -- Summary: Edge Service support calls from different ApplicationIds Key: SCB-673 URL: https://issues.apache.org/jira/browse/SCB-673 Project: Apache ServiceComb Issue Type: Wish Components: Java-Chassis Affects Versions: java-chassis-1.0.0-m2 Environment: java-chassis 1.0.0.m2-snap Reporter: miaoyanjie Fix For: java-chassis-1.0.0-m2 edgeservice just support call betweent diferent service in single app.I Edge Service support calls from different ApplicationIds. 我们现在做的是sass服务，有不同的产品。路由网关这块准备用edgeservice做，但是现在edgesevice只支持同一个appId下面，不同的微服务的路由。 我们需要它能路由不同的appId下面的微服务实例。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-672) Edge Service support calls from different ApplicationIds
miaoyanjie created SCB-672: -- Summary: Edge Service support calls from different ApplicationIds Key: SCB-672 URL: https://issues.apache.org/jira/browse/SCB-672 Project: Apache ServiceComb Issue Type: Wish Components: Java-Chassis Affects Versions: java-chassis-1.0.0-m2 Environment: java-chassis 1.0.0.m2-snap Reporter: miaoyanjie Fix For: java-chassis-1.0.0-m2 edgeservice just support call betweent diferent service in single app.I Edge Service support calls from different ApplicationIds. 我们现在做的是sass服务，有不同的产品。路由网关这块准备用edgeservice做，但是现在edgesevice只支持同一个appId下面，不同的微服务的路由。 我们需要它能路由不同的appId下面的微服务实例。 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-671) Duplicate cse.xxx to servicecomb.xxx to work better in future
[ https://issues.apache.org/jira/browse/SCB-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-671: - Fix Version/s: Java-chassis-1.0.0 > Duplicate cse.xxx to servicecomb.xxx to work better in future > - > > Key: SCB-671 > URL: https://issues.apache.org/jira/browse/SCB-671 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: Java-chassis-1.0.0 > > > As discussed in > [DISCUSSION] How to migrate configurations from cse toservicecomb prefix > It's better to map cse to servicecomb, not servicecomb to cse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-668) Using docker-compose file to start Services from docker plugin in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-668: - Fix Version/s: saga-0.3.0 > Using docker-compose file to start Services from docker plugin in the Accept > test > - > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Assignee: Gao Xin >Priority: Major > Fix For: saga-0.3.0 > > > Docker maven plugin support to start the service from > [docker-compose|https://dmp.fabric8.io/#docker-compose], which could save us > some time as we can reuse the docker compose file for the Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-668) Using docker-compose file to start Services from docker plugin in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned SCB-668: Assignee: Gao Xin > Using docker-compose file to start Services from docker plugin in the Accept > test > - > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Assignee: Gao Xin >Priority: Major > > Docker maven plugin support to start the service from > [docker-compose|https://dmp.fabric8.io/#docker-compose], which could save us > some time as we can reuse the docker compose file for the Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang resolved SCB-630.
--
Resolution: Fixed
Merged the patch into master branch with thanks to GaoXin.
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513297#comment-16513297 ] ASF GitHub Bot commented on SCB-506: coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-384615018 [](https://coveralls.io/builds/17504584) Coverage decreased (-0.2%) to 87.193% when pulling **f8095bffc1c00ead662f784fdd9adc8cdad9fae0 on xuyiyun0929:alarm** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > Fix For: Java-chassis-1.0.0 > > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-244) [pack] add demo to use pack with java chassis
[ https://issues.apache.org/jira/browse/SCB-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned SCB-244: Assignee: yangyongzheng > [pack] add demo to use pack with java chassis > - > > Key: SCB-244 > URL: https://issues.apache.org/jira/browse/SCB-244 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Eric Lee >Assignee: yangyongzheng >Priority: Minor > Fix For: saga-0.3.0 > > > as a dev, I want to know how I can use pack with Java Chassis. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-240) [pack] performance impacts test
[ https://issues.apache.org/jira/browse/SCB-240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-240: - Description: as a user, I want to know how much performance loss if I introduce pack as my transaction consistency solution. We need to deploy the application (which has multiple micro services) and start a client to send the request to the application. 1. Running the application without Omega enabled. 2. Running the application with Omega enabled (without inject the error) 3. Running the application with Omega enabled (with some failed transactions) In Pack mode, every transaction's call could generate events from Omega to Alpha. We may need to collect the calling information to optimize to performance. was:as a user, I want to know how much performance loss if I introduce pack as my transaction consistency solution. > [pack] performance impacts test > --- > > Key: SCB-240 > URL: https://issues.apache.org/jira/browse/SCB-240 > Project: Apache ServiceComb > Issue Type: Task > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Eric Lee >Priority: Major > Fix For: saga-0.3.0 > > > as a user, I want to know how much performance loss if I introduce pack as my > transaction consistency solution. > We need to deploy the application (which has multiple micro services) and > start a client to send the request to the application. > 1. Running the application without Omega enabled. > 2. Running the application with Omega enabled (without inject the error) > 3. Running the application with Omega enabled (with some failed transactions) > > In Pack mode, every transaction's call could generate events from Omega to > Alpha. > We may need to collect the calling information to optimize to performance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-625) ProduceProcessor use SPI to support extends
[ https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiChao closed SCB-625. --- > ProduceProcessor use SPI to support extends > --- > > Key: SCB-625 > URL: https://issues.apache.org/jira/browse/SCB-625 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Currently ProduceProcessor supporting text/plain and JSON， needs to be > changed to SPI to support extensions, e.g. www/url-encoded -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-625) ProduceProcessor use SPI to support extends
[ https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeiChao resolved SCB-625. - Resolution: Implemented > ProduceProcessor use SPI to support extends > --- > > Key: SCB-625 > URL: https://issues.apache.org/jira/browse/SCB-625 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Currently ProduceProcessor supporting text/plain and JSON， needs to be > changed to SPI to support extensions, e.g. www/url-encoded -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513220#comment-16513220
]
ASF GitHub Bot commented on SCB-506:
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r195614690
##
File path:
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.bizkeeper;
+
+import org.apache.servicecomb.core.Invocation;
+
+import com.netflix.hystrix.HystrixCommandGroupKey;
+import com.netflix.hystrix.HystrixKey;
+import com.netflix.hystrix.util.InternMap;
+
+public class CustomizeCommandGroupKey extends HystrixKey.HystrixKeyDefault
implements HystrixCommandGroupKey {
+
+ private String invocationType;
+
+ private String microserviceName;
+
+ private String schema;
+
+ private String operation;
+
+ public CustomizeCommandGroupKey(Invocation invocation) {
+super(invocation.getInvocationType().name() + "." +
invocation.getOperationMeta().getMicroserviceQualifiedName());
+this.invocationType = invocation.getInvocationType().name();
+this.microserviceName = invocation.getMicroserviceName();
+this.schema = invocation.getSchemaId();
+this.operation = invocation.getOperationName();
+ }
+
+ private static final InternMap intern =
+ new InternMap(
+ new InternMap.ValueConstructor() {
+@Override
+public CustomizeCommandGroupKey create(Invocation invocation) {
+ return new CustomizeCommandGroupKey(invocation);
+}
+ });
+
+
+ public static HystrixCommandGroupKey asKey(String type, Invocation
invocation) {
+return intern.interned(invocation);
Review comment:
Submitted code resolved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 服务治理相关的需要事件上报
> -
>
> Key: SCB-506
> URL: https://issues.apache.org/jira/browse/SCB-506
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: xuyiyun
>Assignee: xuyiyun
>Priority: Major
> Fix For: Java-chassis-1.0.0
>
>
> 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513215#comment-16513215
]
ASF GitHub Bot commented on SCB-506:
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r195614463
##
File path:
handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/event/CircutBreakerEvent.java
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.bizkeeper.event;
+
+
+import org.apache.servicecomb.bizkeeper.CustomizeCommandGroupKey;
+import org.apache.servicecomb.foundation.common.event.AlarmEvent;
+
+import com.netflix.hystrix.HystrixCommandKey;
+import com.netflix.hystrix.HystrixCommandMetrics;
+
+public class CircutBreakerEvent extends AlarmEvent {
+
+ private String role;
+
+ private String microservice;
+
+ private String schema;
+
+ private String operation;
+
+ //当前总请求数
+ private long currentTotalRequest;
+
+ //当前请求出错计数
+ private long currentErrorCount;
+
+ //当前请求出错百分比
+ private long currentErrorPercentage;
+
+ private int requestVolumeThreshold;
+
+ private int sleepWindowInMilliseconds;
+
+ private int errorThresholdPercentage;
+
+ public CircutBreakerEvent(HystrixCommandKey commandKey, Type type) {
+super(type);
+HystrixCommandMetrics hystrixCommandMetrics =
+HystrixCommandMetrics.getInstance(commandKey);
+if (hystrixCommandMetrics != null) {
+ CustomizeCommandGroupKey customizeCommandGroupKey =
+ (CustomizeCommandGroupKey) hystrixCommandMetrics.getCommandGroup();
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 服务治理相关的需要事件上报
> -
>
> Key: SCB-506
> URL: https://issues.apache.org/jira/browse/SCB-506
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: xuyiyun
>Assignee: xuyiyun
>Priority: Major
> Fix For: Java-chassis-1.0.0
>
>
> 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[ https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513213#comment-16513213 ] ASF GitHub Bot commented on SCB-651: limbojinne commented on issue #770: [SCB-651] Fixes bug of qps rate limit value URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#issuecomment-397486140 Okay, I've changed lastRequestCount to 1, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QPS rate limit bug > -- > > Key: SCB-651 > URL: https://issues.apache.org/jira/browse/SCB-651 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: Sean Li >Assignee: Sean Li >Priority: Major > Attachments: limit value as 1.jpeg, limit value as 2.jpeg > > > When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the > actual number of requests allowed per second are 1 less than the limit value. > > For example, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 1, I'll get NO successful request at the very > beginning, although I would expect 1 successful request instead of none. > Similarly, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 2, I'll get 1 successful request instead of > 2. > > -However, if I pause before sending requests, for example add > _Thread.sleep(100)_ before invoking the first request, the number of requests > allowed per second will be correct this time. (i.e. 1 successful request when > limit value is 1, 2 successful requests when limit value is 2, etc.)- > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[
https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513207#comment-16513207
]
ASF GitHub Bot commented on SCB-506:
xuyiyun0929 commented on a change in pull request #678: [SCB-506]服务治理相关的需要事件上报
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#discussion_r195613419
##
File path:
handlers/handler-bizkeeper/src/test/java/org/apache/servicecomb/bizkeeper/TestCustomCommandGroupKey.java
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.bizkeeper;
+
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.definition.OperationMeta;
+import org.apache.servicecomb.swagger.invocation.InvocationType;
+import org.junit.Assert;
+import org.junit.Test;
+import org.mockito.Mockito;
+
+public class TestCustomCommandGroupKey {
+ @Test
+ public void testToHystrixCommandGroupKey() {
+
+Invocation invocation = Mockito.mock(Invocation.class);
+
Mockito.when(invocation.getOperationMeta()).thenReturn(Mockito.mock(OperationMeta.class));
+
Mockito.when(invocation.getOperationMeta().getMicroserviceQualifiedName()).thenReturn("test2");
+
Mockito.when(invocation.getMicroserviceName()).thenReturn("microserviceName");
+
Mockito.when(invocation.getInvocationType()).thenReturn(InvocationType.CONSUMER);
+Mockito.when(invocation.getSchemaId()).thenReturn("schemaId");
+Mockito.when(invocation.getOperationName()).thenReturn("operationName");
+CustomizeCommandGroupKey customizeCommandGroupKey =
+(CustomizeCommandGroupKey) CustomizeCommandGroupKey.asKey("type",
invocation);
+Assert.assertEquals("CONSUMER",
customizeCommandGroupKey.getInvocationType());
+Assert.assertEquals("microserviceName",
customizeCommandGroupKey.getMicroserviceName());
+Assert.assertEquals("schemaId", customizeCommandGroupKey.getSchema());
+Assert.assertEquals("operationName",
customizeCommandGroupKey.getOperation());
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> 服务治理相关的需要事件上报
> -
>
> Key: SCB-506
> URL: https://issues.apache.org/jira/browse/SCB-506
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: xuyiyun
>Assignee: xuyiyun
>Priority: Major
> Fix For: Java-chassis-1.0.0
>
>
> 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-506) 服务治理相关的需要事件上报
[ https://issues.apache.org/jira/browse/SCB-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512576#comment-16512576 ] ASF GitHub Bot commented on SCB-506: coveralls commented on issue #678: [SCB-506]服务治理相关的需要事件上报 URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/678#issuecomment-384615018 [](https://coveralls.io/builds/17492237) Coverage decreased (-0.2%) to 87.213% when pulling **b6c65f73f0eb7ef2fe6ebf97e3d7e7e8453a6e49 on xuyiyun0929:alarm** into **5348393b977f5e6a8eac87016dd1f969a7a1e6df on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > 服务治理相关的需要事件上报 > - > > Key: SCB-506 > URL: https://issues.apache.org/jira/browse/SCB-506 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: xuyiyun >Assignee: xuyiyun >Priority: Major > Fix For: Java-chassis-1.0.0 > > > 如果发生服务降级 实例隔离 熔断等操作，业务监控系统需要能获取到对应的通知，方便集成 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation
[ https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512536#comment-16512536 ] ASF GitHub Bot commented on SCB-630: WillemJiang closed pull request #209: SCB-630 Active the -Pdocker profile if detect the docker installation URL: https://github.com/apache/incubator-servicecomb-saga/pull/209 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/acceptance-tests/acceptance-dubbo-demo/pom.xml b/acceptance-tests/acceptance-dubbo-demo/pom.xml index 1dd257af..79e76370 100644 --- a/acceptance-tests/acceptance-dubbo-demo/pom.xml +++ b/acceptance-tests/acceptance-dubbo-demo/pom.xml @@ -44,6 +44,11 @@ docker + + + /var/run/docker.sock + + diff --git a/acceptance-tests/acceptance-spring-cloud-demo/pom.xml b/acceptance-tests/acceptance-spring-cloud-demo/pom.xml index c4185d11..a9c7cc5b 100644 --- a/acceptance-tests/acceptance-spring-cloud-demo/pom.xml +++ b/acceptance-tests/acceptance-spring-cloud-demo/pom.xml @@ -82,6 +82,11 @@ docker + + + /var/run/docker.sock + + diff --git a/alpha/alpha-server/pom.xml b/alpha/alpha-server/pom.xml index 7d154a21..bfb88434 100644 --- a/alpha/alpha-server/pom.xml +++ b/alpha/alpha-server/pom.xml @@ -158,6 +158,11 @@ docker + + + /var/run/docker.sock + + diff --git a/integration-tests/pack-tests/pom.xml b/integration-tests/pack-tests/pom.xml index fce01ed7..fe23dec8 100644 --- a/integration-tests/pack-tests/pom.xml +++ b/integration-tests/pack-tests/pom.xml @@ -150,6 +150,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-dubbo-demo/servicea/pom.xml b/saga-demo/saga-dubbo-demo/servicea/pom.xml index dc2370ba..9dad60d0 100644 --- a/saga-demo/saga-dubbo-demo/servicea/pom.xml +++ b/saga-demo/saga-dubbo-demo/servicea/pom.xml @@ -60,6 +60,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-dubbo-demo/serviceb/pom.xml b/saga-demo/saga-dubbo-demo/serviceb/pom.xml index d8dea590..7aa8bbc4 100644 --- a/saga-demo/saga-dubbo-demo/serviceb/pom.xml +++ b/saga-demo/saga-dubbo-demo/serviceb/pom.xml @@ -56,6 +56,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-dubbo-demo/servicec/pom.xml b/saga-demo/saga-dubbo-demo/servicec/pom.xml index 465df541..6046ed81 100644 --- a/saga-demo/saga-dubbo-demo/servicec/pom.xml +++ b/saga-demo/saga-dubbo-demo/servicec/pom.xml @@ -56,6 +56,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-spring-cloud-demo/booking/pom.xml b/saga-demo/saga-spring-cloud-demo/booking/pom.xml index 45f47901..0f0275a5 100644 --- a/saga-demo/saga-spring-cloud-demo/booking/pom.xml +++ b/saga-demo/saga-spring-cloud-demo/booking/pom.xml @@ -64,6 +64,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-spring-cloud-demo/car/pom.xml b/saga-demo/saga-spring-cloud-demo/car/pom.xml index bfad217a..389da02f 100644 --- a/saga-demo/saga-spring-cloud-demo/car/pom.xml +++ b/saga-demo/saga-spring-cloud-demo/car/pom.xml @@ -64,6 +64,11 @@ docker + + + /var/run/docker.sock + + diff --git a/saga-demo/saga-spring-cloud-demo/hotel/pom.xml b/saga-demo/saga-spring-cloud-demo/hotel/pom.xml index 40395ed4..a4ba9652 100644 --- a/saga-demo/saga-spring-cloud-demo/hotel/pom.xml +++ b/saga-demo/saga-spring-cloud-demo/hotel/pom.xml @@ -64,6 +64,11 @@ docker + + + /var/run/docker.sock + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Active the -Pdocker profile if detect the docker installation > -- > > Key: SCB-630 > URL: https://issues.apache.org/jira/browse/SCB-630 >
[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512482#comment-16512482
]
ASF GitHub Bot commented on SCB-630:
coveralls commented on issue #209: SCB-630 Active the -Pdocker profile if
detect the docker installation
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/209#issuecomment-397293759
[](https://coveralls.io/builds/17490990)
Coverage remained the same at 94.572% when pulling
**c9d8b221857908dc19493c7393d945b5d7099209 on SingleX:SCB-630** into
**55aba24805c1f9db1d6eeb7090b483c1522e3826 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512455#comment-16512455
]
ASF GitHub Bot commented on SCB-630:
coveralls commented on issue #209: SCB-630 Active the -Pdocker profile if
detect the docker installation
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/209#issuecomment-397293759
[](https://coveralls.io/builds/17490552)
Coverage decreased (-0.6%) to 94.02% when pulling
**01cacf2a088bda19ad2eb66a1dbbcf913ef99b6a on SingleX:SCB-630** into
**55aba24805c1f9db1d6eeb7090b483c1522e3826 on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-662) Using cse/servicecomb duplicate key will get list of values
[
https://issues.apache.org/jira/browse/SCB-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512441#comment-16512441
]
ASF GitHub Bot commented on SCB-662:
wujimin commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195413789
##
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+source.addProperty(cseKey, source.getProperty(key));
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Using cse/servicecomb duplicate key will get list of values
> ---
>
> Key: SCB-662
> URL: https://issues.apache.org/jira/browse/SCB-662
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: liubao
>Priority: Major
>
> config file 1:
> cse.test.value=a
>
> config file 2:
> servicecomb.test.value=b
>
> when get value, will get a,b not a nor b.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-662) Using cse/servicecomb duplicate key will get list of values
[
https://issues.apache.org/jira/browse/SCB-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512425#comment-16512425
]
ASF GitHub Bot commented on SCB-662:
liubao68 commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195408761
##
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+source.addProperty(cseKey, source.getProperty(key));
Review comment:
source.setProperty will clear and add. Here we checked existence and logged
a warning message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Using cse/servicecomb duplicate key will get list of values
> ---
>
> Key: SCB-662
> URL: https://issues.apache.org/jira/browse/SCB-662
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: liubao
>Priority: Major
>
> config file 1:
> cse.test.value=a
>
> config file 2:
> servicecomb.test.value=b
>
> when get value, will get a,b not a nor b.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-662) Using cse/servicecomb duplicate key will get list of values
[
https://issues.apache.org/jira/browse/SCB-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512409#comment-16512409
]
ASF GitHub Bot commented on SCB-662:
wujimin commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195403429
##
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+source.addProperty(cseKey, source.getProperty(key));
Review comment:
source.setProperty is better?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Using cse/servicecomb duplicate key will get list of values
> ---
>
> Key: SCB-662
> URL: https://issues.apache.org/jira/browse/SCB-662
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: liubao
>Priority: Major
>
> config file 1:
> cse.test.value=a
>
> config file 2:
> servicecomb.test.value=b
>
> when get value, will get a,b not a nor b.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-625) ProduceProcessor use SPI to support extends
[
https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512400#comment-16512400
]
ASF GitHub Bot commented on SCB-625:
wujimin closed pull request #741: [SCB-625] ProduceProcessor use SPI to support
extends
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/741
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/AbstractProduceProcessor.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/AbstractProduceProcessor.java
deleted file mode 100644
index 7704fa2d6..0
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/AbstractProduceProcessor.java
+++ /dev/null
@@ -1,24 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.servicecomb.common.rest.codec.produce;
-
-public abstract class AbstractProduceProcessor implements ProduceProcessor {
- public AbstractProduceProcessor() {
-ProduceProcessorManager.INSTANCE.register(getName(), this);
- }
-}
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceJsonProcessor.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceJsonProcessor.java
index 28e2b2908..73cbf6296 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceJsonProcessor.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceJsonProcessor.java
@@ -26,7 +26,7 @@
import com.fasterxml.jackson.databind.JavaType;
-public class ProduceJsonProcessor extends AbstractProduceProcessor {
+public class ProduceJsonProcessor implements ProduceProcessor {
@Override
public String getName() {
@@ -42,4 +42,9 @@ public void doEncodeResponse(OutputStream output, Object
result) throws Exceptio
public Object doDecodeResponse(InputStream input, JavaType type) throws
Exception {
return RestObjectMapper.INSTANCE.readValue(input, type);
}
+
+ @Override
+ public int getOrder() {
+return 0;
+ }
}
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessor.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessor.java
index 244c9010a..127250ff7 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessor.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessor.java
@@ -30,6 +30,8 @@
public interface ProduceProcessor {
String getName();
+ int getOrder();
+
default void encodeResponse(OutputStream output, Object result) throws
Exception {
if (result == null) {
return;
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
index d70eac452..255b35d77 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/codec/produce/ProduceProcessorManager.java
@@ -17,24 +17,38 @@
package org.apache.servicecomb.common.rest.codec.produce;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
import javax.ws.rs.core.MediaType;
import org.apache.servicecomb.foundation.common.RegisterManager;
+import org.apache.servicecomb.foundation.common.utils.SPIServiceUtils;
public final class ProduceProcessorManager extends RegisterManager {
+ private static final List produceProcessor =
+ SPIServiceUtils.getSortedService(ProduceProcessor.class);
+
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512389#comment-16512389
]
ASF GitHub Bot commented on SCB-651:
liubao68 commented on a change in pull request #770: [SCB-651] Fixes bug of qps
rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195400342
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
Change lastRequestCount to 1 is preferred. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-661) Logs improvement to give better information
[
https://issues.apache.org/jira/browse/SCB-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512388#comment-16512388
]
ASF GitHub Bot commented on SCB-661:
wujimin closed pull request #766: [SCB-661]logs give more information and
remove unnecessary log for each invocation
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/766
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
index 2dd77556d..a3dbbdb3a 100644
---
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
@@ -72,6 +72,7 @@ protected Swagger loadSwagger(ConsumerSchemaContext context) {
context.getMicroservice().getVersion(),
context.getSchemaId(),
!StringUtils.isEmpty(schemaContent));
+LOGGER.debug(schemaContent);
if (schemaContent != null) {
return SchemaUtils.parseSwagger(schemaContent);
}
diff --git
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
index aad3893d1..a582041f2 100644
---
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
+++
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/BizkeeperCommand.java
@@ -79,7 +79,8 @@ protected String getCacheKey() {
invocation.next(resp -> {
if (isFailedResponse(resp)) {
// e should implements toString
-LOG.warn("bizkeeper command failed due to:" + resp.getResult());
+LOG.warn("bizkeeper command {} failed due to {}",
invocation.getInvocationQualifiedName(),
+resp.getResult());
f.onError(resp.getResult());
FallbackPolicyManager.record(type, invocation, resp, false);
} else {
@@ -89,7 +90,8 @@ protected String getCacheKey() {
}
});
} catch (Exception e) {
-LOG.warn("bizkeeper command execute failed due to:" +
e.getClass().getName());
+LOG.warn("bizkeeper command {} execute failed due to {}",
invocation.getInvocationQualifiedName(),
+e.getClass().getName());
f.onError(e);
}
});
diff --git
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
index 723abef24..06ffb9bc1 100644
---
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
+++
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/LoadbalanceHandler.java
@@ -223,7 +223,8 @@ public void onStartWithServer(ExecutionContext
context,
@Override
public void onExceptionWithServer(ExecutionContext context,
Throwable exception,
ExecutionInfo info) {
-LOGGER.error("onExceptionWithServer msg {}; server {}",
+LOGGER.error("onExceptionWithServer operation {}; msg {}; server {}",
+context.getRequest().getInvocationQualifiedName(),
exception.getMessage(),
context.getRequest().getEndpoint());
}
@@ -274,7 +275,8 @@ public void onExecutionFailed(ExecutionContext
context, Throwable fi
invocation.setEndpoint(((CseServer) s).getEndpoint());
invocation.next(resp -> {
if (isFailedResponse(resp)) {
-LOGGER.error("service call error, msg is {}, server is {} ",
+LOGGER.error("service {}, call error, msg is {}, server is {}
",
+invocation.getInvocationQualifiedName(),
((Throwable) resp.getResult()).getMessage(),
s);
chosenLB.getLoadBalancerStats().incrementSuccessiveConnectionFailureCount(s);
diff --git
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
b/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
index aaffa3fe2..9c379a9c0 100644
---
a/handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
+++
[jira] [Assigned] (SCB-671) Duplicate cse.xxx to servicecomb.xxx to work better in future
[ https://issues.apache.org/jira/browse/SCB-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao reassigned SCB-671: -- Assignee: liubao > Duplicate cse.xxx to servicecomb.xxx to work better in future > - > > Key: SCB-671 > URL: https://issues.apache.org/jira/browse/SCB-671 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > > As discussed in > [DISCUSSION] How to migrate configurations from cse toservicecomb prefix > It's better to map cse to servicecomb, not servicecomb to cse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-490) Service Center verrsion is not forward compatible and needs to be noted in releasenote.
[ https://issues.apache.org/jira/browse/SCB-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512380#comment-16512380 ] liubao commented on SCB-490: For each SDK release, we should notice the minimal supported SC version. I think we can release 1.0.0.m2 to support the latest released SC. I will check the release when 1.0.0.m2 is released and close this issue at that time. > Service Center verrsion is not forward compatible and needs to be noted in > releasenote. > --- > > Key: SCB-490 > URL: https://issues.apache.org/jira/browse/SCB-490 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis, Service-Center >Reporter: mabin >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0-m2, service-center-1.0.0 > > > Service Center verrsion is not forward compatible and needs to be noted in > releasenote,so that users can detect and correct in advance. > For example,Service Center 0.5.0 can not be used with Java-chassis 1.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512362#comment-16512362
]
ASF GitHub Bot commented on SCB-651:
limbojinne commented on a change in pull request #770: [SCB-651] Fixes bug of
qps rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195391793
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
It is. So do you want me to keep the code this way or change
lastRequestCount to 1?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-662) Using cse/servicecomb duplicate key will get list of values
[
https://issues.apache.org/jira/browse/SCB-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512360#comment-16512360
]
ASF GitHub Bot commented on SCB-662:
liubao68 commented on a change in pull request #767: [SCB-662]Using
cse/servicecomb duplicate key will get list of values
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r195391079
##
File path:
foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
##
@@ -171,7 +171,14 @@ private static void
duplicateServiceCombConfigToCse(AbstractConfiguration source
}
String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
- source.addProperty(cseKey, source.getProperty(key));
+ if (!source.containsKey(cseKey)) {
+source.addProperty(cseKey, source.getProperty(key));
+ } else {
+LOGGER
+.warn(
Review comment:
"stop working" can not be applied because we may configure some default
values using cse or servicecomb, if doing this users code have to change to
work properly. We can't do this now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Using cse/servicecomb duplicate key will get list of values
> ---
>
> Key: SCB-662
> URL: https://issues.apache.org/jira/browse/SCB-662
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: liubao
>Priority: Major
>
> config file 1:
> cse.test.value=a
>
> config file 2:
> servicecomb.test.value=b
>
> when get value, will get a,b not a nor b.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-669) Fix List response body deserialization problem
[
https://issues.apache.org/jira/browse/SCB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512352#comment-16512352
]
ASF GitHub Bot commented on SCB-669:
liubao68 closed pull request #768: [SCB-669] add extra hashcode into
CtTypeJavaType to avoid deserialization problem
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/768
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/CtTypeJavaType.java
b/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/CtTypeJavaType.java
index 1ef4cec8e..74c083cb0 100644
---
a/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/CtTypeJavaType.java
+++
b/common/common-javassist/src/main/java/org/apache/servicecomb/common/javassist/CtTypeJavaType.java
@@ -16,7 +16,10 @@
*/
package org.apache.servicecomb.common.javassist;
+import java.util.Objects;
+
import com.fasterxml.jackson.databind.type.SimpleType;
+import com.fasterxml.jackson.databind.type.TypeBindings;
/**
* just a wrapper for CtType
@@ -28,7 +31,9 @@
private CtType type;
public CtTypeJavaType(CtType type) {
-super(CtTypeJavaType.class);
+super(CtTypeJavaType.class, TypeBindings.emptyBindings(), null, null,
+type == null ? 0 : type.getGenericSignature().hashCode(),
+null, null, false);
this.type = type;
}
@@ -46,9 +51,20 @@ public String getGenericSignature() {
return type.getGenericSignature();
}
-
@Override
public StringBuilder getGenericSignature(StringBuilder sb) {
return sb.append(type.getGenericSignature());
}
+
+ @Override
+ public boolean equals(Object o) {
+if (this == o) {
+ return true;
+}
+if (o == null || !this.getClass().isAssignableFrom(o.getClass())) {
+ return false;
+}
+CtTypeJavaType that = (CtTypeJavaType) o;
+return Objects.equals(this.getGenericSignature(),
that.getGenericSignature());
+ }
}
diff --git
a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestCtTypeJavaType.java
b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestCtTypeJavaType.java
index 46213a316..9ec4ea96c 100644
---
a/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestCtTypeJavaType.java
+++
b/common/common-javassist/src/test/java/org/apache/servicecomb/common/javassist/TestCtTypeJavaType.java
@@ -45,4 +45,45 @@ public void getGenericSignature() {
Assert.assertEquals("Ljava/util/List;",
listJavaType.getGenericSignature());
}
+
+ /**
+ * The {@link CtTypeJavaType} with different CtType should holds different
hash code.
+ */
+ @Test
+ public void testHashCode() {
+JavaType newJavaType =
TypeFactory.defaultInstance().constructType(String.class);
+CtType newCtType = new CtType(newJavaType);
+CtTypeJavaType newCtTypeJavaType = new CtTypeJavaType(newCtType);
+Assert.assertNotEquals(ctTypeJavaType.hashCode(),
newCtTypeJavaType.hashCode());
+
+newJavaType = TypeFactory.defaultInstance().constructType(cls);
+newCtType = new CtType(newJavaType);
+newCtTypeJavaType = new CtTypeJavaType(newCtType);
+Assert.assertEquals(ctTypeJavaType.hashCode(),
newCtTypeJavaType.hashCode());
+ }
+
+ /**
+ * The {@link CtTypeJavaType}s holding different type information should not
equal to each others.
+ * While those holding the same type information should be equal.
+ */
+ @Test
+ public void testEquals() {
+JavaType newJavaType =
TypeFactory.defaultInstance().constructType(String.class);
+CtType newCtType = new CtType(newJavaType);
+CtTypeJavaType newCtTypeJavaType = new CtTypeJavaType(newCtType);
+Assert.assertNotEquals(ctTypeJavaType, newCtTypeJavaType);
+
+newJavaType = TypeFactory.defaultInstance().constructType(cls);
+newCtType = new CtType(newJavaType);
+newCtTypeJavaType = new CtTypeJavaType(newCtType);
+Assert.assertEquals(ctTypeJavaType, newCtTypeJavaType);
+
+// test subClass of CtTypeJavaType
+newJavaType = TypeFactory.defaultInstance().constructType(cls);
+newCtType = new CtType(newJavaType);
+newCtTypeJavaType = new CtTypeJavaType(newCtType) {
+ private static final long serialVersionUID = 1876189050753964880L;
+};
+Assert.assertEquals(ctTypeJavaType, newCtTypeJavaType);
+ }
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512351#comment-16512351
]
ASF GitHub Bot commented on SCB-651:
liubao68 commented on a change in pull request #770: [SCB-651] Fixes bug of qps
rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195389425
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
If you change lastRequestCount to 1, the algorithm is consistent. Because
for next cycles it's initial value is the newCount, not newCount - 1. This can
be a minor fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SCB-667) gracefully shutdown is not work in some case
[ https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-667. -- Resolution: Fixed Merged the PR into master and 1.0.0-mX branch. > gracefully shutdown is not work in some case > > > Key: SCB-667 > URL: https://issues.apache.org/jira/browse/SCB-667 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > In some case like consumer never stop sending request to prodiver, privider > do not reject new request from consumer and still process them, > So shutdown will be blocked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512283#comment-16512283
]
ASF GitHub Bot commented on SCB-667:
WillemJiang closed pull request #769: [SCB-667] fix gracefully shutdown is not
work in some case
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/769
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
index 81e6fc925..cb4413b47 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
@@ -108,7 +108,13 @@ public String getContext(String key) {
}
protected void scheduleInvocation() {
-createInvocation();
+try {
+ createInvocation();
+} catch (IllegalStateException e) {
+ sendFailResponse(e);
+ return;
+}
+
invocation.onStart();
OperationMeta operationMeta = restOperationMeta.getOperationMeta();
@@ -161,7 +167,6 @@ public void invoke() {
protected Response prepareInvoke() throws Throwable {
this.initProduceProcessor();
-
this.setContext();
invocation.getHandlerContext().put(RestConst.REST_REQUEST, requestEx);
diff --git
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/TestAbstractRestInvocation.java
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/TestAbstractRestInvocation.java
index 6e5df508f..e8d4d7f08 100644
---
a/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/TestAbstractRestInvocation.java
+++
b/common/common-rest/src/test/java/org/apache/servicecomb/common/rest/TestAbstractRestInvocation.java
@@ -36,6 +36,8 @@
import org.apache.servicecomb.core.Endpoint;
import org.apache.servicecomb.core.Handler;
import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.SCBEngine;
+import org.apache.servicecomb.core.SCBStatus;
import org.apache.servicecomb.core.definition.MicroserviceMeta;
import org.apache.servicecomb.core.definition.MicroserviceMetaManager;
import org.apache.servicecomb.core.definition.OperationMeta;
@@ -121,11 +123,13 @@ protected void createInvocation() {
@BeforeClass
public static void classSetup() {
EventManager.eventBus = new EventBus();
+SCBEngine.getInstance().setStatus(SCBStatus.UP);
}
@AfterClass
public static void classTeardown() {
EventManager.eventBus = new EventBus();
+SCBEngine.getInstance().setStatus(SCBStatus.DOWN);
}
@Before
diff --git a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
index 4d2f15702..aa42ded56 100644
--- a/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
+++ b/core/src/main/java/org/apache/servicecomb/core/SCBEngine.java
@@ -273,11 +273,11 @@ private void validAllInvocationFinished() throws
InterruptedException {
}
}
- protected void ensureStatusUp() {
+ public void ensureStatusUp() {
SCBStatus currentStatus = getStatus();
if (!SCBStatus.UP.equals(currentStatus)) {
throw new IllegalStateException(
- "System is starting and not ready for remote calls or shutting down
in progress, STATUS = " + currentStatus);
+ "The request is rejected, as the service cannot process the request
due to STATUS = " + currentStatus);
}
}
diff --git
a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationFactory.java
b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationFactory.java
index 8410d935d..8c72f9355 100644
---
a/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/invocation/InvocationFactory.java
@@ -20,6 +20,7 @@
import org.apache.servicecomb.core.Const;
import org.apache.servicecomb.core.Endpoint;
import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.SCBEngine;
import org.apache.servicecomb.core.definition.MicroserviceMeta;
import org.apache.servicecomb.core.definition.OperationMeta;
import org.apache.servicecomb.core.definition.SchemaMeta;
@@ -68,6 +69,7 @@ public static Invocation forConsumer(ReferenceConfig
referenceConfig, String ope
public static Invocation forProvider(Endpoint endpoint,
OperationMeta operationMeta,
Object[] swaggerArguments) {
+SCBEngine.getInstance().ensureStatusUp();
return new
[jira] [Commented] (SCB-631) Using testcontainers to start the alpha server in the integration test
[ https://issues.apache.org/jira/browse/SCB-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512276#comment-16512276 ] Willem Jiang commented on SCB-631: -- Just play with it test container a while, compare to the docker plugin there could be a long way to go. > Using testcontainers to start the alpha server in the integration test > -- > > Key: SCB-631 > URL: https://issues.apache.org/jira/browse/SCB-631 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > Labels: newbie > > testcontainers provides an easy way to start the docker image from java. > It could make us easy to debug the integration test from the IDE. > Now we can start to use it in the saga integration tests. > [https://www.testcontainers.org/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-625) ProduceProcessor use SPI to support extends
[ https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512249#comment-16512249 ] ASF GitHub Bot commented on SCB-625: coveralls commented on issue #741: [SCB-625] ProduceProcessor use SPI to support extends URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/741#issuecomment-393089504 [](https://coveralls.io/builds/17487780) Coverage decreased (-0.2%) to 87.334% when pulling **40b26dd0d589fa5612f8a30c53834335c6a87664 on weichao666:produceprocessor** into **69f8b17bb82c777ea0b685405fa4e3c44ae9b066 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ProduceProcessor use SPI to support extends > --- > > Key: SCB-625 > URL: https://issues.apache.org/jira/browse/SCB-625 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: WeiChao >Assignee: WeiChao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Currently ProduceProcessor supporting text/plain and JSON， needs to be > changed to SPI to support extensions, e.g. www/url-encoded -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512213#comment-16512213
]
ASF GitHub Bot commented on SCB-651:
limbojinne commented on a change in pull request #770: [SCB-651] Fixes bug of
qps rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195353249
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
But why only set the limit in the first cycle higher than the expected value
at the beginning? After the first cycle, the number of successful requests in
the following new cycles will still be equal to the limit value. The
modification is supposed to keep the logic consistent both in the first cycle
and the following new cycles.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-625) ProduceProcessor use SPI to support extends
[
https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512204#comment-16512204
]
ASF GitHub Bot commented on SCB-625:
weichao666 commented on a change in pull request #741: [SCB-625]
ProduceProcessor use SPI to support extends
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/741#discussion_r195350417
##
File path:
demo/demo-schema/src/main/java/org/apache/servicecomb/demo/CodeFirstRestTemplate.java
##
@@ -123,6 +128,21 @@ private void testCodeFirstTextPlain(RestTemplate
template, String cseUrlPrefix)
TestMgr.check(body, result);
}
+ private void testCodeFirstAppXml(RestTemplate template, String cseUrlPrefix)
{
+JAXBPerson person = new JAXBPerson("jake", 22, "it", "60kg");
+person.setJob(new JAXBJob("developer", "coding"));
+HttpHeaders headers = new HttpHeaders();
+headers.add("Accept", MediaType.APPLICATION_XML_VALUE);
+headers.add("Content-Type", MediaType.APPLICATION_XML_VALUE);
Review comment:
yes, now servicecomb processing client requests only use application/xml,
don't support extend, that means whatever i set in ContentType, it all will be
cover to application/xml before send to server, and server will default use
json to do decode.
so the xml produceprocessor actually effective in response, when response,
provider use xml encode and consumer use xml docode
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ProduceProcessor use SPI to support extends
> ---
>
> Key: SCB-625
> URL: https://issues.apache.org/jira/browse/SCB-625
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Currently ProduceProcessor supporting text/plain and JSON， needs to be
> changed to SPI to support extensions, e.g. www/url-encoded
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[ https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512201#comment-16512201 ] ASF GitHub Bot commented on SCB-667: coveralls commented on issue #769: [SCB-667] fix gracefully shutdown is not work in some case URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#issuecomment-397200436 [](https://coveralls.io/builds/17486994) Coverage decreased (-0.03%) to 87.328% when pulling **a7ce588e86ce0ee0c0a5fd0732048f030ad5908c on zhengyangyong:SCB-667** into **b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > gracefully shutdown is not work in some case > > > Key: SCB-667 > URL: https://issues.apache.org/jira/browse/SCB-667 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > In some case like consumer never stop sending request to prodiver, privider > do not reject new request from consumer and still process them, > So shutdown will be blocked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-669) Fix List response body deserialization problem
[
https://issues.apache.org/jira/browse/SCB-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512172#comment-16512172
]
ASF GitHub Bot commented on SCB-669:
coveralls commented on issue #768: [SCB-669] add extra hashcode into
CtTypeJavaType to avoid deserialization problem
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/768#issuecomment-397180033
[](https://coveralls.io/builds/17486639)
Coverage decreased (-0.02%) to 87.343% when pulling
**ce99d46d01ed5e0cf734edf853caf2bed5a415d8 on
yhs0092:fix_list_response_body_deserialization_problem** into
**b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix List response body deserialization problem
> --
>
> Key: SCB-669
> URL: https://issues.apache.org/jira/browse/SCB-669
> Project: Apache ServiceComb
> Issue Type: Bug
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: service-center-1.0.0-m2
>
> Attachments: invokeProviderDirectly.jpg, invokeViaEdgeService.jpg
>
>
> When a provider has a rest operation whose response is List, and the
> type Pack is like below
> {code:java}
> public class Pack{
> private String name;
> private int i;
> // PackageProp is a type defined by user, and it only contains simple java
> type
> private List packagePropList;
> }
> public class PackageProp{
> private String name;
> private int j;
> private String prop;
> }
> {code}
> We can use postman to invoke the rest operation directly and it works well.
> But if we invoke this operation via EdgeService, the response body will be
> deserialized in edge unproperly. The edge treat the response List as
> List.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512171#comment-16512171
]
ASF GitHub Bot commented on SCB-651:
yangbor commented on a change in pull request #770: [SCB-651] Fixes bug of qps
rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195344393
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
I agree with liubao's opinion. It's impractical to make the actual qps
exactly equal to the configured limit. Thus the fix is not needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512168#comment-16512168
]
ASF GitHub Bot commented on SCB-667:
zhengyangyong commented on a change in pull request #769: [SCB-667] fix
gracefully shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195343041
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
-this.initProduceProcessor();
+SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
+if (SCBStatus.UP.equals(currentStatus)) {
+ this.initProduceProcessor();
-this.setContext();
-invocation.getHandlerContext().put(RestConst.REST_REQUEST, requestEx);
+ this.setContext();
+ invocation.getHandlerContext().put(RestConst.REST_REQUEST, requestEx);
-for (HttpServerFilter filter : httpServerFilters) {
- Response response = filter.afterReceiveRequest(invocation, requestEx);
- if (response != null) {
-return response;
+ for (HttpServerFilter filter : httpServerFilters) {
+Response response = filter.afterReceiveRequest(invocation, requestEx);
+if (response != null) {
+ return response;
+}
}
+} else {
+ LOGGER.warn(
+ "System is starting and not ready for remote calls or shutting down
in progress, STATUS = " + currentStatus);
Review comment:
OK,it seems better,Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512167#comment-16512167
]
ASF GitHub Bot commented on SCB-667:
zhengyangyong commented on a change in pull request #769: [SCB-667] fix
gracefully shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195342948
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
-this.initProduceProcessor();
+SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
Review comment:
sounds good,Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512166#comment-16512166
]
ASF GitHub Bot commented on SCB-667:
zhengyangyong commented on a change in pull request #769: [SCB-667] fix
gracefully shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195342857
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/Invoker.java
##
@@ -57,7 +58,10 @@ public InvokerMeta(ReferenceConfig referenceConfig,
// initialized and meta not changed
public boolean isValid() {
- return swaggerConsumer != null && microserviceMeta ==
referenceConfig.getMicroserviceMeta();
+ SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
+ return SCBStatus.UP.equals(currentStatus)
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-625) ProduceProcessor use SPI to support extends
[
https://issues.apache.org/jira/browse/SCB-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512160#comment-16512160
]
ASF GitHub Bot commented on SCB-625:
liubao68 commented on a change in pull request #741: [SCB-625] ProduceProcessor
use SPI to support extends
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/741#discussion_r195341712
##
File path:
demo/demo-schema/src/main/java/org/apache/servicecomb/demo/CodeFirstRestTemplate.java
##
@@ -123,6 +128,21 @@ private void testCodeFirstTextPlain(RestTemplate
template, String cseUrlPrefix)
TestMgr.check(body, result);
}
+ private void testCodeFirstAppXml(RestTemplate template, String cseUrlPrefix)
{
+JAXBPerson person = new JAXBPerson("jake", 22, "it", "60kg");
+person.setJob(new JAXBJob("developer", "coding"));
+HttpHeaders headers = new HttpHeaders();
+headers.add("Accept", MediaType.APPLICATION_XML_VALUE);
+headers.add("Content-Type", MediaType.APPLICATION_XML_VALUE);
Review comment:
This demo shows something like we support XML consumer and provider parsing
XML contents. But actually they both working in default to APPLICATION/json.
Anyway, I'll approve this modification.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ProduceProcessor use SPI to support extends
> ---
>
> Key: SCB-625
> URL: https://issues.apache.org/jira/browse/SCB-625
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: WeiChao
>Assignee: WeiChao
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Currently ProduceProcessor supporting text/plain and JSON， needs to be
> changed to SPI to support extensions, e.g. www/url-encoded
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512155#comment-16512155
]
ASF GitHub Bot commented on SCB-651:
limbojinne commented on a change in pull request #770: [SCB-651] Fixes bug of
qps rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195340419
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
Yes, it's same as setting lastRequestCount = 1. I separate the assignment
clause since this issue only occurs at the beginning (i.e. in the first cycle),
but the following cycles operate just as expected.
I committed this modification because I was expecting the number of requests
allowed per second should be equal to the qps limit value. For example, 5
successful requests when setting limit value as 5, no matter that's in a first
cycle or new cycles.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512152#comment-16512152
]
ASF GitHub Bot commented on SCB-651:
limbojinne commented on a change in pull request #770: [SCB-651] Fixes bug of
qps rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195340419
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
Yes, it's same as setting lastRequestCount = 1. I separate the assignment
clause since this issue only occurs at the beginning (i.e. in the first cycle),
but the following cycles operate just as expected.
I committed this modification because I was expecting the number of requests
allowed per second should be equal to the qps limit value. For example, 5
successful requests when setting limit value as 5.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-668) Using docker-compose file to start Services from docker plugin in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-668: - Summary: Using docker-compose file to start Services from docker plugin in the Accept test (was: Using docker-compose file to start Services in the Accept test) > Using docker-compose file to start Services from docker plugin in the Accept > test > - > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > Docker maven plugin support to start the service from > [docker-compose|https://dmp.fabric8.io/#docker-compose], which could save us > some time as we can reuse the docker compose file for the Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512141#comment-16512141
]
ASF GitHub Bot commented on SCB-667:
WillemJiang commented on a change in pull request #769: [SCB-667] fix
gracefully shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195336085
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
-this.initProduceProcessor();
+SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
+if (SCBStatus.UP.equals(currentStatus)) {
+ this.initProduceProcessor();
-this.setContext();
-invocation.getHandlerContext().put(RestConst.REST_REQUEST, requestEx);
+ this.setContext();
+ invocation.getHandlerContext().put(RestConst.REST_REQUEST, requestEx);
-for (HttpServerFilter filter : httpServerFilters) {
- Response response = filter.afterReceiveRequest(invocation, requestEx);
- if (response != null) {
-return response;
+ for (HttpServerFilter filter : httpServerFilters) {
+Response response = filter.afterReceiveRequest(invocation, requestEx);
+if (response != null) {
+ return response;
+}
}
+} else {
+ LOGGER.warn(
+ "System is starting and not ready for remote calls or shutting down
in progress, STATUS = " + currentStatus);
Review comment:
The Request is rejected, as the service provider cannot process the request
due to STATUS = (you can add the status information here).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-668) Using docker-compose file to start Services in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-668: - Description: Docker maven plugin support to start the service from [docker-compose|https://dmp.fabric8.io/#docker-compose], which could save us some time as we can reuse the docker compose file for the Accept test. (was: Docker maven plugin support to start the service from docker-compose, which could save us some time as we can reuse the docker compose file for the Accept test.) > Using docker-compose file to start Services in the Accept test > -- > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > Docker maven plugin support to start the service from > [docker-compose|https://dmp.fabric8.io/#docker-compose], which could save us > some time as we can reuse the docker compose file for the Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-668) Using docker-compose file to start Services in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-668: - Description: Docker maven plugin support to start the service from docker-compose, which could save us some time as we can reuse the docker compose file for the Accept test. (was: Docker maven plugin support to set the service from docker compose, which could save us some time as we can reuse the docker compose file for the Accept test.) > Using docker-compose file to start Services in the Accept test > -- > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > Docker maven plugin support to start the service from docker-compose, which > could save us some time as we can reuse the docker compose file for the > Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-668) Using docker-compose file to start Services in the Accept test
[ https://issues.apache.org/jira/browse/SCB-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-668: - Description: Docker maven plugin support to set the service from docker compose, which could save us some time as we can reuse the docker compose file for the Accept test. (was: Please take SCB-631 as a example start the docker images that Accept test need from Java process.) > Using docker-compose file to start Services in the Accept test > -- > > Key: SCB-668 > URL: https://issues.apache.org/jira/browse/SCB-668 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > Docker maven plugin support to set the service from docker compose, which > could save us some time as we can reuse the docker compose file for the > Accept test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[
https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512119#comment-16512119
]
ASF GitHub Bot commented on SCB-651:
liubao68 commented on a change in pull request #770: [SCB-651] Fixes bug of qps
rate limit value
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#discussion_r195332212
##
File path:
handlers/handler-flowcontrol-qps/src/main/java/org/apache/servicecomb/qps/QpsController.java
##
@@ -57,6 +60,11 @@ public void setQpsLimit(Integer qpsLimit) {
public boolean isLimitNewRequest() {
long newCount = requestCount.incrementAndGet();
long msNow = System.currentTimeMillis();
+if (firstCycle) {
Review comment:
Is this solution the same as set lastRequestCount = 1?
In concurrent scenario, flow control is not work very precisely as the
configured rate. In practice, we can not assume a concrete rate and will set
the limit a bit higher than the expected value.
So I think this modification is not quit necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> QPS rate limit bug
> --
>
> Key: SCB-651
> URL: https://issues.apache.org/jira/browse/SCB-651
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: Sean Li
>Assignee: Sean Li
>Priority: Major
> Attachments: limit value as 1.jpeg, limit value as 2.jpeg
>
>
> When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the
> actual number of requests allowed per second are 1 less than the limit value.
>
> For example, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 1, I'll get NO successful request at the very
> beginning, although I would expect 1 successful request instead of none.
> Similarly, if I set _flowcontrol.Provider.qps.limit._
> _business-service-consumer_ as 2, I'll get 1 successful request instead of
> 2.
>
> -However, if I pause before sending requests, for example add
> _Thread.sleep(100)_ before invoking the first request, the number of requests
> allowed per second will be correct this time. (i.e. 1 successful request when
> limit value is 1, 2 successful requests when limit value is 2, etc.)-
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[ https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512099#comment-16512099 ] ASF GitHub Bot commented on SCB-651: coveralls commented on issue #770: [SCB-651] Fixes bug of qps rate limit value URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/770#issuecomment-397202923 [](https://coveralls.io/builds/17485864) Coverage increased (+0.02%) to 87.377% when pulling **2f4912fa7a05234c4ef864df3a0735de3c561c39 on limbojinne:patch-1** into **b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QPS rate limit bug > -- > > Key: SCB-651 > URL: https://issues.apache.org/jira/browse/SCB-651 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: Sean Li >Assignee: Sean Li >Priority: Major > Attachments: limit value as 1.jpeg, limit value as 2.jpeg > > > When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the > actual number of requests allowed per second are 1 less than the limit value. > > For example, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 1, I'll get NO successful request at the very > beginning, although I would expect 1 successful request instead of none. > Similarly, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 2, I'll get 1 successful request instead of > 2. > > -However, if I pause before sending requests, for example add > _Thread.sleep(100)_ before invoking the first request, the number of requests > allowed per second will be correct this time. (i.e. 1 successful request when > limit value is 1, 2 successful requests when limit value is 2, etc.)- > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-670) Check the etcd cluster health when new connection
[ https://issues.apache.org/jira/browse/SCB-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512095#comment-16512095 ] ASF GitHub Bot commented on SCB-670: codecov-io commented on issue #374: SCB-670 Check the etcd cluster health when new connection URL: https://github.com/apache/incubator-servicecomb-service-center/pull/374#issuecomment-397202205 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=h1) Report > Merging [#374](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/cb913ba39b69c8161a02593ab13c64a2fd3250d2?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #374 +/- ## === Coverage 71.46% 71.46% === Files 25 25 Lines3690 3690 === Hits 2637 2637 Misses884 884 Partials 169 169 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=footer). Last update [cb913ba...bd85b73](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/374?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Check the etcd cluster health when new connection > - > > Key: SCB-670 > URL: https://issues.apache.org/jira/browse/SCB-670 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-670) Check the etcd cluster health when new connection
[ https://issues.apache.org/jira/browse/SCB-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512096#comment-16512096 ] ASF GitHub Bot commented on SCB-670: coveralls commented on issue #374: SCB-670 Check the etcd cluster health when new connection URL: https://github.com/apache/incubator-servicecomb-service-center/pull/374#issuecomment-397202249 [](https://coveralls.io/builds/17485900) Coverage increased (+0.2%) to 74.705% when pulling **bd85b7378b0da5159098b66f7f836d2b39423d19 on little-cui:cluster** into **cb913ba39b69c8161a02593ab13c64a2fd3250d2 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Check the etcd cluster health when new connection > - > > Key: SCB-670 > URL: https://issues.apache.org/jira/browse/SCB-670 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512091#comment-16512091
]
ASF GitHub Bot commented on SCB-630:
SingleX opened a new pull request #209: SCB-630 Active the -Pdocker profile if
detect the docker installation
URL: https://github.com/apache/incubator-servicecomb-saga/pull/209
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
- [X] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [X] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [X] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512081#comment-16512081
]
Gao Xin commented on SCB-630:
-
With the newest offical docker CE, it does not need `DOCKER_HOST` any more。
There are other problems in keeping this configuration for compatibility.
Unfortunately, maven `` block changed from a list of `OR` to 'AND'
since 3.2.2.
references:
[https://stackoverflow.com/questions/4629140/maven-profile-activation-with-multiple-conditions]
https://issues.apache.org/jira/browse/MNG-4565
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[ https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512080#comment-16512080 ] ASF GitHub Bot commented on SCB-667: coveralls commented on issue #769: [SCB-667] fix gracefully shutdown is not work in some case URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#issuecomment-397200436 [](https://coveralls.io/builds/17485329) Coverage decreased (-0.1%) to 87.225% when pulling **4d595f7d555296883976cab5d8f54ec81d0e76ac on zhengyangyong:SCB-667** into **b81196f6eedf220dfb87b77b3a548cd201a7f3ac on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > gracefully shutdown is not work in some case > > > Key: SCB-667 > URL: https://issues.apache.org/jira/browse/SCB-667 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > In some case like consumer never stop sending request to prodiver, privider > do not reject new request from consumer and still process them, > So shutdown will be blocked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-670) Check the etcd cluster health when new connection
[ https://issues.apache.org/jira/browse/SCB-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512075#comment-16512075 ] ASF GitHub Bot commented on SCB-670: little-cui opened a new pull request #374: SCB-670 Check the etcd cluster health when new connection URL: https://github.com/apache/incubator-servicecomb-service-center/pull/374 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Check the etcd cluster health when new connection > - > > Key: SCB-670 > URL: https://issues.apache.org/jira/browse/SCB-670 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-670) Check the etcd cluster health when new connection
[ https://issues.apache.org/jira/browse/SCB-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-670. Resolution: Fixed > Check the etcd cluster health when new connection > - > > Key: SCB-670 > URL: https://issues.apache.org/jira/browse/SCB-670 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-631) Using testcontainers to start the alpha server in the integration test
[ https://issues.apache.org/jira/browse/SCB-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-631: - Description: testcontainers provides an easy way to start the docker image from java. It could make us easy to debug the integration test from the IDE. Now we can start to use it in the saga integration tests. [https://www.testcontainers.org/] was: testcontainers provides an easy way to start the docker image from java. It could make us easy to debug the integration test from the IDE. Now we can start to use it in the saga integration tests. [https://www.testcontainers.org/] > Using testcontainers to start the alpha server in the integration test > -- > > Key: SCB-631 > URL: https://issues.apache.org/jira/browse/SCB-631 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > Labels: newbie > > testcontainers provides an easy way to start the docker image from java. > It could make us easy to debug the integration test from the IDE. > Now we can start to use it in the saga integration tests. > [https://www.testcontainers.org/] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-630) Active the -Pdocker profile if detect the docker installation
[
https://issues.apache.org/jira/browse/SCB-630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang reassigned SCB-630:
Assignee: Gao Xin
> Active the -Pdocker profile if detect the docker installation
> --
>
> Key: SCB-630
> URL: https://issues.apache.org/jira/browse/SCB-630
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
>Reporter: Willem Jiang
>Assignee: Gao Xin
>Priority: Major
> Labels: easyfix, newbie
> Fix For: saga-0.3.0
>
>
> Currently we use the -Pdocker to use the docker enabled feature to avoid the
> build failure if there is no docker installation.
> Now we can use the maven [profile with
> activation|https://books.sonatype.com/mvnref-book/reference/profiles-sect-activation.html]
> to enable the docker profile automatically.
> {code}
>
>
> /var/run/docker.sock
>
>
> env.DOCKER_HOST
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-651) QPS rate limit bug
[ https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512056#comment-16512056 ] ASF GitHub Bot commented on SCB-651: limbojinne opened a new pull request #770: [SCB-651] Fixes bug of qps rate limit value URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/770 Added the logic for the first cycle of qps controller so that the number of requests allowed per second equals to its limit value. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > QPS rate limit bug > -- > > Key: SCB-651 > URL: https://issues.apache.org/jira/browse/SCB-651 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: Sean Li >Assignee: Sean Li >Priority: Major > Attachments: limit value as 1.jpeg, limit value as 2.jpeg > > > When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the > actual number of requests allowed per second are 1 less than the limit value. > > For example, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 1, I'll get NO successful request at the very > beginning, although I would expect 1 successful request instead of none. > Similarly, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 2, I'll get 1 successful request instead of > 2. > > -However, if I pause before sending requests, for example add > _Thread.sleep(100)_ before invoking the first request, the number of requests > allowed per second will be correct this time. (i.e. 1 successful request when > limit value is 1, 2 successful requests when limit value is 2, etc.)- > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-651) QPS rate limit bug
[ https://issues.apache.org/jira/browse/SCB-651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Li updated SCB-651: Description: When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the actual number of requests allowed per second are 1 less than the limit value. For example, if I set _flowcontrol.Provider.qps.limit._ _business-service-consumer_ as 1, I'll get NO successful request at the very beginning, although I would expect 1 successful request instead of none. Similarly, if I set _flowcontrol.Provider.qps.limit._ _business-service-consumer_ as 2, I'll get 1 successful request instead of 2. -However, if I pause before sending requests, for example add _Thread.sleep(100)_ before invoking the first request, the number of requests allowed per second will be correct this time. (i.e. 1 successful request when limit value is 1, 2 successful requests when limit value is 2, etc.)- was: When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the actual number of requests allowed per second is always 1 less than the limit value. For example, if I set _flowcontrol.Provider.qps.limit._ _business-service-consumer_ as 1, I'll get NO successful request at the very beginning, although I would expect 1 successful request instead of none. Similarly, if I set _flowcontrol.Provider.qps.limit._ _business-service-consumer_ as 2, I'll get 1 successful request instead of 2. -However, if I pause before sending requests, for example add _Thread.sleep(100)_ before invoking the first request, the number of requests allowed per second will be correct this time. (i.e. 1 successful request when limit value is 1, 2 successful requests when limit value is 2, etc.)- > QPS rate limit bug > -- > > Key: SCB-651 > URL: https://issues.apache.org/jira/browse/SCB-651 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: Sean Li >Assignee: Sean Li >Priority: Major > Attachments: limit value as 1.jpeg, limit value as 2.jpeg > > > When setting _servicecomb.flowcontrol.Provider.qps.limit.[ServiceName]_, the > actual number of requests allowed per second are 1 less than the limit value. > > For example, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 1, I'll get NO successful request at the very > beginning, although I would expect 1 successful request instead of none. > Similarly, if I set _flowcontrol.Provider.qps.limit._ > _business-service-consumer_ as 2, I'll get 1 successful request instead of > 2. > > -However, if I pause before sending requests, for example add > _Thread.sleep(100)_ before invoking the first request, the number of requests > allowed per second will be correct this time. (i.e. 1 successful request when > limit value is 1, 2 successful requests when limit value is 2, etc.)- > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512046#comment-16512046
]
ASF GitHub Bot commented on SCB-667:
wujimin commented on a change in pull request #769: [SCB-667] fix gracefully
shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195317868
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
-this.initProduceProcessor();
+SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
Review comment:
is it possible check in InvocationFactory.forProvider?
if need to send response, then catch exception for "forProvider"
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512040#comment-16512040
]
ASF GitHub Bot commented on SCB-667:
wujimin commented on a change in pull request #769: [SCB-667] fix gracefully
shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195315524
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -160,16 +163,24 @@ public void invoke() {
}
protected Response prepareInvoke() throws Throwable {
-this.initProduceProcessor();
+SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
Review comment:
why not just invoke ensureStatusUp, or refactor ensureStatusUp, so that no
need to write the error message everywhere
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[
https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512038#comment-16512038
]
ASF GitHub Bot commented on SCB-667:
wujimin commented on a change in pull request #769: [SCB-667] fix gracefully
shutdown is not work in some case
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/769#discussion_r195315235
##
File path:
providers/provider-pojo/src/main/java/org/apache/servicecomb/provider/pojo/Invoker.java
##
@@ -57,7 +58,10 @@ public InvokerMeta(ReferenceConfig referenceConfig,
// initialized and meta not changed
public boolean isValid() {
- return swaggerConsumer != null && microserviceMeta ==
referenceConfig.getMicroserviceMeta();
+ SCBStatus currentStatus = SCBEngine.getInstance().getStatus();
+ return SCBStatus.UP.equals(currentStatus)
Review comment:
when shutdown, this will cause createInvokerMeta again, not throw exception
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gracefully shutdown is not work in some case
>
>
> Key: SCB-667
> URL: https://issues.apache.org/jira/browse/SCB-667
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Affects Versions: java-chassis-1.0.0-m1
>Reporter: yangyongzheng
>Assignee: yangyongzheng
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> In some case like consumer never stop sending request to prodiver, privider
> do not reject new request from consumer and still process them,
> So shutdown will be blocked.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-667) gracefully shutdown is not work in some case
[ https://issues.apache.org/jira/browse/SCB-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512029#comment-16512029 ] ASF GitHub Bot commented on SCB-667: zhengyangyong opened a new pull request #769: [SCB-667] fix gracefully shutdown is not work in some case URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/769 Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > gracefully shutdown is not work in some case > > > Key: SCB-667 > URL: https://issues.apache.org/jira/browse/SCB-667 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m1 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > In some case like consumer never stop sending request to prodiver, privider > do not reject new request from consumer and still process them, > So shutdown will be blocked. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
