[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577848#comment-16577848
]
ASF GitHub Bot commented on SCB-736:
maheshrajus commented on a change in pull request #863: [SCB-736] generate
default value to swagger for primitive type when there is no defaultValue
annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r209494618
##
File path:
demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
##
@@ -88,4 +88,34 @@ public String queryPackages(HttpServletRequest httpRequest,
return "" + appType;
}
+ @Path("/javaprimitive1")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrim1(@FormParam("a") int a, @DefaultValue("bobo")
@FormParam("b") String b) {
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-792) More abundant metrics information
[
https://issues.apache.org/jira/browse/SCB-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577835#comment-16577835
]
ASF GitHub Bot commented on SCB-792:
asifdxtreme closed pull request #413: SCB-792 More abundant metrics information
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/413
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/pkg/buffer/pool.go b/pkg/buffer/pool.go
new file mode 100644
index ..66d7ecde
--- /dev/null
+++ b/pkg/buffer/pool.go
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package buffer
+
+import (
+ "bytes"
+ "sync"
+)
+
+type Pool struct {
+ pool sync.Pool
+}
+
+func (p *Pool) Get() *bytes.Buffer {
+ return p.pool.Get().(*bytes.Buffer)
+}
+
+func (p *Pool) Put(buf *bytes.Buffer) {
+ buf.Reset()
+ p.pool.Put(buf)
+}
+
+func NewPool(s int) *Pool {
+ return {
+ pool: sync.Pool{
+ New: func() interface{} {
+ b := bytes.NewBuffer(make([]byte, s))
+ b.Reset()
+ return b
+ },
+ },
+ }
+}
diff --git a/pkg/buffer/pool_test.go b/pkg/buffer/pool_test.go
new file mode 100644
index ..959b2597
--- /dev/null
+++ b/pkg/buffer/pool_test.go
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package buffer
+
+import (
+ "strings"
+ "testing"
+)
+
+func TestNewPool(t *testing.T) {
+ p := NewPool(10)
+ b := p.Get()
+ if b == nil {
+ t.Fatalf("TestNewPool falied")
+ }
+ b.WriteString("a")
+ if b.String() != "a" {
+ t.Fatalf("TestNewPool falied")
+ }
+ p.Put(b)
+ b = p.Get()
+ if b == nil || b.Len() != 0 {
+ t.Fatalf("TestNewPool falied")
+ }
+}
+
+func BenchmarkNewPool(b *testing.B) {
+ p := NewPool(4 * 10)
+ s := strings.Repeat("a", 4*1024)
+ b.ResetTimer()
+ b.RunParallel(func(pb *testing.PB) {
+ for pb.Next() {
+ buf := p.Get()
+ buf.WriteString(s)
+ _ = buf.String()
+ p.Put(buf)
+ }
+ })
+ b.ReportAllocs()
+ // 200 872 ns/op4098 B/op 1
allocs/op
+}
diff --git a/pkg/rest/route.go b/pkg/rest/route.go
index 7e2088c2..084fe44b 100644
--- a/pkg/rest/route.go
+++ b/pkg/rest/route.go
@@ -71,7 +71,7 @@ func (this *ROAServerHandler) addRoute(route *Route) (err
error) {
this.handlers[method] = append(this.handlers[method],
{
util.FormatFuncName(util.FuncName(route.Func)), route.Path,
http.HandlerFunc(route.Func)})
- util.Logger().Infof("register route %s(%s).", route.Path, method)
+ util.Logger().Infof("register route %s(%s)", route.Path, method)
return nil
}
diff --git a/pkg/util/concurrent_map.go b/pkg/util/concurrent_map.go
index fce2c3ce..6c6a484a 100644
--- a/pkg/util/concurrent_map.go
+++ b/pkg/util/concurrent_map.go
@@ -1,19 +1,20 @@
-/*
-
[jira] [Created] (SCB-837) make http2 production ready
wujimin created SCB-837: --- Summary: make http2 production ready Key: SCB-837 URL: https://issues.apache.org/jira/browse/SCB-837 Project: Apache ServiceComb Issue Type: Improvement Components: Java-Chassis Reporter: wujimin Fix For: java-chassis-1.1.0 currenty, http2 client use all http1.1 settings, that cause http2 client performance is so bad. we need to conside http2 client settings at least: 1.concurrent stream in one connection, default value is 3, we must make it bigger 2.maxPoolSize, http1.1 need a big pool, but http2 need a big concurrent stream count we must perform a performance test, that make sure got a good result, and then set the setting to be our default setting. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-836) Support the nesting SagaStart
[ https://issues.apache.org/jira/browse/SCB-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-836: - Description: We can take the [nesting-lras|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#323-nesting-lras] from the microprofile as an example. An activity can be scoped within an existing Saga using the @NestedSaga annotation. Invoking a method marked with this annotation will start a new Saga whose outcome depends upon whether the enclosing Saga is closed or cancelled. * If the nested Saga is closed but the outer Saga is cancelled then the participants registered with the nested Saga will be told to compensate. * If the nested Saga is cancelled the outer Saga can be still closed. > Support the nesting SagaStart > - > > Key: SCB-836 > URL: https://issues.apache.org/jira/browse/SCB-836 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We can take the > [nesting-lras|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#323-nesting-lras] > from the microprofile as an example. > An activity can be scoped within an existing Saga using the @NestedSaga > annotation. Invoking a method marked with this annotation will start a new > Saga whose outcome depends upon whether the enclosing Saga is closed or > cancelled. > * If the nested Saga is closed but the outer Saga is cancelled then the > participants registered with the nested Saga will be told to compensate. > * If the nested Saga is cancelled the outer Saga can be still closed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-836) Support the nesting SagaStart
[ https://issues.apache.org/jira/browse/SCB-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-836: - Summary: Support the nesting SagaStart (was: Support the of SagaStart) > Support the nesting SagaStart > - > > Key: SCB-836 > URL: https://issues.apache.org/jira/browse/SCB-836 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-836) Support the of SagaStart
[ https://issues.apache.org/jira/browse/SCB-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-836: - Summary: Support the of SagaStart (was: SagaStart) > Support the of SagaStart > - > > Key: SCB-836 > URL: https://issues.apache.org/jira/browse/SCB-836 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-836) SagaStart
[ https://issues.apache.org/jira/browse/SCB-836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-836: - Component/s: Saga > SagaStart > - > > Key: SCB-836 > URL: https://issues.apache.org/jira/browse/SCB-836 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-836) SagaStart
Willem Jiang created SCB-836: Summary: SagaStart Key: SCB-836 URL: https://issues.apache.org/jira/browse/SCB-836 Project: Apache ServiceComb Issue Type: Improvement Reporter: Willem Jiang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-268) [pack] compact events to remove unnecessary fields
[ https://issues.apache.org/jira/browse/SCB-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577788#comment-16577788 ] Willem Jiang commented on SCB-268: -- In the [micro-profile LRA|https://github.com/eclipse/microprofile-lra/blob/master/spec/src/main/asciidoc/microprofile-lra-spec.adoc#322-compensating-activities], it just use the LRA reference id as the parameters for the participate to do the compensation work. Now we can do the same thing with the help of SCB-785 to reduce the efforts between the omega and alpha. Using the Global transaction ID and Local transaction ID or（LRA） with the local service persistent store can help us find out the context for recovery or retry. > [pack] compact events to remove unnecessary fields > -- > > Key: SCB-268 > URL: https://issues.apache.org/jira/browse/SCB-268 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Yin Xiang >Assignee: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > only TxStartedEvent needs to contain all tx information. > Asking other events to provide info such as payloads, compensationMethod, > parentTxId, etc. is not necessary. > > compacting events not only reduces network load and null/duplicate data in > database -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-690) when producer invocation prepare to run in executor, make sure not disconnect/ not time out
[ https://issues.apache.org/jira/browse/SCB-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577759#comment-16577759 ] ASF GitHub Bot commented on SCB-690: zhengyangyong commented on issue #862: [SCB-690] add check if connection is still connected before execute invocation URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/862#issuecomment-412386242 OK,I will cost some time to learn vertx metrics mechanism first This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > when producer invocation prepare to run in executor, make sure not > disconnect/ not time out > --- > > Key: SCB-690 > URL: https://issues.apache.org/jira/browse/SCB-690 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > > vertx rest and highway not control producer timeout > > note: if already running, then could do nothing, just let it go till finished. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-835) Alpha should call the compensation method once it gets the abort event
[ https://issues.apache.org/jira/browse/SCB-835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-835: - Fix Version/s: saga-0.3.0 > Alpha should call the compensation method once it gets the abort event > -- > > Key: SCB-835 > URL: https://issues.apache.org/jira/browse/SCB-835 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > Fix For: saga-0.3.0 > > > It's more straightforward to call the compensation method once Alpha got the > compensation method instead of let the event scanner to do that kind of job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-834) Upgrade akka version to 2.5.14
[ https://issues.apache.org/jira/browse/SCB-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577751#comment-16577751 ] ASF GitHub Bot commented on SCB-834: coveralls commented on issue #248: SCB-834 Upgrade Akka version to 2.5.14 URL: https://github.com/apache/incubator-servicecomb-saga/pull/248#issuecomment-412383733 [](https://coveralls.io/builds/18448729) Coverage increased (+0.04%) to 94.235% when pulling **ada6242049b38076f9d1f713b77e6eebcc5814d7 on SCB-834** into **d75dfe82d8f4a8a5084fdc44187ea01f110f0dfc on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade akka version to 2.5.14 > -- > > Key: SCB-834 > URL: https://issues.apache.org/jira/browse/SCB-834 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-835) Alpha should call the compensation method once it gets the abort event
Willem Jiang created SCB-835: Summary: Alpha should call the compensation method once it gets the abort event Key: SCB-835 URL: https://issues.apache.org/jira/browse/SCB-835 Project: Apache ServiceComb Issue Type: Improvement Components: Saga Reporter: Willem Jiang It's more straightforward to call the compensation method once Alpha got the compensation method instead of let the event scanner to do that kind of job. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-834) Upgrade akka version to 2.5.14
[ https://issues.apache.org/jira/browse/SCB-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577749#comment-16577749 ] ASF GitHub Bot commented on SCB-834: WillemJiang opened a new pull request #248: SCB-834 Upgrade Akka version to 2.5.14 URL: https://github.com/apache/incubator-servicecomb-saga/pull/248 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade akka version to 2.5.14 > -- > > Key: SCB-834 > URL: https://issues.apache.org/jira/browse/SCB-834 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-834) Upgrade akka version to 2.5.14
[ https://issues.apache.org/jira/browse/SCB-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577750#comment-16577750 ] ASF GitHub Bot commented on SCB-834: WillemJiang closed pull request #248: SCB-834 Upgrade Akka version to 2.5.14 URL: https://github.com/apache/incubator-servicecomb-saga/pull/248 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade akka version to 2.5.14 > -- > > Key: SCB-834 > URL: https://issues.apache.org/jira/browse/SCB-834 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-834) Upgrade akka version to 2.5.14
[ https://issues.apache.org/jira/browse/SCB-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577746#comment-16577746 ] ASF GitHub Bot commented on SCB-834: WillemJiang opened a new pull request #248: SCB-834 Upgrade Akka version to 2.5.14 URL: https://github.com/apache/incubator-servicecomb-saga/pull/248 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade akka version to 2.5.14 > -- > > Key: SCB-834 > URL: https://issues.apache.org/jira/browse/SCB-834 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-834) Upgrade akka version to 2.5.14
[ https://issues.apache.org/jira/browse/SCB-834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577748#comment-16577748 ] ASF GitHub Bot commented on SCB-834: WillemJiang closed pull request #248: SCB-834 Upgrade Akka version to 2.5.14 URL: https://github.com/apache/incubator-servicecomb-saga/pull/248 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade akka version to 2.5.14 > -- > > Key: SCB-834 > URL: https://issues.apache.org/jira/browse/SCB-834 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > > We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-827) Add response decode error log
[
https://issues.apache.org/jira/browse/SCB-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577628#comment-16577628
]
ASF GitHub Bot commented on SCB-827:
yhs0092 commented on a change in pull request #865: [SCB-827] Add response body
decoding error log
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/865#discussion_r209459205
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
##
@@ -79,13 +82,15 @@ protected Object extractResult(Invocation invocation,
HttpServletResponseEx resp
responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(),
responseEx.getHeader(HttpHeaders.CONTENT_TYPE));
+ LOGGER.error(msg);
return ExceptionFactory.createConsumerException(new
InvocationException(responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(), msg));
}
try {
return produceProcessor.decodeResponse(responseEx.getBodyBuffer(),
responseMeta.getJavaType());
} catch (Exception e) {
- return ExceptionFactory.createConsumerException(e);
+ LOGGER.error("failed to decode response body", e);
+ throw ExceptionFactory.createConsumerException(e);
Review comment:
Get it.. Maybe we can throw the `InvocationException` directly? After
all, a none 2xx response will be transferred into an `Exception` in
`Invoker.syncInvoke()` and `CseClientHttpRequest.invoke()`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add response decode error log
> -
>
> Key: SCB-827
> URL: https://issues.apache.org/jira/browse/SCB-827
> Project: Apache ServiceComb
> Issue Type: Improvement
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> In DefaultHttpClientFilter.extractResult(), once response decode error
> occurs, it will be caught and set into an InvocationException, and the
> InvocationException will be treated as response body, which will cause
> confusing result.
> We need to print some logs to help developers locate such problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[ https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577480#comment-16577480 ] ASF GitHub Bot commented on SCB-612: coveralls edited a comment on issue #861: [SCB-612]delete useless MicroserviceMetaManager URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#issuecomment-411266453 [](https://coveralls.io/builds/18443779) Coverage increased (+1.2%) to 86.417% when pulling **0ed0be36e548963147e9afa0d1056c1f19ef4ebc on heyile:cse-612** into **7abb7b12636fc9040a18778246260b9f438e4bdb on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > delete useless MicroserviceMetaManager > -- > > Key: SCB-612 > URL: https://issues.apache.org/jira/browse/SCB-612 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Priority: Major > Labels: newbie > > in previous versions, consumer and producer microserviceMeta all managed by > MicroserviceMetaManager > > currently: > all consumer MicroserviceMeta managed by AppManager > only producer MicroserviceMeta remains in MicroserviceMetaManager, there is > only one MicroserviceMeta instance, so MicroserviceMetaManager is useless > just move producer MicroserviceMeta to SCBEngine is enough -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-736) generate default value to swagger for primitive type, even there is no defaultValue annotation
[
https://issues.apache.org/jira/browse/SCB-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577460#comment-16577460
]
ASF GitHub Bot commented on SCB-736:
wujimin commented on a change in pull request #863: [SCB-736] generate default
value to swagger for primitive type when there is no defaultValue annotation
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/863#discussion_r209447957
##
File path:
demo/demo-jaxrs/jaxrs-server/src/main/java/org/apache/servicecomb/demo/jaxrs/server/JaxRSDefaultValues.java
##
@@ -88,4 +88,34 @@ public String queryPackages(HttpServletRequest httpRequest,
return "" + appType;
}
+ @Path("/javaprimitive1")
+ @POST
+ @Consumes(MediaType.APPLICATION_FORM_URLENCODED)
+ public String jaxRsJavaPrim1(@FormParam("a") int a, @DefaultValue("bobo")
@FormParam("b") String b) {
Review comment:
test case for different parameter type, do not named them 1/2/3/4..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> generate default value to swagger for primitive type, even there is no
> defaultValue annotation
> --
>
> Key: SCB-736
> URL: https://issues.apache.org/jira/browse/SCB-736
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
>
> {code:java}
> @GetMapping(path = "test")
> public String test(int i, boolean b) {
> return "" + i + b;
> }
> {code}
> request without any query parameter should be ok
> must include all primitive types.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SCB-834) Upgrade akka version to 2.5.14
Willem Jiang created SCB-834: Summary: Upgrade akka version to 2.5.14 Key: SCB-834 URL: https://issues.apache.org/jira/browse/SCB-834 Project: Apache ServiceComb Issue Type: Improvement Components: Saga Reporter: Willem Jiang We could consider to upgrade the akka version to 2.5.14. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-827) Add response decode error log
[
https://issues.apache.org/jira/browse/SCB-827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577457#comment-16577457
]
ASF GitHub Bot commented on SCB-827:
wujimin commented on a change in pull request #865: [SCB-827] Add response body
decoding error log
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/865#discussion_r209447470
##
File path:
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/DefaultHttpClientFilter.java
##
@@ -79,13 +82,15 @@ protected Object extractResult(Invocation invocation,
HttpServletResponseEx resp
responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(),
responseEx.getHeader(HttpHeaders.CONTENT_TYPE));
+ LOGGER.error(msg);
return ExceptionFactory.createConsumerException(new
InvocationException(responseEx.getStatus(),
responseEx.getStatusType().getReasonPhrase(), msg));
}
try {
return produceProcessor.decodeResponse(responseEx.getBodyBuffer(),
responseMeta.getJavaType());
} catch (Exception e) {
- return ExceptionFactory.createConsumerException(e);
+ LOGGER.error("failed to decode response body", e);
+ throw ExceptionFactory.createConsumerException(e);
Review comment:
oh, i means result of the method change form "result" to "Response"
otherwise line 86 still have problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add response decode error log
> -
>
> Key: SCB-827
> URL: https://issues.apache.org/jira/browse/SCB-827
> Project: Apache ServiceComb
> Issue Type: Improvement
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> In DefaultHttpClientFilter.extractResult(), once response decode error
> occurs, it will be caught and set into an InvocationException, and the
> InvocationException will be treated as response body, which will cause
> confusing result.
> We need to print some logs to help developers locate such problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577456#comment-16577456
]
ASF GitHub Bot commented on SCB-612:
wujimin commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r209447409
##
File path:
dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
##
@@ -404,13 +404,13 @@ public void refreshConfig(String configcenter, boolean
wait) {
request.end();
});
if (wait) {
-LOGGER.info("Refreshing remote config...");
+LOGGER.debug("Refreshing remote config...");
Review comment:
who do this change?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete useless MicroserviceMetaManager
> --
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577455#comment-16577455
]
ASF GitHub Bot commented on SCB-612:
wujimin commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r209447392
##
File path:
core/src/test/java/org/apache/servicecomb/core/definition/schema/TestProducerSchemaFactory.java
##
@@ -93,8 +90,7 @@ public static void init() {
};
new MockUp() {
@SuppressWarnings("unchecked")
- @Mock
- T getBean(String name) {
+ @Mock T getBean(String name) {
Review comment:
impossible
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete useless MicroserviceMetaManager
> --
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-612) delete useless MicroserviceMetaManager
[
https://issues.apache.org/jira/browse/SCB-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577454#comment-16577454
]
ASF GitHub Bot commented on SCB-612:
wujimin commented on a change in pull request #861: [SCB-612]delete useless
MicroserviceMetaManager
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/861#discussion_r209447384
##
File path:
core/src/main/java/org/apache/servicecomb/core/definition/loader/SchemaListenerManager.java
##
@@ -74,12 +71,22 @@ public void notifySchemaListener(List
schemaMetaList) {
}
public SchemaMeta ensureFindSchemaMeta(String microserviceName, String
schemaId) {
-MicroserviceMeta microserviceMeta =
microserviceMetaManager.ensureFindValue(microserviceName);
+if
(!RegistryUtils.getMicroservice().getServiceName().equals(microserviceName)) {
+ LOGGER.error("miroserviceName : {} is different from the default
microserviceName :{}",
+ microserviceName,
+ RegistryUtils.getMicroservice().getServiceName());
Review comment:
but the go on logic, will make producerMicroserviceMeta incorrect.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> delete useless MicroserviceMetaManager
> --
>
> Key: SCB-612
> URL: https://issues.apache.org/jira/browse/SCB-612
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
>Reporter: wujimin
>Priority: Major
> Labels: newbie
>
> in previous versions, consumer and producer microserviceMeta all managed by
> MicroserviceMetaManager
>
> currently:
> all consumer MicroserviceMeta managed by AppManager
> only producer MicroserviceMeta remains in MicroserviceMetaManager, there is
> only one MicroserviceMeta instance, so MicroserviceMetaManager is useless
> just move producer MicroserviceMeta to SCBEngine is enough
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
