[jira] [Commented] (SCB-985) Add springboot2-starter-discovery

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664732#comment-16664732
 ] 

ASF GitHub Bot commented on SCB-985:


yangbor opened a new pull request #969: [SCB-985] Add 
spring-boot2-starter-discovery
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/969
 
 
   The code is copied from springboot-starter-discovery and test code
   is removed. Adjusted the springboot and spring cloud versions for
   compatibility issues.
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add springboot2-starter-discovery
> -
>
> Key: SCB-985
> URL: https://issues.apache.org/jira/browse/SCB-985
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Affects Versions: java-chassis-1.1.0
>Reporter: Yang Bo
>Assignee: Yang Bo
>Priority: Major
>
> Copied springboot-starter-discovery to spritnboot2. Removed test code and 
> updated some spring-boot and spring-cloud versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-985) Add springboot2-starter-discovery

2018-10-25 Thread Yang Bo (JIRA)
Yang Bo created SCB-985:
---

 Summary: Add springboot2-starter-discovery
 Key: SCB-985
 URL: https://issues.apache.org/jira/browse/SCB-985
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Java-Chassis
Affects Versions: java-chassis-1.1.0
Reporter: Yang Bo
Assignee: Yang Bo


Copied springboot-starter-discovery to spritnboot2. Removed test code and 
updated some spring-boot and spring-cloud versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-983) Output the QPS per domain

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664719#comment-16664719
 ] 

ASF GitHub Bot commented on SCB-983:


tianxiaoliang commented on issue #467: SCB-983 Output the QPS per domain
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/467#issuecomment-433300851
 
 
   ok


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Output the QPS per domain
> -
>
> Key: SCB-983
> URL: https://issues.apache.org/jira/browse/SCB-983
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SCB-982) Show the warning message in maven compile plugin

2018-10-25 Thread wujimin (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wujimin reassigned SCB-982:
---

Assignee: wujimin

> Show the warning message in maven compile plugin
> 
>
> Key: SCB-982
> URL: https://issues.apache.org/jira/browse/SCB-982
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis, Saga
>Reporter: Willem Jiang
>Assignee: wujimin
>Priority: Major
>  Labels: easyfix, newbie
>
> It could help us find more waring message durning the developing time.
>  {code}
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
>   3.1
>   
>     1.8
>     1.8
>     true
>     true
>     
>       -Werror
>       -Xlint:all
>     
>   
> 
>  {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-983) Output the QPS per domain

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664693#comment-16664693
 ] 

ASF GitHub Bot commented on SCB-983:


coveralls commented on issue #467: SCB-983 Output the QPS per domain
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/467#issuecomment-433291475
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19734519/badge)](https://coveralls.io/builds/19734519)
   
   Coverage decreased (-0.05%) to 62.642% when pulling 
**ef18b3f9cfd6570e2251351da7d4cace5372f07c on little-cui:metrics** into 
**c5473e0d125130abd8e5469566fcf4c24cbab965 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Output the QPS per domain
> -
>
> Key: SCB-983
> URL: https://issues.apache.org/jira/browse/SCB-983
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-983) Output the QPS per domain

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664691#comment-16664691
 ] 

ASF GitHub Bot commented on SCB-983:


codecov-io commented on issue #467: SCB-983 Output the QPS per domain
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/467#issuecomment-433291461
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=h1)
 Report
   > Merging 
[#467](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/c5473e0d125130abd8e5469566fcf4c24cbab965?src=pr&el=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#467  +/-   ##
   =
   + Coverage   60.17%   60.2%   +0.02% 
   =
 Files 156 156  
 Lines   13410   13410  
   =
   + Hits 80708074   +4 
 Misses   47594759  
   + Partials  581 577   -4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv)
 | `57.94% <0%> (+0.15%)` | :arrow_up: |
   | 
[pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=)
 | `34.28% <0%> (+0.57%)` | :arrow_up: |
   | 
[pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==)
 | `67.56% <0%> (+1.35%)` | :arrow_up: |
   | 
[server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv)
 | `81.81% <0%> (+9.09%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=footer).
 Last update 
[c5473e0...ef18b3f](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/467?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Output the QPS per domain
> -
>
> Key: SCB-983
> URL: https://issues.apache.org/jira/browse/SCB-983
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-983) Output the QPS per domain

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664663#comment-16664663
 ] 

ASF GitHub Bot commented on SCB-983:


little-cui opened a new pull request #467: SCB-983 Output the QPS per domain
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/467
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Output the QPS per domain
> -
>
> Key: SCB-983
> URL: https://issues.apache.org/jira/browse/SCB-983
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-984) Add Health Check command

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664661#comment-16664661
 ] 

ASF GitHub Bot commented on SCB-984:


little-cui opened a new pull request #466: SCB-984 Add Health Check command
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/466
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Health Check command
> 
>
> Key: SCB-984
> URL: https://issues.apache.org/jira/browse/SCB-984
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-984) Add Health Check command

2018-10-25 Thread little-cui (JIRA)
little-cui created SCB-984:
--

 Summary: Add Health Check command
 Key: SCB-984
 URL: https://issues.apache.org/jira/browse/SCB-984
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Service-Center
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SCB-975) Improve retry rule

2018-10-25 Thread jeho0815 (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jeho0815 closed SCB-975.


> Improve retry rule
> --
>
> Key: SCB-975
> URL: https://issues.apache.org/jira/browse/SCB-975
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> current loadbalance retry rule is ConnectionException and 
> socketTimeoutException, really has some IOException and VertxException 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SCB-975) Improve retry rule

2018-10-25 Thread jeho0815 (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jeho0815 resolved SCB-975.
--
Resolution: Fixed

> Improve retry rule
> --
>
> Key: SCB-975
> URL: https://issues.apache.org/jira/browse/SCB-975
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
> current loadbalance retry rule is ConnectionException and 
> socketTimeoutException, really has some IOException and VertxException 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-891) Add kamon metrics to Omega client

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664577#comment-16664577
 ] 

ASF GitHub Bot commented on SCB-891:


zhfeng commented on issue #314: [SCB-891] Add kamon metrics to Omega client
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/314#issuecomment-433267765
 
 
   @WillemJiang can you add your review as the changes request ? Btw, do you 
have any suggest to build this trace stack ?
   It might be useful to add some references to help @maheshrajus  to 
understand.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add kamon metrics to Omega client
> -
>
> Key: SCB-891
> URL: https://issues.apache.org/jira/browse/SCB-891
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Mahesh Raju Somalaraju
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
> Fix For: saga-0.3.0
>
>
> Need to add Kamon traces/metrics to omega client.
> Need to find the major flows in omega client side and need to add the kamon 
> annotations for traces/metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-975) Improve retry rule

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664564#comment-16664564
 ] 

ASF GitHub Bot commented on SCB-975:


wujimin closed pull request #966: [SCB-975] add some special exception to 
loadbalance default retry han…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/966
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
 
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
index ea23aca6c..5a61dc7b3 100644
--- 
a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
+++ 
b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
@@ -16,18 +16,23 @@
  */
 package org.apache.servicecomb.loadbalance;
 
+import java.io.IOException;
 import java.net.ConnectException;
 import java.net.SocketTimeoutException;
 import java.util.Collection;
 import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
 
 import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
 import org.springframework.stereotype.Component;
 
+import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 import com.netflix.client.DefaultLoadBalancerRetryHandler;
 import com.netflix.client.RetryHandler;
-import com.netflix.client.Utils;
+
+import io.vertx.core.VertxException;
 
 @Component
 public class DefaultRetryExtensionsFactory implements ExtensionsFactory {
@@ -52,9 +57,20 @@ public RetryHandler createRetryHandler(String retryName, 
String microservice) {
   private List> retriable = Lists
   .newArrayList(new Class[] {ConnectException.class, 
SocketTimeoutException.class});
 
+  Map, List> strictRetriable =
+  ImmutableMap., List>builder()
+  .put(ConnectException.class, Lists.newArrayList())
+  .put(SocketTimeoutException.class, Lists.newArrayList())
+  /*
+   * deal with some special exceptions caused by the server side 
close the connection 
+   */
+  .put(IOException.class, Lists.newArrayList(new String[] 
{"Connection reset by peer"}))
+  .put(VertxException.class, Lists.newArrayList(new String[] 
{"Connection was closed"}))
+  .build();
+
   @Override
   public boolean isRetriableException(Throwable e, boolean sameServer) {
-boolean retriable = Utils.isPresentAsCause(e, 
getRetriableExceptions());
+boolean retriable = isPresentAsCause(e);
 if (!retriable) {
   if (e instanceof InvocationException) {
 if (((InvocationException) e).getStatusCode() == 503) {
@@ -69,6 +85,30 @@ public boolean isRetriableException(Throwable e, boolean 
sameServer) {
   protected List> getRetriableExceptions() {
 return this.retriable;
   }
+
+  public boolean isPresentAsCause(Throwable throwableToSearchIn) {
+int infiniteLoopPreventionCounter = 10;
+while (throwableToSearchIn != null && infiniteLoopPreventionCounter > 
0) {
+  infiniteLoopPreventionCounter--;
+  for (Entry, List> c : 
strictRetriable.entrySet()) {
+Class key = c.getKey();
+if (key.isAssignableFrom(throwableToSearchIn.getClass())) {
+  if (c.getValue() == null || c.getValue().isEmpty()) {
+return true;
+  } else {
+String msg = throwableToSearchIn.getMessage();
+for (String val : c.getValue()) {
+  if (val.equals(msg)) {
+return true;
+  }
+}
+  }
+}
+  }
+  throwableToSearchIn = throwableToSearchIn.getCause();
+}
+return false;
+  }
 };
   }
 }
diff --git 
a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
 
b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
new file mode 100644
index 0..8535a5aef
--- /dev/null
+++ 
b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this fil

[jira] [Commented] (SCB-891) Add kamon metrics to Omega client

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664533#comment-16664533
 ] 

ASF GitHub Bot commented on SCB-891:


WillemJiang commented on issue #314: [SCB-891] Add kamon metrics to Omega client
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/314#issuecomment-433261110
 
 
   We need to find a way to build trace stack to help us find the bottleneck 
not just enable kamon.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add kamon metrics to Omega client
> -
>
> Key: SCB-891
> URL: https://issues.apache.org/jira/browse/SCB-891
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Saga
>Reporter: Mahesh Raju Somalaraju
>Assignee: Mahesh Raju Somalaraju
>Priority: Major
> Fix For: saga-0.3.0
>
>
> Need to add Kamon traces/metrics to omega client.
> Need to find the major flows in omega client side and need to add the kamon 
> annotations for traces/metrics.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-935) ServiceComb Saga Frontend

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664525#comment-16664525
 ] 

ASF GitHub Bot commented on SCB-935:


WillemJiang commented on issue #317: [SCB-935] [WIP] Saga transaction 
management console UI initial commit
URL: 
https://github.com/apache/incubator-servicecomb-saga/pull/317#issuecomment-433260193
 
 
   > > > @anvithks After went through the PR, I found you may just copy 
https://github.com/akveo/ngx-admin/tree/starter-kit code here. I'm not sure if 
it's best way to do it, but need to make sure it works with Apache License 
first.
   > > 
   > > 
   > > @WillemJiang sorry for the delayed response. I was on planned vacation 
and could not check on this.
   > > Yes, you are right we can use the starter kit but it does not have many 
of the UI components that we have used in the UI. I will check if I can start 
with the starter-kit and add our modules. Let me get back to you on that.
   > 
   > @WillemJiang after checking the code base of the starter kit and the one 
in the commit I find that I am using even lesser modules and components than 
the starter-kit. I have further reduced the LOC by removing some more unused 
files.
   
   @anvithks Could you remove the unused file first?  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ServiceComb Saga Frontend
> -
>
> Key: SCB-935
> URL: https://issues.apache.org/jira/browse/SCB-935
> Project: Apache ServiceComb
>  Issue Type: New Feature
>  Components: Saga
>Reporter: Mohammad Asif Siddiqui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
>
> Develop new ServiceComb Saga Frontend based on the design over here 
> https://cwiki.apache.org/confluence/display/SERVICECOMB/ServiceComb+Saga+Frontend



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-983) Output the QPS per domain

2018-10-25 Thread little-cui (JIRA)
little-cui created SCB-983:
--

 Summary: Output the QPS per domain
 Key: SCB-983
 URL: https://issues.apache.org/jira/browse/SCB-983
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Service-Center
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SCB-980) The dependency will be broken when commit etcd failed

2018-10-25 Thread little-cui (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

little-cui resolved SCB-980.

Resolution: Fixed

> The dependency will be broken when commit etcd failed
> -
>
> Key: SCB-980
> URL: https://issues.apache.org/jira/browse/SCB-980
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread little-cui (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

little-cui resolved SCB-981.

Resolution: Fixed

> Can not remove the microservice and instance properties
> ---
>
> Key: SCB-981
> URL: https://issues.apache.org/jira/browse/SCB-981
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SCB-982) Show the warning message in maven compile plugin

2018-10-25 Thread Willem Jiang (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Willem Jiang updated SCB-982:
-
Labels: easyfix newbie  (was: )

> Show the warning message in maven compile plugin
> 
>
> Key: SCB-982
> URL: https://issues.apache.org/jira/browse/SCB-982
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Java-Chassis, Saga
>Reporter: Willem Jiang
>Priority: Major
>  Labels: easyfix, newbie
>
> It could help us find more waring message durning the developing time.
>  {code}
> 
>   org.apache.maven.plugins
>   maven-compiler-plugin
>   3.1
>   
>     1.8
>     1.8
>     true
>     true
>     
>       -Werror
>       -Xlint:all
>     
>   
> 
>  {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-982) Show the warning message in maven compile plugin

2018-10-25 Thread Willem Jiang (JIRA)
Willem Jiang created SCB-982:


 Summary: Show the warning message in maven compile plugin
 Key: SCB-982
 URL: https://issues.apache.org/jira/browse/SCB-982
 Project: Apache ServiceComb
  Issue Type: Improvement
  Components: Java-Chassis, Saga
Reporter: Willem Jiang


It could help us find more waring message durning the developing time.

 {code}

  org.apache.maven.plugins
  maven-compiler-plugin
  3.1
  
    1.8
    1.8
    true
    true
    
      -Werror
      -Xlint:all
    
  

 {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-980) The dependency will be broken when commit etcd failed

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663857#comment-16663857
 ] 

ASF GitHub Bot commented on SCB-980:


coveralls edited a comment on issue #464: SCB-980 The dependency will be broken 
when commit etcd failed
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/464#issuecomment-433084838
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19720385/badge)](https://coveralls.io/builds/19720385)
   
   Coverage increased (+0.1%) to 62.793% when pulling 
**4c70d05d9df7dbc61b1668c4e7f48f365d4b5d3d on little-cui:master** into 
**c5473e0d125130abd8e5469566fcf4c24cbab965 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The dependency will be broken when commit etcd failed
> -
>
> Key: SCB-980
> URL: https://issues.apache.org/jira/browse/SCB-980
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-980) The dependency will be broken when commit etcd failed

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663851#comment-16663851
 ] 

ASF GitHub Bot commented on SCB-980:


coveralls commented on issue #464: SCB-980 The dependency will be broken when 
commit etcd failed
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/464#issuecomment-433084838
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19720275/badge)](https://coveralls.io/builds/19720275)
   
   Coverage increased (+0.1%) to 62.813% when pulling 
**4c70d05d9df7dbc61b1668c4e7f48f365d4b5d3d on little-cui:master** into 
**c5473e0d125130abd8e5469566fcf4c24cbab965 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The dependency will be broken when commit etcd failed
> -
>
> Key: SCB-980
> URL: https://issues.apache.org/jira/browse/SCB-980
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663814#comment-16663814
 ] 

ASF GitHub Bot commented on SCB-981:


asifdxtreme closed pull request #465: SCB-981 Can not remove the microservice 
and instance properties
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/465
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/service/instance_test.go b/server/service/instance_test.go
index fb012d3b..dd5de495 100644
--- a/server/service/instance_test.go
+++ b/server/service/instance_test.go
@@ -745,13 +745,14 @@ var _ = Describe("'Instance' service", func() {
 
Expect(err).To(BeNil())

Expect(respUpdateProperties.Response.Code).To(Equal(scerr.ErrInvalidParams))
+
+   By("remove the properties")
respUpdateProperties, err = 
instanceResource.UpdateInstanceProperties(getContext(), 
&pb.UpdateInstancePropsRequest{
ServiceId:  serviceId,
InstanceId: instanceId,
})
-
Expect(err).To(BeNil())
-   
Expect(respUpdateProperties.Response.Code).To(Equal(scerr.ErrInvalidParams))
+   
Expect(respUpdateProperties.Response.Code).To(Equal(pb.Response_SUCCESS))
 
By("service does not exist")
respUpdateProperties, err = 
instanceResource.UpdateInstanceProperties(getContext(), 
&pb.UpdateInstancePropsRequest{
diff --git a/server/service/instance_validator.go 
b/server/service/instance_validator.go
index 369b8aa5..1777b402 100644
--- a/server/service/instance_validator.go
+++ b/server/service/instance_validator.go
@@ -81,7 +81,6 @@ func UpdateInstanceReqValidator() *validate.Validator {
 func UpdateInstancePropsReqValidator() *validate.Validator {
return updateInstancePropsReqValidator.Init(func(v *validate.Validator) 
{
v.AddRules(heartbeatReqValidator.GetRules())
-   v.AddRule("Properties", 
UpdateServicePropsReqValidator().GetRule("Properties"))
})
 }
 
diff --git a/server/service/microservice_test.go 
b/server/service/microservice_test.go
index f27c897f..b1c36b09 100644
--- a/server/service/microservice_test.go
+++ b/server/service/microservice_test.go
@@ -1079,15 +1079,15 @@ var _ = Describe("'Micro-service' service", func() {
})
})
 
-   Context("when property is nil or empty", func() {
-   It("should be failed", func() {
+   Context("when remove the properties", func() {
+   It("should be pass", func() {
r := &pb.UpdateServicePropsRequest{
ServiceId:  serviceId,
Properties: nil,
}
resp, err := 
serviceResource.UpdateProperties(getContext(), r)
Expect(err).To(BeNil())
-   
Expect(resp.Response.Code).ToNot(Equal(pb.Response_SUCCESS))
+   
Expect(resp.Response.Code).To(Equal(pb.Response_SUCCESS))
 
r = &pb.UpdateServicePropsRequest{
ServiceId:  "",
diff --git a/server/service/microservice_validator.go 
b/server/service/microservice_validator.go
index d010ec52..b4eb4a73 100644
--- a/server/service/microservice_validator.go
+++ b/server/service/microservice_validator.go
@@ -108,6 +108,5 @@ func CreateServiceReqValidator() *validate.Validator {
 func UpdateServicePropsReqValidator() *validate.Validator {
return updateServicePropsReqValidator.Init(func(v *validate.Validator) {
v.AddRule("ServiceId", 
GetServiceReqValidator().GetRule("ServiceId"))
-   v.AddRule("Properties", &validate.ValidateRule{Min: 1})
})
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can not remove the microservice and instance properties
> ---
>
> Key: SCB-981
> URL: https://issues.apache.org/jira/browse/SCB-981

[jira] [Commented] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663815#comment-16663815
 ] 

ASF GitHub Bot commented on SCB-981:


coveralls commented on issue #465: SCB-981 Can not remove the microservice and 
instance properties
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/465#issuecomment-433074164
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/19719613/badge)](https://coveralls.io/builds/19719613)
   
   Coverage decreased (-0.1%) to 62.636% when pulling 
**a37deabccbef01c8ecca9dcf15cb49fdc9ac52e9 on little-cui:bug** into 
**3ddb255953e70a35ec511aecb064f18c50236f81 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can not remove the microservice and instance properties
> ---
>
> Key: SCB-981
> URL: https://issues.apache.org/jira/browse/SCB-981
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663813#comment-16663813
 ] 

ASF GitHub Bot commented on SCB-981:


codecov-io commented on issue #465: SCB-981 Can not remove the microservice and 
instance properties
URL: 
https://github.com/apache/incubator-servicecomb-service-center/pull/465#issuecomment-433073581
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=h1)
 Report
   > Merging 
[#465](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/3ddb255953e70a35ec511aecb064f18c50236f81?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#465  +/-   ##
   =
   - Coverage60.2%   60.2%   -0.01% 
   =
 Files 156 156  
 Lines   13412   13410   -2 
   =
   - Hits 80758073   -2 
   + Misses   47634760   -3 
   - Partials  574 577   +3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[server/service/microservice\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlX3ZhbGlkYXRvci5nbw==)
 | `100% <ø> (ø)` | :arrow_up: |
   | 
[pkg/task/executor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL3Rhc2svZXhlY3V0b3IuZ28=)
 | `72% <0%> (-4%)` | :arrow_down: |
   | 
[server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==)
 | `61.53% <0%> (-3.85%)` | :arrow_down: |
   | 
[pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==)
 | `81.25% <0%> (-3.13%)` | :arrow_down: |
   | 
[server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==)
 | `83.87% <0%> (-0.65%)` | :arrow_down: |
   | 
[server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv)
 | `68.26% <0%> (-0.6%)` | :arrow_down: |
   | 
[pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=)
 | `33.71% <0%> (-0.58%)` | :arrow_down: |
   | 
[server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv)
 | `72.44% <0%> (+0.98%)` | :arrow_up: |
   | 
[server/service/notification/stream.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3N0cmVhbS5nbw==)
 | `69.56% <0%> (+4.34%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=footer).
 Last update 
[3ddb255...a37deab](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/465?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@in

[jira] [Commented] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663777#comment-16663777
 ] 

ASF GitHub Bot commented on SCB-981:


little-cui opened a new pull request #465: SCB-981 Can not remove the 
microservice and instance properties
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/465
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Can not remove the microservice and instance properties
> ---
>
> Key: SCB-981
> URL: https://issues.apache.org/jira/browse/SCB-981
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-980) The dependency will be broken when commit etcd failed

2018-10-25 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663776#comment-16663776
 ] 

ASF GitHub Bot commented on SCB-980:


little-cui opened a new pull request #464: SCB-980 The dependency will be 
broken when commit etcd failed
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/464
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
- [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> The dependency will be broken when commit etcd failed
> -
>
> Key: SCB-980
> URL: https://issues.apache.org/jira/browse/SCB-980
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-981) Can not remove the microservice and instance properties

2018-10-25 Thread little-cui (JIRA)
little-cui created SCB-981:
--

 Summary: Can not remove the microservice and instance properties
 Key: SCB-981
 URL: https://issues.apache.org/jira/browse/SCB-981
 Project: Apache ServiceComb
  Issue Type: Bug
  Components: Service-Center
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCB-980) The dependency will be broken when commit etcd failed

2018-10-25 Thread little-cui (JIRA)
little-cui created SCB-980:
--

 Summary: The dependency will be broken when commit etcd failed
 Key: SCB-980
 URL: https://issues.apache.org/jira/browse/SCB-980
 Project: Apache ServiceComb
  Issue Type: Bug
  Components: Service-Center
Reporter: little-cui
Assignee: little-cui
 Fix For: service-center-1.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SCB-977) Dependencies will not be updated in 5min when micro service is changed

2018-10-25 Thread little-cui (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

little-cui resolved SCB-977.

Resolution: Fixed

> Dependencies will not be updated in 5min when micro service is changed
> --
>
> Key: SCB-977
> URL: https://issues.apache.org/jira/browse/SCB-977
> Project: Apache ServiceComb
>  Issue Type: Bug
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SCB-438) As SC model is changing, we should keep SC proto spec in isolated project, so that go sdk can import same model as SC does

2018-10-25 Thread Mohammad Asif Siddiqui (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Asif Siddiqui reassigned SCB-438:
--

Assignee: little-cui  (was: Mohammad Asif Siddiqui)

> As SC model is changing, we should keep SC proto spec in isolated project, so 
> that go sdk can import same model as SC does
> --
>
> Key: SCB-438
> URL: https://issues.apache.org/jira/browse/SCB-438
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SCB-418) How to deploy a SC cluster in container environment

2018-10-25 Thread Mohammad Asif Siddiqui (JIRA)


[ 
https://issues.apache.org/jira/browse/SCB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663524#comment-16663524
 ] 

Mohammad Asif Siddiqui commented on SCB-418:


Guide to deploy SC  Cluster in container env is available here 
https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/helm.md
 

> How to deploy a SC cluster in container environment
> ---
>
> Key: SCB-418
> URL: https://issues.apache.org/jira/browse/SCB-418
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m2
>Reporter: little-cui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SCB-418) How to deploy a SC cluster in container environment

2018-10-25 Thread Mohammad Asif Siddiqui (JIRA)


 [ 
https://issues.apache.org/jira/browse/SCB-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohammad Asif Siddiqui closed SCB-418.
--
Resolution: Fixed

> How to deploy a SC cluster in container environment
> ---
>
> Key: SCB-418
> URL: https://issues.apache.org/jira/browse/SCB-418
> Project: Apache ServiceComb
>  Issue Type: Improvement
>  Components: Service-Center
>Affects Versions: service-center-1.0.0-m2
>Reporter: little-cui
>Assignee: Mohammad Asif Siddiqui
>Priority: Major
> Fix For: service-center-1.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)