[jira] [Commented] (SCB-1016) Change git repo name
[ https://issues.apache.org/jira/browse/SCB-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681011#comment-16681011 ] ASF GitHub Bot commented on SCB-1016: - codecov-io edited a comment on issue #483: SCB-1016 Change git repo name URL: https://github.com/apache/servicecomb-service-center/pull/483#issuecomment-437277707 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@ed23586`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `56.02%`. [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #483 +/- ## = Coverage ? 60.35% = Files ? 159 Lines ?13534 Branches ?0 = Hits ? 8169 Misses? 4787 Partials ? 578 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <ø> (ø)` | | | [scctl/pkg/plugin/diagnose/cmd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jbWQuZ28=) | `100% <ø> (ø)` | | | [server/plugin/pkg/registry/etcd/logger.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9sb2dnZXIuZ28=) | `80.76% <ø> (ø)` | | | [server/plugin/pkg/tls/buildin/tls.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdGxzL2J1aWxkaW4vdGxzLmdv) | `82.08% <ø> (ø)` | | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <ø> (ø)` | | | [pkg/validate/validator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-cGtnL3ZhbGlkYXRlL3ZhbGlkYXRvci5nbw==) | `54.11% <ø> (ø)` | | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <ø> (ø)` | | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.17% <ø> (ø)` | | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <ø> (ø)` | | | [server/service/notification/publisher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3B1Ymxpc2hlci5nbw==) | `95.65% <ø> (ø)` | | | ... and [98 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=footer). Last update [ed23586...795d427](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change git repo name > > > Key: SCB-1016 > URL: https://issues.apache.org/jira/browse/SCB-1016 > Project: Apach
[jira] [Commented] (SCB-1016) Change git repo name
[ https://issues.apache.org/jira/browse/SCB-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681004#comment-16681004 ] ASF GitHub Bot commented on SCB-1016: - codecov-io commented on issue #483: SCB-1016 Change git repo name URL: https://github.com/apache/servicecomb-service-center/pull/483#issuecomment-437277707 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@ed23586`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `56.02%`. [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #483 +/- ## = Coverage ? 60.35% = Files ? 159 Lines ?13534 Branches ?0 = Hits ? 8169 Misses? 4787 Partials ? 578 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <ø> (ø)` | | | [scctl/pkg/plugin/diagnose/cmd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jbWQuZ28=) | `100% <ø> (ø)` | | | [server/plugin/pkg/registry/etcd/logger.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9sb2dnZXIuZ28=) | `80.76% <ø> (ø)` | | | [server/plugin/pkg/tls/buildin/tls.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdGxzL2J1aWxkaW4vdGxzLmdv) | `82.08% <ø> (ø)` | | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <ø> (ø)` | | | [pkg/validate/validator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-cGtnL3ZhbGlkYXRlL3ZhbGlkYXRvci5nbw==) | `54.11% <ø> (ø)` | | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <ø> (ø)` | | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.17% <ø> (ø)` | | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <ø> (ø)` | | | [server/service/notification/publisher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3B1Ymxpc2hlci5nbw==) | `95.65% <ø> (ø)` | | | ... and [99 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/483/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=footer). Last update [ed23586...795d427](https://codecov.io/gh/apache/servicecomb-service-center/pull/483?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change git repo name > > > Key: SCB-1016 > URL: https://issues.apache.org/jira/browse/SCB-1016 > Project: Apache Servi
[jira] [Commented] (SCB-1014) Fix priority problem of ExceptionToResponseConverter
[ https://issues.apache.org/jira/browse/SCB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681000#comment-16681000 ] ASF GitHub Bot commented on SCB-1014: - yhs0092 closed pull request #985: [SCB-1014] Fix priority of ExceptionToResponseConverter URL: https://github.com/apache/servicecomb-java-chassis/pull/985 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java b/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java similarity index 91% rename from demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java rename to demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java index fd2ccd90f..9894b6d37 100644 --- a/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java +++ b/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java @@ -21,10 +21,11 @@ import org.apache.servicecomb.swagger.invocation.Response; import org.apache.servicecomb.swagger.invocation.SwaggerInvocation; -import org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter; +import org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter; import org.apache.servicecomb.swagger.invocation.exception.InvocationException; -public class CustomExceptionToResponseConverter implements ExceptionToResponseConverter { +public class CustomExceptionToProducerResponseConverter implements +ExceptionToProducerResponseConverter { @Override public Class getExceptionClass() { return IllegalStateException.class; diff --git a/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter b/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter similarity index 97% rename from demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter rename to demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter index 9a433318c..1633f6968 100644 --- a/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter +++ b/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter @@ -15,4 +15,4 @@ # limitations under the License. # -org.apache.servicecomb.demo.edge.business.error.CustomExceptionToResponseConverter \ No newline at end of file +org.apache.servicecomb.demo.edge.business.error.CustomExceptionToProducerResponseConverter \ No newline at end of file diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java similarity index 89% rename from swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java rename to swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java index 03d4cb392..a64405ed5 100644 --- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java +++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java @@ -21,8 +21,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class DefaultExceptionToResponseConverter implements ExceptionToResponseConverter { - private static final Logger LOGGER = LoggerFactory.getLogger(DefaultExceptionToResponseConverter.class); +public class DefaultExceptionToProducer
[jira] [Commented] (SCB-1014) Fix priority problem of ExceptionToResponseConverter
[ https://issues.apache.org/jira/browse/SCB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681001#comment-16681001 ] ASF GitHub Bot commented on SCB-1014: - yhs0092 opened a new pull request #985: [SCB-1014] Fix priority of ExceptionToResponseConverter URL: https://github.com/apache/servicecomb-java-chassis/pull/985 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- See details in [SCB-1014](https://issues.apache.org/jira/browse/SCB-1014) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix priority problem of ExceptionToResponseConverter > > > Key: SCB-1014 > URL: https://issues.apache.org/jira/browse/SCB-1014 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > > Currently the priority rule of default ExceptionToResponseConverter is that > the smaller the order is, the higher the priority is. But the other common > ExceptionToResponseConverters obey the contrary priority rule. > We need to modify the implementation logic of ExceptionToResponseConverters > to make sure the two kinds of ExceptionToResponseConverters obey the same > priority rule. > And the name of ExceptionToResponseConverter will be changed to remind users > to be aware of the modification. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1016) Change git repo name
[ https://issues.apache.org/jira/browse/SCB-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680976#comment-16680976 ] ASF GitHub Bot commented on SCB-1016: - little-cui opened a new pull request #483: SCB-1016 Change git repo name URL: https://github.com/apache/servicecomb-service-center/pull/483 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change git repo name > > > Key: SCB-1016 > URL: https://issues.apache.org/jira/browse/SCB-1016 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1016) Change git repo name
little-cui created SCB-1016: --- Summary: Change git repo name Key: SCB-1016 URL: https://issues.apache.org/jira/browse/SCB-1016 Project: Apache ServiceComb Issue Type: Task Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1015) Support four bit version registration
little-cui created SCB-1015: --- Summary: Support four bit version registration Key: SCB-1015 URL: https://issues.apache.org/jira/browse/SCB-1015 Project: Apache ServiceComb Issue Type: Improvement Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-973) TLP graduation tasks
[ https://issues.apache.org/jira/browse/SCB-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680912#comment-16680912 ] ASF GitHub Bot commented on SCB-973: WillemJiang closed pull request #332: SCB-973 update to remvoing the incubator URL: https://github.com/apache/servicecomb-saga/pull/332 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java index b1f931975..c600fd110 100644 --- a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java +++ b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/annotations/Compensable.java @@ -30,7 +30,7 @@ * is idempotent * the object instance which @Compensable method resides in should be stateless * if compensationMethod exists, both methods must be commutative, see this - * https://servicecomb.incubator.apache.org/docs/distributed_saga_2/";>link. + * https://servicecomb.apache.org/docs/distributed_saga_2/";>link. * */ @Target(ElementType.METHOD) diff --git a/pom.xml b/pom.xml index 57ab4498a..4b4ff8afa 100644 --- a/pom.xml +++ b/pom.xml @@ -78,7 +78,7 @@ ServiceComb Saga Eventual consistency component for distributed systems - https://github.com/apache/incubator-servicecomb-saga + https://github.com/apache/servicecomb-saga @@ -121,9 +121,9 @@ - scm:git:https://github.com/apache/incubator-servicecomb-saga.git - scm:git:https://github.com/apache/incubator-servicecomb-saga.git -https://github.com/apache/incubator-servicecomb-saga + scm:git:https://github.com/apache/servicecomb-saga.git + scm:git:https://github.com/apache/servicecomb-saga.git +https://github.com/apache/servicecomb-saga ${project.version} diff --git a/saga-demo/saga-servicecomb-demo/scb-booking/src/main/resources/microservice.yaml b/saga-demo/saga-servicecomb-demo/scb-booking/src/main/resources/microservice.yaml index 60d9a7aac..4b1ee07da 100644 --- a/saga-demo/saga-servicecomb-demo/scb-booking/src/main/resources/microservice.yaml +++ b/saga-demo/saga-servicecomb-demo/scb-booking/src/main/resources/microservice.yaml @@ -16,9 +16,9 @@ ## --- #More details can be found : -# 1.http://servicecomb.incubator.apache.org/users/service-definition/ -# 2.http://servicecomb.incubator.apache.org/users/service-configurations/ -# 3.http://servicecomb.incubator.apache.org/users/communicate-protocol/ +# 1.http://servicecomb.apache.org/users/service-definition/ +# 2.http://servicecomb.apache.org/users/service-configurations/ +# 3.http://servicecomb.apache.org/users/communicate-protocol/ #Indicates an application name APPLICATION_ID: demo diff --git a/saga-demo/saga-servicecomb-demo/scb-car/src/main/resources/microservice.yaml b/saga-demo/saga-servicecomb-demo/scb-car/src/main/resources/microservice.yaml index 49aab59b3..20927bfe3 100644 --- a/saga-demo/saga-servicecomb-demo/scb-car/src/main/resources/microservice.yaml +++ b/saga-demo/saga-servicecomb-demo/scb-car/src/main/resources/microservice.yaml @@ -16,9 +16,9 @@ ## --- #More details can be found : -# 1.http://servicecomb.incubator.apache.org/users/service-definition/ -# 2.http://servicecomb.incubator.apache.org/users/service-configurations/ -# 3.http://servicecomb.incubator.apache.org/users/communicate-protocol/ +# 1.http://servicecomb.apache.org/users/service-definition/ +# 2.http://servicecomb.apache.org/users/service-configurations/ +# 3.http://servicecomb.apache.org/users/communicate-protocol/ #Indicates an application name APPLICATION_ID: demo diff --git a/saga-demo/saga-servicecomb-demo/scb-hotel/src/main/resources/microservice.yaml b/saga-demo/saga-servicecomb-demo/scb-hotel/src/main/resources/microservice.yaml index 0ac5dbac1..40a453b31 100644 --- a/saga-demo/saga-servicecomb-demo/scb-hotel/src/main/resources/microservice.yaml +++ b/saga-demo/saga-servicecomb-demo/scb-hotel/src/main/resources/microservice.yaml @@ -16,9 +16,9 @@ ## --- #More details can be found : -# 1.http://servicecomb.incubator.apache.org/users/service-definition/ -# 2.http://servicecomb.incubator.apache.org/users/service-configurations/ -# 3.http://servicecomb.incubator.apache.org/users/communicate-protocol/ +# 1.http:/
[jira] [Commented] (SCB-1014) Fix priority problem of ExceptionToResponseConverter
[ https://issues.apache.org/jira/browse/SCB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680774#comment-16680774 ] ASF GitHub Bot commented on SCB-1014: - yhs0092 opened a new pull request #985: [SCB-1014] Fix priority of ExceptionToResponseConverter URL: https://github.com/apache/servicecomb-java-chassis/pull/985 Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- See details in [SCB-1014](https://issues.apache.org/jira/browse/SCB-1014) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix priority problem of ExceptionToResponseConverter > > > Key: SCB-1014 > URL: https://issues.apache.org/jira/browse/SCB-1014 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > > Currently the priority rule of default ExceptionToResponseConverter is that > the smaller the order is, the higher the priority is. But the other common > ExceptionToResponseConverters obey the contrary priority rule. > We need to modify the implementation logic of ExceptionToResponseConverters > to make sure the two kinds of ExceptionToResponseConverters obey the same > priority rule. > And the name of ExceptionToResponseConverter will be changed to remind users > to be aware of the modification. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-973) TLP graduation tasks
[ https://issues.apache.org/jira/browse/SCB-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680777#comment-16680777 ] ASF GitHub Bot commented on SCB-973: coveralls commented on issue #332: SCB-973 update to remvoing the incubator URL: https://github.com/apache/servicecomb-saga/pull/332#issuecomment-437234038 [![Coverage Status](https://coveralls.io/builds/19998965/badge)](https://coveralls.io/builds/19998965) Coverage remained the same at 91.869% when pulling **a714c1b9b79ef92ea9082f17e9cdf99b0cdd4aaa on zhfeng:SCB_973** into **4e3539337fbcd3bf2b1bda653f425d670cb10669 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > TLP graduation tasks > > > Key: SCB-973 > URL: https://issues.apache.org/jira/browse/SCB-973 > Project: Apache ServiceComb > Issue Type: Task >Reporter: Willem Jiang >Assignee: Willem Jiang >Priority: Major > > ServiceComb's TLP graduation tasks > * Remove the incubator word from the git repo > * Clean up the disclaim file from the git repo > * Update the document remove the incubating word. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1014) Fix priority problem of ExceptionToResponseConverter
[ https://issues.apache.org/jira/browse/SCB-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680770#comment-16680770 ] ASF GitHub Bot commented on SCB-1014: - yhs0092 closed pull request #985: [SCB-1014] Fix priority of ExceptionToResponseConverter URL: https://github.com/apache/servicecomb-java-chassis/pull/985 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java b/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java similarity index 91% rename from demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java rename to demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java index fd2ccd90f..9894b6d37 100644 --- a/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToResponseConverter.java +++ b/demo/demo-edge/business-2.0.0/src/main/java/org/apache/servicecomb/demo/edge/business/error/CustomExceptionToProducerResponseConverter.java @@ -21,10 +21,11 @@ import org.apache.servicecomb.swagger.invocation.Response; import org.apache.servicecomb.swagger.invocation.SwaggerInvocation; -import org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter; +import org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter; import org.apache.servicecomb.swagger.invocation.exception.InvocationException; -public class CustomExceptionToResponseConverter implements ExceptionToResponseConverter { +public class CustomExceptionToProducerResponseConverter implements +ExceptionToProducerResponseConverter { @Override public Class getExceptionClass() { return IllegalStateException.class; diff --git a/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter b/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter similarity index 97% rename from demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter rename to demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter index 9a433318c..1633f6968 100644 --- a/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToResponseConverter +++ b/demo/demo-edge/business-2.0.0/src/main/resources/META-INF/services/org.apache.servicecomb.swagger.invocation.exception.ExceptionToProducerResponseConverter @@ -15,4 +15,4 @@ # limitations under the License. # -org.apache.servicecomb.demo.edge.business.error.CustomExceptionToResponseConverter \ No newline at end of file +org.apache.servicecomb.demo.edge.business.error.CustomExceptionToProducerResponseConverter \ No newline at end of file diff --git a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java similarity index 89% rename from swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java rename to swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java index 03d4cb392..a64405ed5 100644 --- a/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToResponseConverter.java +++ b/swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/DefaultExceptionToProducerResponseConverter.java @@ -21,8 +21,8 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class DefaultExceptionToResponseConverter implements ExceptionToResponseConverter { - private static final Logger LOGGER = LoggerFactory.getLogger(DefaultExceptionToResponseConverter.class); +public class DefaultExceptionToProducer
[jira] [Commented] (SCB-973) TLP graduation tasks
[ https://issues.apache.org/jira/browse/SCB-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680762#comment-16680762 ] ASF GitHub Bot commented on SCB-973: zhfeng commented on issue #332: SCB-973 update to remvoing the incubator URL: https://github.com/apache/servicecomb-saga/pull/332#issuecomment-437230513 I just use the command to search in the plain text files. ``` find . -type f -exec grep -H 'incubator' '{}' \; ``` There are still two in the pom.xml and .travis.xml.setting which I'm not sure needing the changes. So maybe you can take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > TLP graduation tasks > > > Key: SCB-973 > URL: https://issues.apache.org/jira/browse/SCB-973 > Project: Apache ServiceComb > Issue Type: Task >Reporter: Willem Jiang >Assignee: Willem Jiang >Priority: Major > > ServiceComb's TLP graduation tasks > * Remove the incubator word from the git repo > * Clean up the disclaim file from the git repo > * Update the document remove the incubating word. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-973) TLP graduation tasks
[ https://issues.apache.org/jira/browse/SCB-973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680760#comment-16680760 ] ASF GitHub Bot commented on SCB-973: zhfeng opened a new pull request #332: SCB-973 update to remvoing the incubator URL: https://github.com/apache/servicecomb-saga/pull/332 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > TLP graduation tasks > > > Key: SCB-973 > URL: https://issues.apache.org/jira/browse/SCB-973 > Project: Apache ServiceComb > Issue Type: Task >Reporter: Willem Jiang >Assignee: Willem Jiang >Priority: Major > > ServiceComb's TLP graduation tasks > * Remove the incubator word from the git repo > * Clean up the disclaim file from the git repo > * Update the document remove the incubating word. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-988) Add loadbalancer in sc client
[ https://issues.apache.org/jira/browse/SCB-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-988. Resolution: Fixed > Add loadbalancer in sc client > - > > Key: SCB-988 > URL: https://issues.apache.org/jira/browse/SCB-988 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680690#comment-16680690 ] ASF GitHub Bot commented on SCB-993: little-cui closed pull request #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/servicecomb-service-center/pull/481 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pkg/client/sc/client.go b/pkg/client/sc/client.go index 38ab11bd..18ee9db2 100644 --- a/pkg/client/sc/client.go +++ b/pkg/client/sc/client.go @@ -24,18 +24,18 @@ func NewSCClient(cfg Config) (*SCClient, error) { if err != nil { return nil, err } - return &SCClient{LBClient: client, Token: cfg.Token}, nil + return &SCClient{LBClient: client, Cfg: cfg}, nil } type SCClient struct { *LBClient - Token string + Cfg Config } func (c *SCClient) CommonHeaders() http.Header { var headers = make(http.Header) - if len(c.Token) > 0 { - headers.Set("X-Auth-Token", c.Token) + if len(c.Cfg.Token) > 0 { + headers.Set("X-Auth-Token", c.Cfg.Token) } return headers } diff --git a/pkg/client/sc/config.go b/pkg/client/sc/config.go index f78845b2..9cbc0c60 100644 --- a/pkg/client/sc/config.go +++ b/pkg/client/sc/config.go @@ -22,8 +22,11 @@ import ( "time" ) +const defaultRequestTimeout = 10 * time.Second + type Config struct { rest.URLClientOption + Name string Endpoints []string // TODO Expandable header not only token header Token string @@ -38,7 +41,7 @@ func (cfg *Config) Merge() rest.URLClientOption { } cfg.SSLEnabled = ssl if cfg.RequestTimeout == 0 { - cfg.RequestTimeout = 10 * time.Second + cfg.RequestTimeout = defaultRequestTimeout } return cfg.URLClientOption } diff --git a/server/admin/model/dump.go b/server/admin/model/dump.go index 461be7ec..6165c53b 100644 --- a/server/admin/model/dump.go +++ b/server/admin/model/dump.go @@ -161,9 +161,10 @@ type Cache struct { } type KV struct { - Key string `json:"key"` - Rev int64 `json:"rev"` - Value interface{} `json:"-"` + Key string `json:"key"` + Rev int64 `json:"rev"` + Value interface{} `json:"-"` + ClusterName string `json:"cluster"` } type Microservice struct { diff --git a/server/admin/service.go b/server/admin/service.go index 6255f382..90c6d9e3 100644 --- a/server/admin/service.go +++ b/server/admin/service.go @@ -95,13 +95,13 @@ func (service *AdminService) dumpAll(ctx context.Context, cache *model.Cache) { } func setValue(e discovery.Adaptor, setter model.Setter) { - exists := make(map[string]struct{}) e.Cache().ForEach(func(k string, kv *discovery.KeyValue) (next bool) { - if _, ok := exists[k]; ok { - return true - } - exists[k] = struct{}{} - setter.SetValue(&model.KV{Key: k, Rev: kv.ModRevision, Value: kv.Value}) + setter.SetValue(&model.KV{ + Key: k, + Rev: kv.ModRevision, + Value: kv.Value, + ClusterName: kv.ClusterName, + }) return true }) } diff --git a/server/core/key_convertor.go b/server/core/key_convertor.go index 296b727f..d0730986 100644 --- a/server/core/key_convertor.go +++ b/server/core/key_convertor.go @@ -108,6 +108,10 @@ func GetInfoFromSvcIndexKV(key []byte) *pb.MicroServiceKey { } } +func GetInfoFromSvcAliasKV(key []byte) *pb.MicroServiceKey { + return GetInfoFromSvcIndexKV(key) +} + func GetInfoFromSchemaSummaryKV(key []byte) (domainProject, serviceId, schemaId string) { keys := KvToResponse(key) l := len(keys) diff --git a/server/plugin/pkg/discovery/aggregate/adaptor.go b/server/plugin/pkg/discovery/aggregate/adaptor.go index cb669806..d48e7d5b 100644 --- a/server/plugin/pkg/discovery/aggregate/adaptor.go +++ b/server/plugin/pkg/discovery/aggregate/adaptor.go @@ -16,69 +16,86 @@ package aggregate import ( - "github.com/apache/incubator-servicecomb-service-center/pkg/util" + "github.com/apache/incubator-servicecomb-service-center/pkg/log" + "github.com/apache/incubator-servicecomb-service-center/server/core" + "github.com/apache/incubator-servicecomb-service-center/server/core/backend" mgr "github.com/apache/incubator-servicecomb-service-center/server/plugin"
[jira] [Resolved] (SCB-994) SC can not read the context when client using grpc api
[ https://issues.apache.org/jira/browse/SCB-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-994. Resolution: Fixed > SC can not read the context when client using grpc api > -- > > Key: SCB-994 > URL: https://issues.apache.org/jira/browse/SCB-994 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679524#comment-16679524 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `41.17%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == - Coverage 60.32% 60.31% -0.01% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8163 +2 - Misses 4789 4790 +1 - Partials 579 581 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=footer). Last update [ea31a1a...3cb34ae](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond t
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679527#comment-16679527 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [![Coverage Status](https://coveralls.io/builds/19980045/badge)](https://coveralls.io/builds/19980045) Coverage decreased (-0.1%) to 62.651% when pulling **3cb34aed9abde03b42107e0ac773998e22c2dd42 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679825#comment-16679825 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `41.17%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == + Coverage 60.32% 60.35% +0.02% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8168 +7 + Misses 4789 4787 -2 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.95% <0%> (+0.55%)` | :arrow_up: | | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `78.87% <0%> (+9.85%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=footer). Last update [ea31a1a...f7762e2](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment.
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679826#comment-16679826 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [![Coverage Status](https://coveralls.io/builds/19984563/badge)](https://coveralls.io/builds/19984563) Coverage decreased (-0.1%) to 62.653% when pulling **f7762e23c1f01962b2885943febff253bb252335 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679794#comment-16679794 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436660133 [![Coverage Status](https://coveralls.io/builds/19984076/badge)](https://coveralls.io/builds/19984076) Coverage decreased (-0.09%) to 62.675% when pulling **fd5414aa791970fb6ab415f31c7c2008233608b1 on little-cui:bug** into **ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679793#comment-16679793 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #481: SCB-993 print warning log when aggregate conflict URL: https://github.com/apache/incubator-servicecomb-service-center/pull/481#issuecomment-436938114 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=h1) Report > Merging [#481](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ea31a1a3c9fdbd242817157f61e4aad15bfa5f0f?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `41.17%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/graphs/tree.svg?width=650&token=GAaF7zrg8R&height=150&src=pr)](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #481 +/- ## == + Coverage 60.32% 60.35% +0.02% == Files 159 159 Lines 1352913534 +5 == + Hits 8161 8168 +7 + Misses 4789 4787 -2 Partials 579 579 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/plugin/pkg/discovery/indexer\_cache.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2luZGV4ZXJfY2FjaGUuZ28=) | `100% <ø> (ø)` | :arrow_up: | | [server/core/key\_convertor.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2NvcmUva2V5X2NvbnZlcnRvci5nbw==) | `91.81% <0%> (-1.71%)` | :arrow_down: | | [server/service/event/service\_event\_handler.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvc2VydmljZV9ldmVudF9oYW5kbGVyLmdv) | `12.5% <0%> (ø)` | :arrow_up: | | [server/admin/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL2FkbWluL3NlcnZpY2UuZ28=) | `66.66% <0%> (-5.08%)` | :arrow_down: | | [server/plugin/pkg/discovery/types.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3R5cGVzLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/cacher\_kv.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvY2FjaGVyX2t2Lmdv) | `67.48% <100%> (ø)` | :arrow_up: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `67.61% <100%> (-0.07%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: | | ... and [4 more](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=footer). Last update [ea31a1a...fd5414a](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/481?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated mes
[jira] [Commented] (SCB-1013) Support to disable the event scanner Alpha
[ https://issues.apache.org/jira/browse/SCB-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679321#comment-16679321 ] ASF GitHub Bot commented on SCB-1013: - WillemJiang closed pull request #331: SCB-1013 Support to disable the event scanner of Alpha URL: https://github.com/apache/incubator-servicecomb-saga/pull/331 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support to disable the event scanner Alpha > -- > > Key: SCB-1013 > URL: https://issues.apache.org/jira/browse/SCB-1013 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Affects Versions: saga-0.3.0 >Reporter: Willem Jiang >Assignee: Willem Jiang >Priority: Major > > Current Event Scanner can only start one process if we start two Alpha > instance we have to stop one scanner process. Now we could use the > "alpha.event.scanner.enabled" to disable the event scanner manually. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-1014) Fix priority problem of ExceptionToResponseConverter
YaoHaishi created SCB-1014: -- Summary: Fix priority problem of ExceptionToResponseConverter Key: SCB-1014 URL: https://issues.apache.org/jira/browse/SCB-1014 Project: Apache ServiceComb Issue Type: Bug Reporter: YaoHaishi Assignee: YaoHaishi Currently the priority rule of default ExceptionToResponseConverter is that the smaller the order is, the higher the priority is. But the other common ExceptionToResponseConverters obey the contrary priority rule. We need to modify the implementation logic of ExceptionToResponseConverters to make sure the two kinds of ExceptionToResponseConverters obey the same priority rule. And the name of ExceptionToResponseConverter will be changed to remind users to be aware of the modification. -- This message was sent by Atlassian JIRA (v7.6.3#76005)