[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692538#comment-16692538 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/5cec4bafcfe1f111de44efd47e2aff22843921ff?src=pr=desc) will **decrease** coverage by `0.4%`. > The diff coverage is `27%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.72% 59.31% -0.41% == Files 165 166 +1 Lines 1379613865 +69 == - Hits 8239 8224 -15 - Misses 4973 5057 +84 Partials 584 584 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `42.74% <42.74%> (ø)` | | | ... and [4 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [5cec4ba...8ec7aba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692537#comment-16692537 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20193166) Coverage decreased (-0.5%) to 61.674% when pulling **8ec7ababd1be86d6d675e9da908c5eab814dda5c on little-cui:bug** into **5cec4bafcfe1f111de44efd47e2aff22843921ff on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[
https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692499#comment-16692499
]
ASF GitHub Bot commented on SCB-963:
WillemJiang closed pull request #339: SCB-963 Add Test case for saga
transactional compensation.
URL: https://github.com/apache/servicecomb-saga/pull/339
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionInterceptionTest.java
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionInterceptionTest.java
index 6b66befb3..85cd3bf54 100644
---
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionInterceptionTest.java
+++
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionInterceptionTest.java
@@ -29,6 +29,7 @@
import static org.hamcrest.Matchers.allOf;
import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertArrayEquals;
+import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.mockito.Mockito.when;
@@ -280,6 +281,17 @@ public void run() {
);
}
+ @Test
+ public void assertCompensationMethodTransactionAware() throws
NoSuchMethodException {
+userService.add(user);
+compensationMethod =
TransactionalUserService.class.getDeclaredMethod("deleteTransactional",
User.class).toString();
+messageHandler.onReceive(globalTxId, newLocalTxId, globalTxId,
compensationMethod, user);
+User actualUser = userRepository.findByUsername(user.username());
+assertNotNull(actualUser);
+assertThat(actualUser.username(), is(username));
+assertThat(actualUser.email(), is(email));
+ }
+
@Test
public void passesOmegaContextInThreadPool() throws Exception {
executor.schedule(new Runnable() {
@@ -353,11 +365,6 @@ public void passesOmegaContextAmongActors() throws
Exception {
actorSystem.terminate();
}
- @Test
- public void tccWorkflowTest() {
-
- }
-
private void waitTillSavedUser(final String username) {
await().atMost(1000, MILLISECONDS).until(new Callable() {
@Override
diff --git
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
index 11bc4374a..6628f7e49 100644
---
a/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
+++
b/omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
@@ -65,4 +65,17 @@ public void delete(User user, int count) {
resetCount();
userRepository.delete(user);
}
+
+ @Compensable(compensationMethod = "deleteTransactional")
+ public User addTransactional(User user) {
+if (ILLEGAL_USER.equals(user.username())) {
+ throw new IllegalArgumentException("User is illegal");
+}
+return userRepository.save(user);
+ }
+
+ public void deleteTransactional(User user) {
+userRepository.delete(user);
+throw new RuntimeException("saga compensation rollback test");
+ }
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Saga transactional method can't work when compensation happens
> --
>
> Key: SCB-963
> URL: https://issues.apache.org/jira/browse/SCB-963
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.2.0, saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> currently we cached the compensation method of raw bean in callback context.
> it will make transactional method inefficient, we should cache the
> transaction proxy bean instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[
https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692497#comment-16692497
]
ASF GitHub Bot commented on SCB-963:
WillemJiang commented on a change in pull request #339: SCB-963 Add Test case
for saga transactional compensation.
URL: https://github.com/apache/servicecomb-saga/pull/339#discussion_r234836400
##
File path:
omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
##
@@ -65,4 +65,17 @@ public void delete(User user, int count) {
resetCount();
userRepository.delete(user);
}
+
+ @Compensable(compensationMethod = "deleteTransactional")
+ public User addTransactional(User user) {
+if (ILLEGAL_USER.equals(user.username())) {
+ throw new IllegalArgumentException("User is illegal");
+}
+return userRepository.save(user);
+ }
+
+ public void deleteTransactional(User user) {
+userRepository.delete(user);
+throw new RuntimeException("saga compensation rollback test");
Review comment:
We just let the user know this method is supposed to be failed and the
repository operation will be rollback. Don't worry I will submit a quick fix
for it after merging your PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Saga transactional method can't work when compensation happens
> --
>
> Key: SCB-963
> URL: https://issues.apache.org/jira/browse/SCB-963
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.2.0, saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> currently we cached the compensation method of raw bean in callback context.
> it will make transactional method inefficient, we should cache the
> transaction proxy bean instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691889#comment-16691889 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20182133) Coverage decreased (-0.3%) to 61.841% when pulling **16d080b0f2d912226cc24dde179f889d8a5a0595 on little-cui:bug** into **5cec4bafcfe1f111de44efd47e2aff22843921ff on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691888#comment-16691888 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/5cec4bafcfe1f111de44efd47e2aff22843921ff?src=pr=desc) will **decrease** coverage by `0.39%`. > The diff coverage is `27%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) ```diff @@Coverage Diff@@ ## master #493 +/- ## = - Coverage 59.72% 59.32% -0.4% = Files 165 166 +1 Lines 1379613865 +69 = - Hits 8239 8226 -13 - Misses 4973 5057 +84 + Partials 584 582 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/syncer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvc3luY2VyLmdv) | `42.74% <42.74%> (ø)` | | | ... and [6 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=footer). Last update [5cec4ba...16d080b](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[ https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691741#comment-16691741 ] ASF GitHub Bot commented on SCB-1021: - coveralls commented on issue #997: [SCB-1021] Add vertx client server meters URL: https://github.com/apache/servicecomb-java-chassis/pull/997#issuecomment-439906101 [](https://coveralls.io/builds/20180331) Coverage increased (+0.04%) to 86.756% when pulling **2c95a52863cc0df3e66dd8f44ce0b39a816564d4 on wujimin:add-vertx-client-server-meters** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add vertx client/server meters to metrics > - > > Key: SCB-1021 > URL: https://issues.apache.org/jira/browse/SCB-1021 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-175) Provide accesslog for the microservice
[ https://issues.apache.org/jira/browse/SCB-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691729#comment-16691729 ] wujimin commented on SCB-175: - by subscribe invocation finish event, we can provode unified RESTful/highway accesslog, right? > Provide accesslog for the microservice > --- > > Key: SCB-175 > URL: https://issues.apache.org/jira/browse/SCB-175 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Minor > Fix For: java-chassis-1.1.0 > > > As a SDK user, I need to record accesslog so that I can record all of my > access in each microservice for the debugging purpose > moved from [https://servicecomb.atlassian.net/browse/JAV-561] > 1.provide a mechanism to generate traceId > 2.create a new project, inherit from http header or init tranceId in > invocation context, event not use trace like zipkin/pinpoint/apm and so on. > 3.accessLog for consumer and producer ,both include traceId -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-843) add http client pool request time to consumer invocation meter
[ https://issues.apache.org/jira/browse/SCB-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-843. - Resolution: Duplicate already implemented > add http client pool request time to consumer invocation meter > -- > > Key: SCB-843 > URL: https://issues.apache.org/jira/browse/SCB-843 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-493) parameters and DefaultLogPublisher optimize
[
https://issues.apache.org/jira/browse/SCB-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wujimin resolved SCB-493.
-
Resolution: Implemented
Assignee: wujimin
Fix Version/s: java-chassis-1.1.0
1 and 2 already implemented
3 processed by https://issues.apache.org/jira/browse/SCB-1021, idle meters will
expired after serval minutes(default to be 15 minutes)
> parameters and DefaultLogPublisher optimize
> ---
>
> Key: SCB-493
> URL: https://issues.apache.org/jira/browse/SCB-493
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
> Attachments: image-2018-04-16-10-56-40-897.png,
> image-2018-04-16-10-57-11-883.png
>
>
> 1.change Servicecomb.metrics.window_time from 5000 to 6
> 2.change servicecomb.metrics.publisher.defaultLog.enabled from true to false
> 3.when there is no invocatio relate to the operation in this period, then
> DefaultLogPublisher should not output related tps/latency and so on.
> eg:
> {color:#59afe1}before optimize：{color}
> !image-2018-04-16-10-56-40-897.png!
> {color:#59afe1}after optimize:{color}
> !image-2018-04-16-10-57-11-883.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (SCB-419) tag_status support customize
[ https://issues.apache.org/jira/browse/SCB-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin closed SCB-419. --- Resolution: Invalid customers cancel the requirement > tag_status support customize > > > Key: SCB-419 > URL: https://issues.apache.org/jira/browse/SCB-419 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > for some products: > http status code is failed, then the invocation must be failed > http status code is successed, then the invocation maybe not successed, it > depend on response body value -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-691) add vertx server/ rest client/highway client/ highway server connection meter
[ https://issues.apache.org/jira/browse/SCB-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-691. - Resolution: Duplicate Assignee: wujimin Fix Version/s: java-chassis-1.1.0 already implemented > add vertx server/ rest client/highway client/ highway server connection meter > - > > Key: SCB-691 > URL: https://issues.apache.org/jira/browse/SCB-691 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > > if we can get connection count of servlet rest server, then create meter for > it too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-843) add http client pool request time to consumer invocation meter
[ https://issues.apache.org/jira/browse/SCB-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-843: Fix Version/s: java-chassis-1.1.0 > add http client pool request time to consumer invocation meter > -- > > Key: SCB-843 > URL: https://issues.apache.org/jira/browse/SCB-843 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-843) add http client pool request time to consumer invocation meter
[ https://issues.apache.org/jira/browse/SCB-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin reassigned SCB-843: --- Assignee: wujimin > add http client pool request time to consumer invocation meter > -- > > Key: SCB-843 > URL: https://issues.apache.org/jira/browse/SCB-843 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-1017) [SCB-1017] add os cpu net info in the metrics with linux os
[ https://issues.apache.org/jira/browse/SCB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-1017: - Issue Type: Sub-task (was: Improvement) Parent: SCB-359 > [SCB-1017] add os cpu net info in the metrics with linux os > > > Key: SCB-1017 > URL: https://issues.apache.org/jira/browse/SCB-1017 > Project: Apache ServiceComb > Issue Type: Sub-task >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1022) measure tcpServer and tcpClient
[ https://issues.apache.org/jira/browse/SCB-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-1022. -- Resolution: Done > measure tcpServer and tcpClient > --- > > Key: SCB-1022 > URL: https://issues.apache.org/jira/browse/SCB-1022 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[ https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691692#comment-16691692 ] ASF GitHub Bot commented on SCB-1021: - wujimin opened a new pull request #997: [SCB-1021] Add vertx client server meters URL: https://github.com/apache/servicecomb-java-chassis/pull/997 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add vertx client/server meters to metrics > - > > Key: SCB-1021 > URL: https://issues.apache.org/jira/browse/SCB-1021 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691657#comment-16691657 ] ASF GitHub Bot commented on SCB-1028: - asifdxtreme closed pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/docker-compose.yml b/docker-compose.yml index 9a9a01dc..c7be231e 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -1,3 +1,19 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- version: '3' services: etcd: diff --git a/docs/release/Readme.md b/docs/release/Readme.md index 3ceb1763..e01bca87 100644 --- a/docs/release/Readme.md +++ b/docs/release/Readme.md @@ -28,7 +28,7 @@ cp apache-rat-0.12/apache-rat-0.12.jar ./ Run the Rat tool using the below command ``` -java -jar apache-rat-0.12.jar -a -d servicecomb-service-center/ -e *.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses** bower.json +java -jar apache-rat-0.12.jar -a -d servicecomb-service-center/ -e *.md *.MD .gitignore .gitmodules .travis.yml manifest **vendor** **licenses** bower.json cert_pwd *.cer *.tpl glide.yaml go.mod go.sum ``` Below is the list of the files which has been excluded from the list of RAT tool. @@ -36,7 +36,9 @@ Below is the list of the files which has been excluded from the list of RAT tool - .gitignore .gitmodules .travis.yml : Skip the git files and travis file. - manifest **vendor : Skip manifest and all the files under vendor. - bower.json : Skip bower installation file - + - cert_pwd server.cer trust.cer : Skip ssl files + - *.tpl : Ignore template files + - glide.yaml go.mod go.sum : Skip dependency config files You can access the latest RAT report [here](/docs/release/rat-report) diff --git a/examples/infrastructures/docker/docker-compose.yml b/examples/infrastructures/docker/docker-compose.yml index bab0ac45..b54a2106 100644 --- a/examples/infrastructures/docker/docker-compose.yml +++ b/examples/infrastructures/docker/docker-compose.yml @@ -1,3 +1,19 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not use this file except in compliance with +## the License. You may obtain a copy of the License at +## +## http://www.apache.org/licenses/LICENSE-2.0 +## +## Unless required by applicable law or agreed to in writing, software +## distributed under the License is distributed on an "AS IS" BASIS, +## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +## See the License for the specific language governing permissions and +## limitations under the License. +## --- version: '3' services: prometheus: diff --git a/examples/infrastructures/docker/prometheus.yml b/examples/infrastructures/docker/prometheus.yml index 514df3b8..f1c203c6 100644 --- a/examples/infrastructures/docker/prometheus.yml +++ b/examples/infrastructures/docker/prometheus.yml @@ -1,3 +1,20 @@ +## --- +## Licensed to the Apache Software Foundation (ASF) under one or more +## contributor license agreements. See the NOTICE file distributed with +## this work for additional information regarding copyright ownership. +## The ASF licenses this file to You under the Apache License, Version 2.0 +## (the "License"); you may not
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[
https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691524#comment-16691524
]
ASF GitHub Bot commented on SCB-963:
cherrylzhao commented on a change in pull request #339: SCB-963 Add Test case
for saga transactional compensation.
URL: https://github.com/apache/servicecomb-saga/pull/339#discussion_r234564883
##
File path:
omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
##
@@ -65,4 +65,17 @@ public void delete(User user, int count) {
resetCount();
userRepository.delete(user);
}
+
+ @Compensable(compensationMethod = "deleteTransactional")
+ public User addTransactional(User user) {
+if (ILLEGAL_USER.equals(user.username())) {
+ throw new IllegalArgumentException("User is illegal");
+}
+return userRepository.save(user);
+ }
+
+ public void deleteTransactional(User user) {
+userRepository.delete(user);
+throw new RuntimeException("saga compensation rollback test");
Review comment:
yes, runtimeException is for transaction rollback. we need change the method
name?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Saga transactional method can't work when compensation happens
> --
>
> Key: SCB-963
> URL: https://issues.apache.org/jira/browse/SCB-963
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.2.0, saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> currently we cached the compensation method of raw bean in callback context.
> it will make transactional method inefficient, we should cache the
> transaction proxy bean instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[ https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691498#comment-16691498 ] ASF GitHub Bot commented on SCB-963: coveralls commented on issue #339: SCB-963 Add Test case for saga transactional compensation. URL: https://github.com/apache/servicecomb-saga/pull/339#issuecomment-439838304 [](https://coveralls.io/builds/20176064) Coverage increased (+0.3%) to 92.091% when pulling **d044e1d632f27e63a510ec11703cb1c472035a46 on cherrylzhao:master** into **58c2e228fed1f660ac9c5500666c942263947b65 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Saga transactional method can't work when compensation happens > -- > > Key: SCB-963 > URL: https://issues.apache.org/jira/browse/SCB-963 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0, saga-0.3.0 >Reporter: cherrylzhao >Assignee: cherrylzhao >Priority: Major > Fix For: saga-0.3.0, saga-0.2.1 > > > currently we cached the compensation method of raw bean in callback context. > it will make transactional method inefficient, we should cache the > transaction proxy bean instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[
https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691493#comment-16691493
]
ASF GitHub Bot commented on SCB-963:
WillemJiang commented on a change in pull request #339: SCB-963 Add Test case
for saga transactional compensation.
URL: https://github.com/apache/servicecomb-saga/pull/339#discussion_r234554223
##
File path:
omega/omega-spring-tx/src/test/java/org/apache/servicecomb/saga/omega/transaction/spring/TransactionalUserService.java
##
@@ -65,4 +65,17 @@ public void delete(User user, int count) {
resetCount();
userRepository.delete(user);
}
+
+ @Compensable(compensationMethod = "deleteTransactional")
+ public User addTransactional(User user) {
+if (ILLEGAL_USER.equals(user.username())) {
+ throw new IllegalArgumentException("User is illegal");
+}
+return userRepository.save(user);
+ }
+
+ public void deleteTransactional(User user) {
+userRepository.delete(user);
+throw new RuntimeException("saga compensation rollback test");
Review comment:
If the exception is thrown on purpose we need to change the name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Saga transactional method can't work when compensation happens
> --
>
> Key: SCB-963
> URL: https://issues.apache.org/jira/browse/SCB-963
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.2.0, saga-0.3.0
>Reporter: cherrylzhao
>Assignee: cherrylzhao
>Priority: Major
> Fix For: saga-0.3.0, saga-0.2.1
>
>
> currently we cached the compensation method of raw bean in callback context.
> it will make transactional method inefficient, we should cache the
> transaction proxy bean instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-986) ServerInstances can be cached in spring-boot2-starter-discovery
[
https://issues.apache.org/jira/browse/SCB-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691461#comment-16691461
]
ASF GitHub Bot commented on SCB-986:
liubao68 closed pull request #990: [SCB-986] Cache instances result in
CseDiscoveryClient
URL: https://github.com/apache/servicecomb-java-chassis/pull/990
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/java-chassis-dependencies/pom.xml
b/java-chassis-dependencies/pom.xml
index 6ab39942c..50a0778db 100644
--- a/java-chassis-dependencies/pom.xml
+++ b/java-chassis-dependencies/pom.xml
@@ -1040,6 +1040,11 @@
metrics-prometheus
1.1.0-SNAPSHOT
+
+org.apache.servicecomb
+spring-boot-common
+1.1.0-SNAPSHOT
+
com.google.protobuf
protobuf-java
diff --git a/java-chassis-spring-boot/pom.xml b/java-chassis-spring-boot/pom.xml
new file mode 100644
index 0..a20df52d4
--- /dev/null
+++ b/java-chassis-spring-boot/pom.xml
@@ -0,0 +1,37 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+java-chassis
+org.apache.servicecomb
+1.1.0-SNAPSHOT
+
+ 4.0.0
+ pom
+ java-chassis-spring-boot
+
+
+spring-boot-common
+spring-boot-starter
+spring-boot2-starter-parent
+
+
+
\ No newline at end of file
diff --git a/java-chassis-spring-boot/spring-boot-common/pom.xml
b/java-chassis-spring-boot/spring-boot-common/pom.xml
new file mode 100644
index 0..ad6f2882f
--- /dev/null
+++ b/java-chassis-spring-boot/spring-boot-common/pom.xml
@@ -0,0 +1,51 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+
+java-chassis-parent
+org.apache.servicecomb
+1.1.0-SNAPSHOT
+../../parent
+
+ 4.0.0
+
+ spring-boot-common
+
+
+ org.apache.servicecomb
+ service-registry
+
+
+
+
+
+
+org.apache.maven.plugins
+maven-compiler-plugin
+
+ 1.8
+ 1.8
+
+
+
+
+
+
\ No newline at end of file
diff --git
a/spring-boot2-starter-parent/spring-boot2-starter-discovery/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/CseDiscoveryClient.java
b/java-chassis-spring-boot/spring-boot-common/src/main/java/org/apache/servicecomb/springboot/common/AbstractDiscoveryClient.java
similarity index 67%
rename from
spring-boot2-starter-parent/spring-boot2-starter-discovery/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/CseDiscoveryClient.java
rename to
java-chassis-spring-boot/spring-boot-common/src/main/java/org/apache/servicecomb/springboot/common/AbstractDiscoveryClient.java
index ad605af26..f114439c7 100644
---
a/spring-boot2-starter-parent/spring-boot2-starter-discovery/src/main/java/org/apache/servicecomb/springboot2/starter/discovery/CseDiscoveryClient.java
+++
b/java-chassis-spring-boot/spring-boot-common/src/main/java/org/apache/servicecomb/springboot/common/AbstractDiscoveryClient.java
@@ -14,7 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.servicecomb.springboot2.starter.discovery;
+package org.apache.servicecomb.springboot.common;
import java.util.ArrayList;
import java.util.List;
@@ -22,49 +22,41 @@
import org.apache.servicecomb.foundation.common.cache.VersionedCache;
import org.apache.servicecomb.foundation.common.concurrent.ConcurrentHashMapEx;
-import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.serviceregistry.RegistryUtils;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
-import
org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;
import org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient;
import org.apache.servicecomb.serviceregistry.definition.DefinitionConst;
import org.apache.servicecomb.serviceregistry.discovery.DiscoveryContext;
+import org.apache.servicecomb.serviceregistry.discovery.DiscoveryFilter;
import org.apache.servicecomb.serviceregistry.discovery.DiscoveryTree;
-import org.springframework.cloud.client.DefaultServiceInstance;
-import org.springframework.cloud.client.ServiceInstance;
-import org.springframework.cloud.client.discovery.DiscoveryClient;
-public class CseDiscoveryClient implements DiscoveryClient {
+public abstract class AbstractDiscoveryClient {
+
private
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691471#comment-16691471 ] ASF GitHub Bot commented on SCB-1028: - little-cui commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234548347 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: this is grpc mechanism, sc need to export these interfaces. Users can import it from this repository This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-963) Saga transactional method can't work when compensation happens
[ https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691469#comment-16691469 ] ASF GitHub Bot commented on SCB-963: cherrylzhao opened a new pull request #339: SCB-963 Add Test case for saga transactional compensation. URL: https://github.com/apache/servicecomb-saga/pull/339 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Saga transactional method can't work when compensation happens > -- > > Key: SCB-963 > URL: https://issues.apache.org/jira/browse/SCB-963 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0, saga-0.3.0 >Reporter: cherrylzhao >Assignee: cherrylzhao >Priority: Major > Fix For: saga-0.3.0, saga-0.2.1 > > > currently we cached the compensation method of raw bean in callback context. > it will make transactional method inefficient, we should cache the > transaction proxy bean instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691464#comment-16691464 ] ASF GitHub Bot commented on SCB-1028: - asifdxtreme commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234547129 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: I think so its required, @little-cui can give more detail to this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691459#comment-16691459 ] ASF GitHub Bot commented on SCB-1028: - WillemJiang commented on a change in pull request #494: SCB-1028 Fix License Files URL: https://github.com/apache/servicecomb-service-center/pull/494#discussion_r234546036 ## File path: server/broker/brokerpb/broker.pb.go ## @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + Review comment: If it's generated, do we still need to add this file into repository? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1030) NPE when use DynamicSchemaLoader.registerSchemas(String, String)
[ https://issues.apache.org/jira/browse/SCB-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691439#comment-16691439 ] ASF GitHub Bot commented on SCB-1030: - coveralls commented on issue #996: 【SCB-1030】NPE when use DynamicSchemaLoader.registerSchemas(String, St… URL: https://github.com/apache/servicecomb-java-chassis/pull/996#issuecomment-439823018 [](https://coveralls.io/builds/20175437) Coverage increased (+0.0005%) to 86.692% when pulling **03a80f8960f2068e9da62c7e60345135568b1516 on laijianbin:patch-2** into **79b618569ae374ab5e983c9d0ca42a2dc313655b on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NPE when use DynamicSchemaLoader.registerSchemas(String, String) > > > Key: SCB-1030 > URL: https://issues.apache.org/jira/browse/SCB-1030 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > Attachments: image-2018-11-19-15-23-58-612.png > > > 2018-11-19 11:46:14,758 [ERROR] http server failed. > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.failureHandler(VertxRestDispatcher.java:72) > java.lang.NullPointerException > at > org.apache.servicecomb.common.rest.locator.OperationLocator.locate(OperationLocator.java:56) > at > org.apache.servicecomb.common.rest.locator.ServicePathManager.producerLocateOperation(ServicePathManager.java:116) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.locateOperation(RestProducerInvocation.java:61) > at > org.apache.servicecomb.common.rest.AbstractRestInvocation.findRestOperation(AbstractRestInvocation.java:80) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.findRestOperation(RestProducerInvocation.java:56) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.invoke(RestProducerInvocation.java:45) > at > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.onRequest(VertxRestDispatcher.java:194) > at io.vertx.ext.web.impl.RouteImpl.handleContext(RouteImpl.java:223) > at > io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:101) > at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:120) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.doEnd(RestBodyHandler.java:248) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.end(RestBodyHandler.java:226) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler.lambda$0(RestBodyHandler.java:86) > at > io.vertx.core.http.impl.HttpServerRequestImpl.handleEnd(HttpServerRequestImpl.java:418) > at > io.vertx.core.http.impl.ServerConnection.handleLastHttpContent(ServerConnection.java:475) > at > io.vertx.core.http.impl.ServerConnection.processMessage(ServerConnection.java:446) > at > io.vertx.core.http.impl.ServerConnection.handleMessage(ServerConnection.java:156) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:705) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:614) > at > io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:150) > at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:342) > at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:200) > at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:148) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) > at > io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284) > at >
[jira] [Commented] (SCB-1022) measure tcpServer and tcpClient
[
https://issues.apache.org/jira/browse/SCB-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691452#comment-16691452
]
ASF GitHub Bot commented on SCB-1022:
-
liubao68 closed pull request #993: [SCB-1022] measure tcpServer and tcpClient
URL: https://github.com/apache/servicecomb-java-chassis/pull/993
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
index d8d5286b1..f2f2b75f3 100644
---
a/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
+++
b/foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/metrics/DefaultHttpClientMetrics.java
@@ -20,77 +20,51 @@
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultClientEndpointMetricManager;
import
org.apache.servicecomb.foundation.vertx.metrics.metric.DefaultHttpSocketMetric;
-import io.vertx.core.http.HttpClient;
-import io.vertx.core.http.HttpClientOptions;
import io.vertx.core.http.HttpClientRequest;
import io.vertx.core.http.HttpClientResponse;
import io.vertx.core.http.WebSocket;
import io.vertx.core.net.SocketAddress;
-import io.vertx.core.net.impl.SocketAddressImpl;
import io.vertx.core.spi.metrics.HttpClientMetrics;
/**
* important: not singleton, every HttpClient instance relate to a
HttpClientMetrics instance
*/
public class DefaultHttpClientMetrics implements
-HttpClientMetrics {
-
+HttpClientMetrics {
private final DefaultClientEndpointMetricManager clientEndpointMetricManager;
- private final HttpClient client;
-
- private final HttpClientOptions options;
-
- public DefaultHttpClientMetrics(DefaultClientEndpointMetricManager
clientEndpointMetricManager,
- HttpClient client, HttpClientOptions options) {
+ public DefaultHttpClientMetrics(DefaultClientEndpointMetricManager
clientEndpointMetricManager) {
this.clientEndpointMetricManager = clientEndpointMetricManager;
-this.client = client;
-this.options = options;
- }
-
- public HttpClient getClient() {
-return client;
- }
-
- public HttpClientOptions getOptions() {
-return options;
}
@Override
- public DefaultClientEndpointMetric createEndpoint(String host, int port, int
maxPoolSize) {
-SocketAddress address = new SocketAddressImpl(port, host);
-return
clientEndpointMetricManager.getOrCreateClientEndpointMetric(address);
+ public Object createEndpoint(String host, int port, int maxPoolSize) {
+return null;
}
@Override
- public void closeEndpoint(String host, int port, DefaultClientEndpointMetric
endpointMetric) {
-endpointMetric.decRefCount();
+ public void closeEndpoint(String host, int port, Object endpointMetric) {
}
@Override
- public Object enqueueRequest(DefaultClientEndpointMetric endpointMetric) {
+ public Object enqueueRequest(Object endpointMetric) {
return null;
}
@Override
- public void dequeueRequest(DefaultClientEndpointMetric endpointMetric,
Object taskMetric) {
+ public void dequeueRequest(Object endpointMetric, Object taskMetric) {
}
@Override
- public void endpointConnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
-// as http2 client will not invoke this method, the endpointMetric info
will lost.
-// you can get more details from
https://github.com/eclipse-vertx/vert.x/issues/2660
-// hence, we will set endpointMetric info in the method
connected(SocketAddress remoteAddress, String remoteName)
+ public void endpointConnected(Object endpointMetric, DefaultHttpSocketMetric
socketMetric) {
}
@Override
- public void endpointDisconnected(DefaultClientEndpointMetric endpointMetric,
DefaultHttpSocketMetric socketMetric) {
-endpointMetric.onDisconnect();
-socketMetric.setConnected(false);
+ public void endpointDisconnected(Object endpointMetric,
DefaultHttpSocketMetric socketMetric) {
}
@Override
- public DefaultHttpSocketMetric requestBegin(DefaultClientEndpointMetric
endpointMetric,
+ public DefaultHttpSocketMetric requestBegin(Object endpointMetric,
DefaultHttpSocketMetric socketMetric, SocketAddress localAddress,
SocketAddress remoteAddress,
HttpClientRequest request) {
socketMetric.requestBegin();
@@ -107,7 +81,7 @@ public void responseBegin(DefaultHttpSocketMetric
requestMetric, HttpClientRespo
}
@Override
- public DefaultHttpSocketMetric
[jira] [Commented] (SCB-1030) NPE when use DynamicSchemaLoader.registerSchemas(String, String)
[ https://issues.apache.org/jira/browse/SCB-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691419#comment-16691419 ] ASF GitHub Bot commented on SCB-1030: - laijianbin commented on issue #996: 【SCB-1030】NPE when use DynamicSchemaLoader.registerSchemas(String, St… URL: https://github.com/apache/servicecomb-java-chassis/pull/996#issuecomment-439816874 I hava descripted how this problem happened at https://issues.apache.org/jira/browse/SCB-1030 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NPE when use DynamicSchemaLoader.registerSchemas(String, String) > > > Key: SCB-1030 > URL: https://issues.apache.org/jira/browse/SCB-1030 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > Attachments: image-2018-11-19-15-23-58-612.png > > > 2018-11-19 11:46:14,758 [ERROR] http server failed. > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.failureHandler(VertxRestDispatcher.java:72) > java.lang.NullPointerException > at > org.apache.servicecomb.common.rest.locator.OperationLocator.locate(OperationLocator.java:56) > at > org.apache.servicecomb.common.rest.locator.ServicePathManager.producerLocateOperation(ServicePathManager.java:116) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.locateOperation(RestProducerInvocation.java:61) > at > org.apache.servicecomb.common.rest.AbstractRestInvocation.findRestOperation(AbstractRestInvocation.java:80) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.findRestOperation(RestProducerInvocation.java:56) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.invoke(RestProducerInvocation.java:45) > at > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.onRequest(VertxRestDispatcher.java:194) > at io.vertx.ext.web.impl.RouteImpl.handleContext(RouteImpl.java:223) > at > io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:101) > at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:120) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.doEnd(RestBodyHandler.java:248) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.end(RestBodyHandler.java:226) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler.lambda$0(RestBodyHandler.java:86) > at > io.vertx.core.http.impl.HttpServerRequestImpl.handleEnd(HttpServerRequestImpl.java:418) > at > io.vertx.core.http.impl.ServerConnection.handleLastHttpContent(ServerConnection.java:475) > at > io.vertx.core.http.impl.ServerConnection.processMessage(ServerConnection.java:446) > at > io.vertx.core.http.impl.ServerConnection.handleMessage(ServerConnection.java:156) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:705) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:614) > at > io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:150) > at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:342) > at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:200) > at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:148) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) > at > io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) > at > io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) > at > io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at >
[jira] [Commented] (SCB-1030) NPE when use DynamicSchemaLoader.registerSchemas(String, String)
[ https://issues.apache.org/jira/browse/SCB-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691412#comment-16691412 ] ASF GitHub Bot commented on SCB-1030: - laijianbin opened a new pull request #996: 【SCB-1030】NPE when use DynamicSchemaLoader.registerSchemas(String, St… URL: https://github.com/apache/servicecomb-java-chassis/pull/996 …ring) Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > NPE when use DynamicSchemaLoader.registerSchemas(String, String) > > > Key: SCB-1030 > URL: https://issues.apache.org/jira/browse/SCB-1030 > Project: Apache ServiceComb > Issue Type: Task >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > Attachments: image-2018-11-19-15-23-58-612.png > > > 2018-11-19 11:46:14,758 [ERROR] http server failed. > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.failureHandler(VertxRestDispatcher.java:72) > java.lang.NullPointerException > at > org.apache.servicecomb.common.rest.locator.OperationLocator.locate(OperationLocator.java:56) > at > org.apache.servicecomb.common.rest.locator.ServicePathManager.producerLocateOperation(ServicePathManager.java:116) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.locateOperation(RestProducerInvocation.java:61) > at > org.apache.servicecomb.common.rest.AbstractRestInvocation.findRestOperation(AbstractRestInvocation.java:80) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.findRestOperation(RestProducerInvocation.java:56) > at > org.apache.servicecomb.common.rest.RestProducerInvocation.invoke(RestProducerInvocation.java:45) > at > org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.onRequest(VertxRestDispatcher.java:194) > at io.vertx.ext.web.impl.RouteImpl.handleContext(RouteImpl.java:223) > at > io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:101) > at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:120) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.doEnd(RestBodyHandler.java:248) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.end(RestBodyHandler.java:226) > at > org.apache.servicecomb.transport.rest.vertx.RestBodyHandler.lambda$0(RestBodyHandler.java:86) > at > io.vertx.core.http.impl.HttpServerRequestImpl.handleEnd(HttpServerRequestImpl.java:418) > at > io.vertx.core.http.impl.ServerConnection.handleLastHttpContent(ServerConnection.java:475) > at > io.vertx.core.http.impl.ServerConnection.processMessage(ServerConnection.java:446) > at > io.vertx.core.http.impl.ServerConnection.handleMessage(ServerConnection.java:156) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:705) > at > io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:614) > at > io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:150) > at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:342) > at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:200) > at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:148) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) > at > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348)
[jira] [Commented] (SCB-1030) NPE when use DynamicSchemaLoader.registerSchemas(String, String)
[
https://issues.apache.org/jira/browse/SCB-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691413#comment-16691413
]
ASF GitHub Bot commented on SCB-1030:
-
laijianbin closed pull request #995: 【SCB-1030】NPE when use
DynamicSchemaLoader.registerSchemas(String, St…
URL: https://github.com/apache/servicecomb-java-chassis/pull/995
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestEngineSchemaListener.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestEngineSchemaListener.java
index 14e4c39e3..580c5327f 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestEngineSchemaListener.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestEngineSchemaListener.java
@@ -72,9 +72,8 @@ protected ServicePathManager findPathManager(Map mgr
mgr = ServicePathManager.getServicePathManager(microserviceMeta);
if (mgr == null) {
mgr = new ServicePathManager(microserviceMeta);
-} else {
- mgr = mgr.cloneServicePathManager();
}
+
mgrMap.put(microserviceMeta.getName(), mgr);
return mgr;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> NPE when use DynamicSchemaLoader.registerSchemas(String, String)
>
>
> Key: SCB-1030
> URL: https://issues.apache.org/jira/browse/SCB-1030
> Project: Apache ServiceComb
> Issue Type: Task
>Reporter: laijianbin
>Assignee: laijianbin
>Priority: Major
> Attachments: image-2018-11-19-15-23-58-612.png
>
>
> 2018-11-19 11:46:14,758 [ERROR] http server failed.
> org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.failureHandler(VertxRestDispatcher.java:72)
> java.lang.NullPointerException
> at
> org.apache.servicecomb.common.rest.locator.OperationLocator.locate(OperationLocator.java:56)
> at
> org.apache.servicecomb.common.rest.locator.ServicePathManager.producerLocateOperation(ServicePathManager.java:116)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.locateOperation(RestProducerInvocation.java:61)
> at
> org.apache.servicecomb.common.rest.AbstractRestInvocation.findRestOperation(AbstractRestInvocation.java:80)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.findRestOperation(RestProducerInvocation.java:56)
> at
> org.apache.servicecomb.common.rest.RestProducerInvocation.invoke(RestProducerInvocation.java:45)
> at
> org.apache.servicecomb.transport.rest.vertx.VertxRestDispatcher.onRequest(VertxRestDispatcher.java:194)
> at io.vertx.ext.web.impl.RouteImpl.handleContext(RouteImpl.java:223)
> at
> io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:101)
> at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:120)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.doEnd(RestBodyHandler.java:248)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler$BHandler.end(RestBodyHandler.java:226)
> at
> org.apache.servicecomb.transport.rest.vertx.RestBodyHandler.lambda$0(RestBodyHandler.java:86)
> at
> io.vertx.core.http.impl.HttpServerRequestImpl.handleEnd(HttpServerRequestImpl.java:418)
> at
> io.vertx.core.http.impl.ServerConnection.handleLastHttpContent(ServerConnection.java:475)
> at
> io.vertx.core.http.impl.ServerConnection.processMessage(ServerConnection.java:446)
> at
> io.vertx.core.http.impl.ServerConnection.handleMessage(ServerConnection.java:156)
> at
> io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:705)
> at
> io.vertx.core.http.impl.HttpServerImpl$ServerHandlerWithWebSockets.handleMessage(HttpServerImpl.java:614)
> at
> io.vertx.core.net.impl.VertxHandler.lambda$channelRead$1(VertxHandler.java:150)
> at io.vertx.core.impl.ContextImpl.lambda$wrapTask$2(ContextImpl.java:342)
> at io.vertx.core.impl.ContextImpl.executeFromIO(ContextImpl.java:200)
> at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:148)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362)
> at
>
[jira] [Commented] (SCB-986) ServerInstances can be cached in spring-boot2-starter-discovery
[ https://issues.apache.org/jira/browse/SCB-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691397#comment-16691397 ] ASF GitHub Bot commented on SCB-986: yangbor commented on a change in pull request #990: [SCB-986] Cache instances result in CseDiscoveryClient URL: https://github.com/apache/servicecomb-java-chassis/pull/990#discussion_r234529807 ## File path: java-chassis-spring-boot/spring-boot-common/src/main/java/org/apache/servicecomb/springboot/common/AbstractInstanceDiscoveryFilter.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.servicecomb.springboot.common; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +import org.apache.servicecomb.core.Const; Review comment: Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ServerInstances can be cached in spring-boot2-starter-discovery > --- > > Key: SCB-986 > URL: https://issues.apache.org/jira/browse/SCB-986 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > > ServerInstances can be cached in spring-boot2-starter-discovery and > spring-boot-starter-discovery -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-940) [SCB-940] move float type test case from demo to integration-test
[ https://issues.apache.org/jira/browse/SCB-940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-940. --- > [SCB-940] move float type test case from demo to integration-test > - > > Key: SCB-940 > URL: https://issues.apache.org/jira/browse/SCB-940 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-950) [SCB-950] modify consumer producer metrics and add edge metrics
[ https://issues.apache.org/jira/browse/SCB-950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-950. --- > [SCB-950] modify consumer producer metrics and add edge metrics > > > Key: SCB-950 > URL: https://issues.apache.org/jira/browse/SCB-950 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > the info in the old metics is not enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-846) [SCB-846] ConfigCenterClient log too much in the pull mode
[ https://issues.apache.org/jira/browse/SCB-846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-846. --- > [SCB-846] ConfigCenterClient log too much in the pull mode > -- > > Key: SCB-846 > URL: https://issues.apache.org/jira/browse/SCB-846 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-755) [SCB-755] 755 Duplicate copy cse config to Servicecomb config
[ https://issues.apache.org/jira/browse/SCB-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-755. --- > [SCB-755] 755 Duplicate copy cse config to Servicecomb config > - > > Key: SCB-755 > URL: https://issues.apache.org/jira/browse/SCB-755 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > Fix For: java-chassis-1.0.0 > > > [main ] WARN Key cse.tcc.transaction.redis.host with an ambiguous > item servicecomb.tcc.transaction.redis.host exists, it's recommended to use > only one of them. > [org.apache.servicecomb.config.ConfigUtil.duplicateCseConfigToServicecomb(ConfigUtil.java:178)] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-782) [SCB-782]support revision check when use pull mode with config center
[ https://issues.apache.org/jira/browse/SCB-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-782. --- > [SCB-782]support revision check when use pull mode with config center > - > > Key: SCB-782 > URL: https://issues.apache.org/jira/browse/SCB-782 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-839) SCB-839 move int type test case from demo to integration-test
[ https://issues.apache.org/jira/browse/SCB-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-839. --- > SCB-839 move int type test case from demo to integration-test > - > > Key: SCB-839 > URL: https://issues.apache.org/jira/browse/SCB-839 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > > move int type test case from demo to integration-test, -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-841) [SCB-841] move string type test case from demo to integration-test
[ https://issues.apache.org/jira/browse/SCB-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-841. --- > [SCB-841] move string type test case from demo to integration-test > -- > > Key: SCB-841 > URL: https://issues.apache.org/jira/browse/SCB-841 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-939) [SCB-939] move double type test case from demo to integration-test
[ https://issues.apache.org/jira/browse/SCB-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-939. --- > [SCB-939] move double type test case from demo to integration-test > -- > > Key: SCB-939 > URL: https://issues.apache.org/jira/browse/SCB-939 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-765) add connection count meter to metrics
[ https://issues.apache.org/jira/browse/SCB-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin resolved SCB-765. - Resolution: Duplicate https://issues.apache.org/jira/browse/SCB-1022 > add connection count meter to metrics > - > > Key: SCB-765 > URL: https://issues.apache.org/jira/browse/SCB-765 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Priority: Major > > include consumer and producer, highway and rest > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-992) Synchronous open source code from Vert.x 3.5.3 version
[ https://issues.apache.org/jira/browse/SCB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jeho0815 closed SCB-992. Resolution: Fixed > Synchronous open source code from Vert.x 3.5.3 version > -- > > Key: SCB-992 > URL: https://issues.apache.org/jira/browse/SCB-992 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-1017) [SCB-1017] add os cpu net info in the metrics with linux os
[ https://issues.apache.org/jira/browse/SCB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 closed SCB-1017. > [SCB-1017] add os cpu net info in the metrics with linux os > > > Key: SCB-1017 > URL: https://issues.apache.org/jira/browse/SCB-1017 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1017) [SCB-1017] add os cpu net info in the metrics with linux os
[ https://issues.apache.org/jira/browse/SCB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 何一乐 resolved SCB-1017. -- Resolution: Fixed Assignee: 何一乐 > [SCB-1017] add os cpu net info in the metrics with linux os > > > Key: SCB-1017 > URL: https://issues.apache.org/jira/browse/SCB-1017 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SCB-963) Saga transactional method can't work when compensation happens
[ https://issues.apache.org/jira/browse/SCB-963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687958#comment-16687958 ] Willem Jiang edited comment on SCB-963 at 11/19/18 7:51 AM: Merged the patch into 0.2.x branch. https://github.com/apache/servicecomb-saga/commit/217afc4e44cb5905463ce658dd425ccb6011f090 was (Author: njiang): Merged the patch into 0.2.x branch. > Saga transactional method can't work when compensation happens > -- > > Key: SCB-963 > URL: https://issues.apache.org/jira/browse/SCB-963 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0, saga-0.3.0 >Reporter: cherrylzhao >Assignee: cherrylzhao >Priority: Major > Fix For: saga-0.3.0, saga-0.2.1 > > > currently we cached the compensation method of raw bean in callback context. > it will make transactional method inefficient, we should cache the > transaction proxy bean instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
