[jira] [Resolved] (SCB-986) ServerInstances can be cached in spring-boot2-starter-discovery
[ https://issues.apache.org/jira/browse/SCB-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Bo resolved SCB-986. - Resolution: Fixed Fix Version/s: java-chassis-1.1.0 done > ServerInstances can be cached in spring-boot2-starter-discovery > --- > > Key: SCB-986 > URL: https://issues.apache.org/jira/browse/SCB-986 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.1.0 >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.1.0 > > > ServerInstances can be cached in spring-boot2-starter-discovery and > spring-boot-starter-discovery -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-348) Proxy all the request of frontend through Go Server which can use TLS
[ https://issues.apache.org/jira/browse/SCB-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-348: --- Fix Version/s: (was: service-center-1.1.0) > Proxy all the request of frontend through Go Server which can use TLS > -- > > Key: SCB-348 > URL: https://issues.apache.org/jira/browse/SCB-348 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Labels: roadmap > > Currently all the request has been sent directly from browser to SC. > Proposal: Proxy all the request through frontend go-server which is used to > host file server, this server should be able to talk to SC with TLS -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-438) As SC model is changing, we should keep SC proto spec in isolated project, so that go sdk can import same model as SC does
[ https://issues.apache.org/jira/browse/SCB-438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-438: --- Fix Version/s: (was: service-center-1.1.0) > As SC model is changing, we should keep SC proto spec in isolated project, so > that go sdk can import same model as SC does > -- > > Key: SCB-438 > URL: https://issues.apache.org/jira/browse/SCB-438 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-993. Resolution: Fixed > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui closed SCB-993. -- > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-1028) Prepare 1.1.0 Service-Center Release
[ https://issues.apache.org/jira/browse/SCB-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-1028. - Resolution: Fixed > Prepare 1.1.0 Service-Center Release > > > Key: SCB-1028 > URL: https://issues.apache.org/jira/browse/SCB-1028 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-871) Add schema source code editor in Schema Test module
[ https://issues.apache.org/jira/browse/SCB-871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-871: --- Fix Version/s: (was: service-center-1.1.0) > Add schema source code editor in Schema Test module > --- > > Key: SCB-871 > URL: https://issues.apache.org/jira/browse/SCB-871 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: xiaoyimei >Priority: Major > > Just like swagger.io, developer can edit the source code in Schema Test dialog -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-602) Add the support of highway in Testing Schema
[ https://issues.apache.org/jira/browse/SCB-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-602: --- Fix Version/s: (was: service-center-1.1.0) > Add the support of highway in Testing Schema > > > Key: SCB-602 > URL: https://issues.apache.org/jira/browse/SCB-602 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Priority: Major > Labels: roadmap > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-723) Support All Infra for deployment of Service-Center
[ https://issues.apache.org/jira/browse/SCB-723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-723: --- Fix Version/s: (was: service-center-1.1.0) > Support All Infra for deployment of Service-Center > -- > > Key: SCB-723 > URL: https://issues.apache.org/jira/browse/SCB-723 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > > Support Deployment of SC on docker, VM, K8S, ServiceStage -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-623) Not detailed internal server error response
[ https://issues.apache.org/jira/browse/SCB-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-623: --- Fix Version/s: (was: service-center-1.1.0) > Not detailed internal server error response > --- > > Key: SCB-623 > URL: https://issues.apache.org/jira/browse/SCB-623 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-872) Push the vendors to git repository
[ https://issues.apache.org/jira/browse/SCB-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-872: --- Fix Version/s: (was: service-center-1.1.0) > Push the vendors to git repository > -- > > Key: SCB-872 > URL: https://issues.apache.org/jira/browse/SCB-872 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Service-Center >Reporter: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693318#comment-16693318 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr&el=desc) will **decrease** coverage by `0.44%`. > The diff coverage is `27.24%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#493 +/- ## = - Coverage 59.74% 59.3% -0.45% = Files 165 166 +1 Lines 13796 13865 +69 = - Hits 82438222 -21 - Misses 49735057 +84 - Partials 580 586 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=footer). Last update [0a0b1fd...8199895](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693323#comment-16693323 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20202735) Coverage decreased (-0.5%) to 61.686% when pulling **8199895e5b31bdc18e27eff6e3f55cb359e2a773 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[ https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693489#comment-16693489 ] ASF GitHub Bot commented on SCB-1021: - coveralls edited a comment on issue #997: [SCB-1021] Add vertx client server meters URL: https://github.com/apache/servicecomb-java-chassis/pull/997#issuecomment-439906101 [](https://coveralls.io/builds/20205681) Coverage increased (+0.04%) to 86.755% when pulling **d24c0e37914e272b4de36d37153b1a96ca8fe1aa on wujimin:add-vertx-client-server-meters** into **defbfa4e67504356f309a0c447840dae06f22726 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add vertx client/server meters to metrics > - > > Key: SCB-1021 > URL: https://issues.apache.org/jira/browse/SCB-1021 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693509#comment-16693509 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr&el=desc) will **decrease** coverage by `0.42%`. > The diff coverage is `27.76%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.31% -0.43% == Files 165 166 +1 Lines 1379613869 +73 == - Hits 8243 8227 -16 - Misses 4973 5059 +86 - Partials 580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.07% <100%> (-0.44%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=footer). Last update [0a0b1fd...ea8bf4a](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693511#comment-16693511 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20205928) Coverage decreased (-0.5%) to 61.653% when pulling **ea8bf4acbd7a6ad2df2c045c3bc825797b44fde8 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693929#comment-16693929
]
ASF GitHub Bot commented on SCB-993:
little-cui commented on a change in pull request #493: WIP: SCB-993 search sc
cluster when key mismatch with aggregator cache
URL:
https://github.com/apache/servicecomb-service-center/pull/493#discussion_r235215710
##
File path: server/service/notification/websocket.go
##
@@ -181,7 +181,9 @@ func (wh *WebSocket) HandleWatchWebSocketJob(o
interface{}) {
message = util.StringToBytesWithNoCopy(fmt.Sprintf("watcher
catch an err: %s", err.Error()))
case time.Time:
domainProject := util.ParseDomainProject(wh.ctx)
- if !serviceUtil.ServiceExist(wh.ctx, domainProject,
wh.watcher.Group()) {
+ if !serviceUtil.ServiceExist(
+ context.WithValue(wh.ctx, serviceUtil.CTX_REGISTRYONLY,
"1"),
+ domainProject, wh.watcher.Group()) {
Review comment:
error logic, we don’t only require consumer registered locally
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16693933#comment-16693933
]
ASF GitHub Bot commented on SCB-993:
little-cui commented on a change in pull request #493: WIP: SCB-993 search sc
cluster when key mismatch with aggregator cache
URL:
https://github.com/apache/servicecomb-service-center/pull/493#discussion_r235216627
##
File path: server/plugin/pkg/discovery/aggregate/indexer.go
##
@@ -42,15 +43,24 @@ func (i *AdaptorsIndexer) Search(ctx context.Context, opts
...registry.PluginOpO
if _, ok := exists[key]; !ok {
Review comment:
Add cache searching here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694093#comment-16694093 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr&el=desc) will **decrease** coverage by `0.43%`. > The diff coverage is `27.07%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.31% -0.44% == Files 165 166 +1 Lines 1379613867 +71 == - Hits 8243 8225 -18 - Misses 4973 5059 +86 - Partials 580 583 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <10.2%> (-6.29%)` | :arrow_down: | | [server/plugin/pkg/discovery/etcd/indexer\_etcd.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9ldGNkLmdv) | `100% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `46.98% <100%> (-1.56%)` | :arrow_down: | | [pkg/cache/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3RyZWUuZ28=) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2NhY2hlci5nbw==) | `100% <100%> (ø)` | :arrow_up: | | [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `88.23% <100%> (-1.77%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=footer). Last update [0a0b1fd...848dc76](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). --
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694095#comment-16694095 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20215170) Coverage decreased (-0.4%) to 61.723% when pulling **848dc76627a5e558fabfdff024e986715dc7f74f on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[
https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694103#comment-16694103
]
ASF GitHub Bot commented on SCB-1021:
-
heyile commented on a change in pull request #997: [SCB-1021] Add vertx client
server meters
URL:
https://github.com/apache/servicecomb-java-chassis/pull/997#discussion_r235230456
##
File path:
foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/spectator/MeasurementNode.java
##
@@ -91,4 +91,12 @@ public double summary() {
return result;
}
+
+ // GaugePoller sync measurements to meters
+ // but when the first time or measurement expired, maybe get half
measurements
+ // so need to support node not exist
+ public double findChildAndSummary(String childName) {
+MeasurementNode node = findChild(childName);
+return node != null ? node.summary() : 0;
Review comment:
only return 0 is ok ? can we prevent the lost of measurements, maybe we can
shorter the interval of gaugePollingFrequency
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add vertx client/server meters to metrics
> -
>
> Key: SCB-1021
> URL: https://issues.apache.org/jira/browse/SCB-1021
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1021) add vertx client/server meters to metrics
[
https://issues.apache.org/jira/browse/SCB-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694107#comment-16694107
]
ASF GitHub Bot commented on SCB-1021:
-
wujimin commented on a change in pull request #997: [SCB-1021] Add vertx client
server meters
URL:
https://github.com/apache/servicecomb-java-chassis/pull/997#discussion_r235232498
##
File path:
foundations/foundation-metrics/src/main/java/org/apache/servicecomb/foundation/metrics/publish/spectator/MeasurementNode.java
##
@@ -91,4 +91,12 @@ public double summary() {
return result;
}
+
+ // GaugePoller sync measurements to meters
+ // but when the first time or measurement expired, maybe get half
measurements
+ // so need to support node not exist
+ public double findChildAndSummary(String childName) {
+MeasurementNode node = findChild(childName);
+return node != null ? node.summary() : 0;
Review comment:
too expensive
first time and expired is rare event, just make it not cause problem is
enough
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add vertx client/server meters to metrics
> -
>
> Key: SCB-1021
> URL: https://issues.apache.org/jira/browse/SCB-1021
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: wujimin
>Priority: Major
> Fix For: java-chassis-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (SCB-1031) Ignore the order of @APIOperation and @Resoponse on the method
jeho0815 created SCB-1031:
-
Summary: Ignore the order of @APIOperation and @Resoponse on the
method
Key: SCB-1031
URL: https://issues.apache.org/jira/browse/SCB-1031
Project: Apache ServiceComb
Issue Type: Improvement
Components: Java-Chassis
Reporter: jeho0815
@ApiResponse(code = 200, message = "200 is ok", response =
String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
response = String.class))
@ApiOperation(nickname="getHelloworld", value="测试", notes="this is a test",
response = Integer.class, code = 200,
responseHeaders = {@ResponseHeader(name = "x-user-name", response =
String.class),
@ResponseHeader(name = "x-user-id", response = String.class)})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SCB-1031) Ignore the order of @APIOperation and @Resoponse on the method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jeho0815 reassigned SCB-1031:
-
Assignee: jeho0815
> Ignore the order of @APIOperation and @Resoponse on the method
> --
>
> Key: SCB-1031
> URL: https://issues.apache.org/jira/browse/SCB-1031
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> @ApiResponse(code = 200, message = "200 is ok", response =
> String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
> response = String.class))
> @ApiOperation(nickname="getHelloworld", value="测试", notes="this is a test",
> response = Integer.class, code = 200,
> responseHeaders = {@ResponseHeader(name = "x-user-name", response =
> String.class),
> @ResponseHeader(name = "x-user-id", response = String.class)})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-1031) Ignore the order of @APIOperation and @Resoponse on the method
[
https://issues.apache.org/jira/browse/SCB-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jeho0815 updated SCB-1031:
--
Description:
@ApiResponse(code = 200, message = "200 is ok", response =
String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
response = String.class))
@ApiOperation(nickname="getHelloworld", value="test", notes="this is a test",
response = Integer.class, code = 200,
responseHeaders =
{@ResponseHeader(name = "x-user-name", response = String.class),
@ResponseHeader(name = "x-user-id", response = String.class)}
)
swagger 's response's descritpion will be default "resoponse of 200", the best
descritpion should be "200 is ok"
was:
@ApiResponse(code = 200, message = "200 is ok", response =
String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
response = String.class))
@ApiOperation(nickname="getHelloworld", value="测试", notes="this is a test",
response = Integer.class, code = 200,
responseHeaders = {@ResponseHeader(name = "x-user-name", response =
String.class),
@ResponseHeader(name = "x-user-id", response = String.class)})
> Ignore the order of @APIOperation and @Resoponse on the method
> --
>
> Key: SCB-1031
> URL: https://issues.apache.org/jira/browse/SCB-1031
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: jeho0815
>Assignee: jeho0815
>Priority: Major
>
> @ApiResponse(code = 200, message = "200 is ok", response =
> String.class, responseHeaders = @ResponseHeader(name = "x-user-domain",
> response = String.class))
> @ApiOperation(nickname="getHelloworld", value="test", notes="this is a
> test", response = Integer.class, code = 200,
> responseHeaders =
> {@ResponseHeader(name = "x-user-name", response = String.class),
> @ResponseHeader(name = "x-user-id", response = String.class)}
> )
>
> swagger 's response's descritpion will be default "resoponse of 200", the
> best descritpion should be "200 is ok"
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694303#comment-16694303 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20217736) Coverage decreased (-0.4%) to 61.797% when pulling **b1888ba4d66c3aba5af8db27f25d7a24a64a58b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694304#comment-16694304 ] ASF GitHub Bot commented on SCB-993: coveralls edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767178 [](https://coveralls.io/builds/20217748) Coverage decreased (-0.6%) to 61.565% when pulling **b1888ba4d66c3aba5af8db27f25d7a24a64a58b6 on little-cui:bug** into **0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694306#comment-16694306 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr&el=desc) will **decrease** coverage by `0.46%`. > The diff coverage is `25.52%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.28% -0.47% == Files 165 166 +1 Lines 1379613879 +83 == - Hits 8243 8228 -15 - Misses 4973 5071 +98 Partials 580 580 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=footer). Last update [0a0b1fd...b1888ba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an autom
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694305#comment-16694305 ] ASF GitHub Bot commented on SCB-993: codecov-io edited a comment on issue #493: WIP: SCB-993 search sc cluster when key mismatch with aggregator cache URL: https://github.com/apache/servicecomb-service-center/pull/493#issuecomment-439767176 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=h1) Report > Merging [#493](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/0a0b1fd8a8f7b1f7c6fd4badcfde6032ed17f8de?src=pr&el=desc) will **decrease** coverage by `0.46%`. > The diff coverage is `25.52%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #493 +/- ## == - Coverage 59.74% 59.28% -0.47% == Files 165 166 +1 Lines 1379613879 +83 == - Hits 8243 8228 -15 - Misses 4973 5071 +98 Partials 580 580 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/event/instance\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvaW5zdGFuY2VfZXZlbnRfaGFuZGxlci5nbw==) | `7.54% <0%> (-0.3%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `62.02% <0%> (-4.2%)` | :arrow_down: | | [...rver/plugin/pkg/discovery/servicecenter/indexer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvaW5kZXhlci5nbw==) | `0% <0%> (-35%)` | :arrow_down: | | [...erver/plugin/pkg/discovery/servicecenter/cacher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvY2FjaGVyLmdv) | `33.33% <0%> (ø)` | :arrow_up: | | [server/service/util/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC91dGlsLmdv) | `80% <0%> (-10%)` | :arrow_down: | | [server/service/event/dependency\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvZGVwZW5kZW5jeV9ldmVudF9oYW5kbGVyLmdv) | `15.17% <0%> (-0.14%)` | :arrow_down: | | [scctl/pkg/plugin/diagnose/diagnose.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9kaWFnbm9zZS5nbw==) | `64.77% <0%> (ø)` | :arrow_up: | | [...rver/plugin/pkg/discovery/servicecenter/adaptor.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWRhcHRvci5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/service/event/rule\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvcnVsZV9ldmVudF9oYW5kbGVyLmdv) | `8.33% <0%> (-0.37%)` | :arrow_down: | | [server/service/event/tag\_event\_handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvZXZlbnQvdGFnX2V2ZW50X2hhbmRsZXIuZ28=) | `7.14% <0%> (-0.27%)` | :arrow_down: | | ... and [14 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/493/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=footer). Last update [0a0b1fd...b1888ba](https://codecov.io/gh/apache/servicecomb-service-center/pull/493?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an autom
