[jira] [Comment Edited] (SPARK-30629) cleanClosure on recursive call leads to node stack overflow

2020-01-25 Thread Maciej Szymkiewicz (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023711#comment-17023711
 ] 

Maciej Szymkiewicz edited comment on SPARK-30629 at 1/26/20 2:46 AM:
-

[~falaki] Fair enough, but the problem is that we actually haves test for that 
specific scenario 
https://github.com/apache/spark/blob/d5b92b24c41b047c64a4d89cc4061ebf534f0995/R/pkg/tests/fulltests/test_utils.R#L92,
 which causes build failures 
(https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/30357218,
 Unicode issue is work in progress ‒ SPARK-30645 / 
https://github.com/apache/spark/pull/27362)


was (Author: zero323):
[~falaki] Fair enough, but the problem is that we actually haves test for that 
specific scenario 
https://github.com/apache/spark/blob/d5b92b24c41b047c64a4d89cc4061ebf534f0995/R/pkg/tests/fulltests/test_utils.R#L92,
 which causes build failures.

> cleanClosure on recursive call leads to node stack overflow
> ---
>
> Key: SPARK-30629
> URL: https://issues.apache.org/jira/browse/SPARK-30629
> Project: Spark
>  Issue Type: Bug
>  Components: SparkR
>Affects Versions: 3.0.0
>Reporter: Maciej Szymkiewicz
>Priority: Major
>
> This problem surfaced while handling SPARK-22817. In theory there are tests, 
> which cover that problem, but it seems like they have been dead for some 
> reason.
> Reproducible example
> {code:r}
> f <- function(x) {
>   f(x)
> }
> SparkR:::cleanClosure(f)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Comment Edited] (SPARK-30629) cleanClosure on recursive call leads to node stack overflow

2020-01-25 Thread Maciej Szymkiewicz (Jira)


[ 
https://issues.apache.org/jira/browse/SPARK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023711#comment-17023711
 ] 

Maciej Szymkiewicz edited comment on SPARK-30629 at 1/26/20 2:42 AM:
-

[~falaki] Fair enough, but the problem is that we actually haves test for that 
specific scenario 
https://github.com/apache/spark/blob/d5b92b24c41b047c64a4d89cc4061ebf534f0995/R/pkg/tests/fulltests/test_utils.R#L92,
 which causes build failures.


was (Author: zero323):
[~falaki] Fair enough, but the problem is that we actually test for that 
specific scenario 
https://github.com/apache/spark/blob/d5b92b24c41b047c64a4d89cc4061ebf534f0995/R/pkg/tests/fulltests/test_utils.R#L92,
 which cause test failures.

> cleanClosure on recursive call leads to node stack overflow
> ---
>
> Key: SPARK-30629
> URL: https://issues.apache.org/jira/browse/SPARK-30629
> Project: Spark
>  Issue Type: Bug
>  Components: SparkR
>Affects Versions: 3.0.0
>Reporter: Maciej Szymkiewicz
>Priority: Major
>
> This problem surfaced while handling SPARK-22817. In theory there are tests, 
> which cover that problem, but it seems like they have been dead for some 
> reason.
> Reproducible example
> {code:r}
> f <- function(x) {
>   f(x)
> }
> SparkR:::cleanClosure(f)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org