[jira] [Comment Edited] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[ https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730311#comment-15730311 ] Michal Šenkýř edited comment on SPARK-3359 at 12/7/16 11:40 PM: Yes, I did do a grep on `[error]`. I am trying to build the docs now with those `>` replaced by `gt;` to see if it completes. I believe it would be worth it to fix. As a newcomer to the Spark community, I had no idea it was Java 8 related. was (Author: michalsenkyr): Yes, I did do a grep on `[error]`. I am trying to build the docs now with those `>` replaced by `>` to see if it completes. I believe it would be worth it to fix. As a newcomer to the Spark community, I had no idea it was Java 8 related. > `sbt/sbt unidoc` doesn't work with Java 8 > - > > Key: SPARK-3359 > URL: https://issues.apache.org/jira/browse/SPARK-3359 > Project: Spark > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.0 >Reporter: Xiangrui Meng >Assignee: Hyukjin Kwon >Priority: Minor > Fix For: 2.1.1 > > Attachments: errors.txt > > > It seems that Java 8 is stricter on JavaDoc. I got many error messages like > {code} > [error] > /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2: > error: modifier private not allowed here > [error] private abstract interface SparkHadoopMapRedUtil { > [error] ^ > {code} > This is minor because we can always use Java 6/7 to generate the doc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[ https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730294#comment-15730294 ] Hyukjin Kwon edited comment on SPARK-3359 at 12/7/16 11:35 PM: --- I believe you ran {{jekyll build}} and {{grep error}}. If you see the logs, it says actually only 6(ish) errors about < and > IIRC, which I guess was missed in the attched log file. I was not submiting a PR because it might be too minor (including java lint break). I can fix both in a single minor PR if it seems worth. was (Author: hyukjin.kwon): I believe you ran {{jekyll build}} and {{grep error}}. If you see the logs, it says actually only 6(ish) errors about < and > IIRC. I was not submiting a PR because it might be too minor (including java lint break). I can fix both in a single minor PR if it seems worth. > `sbt/sbt unidoc` doesn't work with Java 8 > - > > Key: SPARK-3359 > URL: https://issues.apache.org/jira/browse/SPARK-3359 > Project: Spark > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.0 >Reporter: Xiangrui Meng >Assignee: Hyukjin Kwon >Priority: Minor > Fix For: 2.1.1 > > Attachments: errors.txt > > > It seems that Java 8 is stricter on JavaDoc. I got many error messages like > {code} > [error] > /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2: > error: modifier private not allowed here > [error] private abstract interface SparkHadoopMapRedUtil { > [error] ^ > {code} > This is minor because we can always use Java 6/7 to generate the doc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-3359) `sbt/sbt unidoc` doesn't work with Java 8
[ https://issues.apache.org/jira/browse/SPARK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730250#comment-15730250 ] Michal Šenkýř edited comment on SPARK-3359 at 12/7/16 11:16 PM: Javadoc errors as of 2016-12-08 - see attachment was (Author: michalsenkyr): Javadoc errors as of 2016-12-08 > `sbt/sbt unidoc` doesn't work with Java 8 > - > > Key: SPARK-3359 > URL: https://issues.apache.org/jira/browse/SPARK-3359 > Project: Spark > Issue Type: Bug > Components: Documentation >Affects Versions: 1.1.0 >Reporter: Xiangrui Meng >Assignee: Hyukjin Kwon >Priority: Minor > Fix For: 2.1.1 > > Attachments: errors.txt > > > It seems that Java 8 is stricter on JavaDoc. I got many error messages like > {code} > [error] > /Users/meng/src/spark-mengxr/core/target/java/org/apache/hadoop/mapred/SparkHadoopMapRedUtil.java:2: > error: modifier private not allowed here > [error] private abstract interface SparkHadoopMapRedUtil { > [error] ^ > {code} > This is minor because we can always use Java 6/7 to generate the doc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org