[jira] [Commented] (SPARK-12761) Clean up duplicated code in scala 2.11 repl.Main
[
https://issues.apache.org/jira/browse/SPARK-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092963#comment-15092963
]
Apache Spark commented on SPARK-12761:
--
User 'jodersky' has created a pull request for this issue:
https://github.com/apache/spark/pull/10711
> Clean up duplicated code in scala 2.11 repl.Main
>
>
> Key: SPARK-12761
> URL: https://issues.apache.org/jira/browse/SPARK-12761
> Project: Spark
> Issue Type: Improvement
> Components: Spark Shell
>Reporter: Jakob Odersky
>Priority: Trivial
>
> There is duplicate code in
> {{/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala}}.
> According to git blame, I moved the "settings" val to a method-local val,
> however due to a subsequent merge it was reintroduced as a global val.
> Cf
> https://github.com/apache/spark/blame/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala,
> line 33.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-12761) Clean up duplicated code in scala 2.11 repl.Main
[
https://issues.apache.org/jira/browse/SPARK-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092964#comment-15092964
]
Jakob Odersky commented on SPARK-12761:
---
@vanzin, I think this is your area of expertise
> Clean up duplicated code in scala 2.11 repl.Main
>
>
> Key: SPARK-12761
> URL: https://issues.apache.org/jira/browse/SPARK-12761
> Project: Spark
> Issue Type: Improvement
> Components: Spark Shell
>Reporter: Jakob Odersky
>Priority: Trivial
>
> There is duplicate code in
> {{/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala}}.
> According to git blame, I moved the "settings" val to a method-local val,
> however due to a subsequent merge it was reintroduced as a global val.
> Cf
> https://github.com/apache/spark/blame/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala,
> line 33.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
