[jira] [Commented] (SPARK-13920) MIMA checks should apply to @Experimental and @DeveloperAPI APIs

2016-03-15 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196743#comment-15196743
 ] 

Apache Spark commented on SPARK-13920:
--

User 'dongjoon-hyun' has created a pull request for this issue:
https://github.com/apache/spark/pull/11751

> MIMA checks should apply to @Experimental and @DeveloperAPI APIs
> 
>
> Key: SPARK-13920
> URL: https://issues.apache.org/jira/browse/SPARK-13920
> Project: Spark
>  Issue Type: Bug
>  Components: Project Infra
>Reporter: Josh Rosen
>
> Our MIMA binary compatibility checks currently ignore APIs which are marked 
> as {{@Experimental}} or {{@DeveloperApi}}, but I don't think this makes 
> sense. Even if those annotations _reserve_ the right to break binary 
> compatibility, we should still avoid compatibility breaks whenever possible 
> and should be informed explicitly when compatibility breaks.
> As a result, we should update GenerateMIMAIgnore to stop ignoring classes and 
> methods which have those annotations. To remove the ignores, remove the 
> checks from 
> https://github.com/apache/spark/blob/643649dcbfabc5d6952c2ecfb98286324c887665/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala#L43
> After removing the ignores, update {{project/MimaExcludes.scala}} to add 
> exclusions for binary compatibility breaks introduced in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13920) MIMA checks should apply to @Experimental and @DeveloperAPI APIs

2016-03-15 Thread Dongjoon Hyun (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196626#comment-15196626
 ] 

Dongjoon Hyun commented on SPARK-13920:
---

Oh, [~joshrosen]. 
I totally agree with the purpose of this issue. 
I'll start to work this issue.

> MIMA checks should apply to @Experimental and @DeveloperAPI APIs
> 
>
> Key: SPARK-13920
> URL: https://issues.apache.org/jira/browse/SPARK-13920
> Project: Spark
>  Issue Type: Bug
>  Components: Project Infra
>Reporter: Josh Rosen
>
> Our MIMA binary compatibility checks currently ignore APIs which are marked 
> as {{@Experimental}} or {{@DeveloperApi}}, but I don't think this makes 
> sense. Even if those annotations _reserve_ the right to break binary 
> compatibility, we should still avoid compatibility breaks whenever possible 
> and should be informed explicitly when compatibility breaks.
> As a result, we should update GenerateMIMAIgnore to stop ignoring classes and 
> methods which have those annotations. To remove the ignores, remove the 
> checks from 
> https://github.com/apache/spark/blob/643649dcbfabc5d6952c2ecfb98286324c887665/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala#L43
> After removing the ignores, update {{project/MimaExcludes.scala}} to add 
> exclusions for binary compatibility breaks introduced in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13920) MIMA checks should apply to @Experimental and @DeveloperAPI APIs

2016-03-15 Thread Josh Rosen (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196548#comment-15196548
 ] 

Josh Rosen commented on SPARK-13920:


I am not planning to work on this, so this task is up for grabs.

> MIMA checks should apply to @Experimental and @DeveloperAPI APIs
> 
>
> Key: SPARK-13920
> URL: https://issues.apache.org/jira/browse/SPARK-13920
> Project: Spark
>  Issue Type: Bug
>  Components: Project Infra
>Reporter: Josh Rosen
>
> Our MIMA binary compatibility checks currently ignore APIs which are marked 
> as {{@Experimental}} or {{@DeveloperApi}}, but I don't think this makes 
> sense. Even if those annotations _reserve_ the right to break binary 
> compatibility, we should still avoid compatibility breaks whenever possible 
> and should be informed explicitly when compatibility breaks.
> As a result, we should update GenerateMIMAIgnore to stop ignoring classes and 
> methods which have those annotations. To remove the ignores, remove the 
> checks from 
> https://github.com/apache/spark/blob/643649dcbfabc5d6952c2ecfb98286324c887665/tools/src/main/scala/org/apache/spark/tools/GenerateMIMAIgnore.scala#L43
> After removing the ignores, update {{project/MimaExcludes.scala}} to add 
> exclusions for binary compatibility breaks introduced in 2.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org