[jira] [Commented] (SPARK-13937) PySpark ML JavaWrapper, variable _java_obj should not be static
[
https://issues.apache.org/jira/browse/SPARK-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197902#comment-15197902
]
Apache Spark commented on SPARK-13937:
--
User 'BryanCutler' has created a pull request for this issue:
https://github.com/apache/spark/pull/11767
> PySpark ML JavaWrapper, variable _java_obj should not be static
> ---
>
> Key: SPARK-13937
> URL: https://issues.apache.org/jira/browse/SPARK-13937
> Project: Spark
> Issue Type: Bug
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> In PySpark ML wrapper.py, the abstract class {{JavaWrapper}} has a static
> variable {{_java_obj}}. This is meant to hold an instance of a companion
> Java object. It seems as though it was made static accidentally because it
> is never used, and all assignments done in derived classes are done to a
> member variable with {{self._java_obj}}. This does not cause any problems
> with the current functionality, but it should be changed so as not to cause
> any confusion and misuse in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-13937) PySpark ML JavaWrapper, variable _java_obj should not be static
[
https://issues.apache.org/jira/browse/SPARK-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197805#comment-15197805
]
Bryan Cutler commented on SPARK-13937:
--
I'll submit a PR for this
> PySpark ML JavaWrapper, variable _java_obj should not be static
> ---
>
> Key: SPARK-13937
> URL: https://issues.apache.org/jira/browse/SPARK-13937
> Project: Spark
> Issue Type: Bug
> Components: ML, PySpark
>Reporter: Bryan Cutler
>Priority: Minor
>
> In PySpark ML wrapper.py, the abstract class {{JavaWrapper}} has a static
> variable {{_java_obj}}. This is meant to hold an instance of a companion
> Java object. It seems as though it was made static accidentally because it
> is never used, and all assignments done in derived classes are done to a
> member variable with {{self._java_obj}}. This does not cause any problems
> with the current functionality, but it should be changed so as not to cause
> any confusion and misuse in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
