[jira] [Commented] (SPARK-14358) Change SparkListener from a trait to an abstract class, and remove JavaSparkListener
[ https://issues.apache.org/jira/browse/SPARK-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496924#comment-15496924 ] Oleksiy Sayankin commented on SPARK-14358: -- [~rxin], please see my comments here: https://issues.apache.org/jira/browse/SPARK-17563, but I thinks yes, I can. And after all I decided to create an issue https://issues.apache.org/jira/browse/HIVE-14777 > Change SparkListener from a trait to an abstract class, and remove > JavaSparkListener > > > Key: SPARK-14358 > URL: https://issues.apache.org/jira/browse/SPARK-14358 > Project: Spark > Issue Type: Sub-task > Components: Scheduler, Spark Core >Reporter: Reynold Xin >Assignee: Reynold Xin > Fix For: 2.0.0 > > > Scala traits are difficult to maintain binary compatibility on, and as a > result we had to introduce JavaSparkListener. In Spark 2.0 we can change > SparkListener from a trait to an abstract class and then remove > JavaSparkListener. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14358) Change SparkListener from a trait to an abstract class, and remove JavaSparkListener
[ https://issues.apache.org/jira/browse/SPARK-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496798#comment-15496798 ] Reynold Xin commented on SPARK-14358: - [~osayankin] we thought about creating a compatibility package for backward compatibility, but in this case you can trivially add a JavaSparkListener in Hive, can't you? > Change SparkListener from a trait to an abstract class, and remove > JavaSparkListener > > > Key: SPARK-14358 > URL: https://issues.apache.org/jira/browse/SPARK-14358 > Project: Spark > Issue Type: Sub-task > Components: Scheduler, Spark Core >Reporter: Reynold Xin >Assignee: Reynold Xin > Fix For: 2.0.0 > > > Scala traits are difficult to maintain binary compatibility on, and as a > result we had to introduce JavaSparkListener. In Spark 2.0 we can change > SparkListener from a trait to an abstract class and then remove > JavaSparkListener. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14358) Change SparkListener from a trait to an abstract class, and remove JavaSparkListener
[ https://issues.apache.org/jira/browse/SPARK-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496130#comment-15496130 ] Oleksiy Sayankin commented on SPARK-14358: -- Hive-2.X.X uses JavaSparkListener {code} package org.apache.hadoop.hive.ql.exec.spark.status.impl; import ... public class JobMetricsListener extends JavaSparkListener { {code} Configuring Hive-2.X.X on Spark-2.0.0 will give an exception: {code} 2016-09-16T11:20:57,474 INFO [stderr-redir-1]: client.SparkClientImpl (SparkClientImpl.java:run(593)) - java.lang.NoClassDefFoundError: org/apache/spark/JavaSparkListener {code} Please add JavaSparkListener into Spark-2.0.0 > Change SparkListener from a trait to an abstract class, and remove > JavaSparkListener > > > Key: SPARK-14358 > URL: https://issues.apache.org/jira/browse/SPARK-14358 > Project: Spark > Issue Type: Sub-task > Components: Scheduler, Spark Core >Reporter: Reynold Xin >Assignee: Reynold Xin > Fix For: 2.0.0 > > > Scala traits are difficult to maintain binary compatibility on, and as a > result we had to introduce JavaSparkListener. In Spark 2.0 we can change > SparkListener from a trait to an abstract class and then remove > JavaSparkListener. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14358) Change SparkListener from a trait to an abstract class, and remove JavaSparkListener
[ https://issues.apache.org/jira/browse/SPARK-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223647#comment-15223647 ] Apache Spark commented on SPARK-14358: -- User 'rxin' has created a pull request for this issue: https://github.com/apache/spark/pull/12142 > Change SparkListener from a trait to an abstract class, and remove > JavaSparkListener > > > Key: SPARK-14358 > URL: https://issues.apache.org/jira/browse/SPARK-14358 > Project: Spark > Issue Type: Sub-task > Components: Scheduler, Spark Core >Reporter: Reynold Xin >Assignee: Reynold Xin > > Scala traits are difficult to maintain binary compatibility on, and as a > result we had to introduce JavaSparkListener. In Spark 2.0 we can change > SparkListener from a trait to an abstract class and then remove > JavaSparkListener. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org