[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15241534#comment-15241534 ] Dongjoon Hyun commented on SPARK-14577: --- Hi, [~rxin] Could you take a look when you had some time? > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238786#comment-15238786 ] Apache Spark commented on SPARK-14577: -- User 'dongjoon-hyun' has created a pull request for this issue: https://github.com/apache/spark/pull/12353 > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238344#comment-15238344 ] Reynold Xin commented on SPARK-14577: - Yea we shouldn't change the architecture. > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238323#comment-15238323 ] Dongjoon Hyun commented on SPARK-14577: --- In the current Spark architecture, `sql/core` module is designed to depend on `catalyst` module, and `catalyst` module does not access `SQLConf` of `sql/core`. What this issue needs is using configuration without changing any architectural design, isn't it? > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238129#comment-15238129 ] Dongjoon Hyun commented on SPARK-14577: --- Oh, sure! Thank you for guide. > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-14577) spark.sql.codegen.maxCaseBranches config option
[ https://issues.apache.org/jira/browse/SPARK-14577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238057#comment-15238057 ] Reynold Xin commented on SPARK-14577: - cc [~dongjoon] want to do this? > spark.sql.codegen.maxCaseBranches config option > --- > > Key: SPARK-14577 > URL: https://issues.apache.org/jira/browse/SPARK-14577 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Reynold Xin > > We currently disable codegen for CaseWhen if the number of branches is > greater than 20 (in CaseWhen.MAX_NUM_CASES_FOR_CODEGEN). It would be better > if this value is a non-public config defined in SQLConf. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
