[jira] [Commented] (SPARK-18909) The error message in `ExpressionEncoder.toRow` and `fromRow` is too verbose

2017-01-25 Thread Apache Spark (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837438#comment-15837438
 ] 

Apache Spark commented on SPARK-18909:
--

User 'dongjoon-hyun' has created a pull request for this issue:
https://github.com/apache/spark/pull/16701

> The error message in `ExpressionEncoder.toRow` and `fromRow` is too verbose
> ---
>
> Key: SPARK-18909
> URL: https://issues.apache.org/jira/browse/SPARK-18909
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Reporter: Wenchen Fan
>Priority: Minor
>
> In `ExpressionEncoder.toRow` and `fromRow`, we will catch the exception and 
> put the treeString of serializer/deserializer expressions in the error 
> message. However, encoder can be very complex and the serializer/deserializer 
> expressions can be very large trees and blow up the log files(e.g. generate 
> over 500mb logs for this single error message.)
> We should simplify it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-18909) The error message in `ExpressionEncoder.toRow` and `fromRow` is too verbose

2017-01-25 Thread Dongjoon Hyun (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-18909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837411#comment-15837411
 ] 

Dongjoon Hyun commented on SPARK-18909:
---

Hi, [~cloud_fan].
For this issue, is it sufficient to print out `simpleString` instead of 
`treeString`?

> The error message in `ExpressionEncoder.toRow` and `fromRow` is too verbose
> ---
>
> Key: SPARK-18909
> URL: https://issues.apache.org/jira/browse/SPARK-18909
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Reporter: Wenchen Fan
>Priority: Minor
>
> In `ExpressionEncoder.toRow` and `fromRow`, we will catch the exception and 
> put the treeString of serializer/deserializer expressions in the error 
> message. However, encoder can be very complex and the serializer/deserializer 
> expressions can be very large trees and blow up the log files(e.g. generate 
> over 500mb logs for this single error message.)
> We should simplify it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org