[jira] [Commented] (SPARK-19296) Awkward changes for JdbcUtils.saveTable in Spark 2.1.0
[ https://issues.apache.org/jira/browse/SPARK-19296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833205#comment-15833205 ] Dongjoon Hyun commented on SPARK-19296: --- Hi, [~zwu@gmail.com] It looks like a question. Could you ask to dev mailing list before making a JIRA issue? BTW, what you mentioned here is SPARK-17719 and https://github.com/apache/spark/pull/15292 . > Awkward changes for JdbcUtils.saveTable in Spark 2.1.0 > -- > > Key: SPARK-19296 > URL: https://issues.apache.org/jira/browse/SPARK-19296 > Project: Spark > Issue Type: Improvement > Components: SQL >Affects Versions: 2.1.0 >Reporter: Paul Wu >Priority: Minor > > The Change from JdbcUtils.saveTable(DataFrame, String, String, Property) to > JdbcUtils.saveTable(DataFrame, String, String, JDBCOptions), not only > incompatible to previous versions (so the previous code in java won't > compile, but also introduced silly code change: One has to specify url and > table twice like this: > JDBCOptions jdbcOptions = new JDBCOptions(url, table, map); > JdbcUtils.saveTable(ds, url, table,jdbcOptions); > Why does one have to supply the same things ulr, table twice? (If you don't > specify it in both places, the exception will be thrown). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-19296) Awkward changes for JdbcUtils.saveTable in Spark 2.1.0
[ https://issues.apache.org/jira/browse/SPARK-19296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831033#comment-15831033 ] Paul Wu commented on SPARK-19296: - We found this Util is very useful in general (much, much better than primitive jdbc) and have been using it since 1.3.x... didn't realize it is internal. It will a big regret for us to not be able to use it. But it seems it is a pain for us now. I guess for code quality purpose, at least refactor the code to eliminate the duplication args. > Awkward changes for JdbcUtils.saveTable in Spark 2.1.0 > -- > > Key: SPARK-19296 > URL: https://issues.apache.org/jira/browse/SPARK-19296 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 2.1.0 >Reporter: Paul Wu >Priority: Minor > > The Change from JdbcUtils.saveTable(DataFrame, String, String, Property) to > JdbcUtils.saveTable(DataFrame, String, String, JDBCOptions), not only > incompatible to previous versions (so the previous code in java won't > compile, but also introduced silly code change: One has to specify url and > table twice like this: > JDBCOptions jdbcOptions = new JDBCOptions(url, table, map); > JdbcUtils.saveTable(ds, url, table,jdbcOptions); > Why does one have to supply the same things ulr, table twice? (If you don't > specify it in both places, the exception will be thrown). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-19296) Awkward changes for JdbcUtils.saveTable in Spark 2.1.0
[
https://issues.apache.org/jira/browse/SPARK-19296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830924#comment-15830924
]
Hyukjin Kwon commented on SPARK-19296:
--
{quote}
incompatible to previous versions
{quote}
If this JIRA targets the API incompatibility, we could resolve this as a
{{Invaild}}.
{quote}
Why does one have to supply the same things ulr, table twice
{quote}
If this one is about simple refactoring for de-duplicating arguments, I think
it is valid although it is a trivial that can be quickly fixed.
> Awkward changes for JdbcUtils.saveTable in Spark 2.1.0
> --
>
> Key: SPARK-19296
> URL: https://issues.apache.org/jira/browse/SPARK-19296
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.1.0
>Reporter: Paul Wu
>Priority: Minor
>
> The Change from JdbcUtils.saveTable(DataFrame, String, String, Property) to
> JdbcUtils.saveTable(DataFrame, String, String, JDBCOptions), not only
> incompatible to previous versions (so the previous code in java won't
> compile, but also introduced silly code change: One has to specify url and
> table twice like this:
> JDBCOptions jdbcOptions = new JDBCOptions(url, table, map);
> JdbcUtils.saveTable(ds, url, table,jdbcOptions);
> Why does one have to supply the same things ulr, table twice? (If you don't
> specify it in both places, the exception will be thrown).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-19296) Awkward changes for JdbcUtils.saveTable in Spark 2.1.0
[ https://issues.apache.org/jira/browse/SPARK-19296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830915#comment-15830915 ] Hyukjin Kwon commented on SPARK-19296: -- https://github.com/apache/spark/blob/b85e29437d570118f5980a1d6ba56c1f06a3dfd1/sql/core/src/main/scala/org/apache/spark/sql/execution/package.scala#L21-L23 > * The physical execution component of Spark SQL. Note that this is a private > package. > * All classes in catalyst are considered an internal API to Spark SQL and are > subject > * to change between minor releases. I guess that is meant to be a private one. > Awkward changes for JdbcUtils.saveTable in Spark 2.1.0 > -- > > Key: SPARK-19296 > URL: https://issues.apache.org/jira/browse/SPARK-19296 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 2.1.0 >Reporter: Paul Wu >Priority: Minor > > The Change from JdbcUtils.saveTable(DataFrame, String, String, Property) to > JdbcUtils.saveTable(DataFrame, String, String, JDBCOptions), not only > incompatible to previous versions (so the previous code in java won't > compile, but also introduced silly code change: One has to specify url and > table twice like this: > JDBCOptions jdbcOptions = new JDBCOptions(url, table, map); > JdbcUtils.saveTable(ds, url, table,jdbcOptions); > Why does one have to supply the same things ulr, table twice? (If you don't > specify it in both places, the exception will be thrown). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
