[jira] [Commented] (SPARK-20284) Make SerializationStream and DeserializationStream extend Closeable
[
https://issues.apache.org/jira/browse/SPARK-20284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964463#comment-15964463
]
Sergei Lebedev commented on SPARK-20284:
Yes, Scala is a bad citizen in the JVM land and comes w/o any support for
try-with-resources. IIUC scala-arm would manage just fine without Closeable
because it uses structural types. However, I think there is no reason not to
implement Closeable/AutoCloseable even if Spark/Scala code does not need this.
> Make SerializationStream and DeserializationStream extend Closeable
> ---
>
> Key: SPARK-20284
> URL: https://issues.apache.org/jira/browse/SPARK-20284
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
>Affects Versions: 1.6.3, 2.1.0
>Reporter: Sergei Lebedev
>Priority: Trivial
>
> Both {{SerializationStream}} and {{DeserializationStream}} implement
> {{close}} but do not extend {{Closeable}}. As a result, these streams cannot
> be used in try-with-resources.
> Was this intentional or rather nobody ever needed that?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20284) Make SerializationStream and DeserializationStream extend Closeable
[
https://issues.apache.org/jira/browse/SPARK-20284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964263#comment-15964263
]
Sean Owen commented on SPARK-20284:
---
It's a developer API, so dont' think callers will generally be using this.
try-with-resources isn't a JVM feature, it's a Java language feature. For
example this doesn't do anything for Scala AFAIK.
> Make SerializationStream and DeserializationStream extend Closeable
> ---
>
> Key: SPARK-20284
> URL: https://issues.apache.org/jira/browse/SPARK-20284
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
>Affects Versions: 1.6.3, 2.1.0
>Reporter: Sergei Lebedev
>Priority: Trivial
>
> Both {{SerializationStream}} and {{DeserializationStream}} implement
> {{close}} but do not extend {{Closeable}}. As a result, these streams cannot
> be used in try-with-resources.
> Was this intentional or rather nobody ever needed that?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20284) Make SerializationStream and DeserializationStream extend Closeable
[
https://issues.apache.org/jira/browse/SPARK-20284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964257#comment-15964257
]
Sergei Lebedev commented on SPARK-20284:
It makes the stream well-behaved for any JVM user, e.g. pure-Java or
[Kotlin|https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io/use.html].
> Make SerializationStream and DeserializationStream extend Closeable
> ---
>
> Key: SPARK-20284
> URL: https://issues.apache.org/jira/browse/SPARK-20284
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
>Affects Versions: 1.6.3, 2.1.0
>Reporter: Sergei Lebedev
>Priority: Trivial
>
> Both {{SerializationStream}} and {{DeserializationStream}} implement
> {{close}} but do not extend {{Closeable}}. As a result, these streams cannot
> be used in try-with-resources.
> Was this intentional or rather nobody ever needed that?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-20284) Make SerializationStream and DeserializationStream extend Closeable
[
https://issues.apache.org/jira/browse/SPARK-20284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963419#comment-15963419
]
Apache Spark commented on SPARK-20284:
--
User 'superbobry' has created a pull request for this issue:
https://github.com/apache/spark/pull/17598
> Make SerializationStream and DeserializationStream extend Closeable
> ---
>
> Key: SPARK-20284
> URL: https://issues.apache.org/jira/browse/SPARK-20284
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
>Affects Versions: 1.6.3, 2.1.0
>Reporter: Sergei Lebedev
>Priority: Minor
>
> Both {{SerializationStream}} and {{DeserializationStream}} implement
> {{close}} but do not extend {{Closeable}}. As a result, these streams cannot
> be used in try-with-resources.
> Was this intentional or rather nobody ever needed that?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
