[jira] [Commented] (SPARK-23079) Fix query constraints propagation with aliases
[ https://issues.apache.org/jira/browse/SPARK-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327398#comment-16327398 ] Apache Spark commented on SPARK-23079: -- User 'gengliangwang' has created a pull request for this issue: https://github.com/apache/spark/pull/20278 > Fix query constraints propagation with aliases > -- > > Key: SPARK-23079 > URL: https://issues.apache.org/jira/browse/SPARK-23079 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 2.2.1 >Reporter: Gengliang Wang >Priority: Major > > Previously, PR #19201 fix the problem of non-converging constraints. > After that PR #19149 improve the loop and constraints is inferred only once. > So the problem of non-converging constraints is gone. > Also, in current code, the case below will fail. > ``` > spark.range(5).write.saveAsTable("t") > val t = spark.read.table("t") > val left = t.withColumn("xid", $"id" + lit(1)).as("x") > val right = t.withColumnRenamed("id", "xid").as("y") > val df = left.join(right, "xid").filter("id = 3").toDF() > checkAnswer(df, Row(4, 3)) > ``` > Because of `aliasMap` replace all the aliased child. See the test case in PR > for details. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23079) Fix query constraints propagation with aliases
[ https://issues.apache.org/jira/browse/SPARK-23079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326334#comment-16326334 ] Apache Spark commented on SPARK-23079: -- User 'gengliangwang' has created a pull request for this issue: https://github.com/apache/spark/pull/20270 > Fix query constraints propagation with aliases > -- > > Key: SPARK-23079 > URL: https://issues.apache.org/jira/browse/SPARK-23079 > Project: Spark > Issue Type: Bug > Components: SQL >Affects Versions: 2.2.1 >Reporter: Gengliang Wang >Priority: Major > > Previously, PR #19201 fix the problem of non-converging constraints. > After that PR #19149 improve the loop and constraints is inferred only once. > So the problem of non-converging constraints is gone. > Also, in current code, the case below will fail. > ``` > spark.range(5).write.saveAsTable("t") > val t = spark.read.table("t") > val left = t.withColumn("xid", $"id" + lit(1)).as("x") > val right = t.withColumnRenamed("id", "xid").as("y") > val df = left.join(right, "xid").filter("id = 3").toDF() > checkAnswer(df, Row(4, 3)) > ``` > Because of `aliasMap` replace all the aliased child. See the test case in PR > for details. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org