[jira] [Commented] (SPARK-23344) Add KMeans distanceMeasure param to PySpark
[ https://issues.apache.org/jira/browse/SPARK-23344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362902#comment-16362902 ] Sean Owen commented on SPARK-23344: --- Nah, I think the regulars have different views on this, which nevertheless work OK for them. Often where it becomes a problem are for people trying to inflate a JIRA count, and they won't generally have read or paid attention to threads like that anyway. > Add KMeans distanceMeasure param to PySpark > --- > > Key: SPARK-23344 > URL: https://issues.apache.org/jira/browse/SPARK-23344 > Project: Spark > Issue Type: Improvement > Components: ML, PySpark >Affects Versions: 2.4.0 >Reporter: Marco Gaido >Assignee: Marco Gaido >Priority: Minor > Fix For: 2.4.0 > > > SPARK-22119 introduced a new parameter for KMeans, ie. {{distanceMeasure}}. > We should add it also to the Python interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23344) Add KMeans distanceMeasure param to PySpark
[ https://issues.apache.org/jira/browse/SPARK-23344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362774#comment-16362774 ] Marco Gaido commented on SPARK-23344: - I see. It would be good indeed to decide in the community a "standard" approach for this, I think. Do you think it is worth opening a thread in the dev mailing list about this topic? > Add KMeans distanceMeasure param to PySpark > --- > > Key: SPARK-23344 > URL: https://issues.apache.org/jira/browse/SPARK-23344 > Project: Spark > Issue Type: Improvement > Components: ML, PySpark >Affects Versions: 2.4.0 >Reporter: Marco Gaido >Assignee: Marco Gaido >Priority: Minor > Fix For: 2.4.0 > > > SPARK-22119 introduced a new parameter for KMeans, ie. {{distanceMeasure}}. > We should add it also to the Python interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23344) Add KMeans distanceMeasure param to PySpark
[ https://issues.apache.org/jira/browse/SPARK-23344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362760#comment-16362760 ] Sean Owen commented on SPARK-23344: --- My general rule of thumb is: how likely is it you would resolve one issue independently of the other, or cherry-pick the fix for one vs the other? if they'd pretty much always go together then they seem like a logical issue. A lot of other concerns modify that. For example very large changes should probably be broken down even if they go together. This one is ambiguous. > Add KMeans distanceMeasure param to PySpark > --- > > Key: SPARK-23344 > URL: https://issues.apache.org/jira/browse/SPARK-23344 > Project: Spark > Issue Type: Improvement > Components: ML, PySpark >Affects Versions: 2.4.0 >Reporter: Marco Gaido >Assignee: Marco Gaido >Priority: Minor > Fix For: 2.4.0 > > > SPARK-22119 introduced a new parameter for KMeans, ie. {{distanceMeasure}}. > We should add it also to the Python interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23344) Add KMeans distanceMeasure param to PySpark
[ https://issues.apache.org/jira/browse/SPARK-23344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362758#comment-16362758 ] Marco Gaido commented on SPARK-23344: - [~srowen] I did it this way because I always say doing so. Not sure about the reason, maybe in order to make review easier. What would you suggest? > Add KMeans distanceMeasure param to PySpark > --- > > Key: SPARK-23344 > URL: https://issues.apache.org/jira/browse/SPARK-23344 > Project: Spark > Issue Type: Improvement > Components: ML, PySpark >Affects Versions: 2.4.0 >Reporter: Marco Gaido >Assignee: Marco Gaido >Priority: Minor > Fix For: 2.4.0 > > > SPARK-22119 introduced a new parameter for KMeans, ie. {{distanceMeasure}}. > We should add it also to the Python interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-23344) Add KMeans distanceMeasure param to PySpark
[ https://issues.apache.org/jira/browse/SPARK-23344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353992#comment-16353992 ] Apache Spark commented on SPARK-23344: -- User 'mgaido91' has created a pull request for this issue: https://github.com/apache/spark/pull/20520 > Add KMeans distanceMeasure param to PySpark > --- > > Key: SPARK-23344 > URL: https://issues.apache.org/jira/browse/SPARK-23344 > Project: Spark > Issue Type: Improvement > Components: ML, PySpark >Affects Versions: 2.4.0 >Reporter: Marco Gaido >Priority: Major > > SPARK-22119 introduced a new parameter for KMeans, ie. {{distanceMeasure}}. > We should add it also to the Python interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org