[jira] [Commented] (SPARK-23696) StructType.fromString swallows exceptions from DataType.fromJson

2019-05-21 Thread Hyukjin Kwon (JIRA) 


[ 
https://issues.apache.org/jira/browse/SPARK-23696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844885#comment-16844885
 ] 

Hyukjin Kwon commented on SPARK-23696:
--

no, this JIRA targets EOL release. Please reopen after checking if this issue 
exists in higher version of Spark or create another one.

> StructType.fromString swallows exceptions from DataType.fromJson
> 
>
> Key: SPARK-23696
> URL: https://issues.apache.org/jira/browse/SPARK-23696
> Project: Spark
>  Issue Type: Bug
>  Components: ML
>Affects Versions: 2.2.1
>Reporter: Simeon H.K. Fitch
>Priority: Trivial
>  Labels: bulk-closed
>
> `StructType.fromString` swallows exceptions from `DataType.fromJson`, 
> assuming they are an indication that the `LegacyTypeStringParser.parse` 
> should be called instead. When that fails (because it throws an excreption), 
> an error message is generated that does not reflect the true problem at hand, 
> effectively swallowing the exception from `DataType.fromJson`. This makes 
> debugging Parquet schema issues more difficult.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-23696) StructType.fromString swallows exceptions from DataType.fromJson

2019-05-21 Thread Simeon H.K. Fitch (JIRA) 


[ 
https://issues.apache.org/jira/browse/SPARK-23696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844808#comment-16844808
 ] 

Simeon H.K. Fitch commented on SPARK-23696:
---

[~hyukjin.kwon] is there a commit associated with this resolution?

> StructType.fromString swallows exceptions from DataType.fromJson
> 
>
> Key: SPARK-23696
> URL: https://issues.apache.org/jira/browse/SPARK-23696
> Project: Spark
>  Issue Type: Bug
>  Components: ML
>Affects Versions: 2.2.1
>Reporter: Simeon H.K. Fitch
>Priority: Trivial
>  Labels: bulk-closed
>
> `StructType.fromString` swallows exceptions from `DataType.fromJson`, 
> assuming they are an indication that the `LegacyTypeStringParser.parse` 
> should be called instead. When that fails (because it throws an excreption), 
> an error message is generated that does not reflect the true problem at hand, 
> effectively swallowing the exception from `DataType.fromJson`. This makes 
> debugging Parquet schema issues more difficult.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-23696) StructType.fromString swallows exceptions from DataType.fromJson

2018-03-16 Thread Simeon H.K. Fitch (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-23696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401979#comment-16401979
 ] 

Simeon H.K. Fitch commented on SPARK-23696:
---

Not sure what you mean by "we", but I'm just using the Parquet reader, which 
calls `StructType.fromString`; i.e. I don't have a choice.

> StructType.fromString swallows exceptions from DataType.fromJson
> 
>
> Key: SPARK-23696
> URL: https://issues.apache.org/jira/browse/SPARK-23696
> Project: Spark
>  Issue Type: Bug
>  Components: ML
>Affects Versions: 2.2.1
>Reporter: Simeon H.K. Fitch
>Priority: Trivial
>
> `StructType.fromString` swallows exceptions from `DataType.fromJson`, 
> assuming they are an indication that the `LegacyTypeStringParser.parse` 
> should be called instead. When that fails (because it throws an excreption), 
> an error message is generated that does not reflect the true problem at hand, 
> effectively swallowing the exception from `DataType.fromJson`. This makes 
> debugging Parquet schema issues more difficult.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-23696) StructType.fromString swallows exceptions from DataType.fromJson

2018-03-15 Thread Hyukjin Kwon (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-23696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401479#comment-16401479
 ] 

Hyukjin Kwon commented on SPARK-23696:
--

Why don't we just directly use {{DataType.fromJson}} if you need to catch the 
exception?

> StructType.fromString swallows exceptions from DataType.fromJson
> 
>
> Key: SPARK-23696
> URL: https://issues.apache.org/jira/browse/SPARK-23696
> Project: Spark
>  Issue Type: Bug
>  Components: ML
>Affects Versions: 2.2.1
>Reporter: Simeon H.K. Fitch
>Priority: Trivial
>
> `StructType.fromString` swallows exceptions from `DataType.fromJson`, 
> assuming they are an indication that the `LegacyTypeStringParser.parse` 
> should be called instead. When that fails (because it throws an excreption), 
> an error message is generated that does not reflect the true problem at hand, 
> effectively swallowing the exception from `DataType.fromJson`. This makes 
> debugging Parquet schema issues more difficult.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org