[jira] [Commented] (SPARK-2499) spark-default.conf parser doesn't ignore inline comments

2015-01-23 Thread Sean Owen (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14289247#comment-14289247
 ] 

Sean Owen commented on SPARK-2499:
--

I agree. These are parsed by java.util.Properties so are in the 'standard' 
format for properties files, and it does not support inline comments. I think 
it's not worth writing custom code to parse this, since it's easy to precede 
the line with a comment. Given Mark agrees I think we can resolve this.

 spark-default.conf parser doesn't ignore inline comments
 

 Key: SPARK-2499
 URL: https://issues.apache.org/jira/browse/SPARK-2499
 Project: Spark
  Issue Type: Bug
Affects Versions: 1.0.1
Reporter: Travis Thompson

 If you add a comment to spark-default.conf at the end of a line, spark will 
 try to parse it, example:
 spark-default.conf
 {noformat}
 spark.ui.port=0 # This forces the webui to always start on a random port
 {noformat}
 Error:
 {noformat}
 java.lang.NumberFormatException: For input string: 0 # This forces the webui 
 to always start on a random port
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-2499) spark-default.conf parser doesn't ignore inline comments

2014-07-15 Thread Mark Wagner (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14062912#comment-14062912
 ] 

Mark Wagner commented on SPARK-2499:


Travis, spark-default.conf is loaded as a Properties object in 
SparkSubmitArguments.scala so this is just behavior inherited from that. Would 
you be okay with just having comments before settings (which I think is the 
standard for .properties files)?

 spark-default.conf parser doesn't ignore inline comments
 

 Key: SPARK-2499
 URL: https://issues.apache.org/jira/browse/SPARK-2499
 Project: Spark
  Issue Type: Bug
Affects Versions: 1.0.1
Reporter: Travis Thompson

 If you add a comment to spark-default.conf at the end of a line, spark will 
 try to parse it, example:
 spark-default.conf
 {noformat}
 spark.ui.port=0 # This forces the webui to always start on a random port
 {noformat}
 Error:
 {noformat}
 java.lang.NumberFormatException: For input string: 0 # This forces the webui 
 to always start on a random port
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)